Jump to content

MediaInfo For Emby Plugin(HDR, Vision, Atmos, DTS:X)


Cheesegeezer

Recommended Posts

Mookdog
On 6/7/2022 at 3:21 PM, Cheesegeezer said:

I’m gonna put this out there but is anyone interested in this feature

75732123-CA73-4521-B128-54C9DBD3D60C.png.615d777a0a98f418a088722d0d9766fe.png
 

 

Ok so say for instance I got 3000 movies and 1000 tv shows this would probably take forever lol

 

Mook

Link to comment
Share on other sites

gihayes
1 minute ago, Mookdog said:

Ok so say for instance I got 3000 movies and 1000 tv shows this would probably take forever lol

 

Mook

But what you'd have after it finished would be great!

Link to comment
Share on other sites

Mookdog
12 minutes ago, gihayes said:

But what you'd have after it finished would be great!

Actually I converted a file just now it look like 6 seconds not bad at all. Does the beta delete the source file ? I hope it does that way I dont have to go through every single folder lol

Mook

Link to comment
Share on other sites

gihayes
Just now, Mookdog said:

 Does the beta delete the source file ? I hope it does that way I dont have to go through every single folder lol

What Cheese showed earlier gave you that option 🙂

Link to comment
Share on other sites

Mookdog
14 minutes ago, gihayes said:

What Cheese showed earlier gave you that option 🙂

I could definitely use that function to convert. The dll with that function hasnt been posted yet ?

 

Mook

Link to comment
Share on other sites

gihayes
2 minutes ago, Mookdog said:

I could definitely use that function to convert. The dll with that function hasnt been posted yet ?

 

Mook

I don't think so. He is still workin' on it. Great stuff!

Link to comment
Share on other sites

rbjtech
6 hours ago, MagicDoubleM said:

Re Tags... I noticed that movies with a radarr tag again lost their mediainfo tags. So here's the only explanation I have currently, emby seems to reset tags when it reads metadata from an nfo file and doesn't ever write tags through the metadata saver plugin, hence tags get lost as soon as there's one in the nfo and a metadata refresh is happening. I'll have to test this, but that's basically what was going on.

Hi - Yep, I think you have uncovered the issue - it's the nfo files.

While my items retain the MediaInfo tag's - they are not in the NFO.  I had a manually added a tag before MediaInfo added more - and that was in the NFO.   

They are only written to the NFO if I go into the metadata and hit 'Save' - then All the Tag's are written.

If I manually add another one - then ALL the tags, incl the MediaInfo ones get written.

Before writing them to the NFO, they are however, not lost if I refresh the metadata, as they are locked items according to the Metadata editor.

So I think all we are missing is 're-saving' the metadata once the tags have been added by MediaInfo - in the API this is the 'ItemUpdateService'

@Cheesegeezer - Any thoughts ?

Edited by rbjtech
  • Like 1
Link to comment
Share on other sites

neik

I feel like the processed list is not being filled correctly.
Today morning I ran the task again for a bit where it processed a couple of files and then I canceled it within the Emby dashboard.
It seemed to have stopped gracefully but the files that were processed have already been processed previously and when I have a look at the XML it only lists two processed IDs which is definitely a bit low.

Anyone else seeing this?
This is on 0.0.2.1

Link to comment
Share on other sites

rbjtech
6 minutes ago, neik said:

I feel like the processed list is not being filled correctly.
Today morning I ran the task again for a bit where it processed a couple of files and then I canceled it within the Emby dashboard.
It seemed to have stopped gracefully but the files that were processed have already been processed previously and when I have a look at the XML it only lists two processed IDs which is definitely a bit low.

Anyone else seeing this?
This is on 0.0.2.1

I can try and reproduce - but my XML is over 700K lol, so lots of stuff is being written ..

I'll delete some 'processed' items and see if it re-picks them up and then re-adds them ..

Link to comment
Share on other sites

Cheesegeezer
2 hours ago, neik said:

I feel like the processed list is not being filled correctly.
Today morning I ran the task again for a bit where it processed a couple of files and then I canceled it within the Emby dashboard.
It seemed to have stopped gracefully but the files that were processed have already been processed previously and when I have a look at the XML it only lists two processed IDs which is definitely a bit low.

Anyone else seeing this?
This is on 0.0.2.1

Did you have refresh on? Because this will delete the processed list.

rich is doing some tests now

Edited by Cheesegeezer
Link to comment
Share on other sites

neik
20 minutes ago, Cheesegeezer said:

Did you have refresh on? Because this will delete the processed list.

rich is doing some tests now

I'm quite sure it was off but I will also double check on my side and do some retests once I get to it.

@rbjtech, let me please know how your tests go on. Thanks! 🙂

Link to comment
Share on other sites

Cheesegeezer

Here is a wee video show casing the MKV Convert feature.

  1. It allows you to preserver Dolby Vision inside of MP4 video.
  2. it will rename your old file to "orig-" + original extension
  3. You can keep the old file for upto 12 weeks or set to 0 for immediate deletion 
  4. If you wish to revert the conversion back to their original format this can also be done.

 

 

Edited by Cheesegeezer
  • Like 1
Link to comment
Share on other sites

rbjtech
6 hours ago, rbjtech said:

Hi - Yep, I think you have uncovered the issue - it's the nfo files.

While my items retain the MediaInfo tag's - they are not in the NFO.  I had a manually added a tag before MediaInfo added more - and that was in the NFO.   

They are only written to the NFO if I go into the metadata and hit 'Save' - then All the Tag's are written.

If I manually add another one - then ALL the tags, incl the MediaInfo ones get written.

Before writing them to the NFO, they are however, not lost if I refresh the metadata, as they are locked items according to the Metadata editor.

So I think all we are missing is 're-saving' the metadata once the tags have been added by MediaInfo - in the API this is the 'ItemUpdateService'

@Cheesegeezer - Any thoughts ?

@MagicDoubleM

This has been fixed - we are testing it now.

In summary, the NFO data is not written as part of the usual metadata update (for some reason), it's written by a separate 'Library' function - this is why it was understandably missed.

Once it's tested, Cheese will update the DLL and then the NFO for each Item will be immediately updated, allowing any further NFO processing to include the Tag updates from MediaInfo.

Edited by rbjtech
  • Like 1
Link to comment
Share on other sites

Cheesegeezer
26 minutes ago, rbjtech said:

Once it's tested, Cheese will update the DLL and then the NFO for each Item will be immediately updated, allowing any further NFO processing to include the Tag updates from MediaInfo.

Actually the librarys will need to be refreshed in the plugin.  So Tick refresh and run again.

  • Like 1
  • Agree 1
Link to comment
Share on other sites

Mookdog
3 hours ago, Cheesegeezer said:

 

Here is a wee video show casing the MKV Convert feature.

  1. It allows you to preserver Dolby Vision inside of MP4 video.
  2. it will rename your old file to "orig-" + original extension
  3. You can keep the old file for upto 12 weeks or set to 0 for immediate deletion 
  4. If you wish to revert the conversion back to their original format this can also be done.

 

 

 

Looks amazing @CheesegeezerI am chomping at the bit just waiting for it so I can get started converting my library lol

 

Mook

Link to comment
Share on other sites

Cheesegeezer
2 minutes ago, Mookdog said:

Looks amazing @CheesegeezerI am chomping at the bit just waiting for it so I can get started converting my library lol

 

Mook

@MagicDoubleM @neik  @Mookdog

 

Version 3.0 is up on first post... I haven't had chance to create a wiki for the Convert to MKV, but the video above will help you out massively.

NOTHING WILL BE DELETED UNITL WE ARE HAPPY WITH THE CONVERSION. So please check your logs in DEBUG mode to keep an eye on this.

If you have any doubts about running the convert to mkv feature, just leave it alone.

Following fixes

  1. NFO tag writting and removal should be fixed
  2. Items remaining in cache should be fixed. 
  • Like 1
Link to comment
Share on other sites

Mookdog
22 minutes ago, Cheesegeezer said:

@MagicDoubleM @neik  @Mookdog

 

Version 3.0 is up on first post... I haven't had chance to create a wiki for the Convert to MKV, but the video above will help you out massively.

NOTHING WILL BE DELETED UNITL WE ARE HAPPY WITH THE CONVERSION. So please check your logs in DEBUG mode to keep an eye on this.

If you have any doubts about running the convert to mkv feature, just leave it alone.

Following fixes

  1. NFO tag writting and removal should be fixed
  2. Items remaining in cache should be fixed. 

Anyway to turn on deletion ? I have over 3000 movies and it would take forever to delete each movie lol

 

Mook

Link to comment
Share on other sites

Cheesegeezer
4 minutes ago, Mookdog said:

Anyway to turn on deletion ? I have over 3000 movies and it would take forever to delete each movie lol

 

Mook

Nope not yet… the idea of allowing that is to stop you losing your entire library should anything go wrong during testing.
 

once we can confirm it worked on your 3000 movies, i can enable the file deletion and you can set your time and they will be deleted 

Edited by Cheesegeezer
Link to comment
Share on other sites

Mookdog
2 hours ago, Cheesegeezer said:

@MagicDoubleM @neik  @Mookdog

 

Version 3.0 is up on first post... I haven't had chance to create a wiki for the Convert to MKV, but the video above will help you out massively.

NOTHING WILL BE DELETED UNITL WE ARE HAPPY WITH THE CONVERSION. So please check your logs in DEBUG mode to keep an eye on this.

If you have any doubts about running the convert to mkv feature, just leave it alone.

Following fixes

  1. NFO tag writting and removal should be fixed
  2. Items remaining in cache should be fixed. 

@CheesegeezerSo nothing will be deleted if I set the days to keep original file to 0 ? Reason I ask is I am pretty limited on space right now and I wouldnt be able to have duplicate in mp4 format bc of that situation. I know all my movies arent mp4 but a good bulk is.

Thanks for all your hard work

Mook

Link to comment
Share on other sites

Cheesegeezer
26 minutes ago, Mookdog said:

@CheesegeezerSo nothing will be deleted if I set the days to keep original file to 0 ? Reason I ask is I am pretty limited on space right now and I wouldnt be able to have duplicate in mp4 format bc of that situation. I know all my movies arent mp4 but a good bulk is.

Thanks for all your hard work

Mook

Can you setup a seperate server with -about 20 movies in to test.

im pretty confident it will work but if i delete all your originals and you have nothing to play because of damaged files, believe me you would be raging with me!

i need it testing first, to appease my good nature and we can go from there.

hope that makes real good sense to you. Cheers

Link to comment
Share on other sites

Mookdog
35 minutes ago, Cheesegeezer said:

Can you setup a seperate server with -about 20 movies in to test.

im pretty confident it will work but if i delete all your originals and you have nothing to play because of damaged files, believe me you would be raging with me!

i need it testing first, to appease my good nature and we can go from there.

hope that makes real good sense to you. Cheers

I understand brother I will test on my laptop later today

Mook

Link to comment
Share on other sites

Mookdog
52 minutes ago, Cheesegeezer said:

Can you setup a seperate server with -about 20 movies in to test.

im pretty confident it will work but if i delete all your originals and you have nothing to play because of damaged files, believe me you would be raging with me!

i need it testing first, to appease my good nature and we can go from there.

hope that makes real good sense to you. Cheers

@Cheesegeezermost of my files are 1080p I will test them in a bit. Do u need a debug log when I am finished ?

 

Mook

Link to comment
Share on other sites

neik
8 hours ago, neik said:

I'm quite sure it was off but I will also double check on my side and do some retests once I get to it.

Just tested with the updated version of today, same issue unfortunately.
Do I need to delete the XML when updating plugin versions?

Link to comment
Share on other sites

rbjtech
11 minutes ago, neik said:

Just tested with the updated version of today, same issue unfortunately.
Do I need to delete the XML when updating plugin versions?

Can you provide the MediaInfo JSON of one of the files - I'm seeing some issues myself where the order of the tracks is Audio then Video, rather than the usual Video then Audio - I'm wondering if this is related to your issue.  In these cases, the item is not written as 'processed' and thus gets repeated over and over again.

Link to comment
Share on other sites

neik
2 minutes ago, rbjtech said:

Can you provide the MediaInfo JSON of one of the files - I'm seeing some issues myself where the order of the tracks is Audio then Video, rather than the usual Video then Audio - I'm wondering if this is related to your issue.  In these cases, the item is not written as 'processed' and thus gets repeated over and over again.

I've seen such files as well but in this case the affected ones are do seem to have a "regular" order.
Example 1:

Format                                   : Matroska
Format version                           : Version 4
File size                                : 2.23 GiB
Duration                                 : 1 h 39 min
Overall bit rate                         : 3 210 kb/s
Encoded date                             : UTC 2020-08-29 10:25:44
Writing application                      : mkvmerge v19.0.0 ('Brave Captain') 64-bit
Writing library                          : libebml v1.3.5 + libmatroska v1.4.8

Video
ID                                       : 1
Format                                   : AVC
Format/Info                              : Advanced Video Codec
Format profile                           : Main@L3.1
Format settings                          : CABAC / 4 Ref Frames
Format settings, CABAC                   : Yes
Format settings, Reference frames        : 4 frames
Format settings, GOP                     : M=1, N=50
Codec ID                                 : V_MPEG4/ISO/AVC
Duration                                 : 1 h 39 min
Bit rate mode                            : Constant
Bit rate                                 : 3 199 kb/s
Width                                    : 1 280 pixels
Height                                   : 720 pixels
Display aspect ratio                     : 16:9
Frame rate mode                          : Constant
Frame rate                               : 25.000 FPS
Color space                              : YUV
Chroma subsampling                       : 4:2:0
Bit depth                                : 8 bits
Scan type                                : Progressive
Bits/(Pixel*Frame)                       : 0.139
Stream size                              : 2.16 GiB (97%)
Title                                    : 720p AVC
Language                                 : German
Default                                  : Yes
Forced                                   : No
Color range                              : Limited
Color primaries                          : BT.709
Transfer characteristics                 : BT.709
Matrix coefficients                      : BT.709

Audio
ID                                       : 2
Format                                   : AAC LC
Format/Info                              : Advanced Audio Codec Low Complexity
Codec ID                                 : A_AAC-2
Duration                                 : 1 h 39 min
Bit rate                                 : 96.0 kb/s
Channel(s)                               : 2 channels
Channel layout                           : L R
Sampling rate                            : 44.1 kHz
Frame rate                               : 43.066 FPS (1024 SPF)
Compression mode                         : Lossy
Stream size                              : 68.3 MiB (3%)
Title                                    : AAC LC 2.0
Language                                 : German
Default                                  : Yes
Forced                                   : No

Example 2:

Format                                   : Matroska
Format version                           : Version 4
File size                                : 911 MiB
Duration                                 : 50 min 21 s
Overall bit rate                         : 2 530 kb/s
Encoded date                             : UTC 2020-08-25 08:43:12
Writing application                      : mkvmerge v47.0.0 ('Black Flag') 64-bit
Writing library                          : libebml v1.3.10 + libmatroska v1.5.2

Video
ID                                       : 1
Format                                   : AVC
Format/Info                              : Advanced Video Codec
Format profile                           : Main@L3.1
Format settings                          : CABAC / 3 Ref Frames
Format settings, CABAC                   : Yes
Format settings, Reference frames        : 3 frames
Codec ID                                 : V_MPEG4/ISO/AVC
Duration                                 : 50 min 21 s
Bit rate                                 : 2 402 kb/s
Width                                    : 1 280 pixels
Height                                   : 720 pixels
Display aspect ratio                     : 16:9
Frame rate mode                          : Constant
Frame rate                               : 25.000 FPS
Standard                                 : PAL
Color space                              : YUV
Chroma subsampling                       : 4:2:0
Bit depth                                : 8 bits
Scan type                                : Progressive
Bits/(Pixel*Frame)                       : 0.104
Stream size                              : 865 MiB (95%)
Title                                    : 720p AVC
Default                                  : Yes
Forced                                   : No
Color range                              : Limited

Audio
ID                                       : 2
Format                                   : AAC LC
Format/Info                              : Advanced Audio Codec Low Complexity
Codec ID                                 : A_AAC-2
Duration                                 : 50 min 21 s
Bit rate                                 : 125 kb/s
Channel(s)                               : 2 channels
Channel layout                           : L R
Sampling rate                            : 48.0 kHz
Frame rate                               : 46.875 FPS (1024 SPF)
Compression mode                         : Lossy
Delay relative to video                  : -80 ms
Stream size                              : 45.2 MiB (5%)
Title                                    : AAC LC 2.0
Language                                 : German
Default                                  : Yes
Forced                                   : No

 

Link to comment
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now
×
×
  • Create New...