Jump to content

embyforkodi (next-gen) 7.X.X support


quickmic

Recommended Posts

quickmic

I'll check it with my samples too. Strange, that Kodi actually shows the Intro Start but not webui. They should exactly match.

Link to comment
Share on other sites

quickmic

Also, please verify if the label position is actually wrong, or if it was an cached image from a previous version, which probably had this bug.

Therefore, shut down Kodi. Delete (or backup) the complete userdata/thumbnails/* folder AND the userdata/Database/Textures13.db file. (this will force a artwork reload)

Restart Kodi and check the bookmark label position again.

Thanks

 

btw, I hope you use the latest 7.x version. -> currently 7.0.8

 

Edited by quickmic
Link to comment
Share on other sites

quickmic

Just found a bug in the chapters. The "IntroEnd" marker was not respected as a bookmark. I'll fix that in next version.

Link to comment
Share on other sites

1moment

Ok I deleted:

%appdata%\Kodi\userdata\Database\Textures13.db

%appdata%\Kodi\userdata\Thumbnails\*

when I restarted kodi i noticed images were in the process of being cached/were not all there immediately - checking chapters in the same episode looks identical to my earlier screenshots sadly

 

I am using:

kodi-19.4-Matrix-x64.exe (stock estuary skin)

plugin.video.emby-next-gen-7.0.8.zip

emby server 4.7.2.0 (docker)

 

Good news about the introend marker!

Thanks again

 

Link to comment
Share on other sites

quickmic

to all, fyi

When I talk about chapters and bookmarks:

As you can see, Kodi labels the markers as chapters or bookmarks. Not possible to change them (hardcoded in Kodi).

That's why I added a textoverlay for custom labels.

Also the markers are labeled as chapters or bookmarks. "chapters" are extracted from the file or video-stream while "Bookmarks" are custom markers.

2022-06-15 19:05:49.184 T:226      INFO <general>: ffmpeg[0x55c734f53a50X]: Input #0, matroska,webm, from 'http://192.168.0.207:80/emby/videos/35802/stream?static=true&MediaSourceId=b3b5bdbe8309d4d6e95a387f607cd992&PlaySessionId=1e3e91eb78c44f8094ff09ee0b691daf&DeviceId=ee89233d-d347-4f9f-92ca-5676013195cd&api_key=MYTOKEN&S01E14.mkv':
2022-06-15 19:05:49.184 T:226      INFO <general>: ffmpeg[0x55c734f53a50X]:   Metadata:
2022-06-15 19:05:49.184 T:226      INFO <general>: ffmpeg[0x55c734f53a50X]:     ENCODER         : Lavf57.83.100
2022-06-15 19:05:49.184 T:226      INFO <general>: ffmpeg[0x55c734f53a50X]:   Duration: 00:42:38.26, start: 0.000000, bitrate: 2309 kb/s
2022-06-15 19:05:49.184 T:226      INFO <general>: ffmpeg[0x55c734f53a50X]:     Chapter #0:0: start 0.080000, end 93.440000
2022-06-15 19:05:49.184 T:226      INFO <general>: ffmpeg[0x55c734f53a50X]:     Metadata:
2022-06-15 19:05:49.184 T:226      INFO <general>: ffmpeg[0x55c734f53a50X]:       title           : Chapter 01
2022-06-15 19:05:49.184 T:226      INFO <general>: ffmpeg[0x55c734f53a50X]:     Chapter #0:1: start 93.440000, end 962.320000
2022-06-15 19:05:49.184 T:226      INFO <general>: ffmpeg[0x55c734f53a50X]:     Metadata:
2022-06-15 19:05:49.184 T:226      INFO <general>: ffmpeg[0x55c734f53a50X]:       title           : Chapter 02
2022-06-15 19:05:49.184 T:226      INFO <general>: ffmpeg[0x55c734f53a50X]:     Chapter #0:2: start 962.320000, end 1980.800000
2022-06-15 19:05:49.184 T:226      INFO <general>: ffmpeg[0x55c734f53a50X]:     Metadata:
2022-06-15 19:05:49.184 T:226      INFO <general>: ffmpeg[0x55c734f53a50X]:       title           : Chapter 03
2022-06-15 19:05:49.184 T:226      INFO <general>: ffmpeg[0x55c734f53a50X]:     Chapter #0:3: start 1980.800000, end 2558.240000
2022-06-15 19:05:49.184 T:226      INFO <general>: ffmpeg[0x55c734f53a50X]:     Metadata:
2022-06-15 19:05:49.184 T:226      INFO <general>: ffmpeg[0x55c734f53a50X]:       title           : Chapter 04
2022-06-15 19:05:49.184 T:226      INFO <general>: ffmpeg[0x55c734f53a50X]:     Stream #0:0(eng): Video: hevc (Main), yuv420p(tv, progressive), 720x576 [SAR 16:15 DAR 4:3], 25 fps, 25 tbr, 1k tbn, 25 tbc
2022-06-15 19:05:49.184 T:226      INFO <general>: ffmpeg[0x55c734f53a50X]:     Metadata:
2022-06-15 19:05:49.184 T:226      INFO <general>: ffmpeg[0x55c734f53a50X]:       ENCODER         : Lavc57.107.100 hevc_nvenc
2022-06-15 19:05:49.184 T:226      INFO <general>: ffmpeg[0x55c734f53a50X]:       DURATION        : 00:42:38.261000000
2022-06-15 19:05:49.184 T:226      INFO <general>: ffmpeg[0x55c734f53a50X]:     Stream #0:1(ger): Audio: aac (LC), 48000 Hz, stereo, fltp (default)
2022-06-15 19:05:49.184 T:226      INFO <general>: ffmpeg[0x55c734f53a50X]:     Metadata:
2022-06-15 19:05:49.184 T:226      INFO <general>: ffmpeg[0x55c734f53a50X]:       ENCODER         : Lavc57.107.100 aac
2022-06-15 19:05:49.184 T:226      INFO <general>: ffmpeg[0x55c734f53a50X]:       DURATION        : 00:42:38.261000000
2022-06-15 19:05:49.184 T:226      INFO <general>: ffmpeg[0x55c734f53a50X]:     Stream #0:2(eng): Audio: aac (LC), 48000 Hz, stereo, fltp
2022-06-15 19:05:49.184 T:226      INFO <general>: ffmpeg[0x55c734f53a50X]:     Metadata:
2022-06-15 19:05:49.184 T:226      INFO <general>: ffmpeg[0x55c734f53a50X]:       ENCODER         : Lavc57.107.100 aac
2022-06-15 19:05:49.184 T:226      INFO <general>: ffmpeg[0x55c734f53a50X]:       DURATION        : 00:42:38.261000000

 

It's also not possible to disable Kodi's "chapter" extraction. (also hardcoded).

On the other hand, Emby chapters do not differentiate between a stream marker (Kodi's chapter) and a custom marker (Kodi's bookmark).

At the moment the plugin does some magic to detect if it's a chapter or a bookmark. Beside some other stuff, it uses modulo (for the experts). This means an even marker is most likely a bookmark. Even means straight numbers. 00:05:00, 00:10:00, 00:15:00 but not 00:05:23, 00:10:34 or 00:15:23

The reason (if it's not already obvious), if the plugin syncs ALL markers from Emby server, it could result in double markers (as mentioned, not possible to disable Kodi's internal chapter extraction via ffmpeg).

@Luke

Would it be possible to tag the markers on Emby server, if it's a custom marker (bookmark) or a "native" marker (chapter)?

 

 

 

 

Edited by quickmic
Link to comment
Share on other sites

4 minutes ago, quickmic said:

to all, fyi

When I talk about chapters and bookmarks:

As you can see, Kodi labels the markers as chapters or bookmarks. Not possible to change them (hardcoded in Kodi).

That's why I added a textoverlay for custom labels.

Also the markers are labeled as chapters or bookmarks. "chapters" are extracted from the file or video-stream while "Bookmarks" are custom markers.

2022-06-15 19:05:49.184 T:226      INFO <general>: ffmpeg[0x55c734f53a50X]: Input #0, matroska,webm, from 'http://192.168.0.207:80/emby/videos/35802/stream?static=true&MediaSourceId=b3b5bdbe8309d4d6e95a387f607cd992&PlaySessionId=1e3e91eb78c44f8094ff09ee0b691daf&DeviceId=ee89233d-d347-4f9f-92ca-5676013195cd&api_key=MYTOKEN&S01E14.mkv':
2022-06-15 19:05:49.184 T:226      INFO <general>: ffmpeg[0x55c734f53a50X]:   Metadata:
2022-06-15 19:05:49.184 T:226      INFO <general>: ffmpeg[0x55c734f53a50X]:     ENCODER         : Lavf57.83.100
2022-06-15 19:05:49.184 T:226      INFO <general>: ffmpeg[0x55c734f53a50X]:   Duration: 00:42:38.26, start: 0.000000, bitrate: 2309 kb/s
2022-06-15 19:05:49.184 T:226      INFO <general>: ffmpeg[0x55c734f53a50X]:     Chapter #0:0: start 0.080000, end 93.440000
2022-06-15 19:05:49.184 T:226      INFO <general>: ffmpeg[0x55c734f53a50X]:     Metadata:
2022-06-15 19:05:49.184 T:226      INFO <general>: ffmpeg[0x55c734f53a50X]:       title           : Chapter 01
2022-06-15 19:05:49.184 T:226      INFO <general>: ffmpeg[0x55c734f53a50X]:     Chapter #0:1: start 93.440000, end 962.320000
2022-06-15 19:05:49.184 T:226      INFO <general>: ffmpeg[0x55c734f53a50X]:     Metadata:
2022-06-15 19:05:49.184 T:226      INFO <general>: ffmpeg[0x55c734f53a50X]:       title           : Chapter 02
2022-06-15 19:05:49.184 T:226      INFO <general>: ffmpeg[0x55c734f53a50X]:     Chapter #0:2: start 962.320000, end 1980.800000
2022-06-15 19:05:49.184 T:226      INFO <general>: ffmpeg[0x55c734f53a50X]:     Metadata:
2022-06-15 19:05:49.184 T:226      INFO <general>: ffmpeg[0x55c734f53a50X]:       title           : Chapter 03
2022-06-15 19:05:49.184 T:226      INFO <general>: ffmpeg[0x55c734f53a50X]:     Chapter #0:3: start 1980.800000, end 2558.240000
2022-06-15 19:05:49.184 T:226      INFO <general>: ffmpeg[0x55c734f53a50X]:     Metadata:
2022-06-15 19:05:49.184 T:226      INFO <general>: ffmpeg[0x55c734f53a50X]:       title           : Chapter 04
2022-06-15 19:05:49.184 T:226      INFO <general>: ffmpeg[0x55c734f53a50X]:     Stream #0:0(eng): Video: hevc (Main), yuv420p(tv, progressive), 720x576 [SAR 16:15 DAR 4:3], 25 fps, 25 tbr, 1k tbn, 25 tbc
2022-06-15 19:05:49.184 T:226      INFO <general>: ffmpeg[0x55c734f53a50X]:     Metadata:
2022-06-15 19:05:49.184 T:226      INFO <general>: ffmpeg[0x55c734f53a50X]:       ENCODER         : Lavc57.107.100 hevc_nvenc
2022-06-15 19:05:49.184 T:226      INFO <general>: ffmpeg[0x55c734f53a50X]:       DURATION        : 00:42:38.261000000
2022-06-15 19:05:49.184 T:226      INFO <general>: ffmpeg[0x55c734f53a50X]:     Stream #0:1(ger): Audio: aac (LC), 48000 Hz, stereo, fltp (default)
2022-06-15 19:05:49.184 T:226      INFO <general>: ffmpeg[0x55c734f53a50X]:     Metadata:
2022-06-15 19:05:49.184 T:226      INFO <general>: ffmpeg[0x55c734f53a50X]:       ENCODER         : Lavc57.107.100 aac
2022-06-15 19:05:49.184 T:226      INFO <general>: ffmpeg[0x55c734f53a50X]:       DURATION        : 00:42:38.261000000
2022-06-15 19:05:49.184 T:226      INFO <general>: ffmpeg[0x55c734f53a50X]:     Stream #0:2(eng): Audio: aac (LC), 48000 Hz, stereo, fltp
2022-06-15 19:05:49.184 T:226      INFO <general>: ffmpeg[0x55c734f53a50X]:     Metadata:
2022-06-15 19:05:49.184 T:226      INFO <general>: ffmpeg[0x55c734f53a50X]:       ENCODER         : Lavc57.107.100 aac
2022-06-15 19:05:49.184 T:226      INFO <general>: ffmpeg[0x55c734f53a50X]:       DURATION        : 00:42:38.261000000

 

It's also not possible to disable Kodi's "chapter" extraction. (also hardcoded).

On the other hand, Emby chapters do not differentiate between a stream marker (Kodi's chapter) and a custom marker (Kodi's bookmark).

At the moment the plugin does some magic to detect if it's a chapter or a bookmark. Beside some other stuff, it uses modulo (for the experts). This means an even marker is most likely a bookmark. Even means straight numbers. 00:05:00, 00:10:00, 00:15:00 but not 00:05:23, 00:10:34 or 00:15:23

The reason (if it's not already obvious), if the plugin syncs ALL markers from Emby server, it could result in double markers (as mentioned, not possible to disable Kodi's internal chapter extraction via ffmpeg).

@Luke

Would it be possible to tag the markers on Emby server, if it's a custom marker (bookmark) or a "native" marker (chapter)?

 

 

 

 

How would we know the difference? I think it will probably have to wait until we have a bookmark feature of our own.

Link to comment
Share on other sites

quickmic
14 minutes ago, Luke said:

How would we know the difference? I think it will probably have to wait until we have a bookmark feature of our own.

Well I assume, Emby also extracts the "chapters" from the files. If this is the case, you can tag them in Emby's database as "native" or "chapter" as Kodi does. On the other hand, auto generated markers like the "5 Minutes" markers are not "native" and could be tagged as "custom" or "bookmark".

The skip-intro markers are already tagged (perfect), no guessing here.

Edited by quickmic
Link to comment
Share on other sites

quickmic

Custom marker:

2022-06-15 19:40:42.515 T:292      INFO <general>: ffmpeg[0x562afeb3fbe0X]: Input #0, matroska,webm, from 'http://192.168.0.207:80/emby/videos/34736/stream?static=true&MediaSourceId=e59ea92636461628abb4389cb9356875&PlaySessionId=e6e186be27a64b5aa9b01ce3814026b6&DeviceId=ee89233d-d347-4f9f-92ca-5676013195cd&api_key=MYTOKE&S04E01.mkv':
2022-06-15 19:40:42.515 T:292      INFO <general>: ffmpeg[0x562afeb3fbe0X]:   Metadata:
2022-06-15 19:40:42.515 T:292      INFO <general>: ffmpeg[0x562afeb3fbe0X]:     MINOR_VERSION   : 512
2022-06-15 19:40:42.515 T:292      INFO <general>: ffmpeg[0x562afeb3fbe0X]:     COMPATIBLE_BRANDS: isomiso2avc1mp41
2022-06-15 19:40:42.515 T:292      INFO <general>: ffmpeg[0x562afeb3fbe0X]:     MAJOR_BRAND     : isom
2022-06-15 19:40:42.515 T:292      INFO <general>: ffmpeg[0x562afeb3fbe0X]:     ENCODER         : Lavf57.83.100
2022-06-15 19:40:42.515 T:292      INFO <general>: ffmpeg[0x562afeb3fbe0X]:   Duration: 00:41:30.99, start: 0.000000, bitrate: 1506 kb/s
2022-06-15 19:40:42.515 T:292      INFO <general>: ffmpeg[0x562afeb3fbe0X]:     Stream #0:0: Video: hevc (Main), yuv420p(tv, progressive), 1280x718 [SAR 1:1 DAR 640:359], 23.98 fps, 23.98 tbr, 1k tbn, 23.98 tbc (default)
2022-06-15 19:40:42.515 T:292      INFO <general>: ffmpeg[0x562afeb3fbe0X]:     Metadata:
2022-06-15 19:40:42.515 T:292      INFO <general>: ffmpeg[0x562afeb3fbe0X]:       HANDLER_NAME    : VideoHandler
2022-06-15 19:40:42.515 T:292      INFO <general>: ffmpeg[0x562afeb3fbe0X]:       ENCODER         : Lavc57.107.100 hevc_nvenc
2022-06-15 19:40:42.515 T:292      INFO <general>: ffmpeg[0x562afeb3fbe0X]:       DURATION        : 00:41:30.970000000
2022-06-15 19:40:42.515 T:292      INFO <general>: ffmpeg[0x562afeb3fbe0X]:     Stream #0:1(eng): Audio: aac (LC), 44100 Hz, stereo, fltp (default)
2022-06-15 19:40:42.515 T:292      INFO <general>: ffmpeg[0x562afeb3fbe0X]:     Metadata:
2022-06-15 19:40:42.515 T:292      INFO <general>: ffmpeg[0x562afeb3fbe0X]:       HANDLER_NAME    : SoundHandler
2022-06-15 19:40:42.515 T:292      INFO <general>: ffmpeg[0x562afeb3fbe0X]:       ENCODER         : Lavc57.107.100 aac
2022-06-15 19:40:42.515 T:292      INFO <general>: ffmpeg[0x562afeb3fbe0X]:       DURATION        : 00:41:30.990000000
2022-06-15 19:40:42.515 T:292     DEBUG <general>: CDVDDemuxFFmpeg::AddStream ID: 0

 

 

sc3.png

Link to comment
Share on other sites

quickmic
43 minutes ago, 1moment said:

Ok I deleted:

%appdata%\Kodi\userdata\Database\Textures13.db

%appdata%\Kodi\userdata\Thumbnails\*

when I restarted kodi i noticed images were in the process of being cached/were not all there immediately - checking chapters in the same episode looks identical to my earlier screenshots sadly

 

I am using:

kodi-19.4-Matrix-x64.exe (stock estuary skin)

plugin.video.emby-next-gen-7.0.8.zip

emby server 4.7.2.0 (docker)

 

Good news about the introend marker!

Thanks again

 

What kind of Kodi device and more important which (screen) resolution?

 

Link to comment
Share on other sites

1moment
3 hours ago, quickmic said:

What kind of Kodi device and more important which (screen) resolution?

 

I was actually thinking about that too in relation to the 'intro skip' text on the 'bookmark' image. My main screen is 4k res with 150% scaling but I had kodi set to be running on a secondary monitor with 1080 res and 100% scaling. Perhaps that is causing the alignment issue?

Link to comment
Share on other sites

quickmic
Just now, 1moment said:

I was actually thinking about that too in relation to the 'intro skip' text on the 'bookmark' image. My main screen is 4k res with 150% scaling but I had kodi set to be running on a secondary monitor with 1080 res and 100% scaling. Perhaps that is causing the alignment issue?

The scaling could be an issue. Remember, each time you perform a new test, you must wipe the thumbnails cache as described.

I don't think the resolution is an issue, I was just asking if you have a odd setup. Portrait instead of landscape something like that.

Theoretically resolution shouldn't be an issue. The text overlay respects resolutions and calculates the position based on native image size. Even it recalculates image positions to a 4:3 ratio (what Kodi expects)

However, I never tested with scaling.

So far, I could not reproduce the incorrect position.

Can you test without scaling?

Link to comment
Share on other sites

quickmic

btw, as the box position is correct, I highly assume the scaling is the issue. The fontsize calculation could be affected by scaling.

Link to comment
Share on other sites

1moment

Well this is thoroughly confusing:

I changed all my monitors to 1080 res with 100% scaling

Reboot windows

deleted %appdata%\Kodi\userdata\Database\Textures13.db

deleted %appdata%\Kodi\userdata\Thumbnails\*

launched kodi

still looks identical to the previous screenshot

  • Thanks 1
Link to comment
Share on other sites

quickmic
9 hours ago, 1moment said:

Well this is thoroughly confusing:

I changed all my monitors to 1080 res with 100% scaling

Reboot windows

deleted %appdata%\Kodi\userdata\Database\Textures13.db

deleted %appdata%\Kodi\userdata\Thumbnails\*

launched kodi

still looks identical to the previous screenshot

Ok, I'll perform a test on a multi monitor PC. Maybe that's the issue, but I doubt it.

Link to comment
Share on other sites

quickmic

New version available 7.1.0

delta changelog:

fix End Intro
add jump to intro end support

 

comment:

this version requires a mandatory database reset.

I still haven't found the bookmark label position issue. -> pending

The skip intro function needs to be enabled in plugin config menu -> playback -> skip intro

Skip intro function is NOT supported in native mode.

  • Thanks 2
Link to comment
Share on other sites

jaybird2203

Hi quickmic, just loaded up 7.1.0 to my 19.4 Windows 10 install and noticed that it appears that the Music import process may have changed since I've also updated Emby server to 4.7.2. 

I've noticed that when viewing Artist -> All Albums Kodi no longer filters the other albums to be just the selected artist but now adds all albums in total. This aligns with Emby server web view of the "Appears On" section. 

Loading some of the files direct into Kodi and the expected functionality (limit the other albums to just the songs the selected artist is present on) is observed. 

I've pulled fresh databases of both scenarios and will be reviewing shortly. 

Link to comment
Share on other sites

quickmic
2 hours ago, jaybird2203 said:

Hi quickmic, just loaded up 7.1.0 to my 19.4 Windows 10 install and noticed that it appears that the Music import process may have changed since I've also updated Emby server to 4.7.2. 

I've noticed that when viewing Artist -> All Albums Kodi no longer filters the other albums to be just the selected artist but now adds all albums in total. This aligns with Emby server web view of the "Appears On" section. 

Loading some of the files direct into Kodi and the expected functionality (limit the other albums to just the songs the selected artist is present on) is observed. 

I've pulled fresh databases of both scenarios and will be reviewing shortly. 

Yep, seems to be a bug. I'll try to fix it.

Link to comment
Share on other sites

quickmic

New version available 7.2.0

 

delta changelog:

fix Artist Album assignment
fix Album update -> year not updated
remove discography in kodi db (not a Kodi stock function, and has no benefit)
some minor music database fixes
fix remote playback strm files
add playable verification for remote content -> if not directplay possible, fallback to transcoding
remove header queries from picture files

 

Comment:
let me know if you experiance artwork issues
Full database is mandatory for this version due to additional fileinfos for remote content

Link to comment
Share on other sites

jaybird2203

Loaded up 7.2.0 and the Artist -> All Albums filter for the individual artist is working again. 

  • Like 1
Link to comment
Share on other sites

838Joel

tested 7.2.0 on Android TV and also on a QNAP, all good so far!👍

Edited by 838Joel
  • Thanks 1
Link to comment
Share on other sites

unmovable

In v6, media items that were deleted/renamed were not synced (i.e. were not removed from Kodi), so the addon was only syncing new additions and happily leaving old non-existing items in Kodi db until you manually forced it to re-sync everything. Does v7 also completely disregard item deletions in the "sync" process or was this finally fixed here?

Link to comment
Share on other sites

quickmic
14 minutes ago, unmovable said:

In v6, media items that were deleted/renamed were not synced (i.e. were not removed from Kodi), so the addon was only syncing new additions and happily leaving old non-existing items in Kodi db until you manually forced it to re-sync everything. Does v7 also completely disregard item deletions in the "sync" process or was this finally fixed here?

Well I hope so, but not sure. Let me know, if you have issues in 7.x

Link to comment
Share on other sites

quickmic

I found an issue when removing items in very special cases. Unfortunately (due to a lag of reported info from Emby server) I need to write some workarounds.

The fix fill take a while. Several changes needs to be done.

  • Thanks 1
Link to comment
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now
×
×
  • Create New...