Jump to content

embyforkodi (next-gen) 7.X.X support


quickmic

Recommended Posts

djon

On 7.06 I just deleted a TV-Show in Kodi using the context menu. However it deleted my entire TV-Shows folder and not just the specific TV-show! Don't know if this has been fixed in later versions. Luckily I had a fresh backup of the entire folder. Phew.

  • Thanks 1
Link to comment
Share on other sites

quickmic
12 hours ago, djon said:

On 7.06 I just deleted a TV-Show in Kodi using the context menu. However it deleted my entire TV-Shows folder and not just the specific TV-show! Don't know if this has been fixed in later versions. Luckily I had a fresh backup of the entire folder. Phew.

Thanks for reporting, I'll check it. I never deleting a complete show, only single content.

 

Link to comment
Share on other sites

quickmic
On 7/1/2022 at 7:31 PM, djon said:

On 7.06 I just deleted a TV-Show in Kodi using the context menu. However it deleted my entire TV-Shows folder and not just the specific TV-show! Don't know if this has been fixed in later versions. Luckily I had a fresh backup of the entire folder. Phew.

When you say "TV-Shows folder" you mean the Emby server TV Show library, right?

I performed a test and looks ok in my (internal) 7.3.0 test version. Continuing review...

to all

Be very very careful when using the delete option and probably take backups before trying. I cannot check each and every case and if something is wrong it results in permanent delete.

Edited by quickmic
Link to comment
Share on other sites

quickmic

New version available 7.3.0

Delta changelog:

fix item remove issue (when moving content from one folder to another) -> major improvement (db went out of sync in previous version)
database performance improvements (adding indexs and reviewed all sql queries)
add support for same content (same folder) assigned to multiple libraries (major code update, even if this is just for an edge case)
fix Musicvideo Artist picture issue
fix Music "single" (album) delete issue
fix multicontent selection in native mode for edge cases (Item path != Mediasource[0]["Path"]
fix audio progress in native mode
add composer support for music
fix progress update issue when multiple Emby servers are synced to Kodi
fix content watched state when Kodi resets play position and content is makred as watched (playcount)
fix special features selection
fix progress report to Emby server for native mode when multi version content is playing

 

Comments

Lot's of modification were required to support same content/multiple libraries. I hope there is no collateral damage.
On the plus side, I unified lot's of code (again).
Database reset is mandatory, I hope it's the last one.
This version has a lot of changes under the hood and I removed some (sync) fallbacks which should never be triggered in the first place.
Let me know if there are sync issues.
Even several issues are fix in native mode, still not very well tested.

Edited by quickmic
Link to comment
Share on other sites

quickmic

New version available 7.3.1:

delta changelog:

Fix realtime content added issue

 

Link to comment
Share on other sites

djon
18 hours ago, quickmic said:

When you say "TV-Shows folder" you mean the Emby server TV Show library, right?

I performed a test and looks ok in my (internal) 7.3.0 test version. Continuing review...

to all

Be very very careful when using the delete option and probably take backups before trying. I cannot check each and every case and if something is wrong it results in permanent delete.

Hi, yes I tried to delete a show again, and in the popup warning I could see that it actually wrote it was going to delete /TV-Shows/ instead of /TV-Shows/TheShowToDelete so it seems to revert back to the root folder.

  • Like 1
Link to comment
Share on other sites

quickmic
11 hours ago, djon said:

Hi, yes I tried to delete a show again, and in the popup warning I could see that it actually wrote it was going to delete /TV-Shows/ instead of /TV-Shows/TheShowToDelete so it seems to revert back to the root folder.

Do you delete via context menu (emby options) or via "del" key (Kodi delete)? Native or addon mode?

Edited by quickmic
Link to comment
Share on other sites

quickmic

New version released 7.4.0:

Delta changelog:

Change skip intro implementation (if enabled, no more msg box by default) -> addon mode
Add skip credits support -> addon mode
Add skip intro and credits support -> native mode
Fix cinnemamode -> native mode

Comment:
Due to modifications in skip intro, once again a full database reset is mandatory. Sorry for the inconvenience, but this is still a development version.

Check the playback settings in plugin's config menu for intro skip and credits skip.

 

Damn sorry, there is a bug in in this version, I'll fix it in the next minutes.... -> use 7.5.0

Edited by quickmic
Link to comment
Share on other sites

quickmic

New version released 7.5.0:

delta changelog:

fix bug fron 7.4.0

Edited by quickmic
Link to comment
Share on other sites

heula

Since I switched to Next gen 7 I have a number of issues.

- No more fan art visible in Kodi. Everything is black and only when I turn off extra fan art I see 1 fan art on some TV shows. Everything just works fine in Emby.

- Photos are not displayed full screen when I click on a photo. When I click on play from here, all photos go full screen, but so fast that it is impossible to follow.

The photos can be displayed full screen from the widget.

- Bookmarks and watched status icons are not visible until I restart Kodi.

This was the case with 7.2.0 and 7.3.1

I will install the latest update tomorrow, but whether that version solves the problem?

 

Thank you

kodi.old.log embyserver.txt kodi.log

  • Like 1
Link to comment
Share on other sites

quickmic
33 minutes ago, heula said:

Since I switched to Next gen 7 I have a number of issues.

- No more fan art visible in Kodi. Everything is black and only when I turn off extra fan art I see 1 fan art on some TV shows. Everything just works fine in Emby.

- Photos are not displayed full screen when I click on a photo. When I click on play from here, all photos go full screen, but so fast that it is impossible to follow.

The photos can be displayed full screen from the widget.

- Bookmarks and watched status icons are not visible until I restart Kodi.

This was the case with 7.2.0 and 7.3.1

I will install the latest update tomorrow, but whether that version solves the problem?

 

Thank you

kodi.old.log 5.38 MB · 1 download embyserver.txt 5.03 MB · 0 downloads kodi.log 375.44 kB · 2 downloads

I'll have a deeper look  into your logs tomorrow. I can tell you this is not normal what you are reporting and surly not a general issue. As usual I recommend testing with stock skin and no exotic plugins and I know you have several of them. e.g. "screensaver.picture.slideshow" reports issues etc.

This doesn't mean, you shouldn't use the plugins, but it's always hard to identify the issue. I need to know, if a regular (stock) installation causes issues (I really doubt that), and if it's fine I need to know what combination causes issues.

Edited by quickmic
  • Like 1
Link to comment
Share on other sites

Pejamas

Just upgraded to 7.5, for some reason library sync is getting stuck on the last boxset item when resetting database.

 

2022-07-05 09:00:56.488 T:27523    INFO <general>: EMBY.core.movies: ADD to boxset [137/1165] Zoolander: 554 to boxset
2022-07-05 09:00:56.489 T:27523    INFO <general>: EMBY.core.movies: ADD to boxset [137/1166] Zoolander 2: 1212 to boxset
2022-07-05 09:00:56.508 T:27523    INFO <general>: EMBY.core.movies: UPDATE boxset [37597] 137 Zoolander Collection
2022-07-05 09:00:56.629 T:27523    INFO <general>: EMBY.database.dbio: ---< DBCloseRW: video/1262/worker_library rows updated on db close
2022-07-05 09:00:56.672 T:27523    INFO <general>: EMBY.core.folder: ADD OR REPLACE folder 3: H:\
2022-07-05 09:00:56.672 T:27523   ERROR <general>: Exception ignored in thread started by
2022-07-05 09:00:56.673 T:27523   ERROR <general>: :
2022-07-05 09:00:56.673 T:27523   ERROR <general>: <bound method Library.InitSync of <database.library.Library object at 0x2abca6e360>>
2022-07-05 09:00:56.673 T:27523   ERROR <general>:
                                                   
2022-07-05 09:00:56.673 T:27523   ERROR <general>: Traceback (most recent call last):
                                                   
2022-07-05 09:00:56.673 T:27523   ERROR <general>:   File "/storage/emulated/0/Android/data/org.xbmc.kodi/files/.kodi/addons/plugin.video.emby-next-gen/database/library.py", line 118, in InitSync
                                                   
2022-07-05 09:00:56.674 T:27523   ERROR <general>:     
2022-07-05 09:00:56.674 T:27523   ERROR <general>: self.select_libraries("AddLibrarySelection")
2022-07-05 09:00:56.674 T:27523   ERROR <general>:
                                                   
2022-07-05 09:00:56.674 T:27523   ERROR <general>:   File "/storage/emulated/0/Android/data/org.xbmc.kodi/files/.kodi/addons/plugin.video.emby-next-gen/database/library.py", line 683, in select_libraries
                                                   
2022-07-05 09:00:56.676 T:27523   ERROR <general>:     
2022-07-05 09:00:56.676 T:27523   ERROR <general>: self.worker_library()
2022-07-05 09:00:56.676 T:27523   ERROR <general>:
                                                   
2022-07-05 09:00:56.676 T:27523   ERROR <general>:   File "/storage/emulated/0/Android/data/org.xbmc.kodi/files/.kodi/addons/plugin.video.emby-next-gen/database/library.py", line 434, in worker_library
                                                   
2022-07-05 09:00:56.677 T:27523   ERROR <general>:     
2022-07-05 09:00:56.677 T:27523   ERROR <general>: Continue, embydb, kodidb = self.ItemOps(index, TotalRecords, Item, embydb, kodidb, SyncItem[4], "add/update")
2022-07-05 09:00:56.677 T:27523   ERROR <general>:
                                                   
2022-07-05 09:00:56.677 T:27523   ERROR <general>:   File "/storage/emulated/0/Android/data/org.xbmc.kodi/files/.kodi/addons/plugin.video.emby-next-gen/database/library.py", line 495, in ItemOps
                                                   
2022-07-05 09:00:56.679 T:27523   ERROR <general>:     
2022-07-05 09:00:56.679 T:27523   ERROR <general>: ProgressMsg = Item['Name']
2022-07-05 09:00:56.679 T:27523   ERROR <general>:
                                                   
2022-07-05 09:00:56.679 T:27523   ERROR <general>: KeyError
2022-07-05 09:00:56.679 T:27523   ERROR <general>: :
2022-07-05 09:00:56.679 T:27523   ERROR <general>: 'Name'
2022-07-05 09:00:56.679 T:27523   ERROR <general>:

Link to comment
Share on other sites

Pejamas

Just clean installed 6.2.20 as a reference, everything synced fine.

2022-07-05 09:16:39.610 T:29406    INFO <general>: INFO: EMBY.core.movies: ADD to boxset [137/1165] Zoolander: 554 to boxset
2022-07-05 09:16:39.610 T:29406    INFO <general>: INFO: EMBY.core.movies: ADD to boxset [137/1166] Zoolander 2: 1212 to boxset
2022-07-05 09:16:39.634 T:29406    INFO <general>: INFO: EMBY.core.movies: UPDATE boxset [37597] 137 Zoolander Collection
2022-07-05 09:16:39.661 T:29406    INFO <general>: INFO: EMBY.database.dbio: --->[video191862848704] 1142 rows updated on db close
2022-07-05 09:16:39.692 T:29406    INFO <general>: INFO: EMBY.database.dbio: ---<[video191862848704] 1142 rows updated on db close
2022-07-05 09:16:39.693 T:29406    INFO <general>: INFO: EMBY.database.dbio: ---<[ database: video191862848704/0 ]
2022-07-05 09:16:39.749 T:29406    INFO <general>: INFO: EMBY.database.library: -->[ library refresh video / worker library ]

  • Like 1
Link to comment
Share on other sites

quickmic
5 hours ago, Pejamas said:

Just upgraded to 7.5, for some reason library sync is getting stuck on the last boxset item when resetting database.

 

2022-07-05 09:00:56.488 T:27523    INFO <general>: EMBY.core.movies: ADD to boxset [137/1165] Zoolander: 554 to boxset
2022-07-05 09:00:56.489 T:27523    INFO <general>: EMBY.core.movies: ADD to boxset [137/1166] Zoolander 2: 1212 to boxset
2022-07-05 09:00:56.508 T:27523    INFO <general>: EMBY.core.movies: UPDATE boxset [37597] 137 Zoolander Collection
2022-07-05 09:00:56.629 T:27523    INFO <general>: EMBY.database.dbio: ---< DBCloseRW: video/1262/worker_library rows updated on db close
2022-07-05 09:00:56.672 T:27523    INFO <general>: EMBY.core.folder: ADD OR REPLACE folder 3: H:\
2022-07-05 09:00:56.672 T:27523   ERROR <general>: Exception ignored in thread started by
2022-07-05 09:00:56.673 T:27523   ERROR <general>: :
2022-07-05 09:00:56.673 T:27523   ERROR <general>: <bound method Library.InitSync of <database.library.Library object at 0x2abca6e360>>
2022-07-05 09:00:56.673 T:27523   ERROR <general>:
                                                   
2022-07-05 09:00:56.673 T:27523   ERROR <general>: Traceback (most recent call last):
                                                   
2022-07-05 09:00:56.673 T:27523   ERROR <general>:   File "/storage/emulated/0/Android/data/org.xbmc.kodi/files/.kodi/addons/plugin.video.emby-next-gen/database/library.py", line 118, in InitSync
                                                   
2022-07-05 09:00:56.674 T:27523   ERROR <general>:     
2022-07-05 09:00:56.674 T:27523   ERROR <general>: self.select_libraries("AddLibrarySelection")
2022-07-05 09:00:56.674 T:27523   ERROR <general>:
                                                   
2022-07-05 09:00:56.674 T:27523   ERROR <general>:   File "/storage/emulated/0/Android/data/org.xbmc.kodi/files/.kodi/addons/plugin.video.emby-next-gen/database/library.py", line 683, in select_libraries
                                                   
2022-07-05 09:00:56.676 T:27523   ERROR <general>:     
2022-07-05 09:00:56.676 T:27523   ERROR <general>: self.worker_library()
2022-07-05 09:00:56.676 T:27523   ERROR <general>:
                                                   
2022-07-05 09:00:56.676 T:27523   ERROR <general>:   File "/storage/emulated/0/Android/data/org.xbmc.kodi/files/.kodi/addons/plugin.video.emby-next-gen/database/library.py", line 434, in worker_library
                                                   
2022-07-05 09:00:56.677 T:27523   ERROR <general>:     
2022-07-05 09:00:56.677 T:27523   ERROR <general>: Continue, embydb, kodidb = self.ItemOps(index, TotalRecords, Item, embydb, kodidb, SyncItem[4], "add/update")
2022-07-05 09:00:56.677 T:27523   ERROR <general>:
                                                   
2022-07-05 09:00:56.677 T:27523   ERROR <general>:   File "/storage/emulated/0/Android/data/org.xbmc.kodi/files/.kodi/addons/plugin.video.emby-next-gen/database/library.py", line 495, in ItemOps
                                                   
2022-07-05 09:00:56.679 T:27523   ERROR <general>:     
2022-07-05 09:00:56.679 T:27523   ERROR <general>: ProgressMsg = Item['Name']
2022-07-05 09:00:56.679 T:27523   ERROR <general>:
                                                   
2022-07-05 09:00:56.679 T:27523   ERROR <general>: KeyError
2022-07-05 09:00:56.679 T:27523   ERROR <general>: :
2022-07-05 09:00:56.679 T:27523   ERROR <general>: 'Name'
2022-07-05 09:00:56.679 T:27523   ERROR <general>:

 

Very interesting, seems it's not related to the Boxsets, in 7.5.0 the Folder are synced too. This is were the plugin crashed due to a folder which has no name. Of course, I could just skip this issue, but I actually wanna know what's the matter here.

Last correctly added folder was your root folder "EMBY.core.folder: ADD OR REPLACE folder 3: H:\"

The next one caused the crash, is there anything "special" about your folders? Network share or dropbox, anything? Maybe an invalid (removed) folder still assigned to Emby server? No read/write permissions?

 

 

 

Edited by quickmic
Link to comment
Share on other sites

quickmic
10 hours ago, heula said:

Since I switched to Next gen 7 I have a number of issues.

- No more fan art visible in Kodi. Everything is black and only when I turn off extra fan art I see 1 fan art on some TV shows. Everything just works fine in Emby.

- Photos are not displayed full screen when I click on a photo. When I click on play from here, all photos go full screen, but so fast that it is impossible to follow.

The photos can be displayed full screen from the widget.

- Bookmarks and watched status icons are not visible until I restart Kodi.

This was the case with 7.2.0 and 7.3.1

I will install the latest update tomorrow, but whether that version solves the problem?

 

Thank you

kodi.old.log 5.38 MB · 2 downloads embyserver.txt 5.03 MB · 0 downloads kodi.log 375.44 kB · 4 downloads

You are using skin.aeon.nox.silvo skin, right?

Link to comment
Share on other sites

Pejamas
21 minutes ago, quickmic said:

 

Very interesting, seems it's not related to the Boxsets, in 7.5.0 the Folder are synced too. This is were the plugin crashed due to a folder which has no name. Of course, I could just skip this issue, but I actually wanna know what's the matter here.

Last correctly added folder was your root folder "EMBY.core.folder: ADD OR REPLACE folder 3: H:\"

The next one caused the crash, is there anything "special" about your folders? Network share or dropbox, anything? Maybe an invalid (removed) folder still assigned to Emby server? No read/write permissions?

 

 

 

Just normal windows drives, no missing folders or special shares etc so I'm not sure what it could be. 7.2 worked fine and 6.2.20 also worked fine. I initially upgraded from 7.2 to 7.5 and had the issue, then tried a clean install and still had the issue, then a clean install with 6.2.20 worked so I'm stumped.

Link to comment
Share on other sites

quickmic
41 minutes ago, Pejamas said:

Just normal windows drives, no missing folders or special shares etc so I'm not sure what it could be. 7.2 worked fine and 6.2.20 also worked fine. I initially upgraded from 7.2 to 7.5 and had the issue, then tried a clean install and still had the issue, then a clean install with 6.2.20 worked so I'm stumped.

7.2.0 didn't sync the folders. This was new in 7.3.0 and above. I'll send you a test version which just ignores the issue but I need a kodi.log after init sync from you for review.

I'll send you the version in the next minutes via PM.

Link to comment
Share on other sites

heula
1 hour ago, quickmic said:

You are using skin.aeon.nox.silvo skin, right?

Yes. All worked fine with next gen 6.

Link to comment
Share on other sites

quickmic
56 minutes ago, heula said:

Yes. All worked fine with next gen 6.

I installed skin.aeon.nox.silvo.

About fanart:

Looks ok to me (stock skin.aeon.nox.silvo installation), will check extra fanart settings....

 

 

 

sc1.png

Edited by quickmic
Link to comment
Share on other sites

heula
5 minutes ago, quickmic said:

I installed skin.aeon.nox.silvo.

About fanart:

Looks ok to me (stock skin.aeon.nox.silvo installation)

 

 

 

sc1.png

Weird, i have 4 shield tv devices and two of them run next gen 7 and both have the same issue now. The two devices with next gen 6 have no issues with fanart.

 

I have tried deleting textures.db and the thumbnails folder but non of that helped. 

Link to comment
Share on other sites

quickmic
4 minutes ago, heula said:

Weird, i have 4 shield tv devices and two of them run next gen 7 and both have the same issue now. The two devices with next gen 6 have no issues with fanart.

 

I have tried deleting textures.db and the thumbnails folder but non of that helped. 

I deleted all my artwork, and I think I see the issue. Once cached, it's fine. For some reason the skin doesn't load the URLs properly. Will check.

  • Thanks 1
Link to comment
Share on other sites

quickmic
15 minutes ago, heula said:

Weird, i have 4 shield tv devices and two of them run next gen 7 and both have the same issue now. The two devices with next gen 6 have no issues with fanart.

 

I have tried deleting textures.db and the thumbnails folder but non of that helped. 

I've send you a test version via PM

Link to comment
Share on other sites

Onana
3 hours ago, quickmic said:

I deleted all my artwork, and I think I see the issue. Once cached, it's fine. For some reason the skin doesn't load the URLs properly. Will check.

Hi

i don’t know if it’s related, but on skin artic horizon 2 by jurialmunkey , episodes thumbnails do not show using version 7.2.0  or up. 
Everything is ok if I use Plex for kodi.

image.thumb.jpeg.ad0cce8402b11455e9edeb27ebc870ae.jpeg

  • Like 1
Link to comment
Share on other sites

quickmic
1 minute ago, Onana said:

Hi

i don’t know if it’s related, but on skin artic horizon 2 by jurialmunkey , episodes thumbnails do not show using version 7.2.0  or up. 
Everything is ok if I use Plex for kodi.

image.thumb.jpeg.ad0cce8402b11455e9edeb27ebc870ae.jpeg

Thanks for reporting, will be fixed in next version.

Link to comment
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now
×
×
  • Create New...