Jump to content

Recommended Posts

Happy2Play
Posted

I found out why they draw so big on the canvas. Smaller width and height actually zooms in in the canvas (in a way) this would cause them to be drawn larger, as if you were closer to the charts. I have fix it.

 

But, I'm still trying to find the checkbox issue.

Is it not what I mentioned here?  I know if I remove and rebuild the check marks are gone for me.

Posted (edited)

Is it not what I mentioned here? I know if I remove and rebuild the check marks are gone for me.

I tried it, but I get no check marks in the boxes at all if I remove the span.

If you display none on the outline, does it affect other check boxes in the web app?

I'll try again.

Edited by chef
Happy2Play
Posted

I tried it, but I get no check marks in the boxes at all if I remove the span.

If you display none on the outline, does it affect other check boxes in the web app?

I'll try again.

Deleting that element or using css (span.checkboxOutline {display: none;}) gets rid of the additional check mark for me, but have only tested locally.

 

 

Also I see not difference with the issues of clicking "Okay" while on Table then changing to Graph.

Happy2Play
Posted (edited)

@@chef removing lines 293-296 give me this.

 

5e3e0cd8a6ef0_dialog.jpg

Edited by Happy2Play
v1.0.2.4 modified
Happy2Play
Posted (edited)

@@chef This change works for my beta 4.4.0.12 server, but just verified in current stable 4.3.1.0 if removes the checkbox.

 

1.0.2.92 does not have the additional check on 4.3.1.0, but does on 4.4.0.12.  I assume do to code change.

Edited by Happy2Play
  • Like 1
Posted (edited)

So Luke might be making some changes to web app web component libraries in beta?

 

How to proceed? Leave the code for non beta users or remove the code?

Edited by chef
Happy2Play
Posted

So Luke might be making some changes to web app web component libraries in beta?

 

How to proceed? Leave the code for non beta users or remove the code?

It is a matter of knowing beta users will have a different experience, and you will have to make changes in the next server release.  So it is a matter of are you will to maintain two branches?  Or make beta users wait for updates until a new stable has dropped. 

 

In the end it is how much work do you want to do.

  • Like 1
Posted

Hi @@chef, Not sure if you have fixed/tried to fix the image size issue, but I'm still seeing it on v1.0.2.92.

Posted (edited)

1.0.2.93 - here is how i hopefully fixed the canvas sizing issue. Read if you are a nerd.

 

Before the fix, when the page loaded all the canvas's (charts) and table data were drawn to the DOM. They were either hidden or shown.

 

But problems with the canvas sizing would happen if:

 

1. you went into table view

2. changed how many drives were going to be drawn with canvas

3. switched back to chart view (showing the canvas elements).

 

Because all the canvases were drawn on load, but were hidden, when they were shown again wierd $h#t happened to them. Because things were removed or added to the DOM but nothing on the canvas elements was redrawn.

some were big, some were small.

 

Now the plugin redraws them each time you switch to show the chart (canvas) view.

 

I hope this handles the chart elements being drawn strangely.

 

I haven't seen it happen since they have been set to redraw, and I've been testing it a bunch this afternoon.

Edited by chef
  • Like 5
Posted (edited)

Canvas is indeed fixed. thanks.

 

Still got ticks though  ;)

Edited by jordy
Posted

1.0.2.93 - here is how i hopefully fixed the canvas sizing issue.

Great work over the few days @@chef.

 

This plugin is really, really useful.

 

I think it has been suggested before in this thread, but is having separate thresholds for each drive on your ToDo list?

Posted

Great work over the few days @@chef.

 

This plugin is really, really useful.

 

I think it has been suggested before in this thread, but is having separate thresholds for each drive on your ToDo list?

I think this can be done by creating a dialog for each drive.

We'd need a click event on each chart card and also on each table entry.

 

We'd also have to remove entries from the config.

 

I think it can be done

  • Like 1
Posted

Not sure what changed here, but I doubt this was what you had in mind:

 

5e41a174e0fd6_Untitled.png

 

Also, I'm still missing labels:

 

5e41a1bed0ec0_Untitled2.png

Posted (edited)

Not sure what changed here, but I doubt this was what you had in mind:

 

5e41a174e0fd6_Untitled.png

 

Also, I'm still missing labels:

 

5e41a1bed0ec0_Untitled2.png

That is strange. That shouldn't happen at all. Is that up to date? What happens when you refresh the page? Edited by chef
Posted (edited)

That is strange. That shouldn't happen at all. Is that up to date? What happens when you refresh the page?

With all the updates going, not sure if I'm on the latest version... lol

 

Version 1.0.2.93

 

When I refresh, it's exactly the same... Once done with the current stuff in this browser (some downloads that take ages) I'll close the browser and see what happens then

Edited by Dibbes
Posted

With all the updates going, not sure if I'm on the latest version... lol

 

Version 1.0.2.93

 

When I refresh, it's exactly the same... Once done with the current stuff in this browser (some downloads that take ages) I'll close the browser and see what happens then

Interesting that the drives are repeating the first three.

 

I'll look and see what might be causing that to happen.

Posted

Interesting that the drives are repeating the first three.

 

I'll look and see what might be causing that to happen.

 

All are repeated, that's just the cut-off of the screenshot... Let me first test further before you start digging though... I've had this browser open for 3 weeks...

Posted

I've had this browser open for 3 weeks...

 

Three weeks !!!

 

Do you have another browser you can use?

Posted (edited)

Three weeks !!!

 

Do you have another browser you can use?

 

Long download... it's a bit of a pain... should be done tomorrow

 

Mozilla displays fine... tried on another VM with Chrome and it's fine too, so I suppose it's this specific browser...

 

No matter which browser I use, I'm still missing the labels for my T and U drives... they display in the Windows explorer though...

Edited by Dibbes
  • Like 1
Posted

Long download... it's a bit of a pain... should be done tomorrow

 

 

Are you downloading the world :D

  • Like 2
Posted (edited)

Are you downloading the world :D

 

LoL! No, copying the contents from a file-server from a site with a 5Mbit connection and need the browser to keep the session alive... then a few Tera is an awful lot of data

Edited by Dibbes
  • Like 2
Posted

Great work over the few days @@chef.

 

This plugin is really, really useful.

 

I think it has been suggested before in this thread, but is having separate thresholds for each drive on your ToDo list?

 

 

This has been added to 1.0.2.94.

 

Might need some tweeking... 

  • Like 1
Posted

This has been added to 1.0.2.94.

 

Might need some tweeking...

Thanks Chef.

 

I'll have a play in a bit.

Posted

This has been added to 1.0.2.94.

 

Might need some tweeking...

I'm not seeing any way of adding the threshold in the PIE chart display.

 

I can see the ... option in the LINE chart.

Posted

This has been added to 1.0.2.94.

 

Might need some tweeking...

The THRESHOLD settings aren't being saved.

 

I'll delete the xml file and try again.

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now
×
×
  • Create New...