Happy2Play 8304 Posted February 8, 2020 Share Posted February 8, 2020 I found out why they draw so big on the canvas. Smaller width and height actually zooms in in the canvas (in a way) this would cause them to be drawn larger, as if you were closer to the charts. I have fix it. But, I'm still trying to find the checkbox issue. Is it not what I mentioned here? I know if I remove and rebuild the check marks are gone for me. Link to comment Share on other sites More sharing options...
chef 3746 Posted February 8, 2020 Author Share Posted February 8, 2020 (edited) Is it not what I mentioned here? I know if I remove and rebuild the check marks are gone for me.I tried it, but I get no check marks in the boxes at all if I remove the span. If you display none on the outline, does it affect other check boxes in the web app? I'll try again. Edited February 8, 2020 by chef Link to comment Share on other sites More sharing options...
Happy2Play 8304 Posted February 8, 2020 Share Posted February 8, 2020 I tried it, but I get no check marks in the boxes at all if I remove the span. If you display none on the outline, does it affect other check boxes in the web app? I'll try again. Deleting that element or using css (span.checkboxOutline {display: none;}) gets rid of the additional check mark for me, but have only tested locally. Also I see not difference with the issues of clicking "Okay" while on Table then changing to Graph. Link to comment Share on other sites More sharing options...
Happy2Play 8304 Posted February 8, 2020 Share Posted February 8, 2020 (edited) @@chef removing lines 293-296 give me this. Edited February 8, 2020 by Happy2Play v1.0.2.4 modified Link to comment Share on other sites More sharing options...
Happy2Play 8304 Posted February 8, 2020 Share Posted February 8, 2020 (edited) @@chef This change works for my beta 4.4.0.12 server, but just verified in current stable 4.3.1.0 if removes the checkbox. 1.0.2.92 does not have the additional check on 4.3.1.0, but does on 4.4.0.12. I assume do to code change. Edited February 8, 2020 by Happy2Play 1 Link to comment Share on other sites More sharing options...
chef 3746 Posted February 8, 2020 Author Share Posted February 8, 2020 (edited) So Luke might be making some changes to web app web component libraries in beta? How to proceed? Leave the code for non beta users or remove the code? Edited February 8, 2020 by chef Link to comment Share on other sites More sharing options...
Happy2Play 8304 Posted February 8, 2020 Share Posted February 8, 2020 So Luke might be making some changes to web app web component libraries in beta? How to proceed? Leave the code for non beta users or remove the code? It is a matter of knowing beta users will have a different experience, and you will have to make changes in the next server release. So it is a matter of are you will to maintain two branches? Or make beta users wait for updates until a new stable has dropped. In the end it is how much work do you want to do. 1 Link to comment Share on other sites More sharing options...
jordy 284 Posted February 8, 2020 Share Posted February 8, 2020 Hi @@chef, Not sure if you have fixed/tried to fix the image size issue, but I'm still seeing it on v1.0.2.92. Link to comment Share on other sites More sharing options...
chef 3746 Posted February 8, 2020 Author Share Posted February 8, 2020 (edited) 1.0.2.93 - here is how i hopefully fixed the canvas sizing issue. Read if you are a nerd. Before the fix, when the page loaded all the canvas's (charts) and table data were drawn to the DOM. They were either hidden or shown. But problems with the canvas sizing would happen if: 1. you went into table view 2. changed how many drives were going to be drawn with canvas 3. switched back to chart view (showing the canvas elements). Because all the canvases were drawn on load, but were hidden, when they were shown again wierd $h#t happened to them. Because things were removed or added to the DOM but nothing on the canvas elements was redrawn. some were big, some were small. Now the plugin redraws them each time you switch to show the chart (canvas) view. I hope this handles the chart elements being drawn strangely. I haven't seen it happen since they have been set to redraw, and I've been testing it a bunch this afternoon. Edited February 9, 2020 by chef 5 Link to comment Share on other sites More sharing options...
jordy 284 Posted February 9, 2020 Share Posted February 9, 2020 (edited) Canvas is indeed fixed. thanks. Still got ticks though Edited February 9, 2020 by jordy Link to comment Share on other sites More sharing options...
CBers 6771 Posted February 10, 2020 Share Posted February 10, 2020 1.0.2.93 - here is how i hopefully fixed the canvas sizing issue. Great work over the few days @@chef. This plugin is really, really useful. I think it has been suggested before in this thread, but is having separate thresholds for each drive on your ToDo list? Link to comment Share on other sites More sharing options...
chef 3746 Posted February 10, 2020 Author Share Posted February 10, 2020 Great work over the few days @@chef. This plugin is really, really useful. I think it has been suggested before in this thread, but is having separate thresholds for each drive on your ToDo list? I think this can be done by creating a dialog for each drive. We'd need a click event on each chart card and also on each table entry. We'd also have to remove entries from the config. I think it can be done 1 Link to comment Share on other sites More sharing options...
Dibbes 431 Posted February 10, 2020 Share Posted February 10, 2020 Not sure what changed here, but I doubt this was what you had in mind: Also, I'm still missing labels: Link to comment Share on other sites More sharing options...
chef 3746 Posted February 11, 2020 Author Share Posted February 11, 2020 (edited) Not sure what changed here, but I doubt this was what you had in mind: Also, I'm still missing labels: That is strange. That shouldn't happen at all. Is that up to date? What happens when you refresh the page? Edited February 11, 2020 by chef Link to comment Share on other sites More sharing options...
Dibbes 431 Posted February 11, 2020 Share Posted February 11, 2020 (edited) That is strange. That shouldn't happen at all. Is that up to date? What happens when you refresh the page? With all the updates going, not sure if I'm on the latest version... lol Version 1.0.2.93 When I refresh, it's exactly the same... Once done with the current stuff in this browser (some downloads that take ages) I'll close the browser and see what happens then Edited February 11, 2020 by Dibbes Link to comment Share on other sites More sharing options...
chef 3746 Posted February 11, 2020 Author Share Posted February 11, 2020 With all the updates going, not sure if I'm on the latest version... lol Version 1.0.2.93 When I refresh, it's exactly the same... Once done with the current stuff in this browser (some downloads that take ages) I'll close the browser and see what happens then Interesting that the drives are repeating the first three. I'll look and see what might be causing that to happen. Link to comment Share on other sites More sharing options...
Dibbes 431 Posted February 11, 2020 Share Posted February 11, 2020 Interesting that the drives are repeating the first three. I'll look and see what might be causing that to happen. All are repeated, that's just the cut-off of the screenshot... Let me first test further before you start digging though... I've had this browser open for 3 weeks... Link to comment Share on other sites More sharing options...
CBers 6771 Posted February 11, 2020 Share Posted February 11, 2020 I've had this browser open for 3 weeks... Three weeks !!! Do you have another browser you can use? Link to comment Share on other sites More sharing options...
Dibbes 431 Posted February 11, 2020 Share Posted February 11, 2020 (edited) Three weeks !!! Do you have another browser you can use? Long download... it's a bit of a pain... should be done tomorrow Mozilla displays fine... tried on another VM with Chrome and it's fine too, so I suppose it's this specific browser... No matter which browser I use, I'm still missing the labels for my T and U drives... they display in the Windows explorer though... Edited February 11, 2020 by Dibbes 1 Link to comment Share on other sites More sharing options...
CBers 6771 Posted February 11, 2020 Share Posted February 11, 2020 Long download... it's a bit of a pain... should be done tomorrow Are you downloading the world 2 Link to comment Share on other sites More sharing options...
Dibbes 431 Posted February 11, 2020 Share Posted February 11, 2020 (edited) Are you downloading the world LoL! No, copying the contents from a file-server from a site with a 5Mbit connection and need the browser to keep the session alive... then a few Tera is an awful lot of data Edited February 11, 2020 by Dibbes 2 Link to comment Share on other sites More sharing options...
chef 3746 Posted February 12, 2020 Author Share Posted February 12, 2020 Great work over the few days @@chef. This plugin is really, really useful. I think it has been suggested before in this thread, but is having separate thresholds for each drive on your ToDo list? This has been added to 1.0.2.94. Might need some tweeking... 1 Link to comment Share on other sites More sharing options...
CBers 6771 Posted February 12, 2020 Share Posted February 12, 2020 This has been added to 1.0.2.94. Might need some tweeking... Thanks Chef. I'll have a play in a bit. Link to comment Share on other sites More sharing options...
CBers 6771 Posted February 12, 2020 Share Posted February 12, 2020 This has been added to 1.0.2.94. Might need some tweeking... I'm not seeing any way of adding the threshold in the PIE chart display. I can see the ... option in the LINE chart. Link to comment Share on other sites More sharing options...
CBers 6771 Posted February 12, 2020 Share Posted February 12, 2020 This has been added to 1.0.2.94. Might need some tweeking... The THRESHOLD settings aren't being saved. I'll delete the xml file and try again. Link to comment Share on other sites More sharing options...
Recommended Posts
Create an account or sign in to comment
You need to be a member in order to leave a comment
Create an account
Sign up for a new account in our community. It's easy!
Register a new accountSign in
Already have an account? Sign in here.
Sign In Now