New Plugin - Disk Space

[jordy 284]

ooh! just remembered something else.

 

The Emby for Android App (beta .96) does not show the Disk Space plugin under the Advanced category (or anywhere else) in Server Management Settings. Don't know if this is intentional or not...

 

jordy

[CBers 6780]

ooh! just remembered something else.

 

The Emby for Android App (beta .96) does not show the Disk Space plugin under the Advanced category (or anywhere else) in Server Management Settings. Don't know if this is intentional or not...

 

jordy

 

It doesn't in beta .97 either, but it does in the mobile dashboard via Chrome.

[Happy2Play 8340]

The clicking the config "okay" while on Table, then changing to Graph issue looks like a refresh issue.  Refreshing or navigating away and back the Graph resolves itself.

[chef 3749]

That was the weird canvas thing I mentioned. I tried to limit the size of the chart by giving it a max-width. But it hasn't worked.

 

Strange that the checkboxes on the dialog have check mark icons outside the box.

 

I've got some fixes to straighten up the issues.

Edited February 7, 2020 by chef

[chef 3749]

ooh! just remembered something else.

 

The Emby for Android App (beta .96) does not show the Disk Space plugin under the Advanced category (or anywhere else) in Server Management Settings. Don't know if this is intentional or not...

 

jordy

I think it is intentional not to show 3rd party plugins in Mobile apps.

 

This is okay, since most of what this plugin is good for has to do with library setup and that is probably best done on a desktop in the web app anyway.

 

 

@@Luke, there are two variables in the PluginPageInfo class I was hoping to take advantage of, they are listed but don't seem to be available. MenuIcon and also MenuSection.

 

They've been there for a while, but aren't wired up.

[chef 3749]

@@chef - great work with this plugin.

 

Question: What does the TICK next to each drive signify please?

 

 

This is in the configuration screen.

 

Thanks.

 

 

@@CBers, do you have custom CSS installed here?

[jordy 284]

The clicking the config "okay" while on Table, then changing to Graph issue looks like a refresh issue.  Refreshing or navigating away and back the Graph resolves itself.

If by "Clicking Away" you mean opening another page and then re-opening the Disk Space plugin, then yes, I concur, the images resize themselves correctly on re-opening - without any further interactions.

[Happy2Play 8340]

@@CBers, do you have custom CSS installed here?

No custom css. 

 

 

4.4.0.12

Edited February 7, 2020 by Happy2Play

[chef 3749]

I don't know if that is because I removed the "is="emby-checkbox" attribute, or if it is because once the classes are added to the input for style, the label check box hack is applied for you and therefore the HTML doesn't have to be written. Which would cause the checkmark.

 

Does that make sense @@Happy2Play

 

I don't see the white check mark because it is hidden by the white background. There is going to be at least two updates before it's figured out. One to add back the "is="emby-checkbox" attribute and one to remove html.

 

This is why a wiki might have to be created for how emby creates elements in the DOM and how to properly use it's custom attributes.

Edited February 7, 2020 by chef

[CBers 6780]

@@CBers, do you have custom CSS installed here?

Yes.

[chef 3749]

1.0.2.9

 

Hopefully the extra check mark has disappeared

 

Fixed odd canvas sizing issue.

[Happy2Play 8340]

1.0.2.9

 

Hopefully the extra check mark has disappeared

 

Fixed odd canvas sizing issue.

I see no change in either issue.

[chef 3749]

I see no change in either issue.

What happens if you clear browsing data?

[Happy2Play 8340]

What happens if you clear browsing data?

Same thing, even tried a different browser.

 

css gets rid of the extra check though.

span.checkboxOutline {display: none;}

[chef 3749]

i think i got 1.0.2.91. 

[Happy2Play 8340]

i think i got 1.0.2.91. 

Sorry I still see no change.

 

I see it is a old version but removing these lines gets rid of the additional check marks

https://github.com/chefbennyj1/Emby.DiskSpace/blob/master/DiskSpace/Configuration/DiskSpacePluginConfigurationPage.js#L293-L296

 

To me it doesn't look like line 292 (emby-checkbox-focushelper) is doing anything either.

Edited February 7, 2020 by Happy2Play

[Psyborg 43]

Unfortunately I don't see any changes, too. ...since some releases.

 

This seems to be a strange effect caused by the config file DiskSpace.xml. My one does not look good in an editor with many doubled entries in <IgnoredPartitions> and even some empty entries there ( <string /> ). So I edited the xml and saved it back. But it is not used by DiskSpace and got overwritten by the same wrong config again.

 

What can I do? Everything is looking exactly like on my last screenshot.

[chef 3749]

Unfortunately I don't see any changes, too. ...since some releases.

 

This seems to be a strange effect caused by the config file DiskSpace.xml. My one does not look good in an editor with many doubled entries in <IgnoredPartitions> and even some empty entries there ( <string /> ). So I edited the xml and saved it back. But it is not used by DiskSpace and got overwritten by the same wrong config again.

 

What can I do? Everything is looking exactly like on my last screenshot.

Could you post your XML? There shouldn't be any private data in it.

 

Maybe place it in some code brackets.

[Psyborg 43]

Sure.

 

This is my cleaned version:

<?xml version="1.0"?>
<PluginConfiguration xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:xsd="http://www.w3.org/2001/XMLSchema">
  <AvailableColor>#ffffff</AvailableColor>
  <AvailableOutline>#000123</AvailableOutline>
  <UsedColor>#000231</UsedColor>
  <UsedOutline>#000124</UsedOutline>
  <Threshold>10</Threshold>
  <IgnoredPartitions>
    <string>tmp</string>
    <string>share</string>
    <string>mntsnapshotexport</string>
    <string>mntHDA_ROOT</string>
    <string>shareCACHEDEV1_DATA</string>
    <string>shareCACHEDEV2_DATA</string>
    <string>shareCACHEDEV3_DATA</string>
    <string>mntext</string>
    <string>mntrfnd</string>
    <string>shareexternal.cm</string>
    <string>shareCACHEDEV1_DATA.sambalockmsg.lock</string>
    <string>mntextoptsambaprivatemsg.sock</string>
    <string>shareCACHEDEV1_DATA.qpkgHD_Stationshare</string>
  </IgnoredPartitions>
  <DataDisplayRender>table</DataDisplayRender>
</PluginConfiguration>

This is the "original" stubborn version: 

<?xml version="1.0"?>
<PluginConfiguration xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:xsd="http://www.w3.org/2001/XMLSchema">
  <AvailableColor>#ffffff</AvailableColor>
  <AvailableOutline>#000123</AvailableOutline>
  <UsedColor>#000231</UsedColor>
  <UsedOutline>#000124</UsedOutline>
  <Threshold>10</Threshold>
  <IgnoredPartitions>
    <string />
    <string>tmp</string>
    <string>share</string>
    <string>mntsnapshotexport</string>
    <string>mntHDA_ROOT</string>
    <string>shareCACHEDEV1_DATA</string>
    <string>shareCACHEDEV2_DATA</string>
    <string>shareCACHEDEV3_DATA</string>
    <string>mntext</string>
    <string>mntrfnd</string>
    <string>shareexternal.cm</string>
    <string />
    <string>tmp</string>
    <string>share</string>
    <string>mntsnapshotexport</string>
    <string>mntHDA_ROOT</string>
    <string>shareCACHEDEV1_DATA</string>
    <string>shareCACHEDEV2_DATA</string>
    <string>shareCACHEDEV3_DATA</string>
    <string>mntext</string>
    <string>mntrfnd</string>
    <string>shareexternal.cm</string>
    <string>shareCACHEDEV1_DATA.sambalockmsg.lock</string>
    <string>mntextoptsambaprivatemsg.sock</string>
    <string>shareCACHEDEV1_DATA.qpkgHD_Stationshare</string>
    <string />
    <string>tmp</string>
    <string>share</string>
    <string>mntsnapshotexport</string>
    <string>mntHDA_ROOT</string>
    <string>shareCACHEDEV1_DATA</string>
    <string>shareCACHEDEV2_DATA</string>
    <string>shareCACHEDEV3_DATA</string>
    <string>mntext</string>
    <string>mntrfnd</string>
    <string>shareexternal.cm</string>
    <string>shareCACHEDEV1_DATA.sambalockmsg.lock</string>
    <string>mntextoptsambaprivatemsg.sock</string>
    <string>shareCACHEDEV1_DATA.qpkgHD_Stationshare</string>
  </IgnoredPartitions>
  <DataDisplayRender>table</DataDisplayRender>
</PluginConfiguration>

[chef 3749]

Can you please delete the XML, and restart the server?

 

Something has happened to it and it might have happened during a couple of prior updates before the config was ironed out.

 

Then keep an eye on it and let me know if this happens again.

Edited February 7, 2020 by chef

[Psyborg 43]

There is a user online now.

 

But I tried this before. After restarting the server the same bad xml was created again after entering Disk Space.

 

I will try later again to double check it.

[Psyborg 43]

Ok, after an Emby crash it worked now and the xml was newly generated:

<?xml version="1.0" ?> 
- <PluginConfiguration xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:xsd="http://www.w3.org/2001/XMLSchema">
  <DataDisplayRender>chart</DataDisplayRender> 
  </PluginConfiguration>

This is the original state with normal sized charts after the new start:

 

and no entries in the tables view:

 

 

Originally every entry was checked in the config. After unchecking the unwanted entries like this...

 

 

...and pressing OK then, the config is saved again and contains this:

<?xml version="1.0"?>
<PluginConfiguration xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:xsd="http://www.w3.org/2001/XMLSchema">
  <IgnoredPartitions>
    <string />
    <string>tmp</string>
    <string>share</string>
    <string>mntsnapshotexport</string>
    <string>mntHDA_ROOT</string>
    <string>shareCACHEDEV1_DATA</string>
    <string>shareCACHEDEV2_DATA</string>
    <string>shareCACHEDEV3_DATA</string>
    <string>mntext</string>
    <string>mntrfnd</string>
    <string>shareexternal.cm</string>
    <string>shareCACHEDEV1_DATA.sambalockmsg.lock</string>
    <string>mntextoptsambaprivatemsg.sock</string>
    <string>shareCACHEDEV1_DATA.qpkgHD_Stationshare</string>
  </IgnoredPartitions>
  <DataDisplayRender>table</DataDisplayRender>
</PluginConfiguration>

Now the unwanted folders are gone, but the remaining drives are looking really big. BTW: The names generally show only the first part ("/shar"):

 

...and in the config all folders look like checked again:

 

Phew! Quite a long story. 

 

In a nutshell: 

- The config is not showing the current state of the enabled/disabled drives and after unchecking drives again they are added to the already added entries in the XML.

- The table view does never show anything for me.

- With many entries the charts are normally sized; with few entries it's way too big. 

- The drive titles show only the first part of the path instead of the last one.

 

 

[chef 3749]

Thank you.

 

What browser is that. Is it Firefox by chance?

[Psyborg 43]

Thank you.

 

What browser is that. Is it Firefox by chance?

 

It's Vivaldi (= Chromium-based).

[chef 3749]

I found out why they draw so big on the canvas. Smaller width and height actually zooms in in the canvas (in a way) this would cause them to be drawn larger, as if you were closer to the charts. I have fix it.

 

But, I'm still trying to find the checkbox issue.