Jump to content

embyforkodi (next-gen) 10.X.X support


quickmic

Recommended Posts

FrostByte
3 hours ago, quickmic said:

New PUBLIC TESTING version available 10.0.10:

Delta changelog 10.0.9 -> 10.0.10

change hdrtype assignment to "VideoRange"
change urllib3 dependency to >= 2.0 version
fix library removal issue for edge case

Most excellent.  E4K is now populating hdrtype for mkv and I can see the flags in skins that support it.

Heads up to others I did have to do a rebuild on movies/tvshows before it showed.

I did not check HLG as I no longer have anything in my library with that hdrtype, but I'm sure videorange supports HLG when I had it in the past so it should work.

image.thumb.jpeg.4f830e90da7201c434db24eeb5ea9ff0.jpeg

image.jpeg.c42e399a534e3de73b5fcc57c1564c9f.jpeg

  • Like 1
Link to comment
Share on other sites

alghorabi

Im having an issue logging in through emby connect

 

it throws an error ive added part of the log file 

2024-03-18 22:27:20.751 T:28034 debug <general>: EMBY.emby.http: [ http ] {'type': 'POST', 'url': 'https://connect.emby.media/service/user/authenticate', 'data': {'nameOrEmail': 'redacted.redacted@redacted.com', 'rawpw': 'redaCted'}} 2024-03-18 22:27:20.756 T:28156 debug <general>: EMBY.emby.http: THREAD: --->[ async queue ] 2024-03-18 22:27:20.756 T:28157 debug <general>: EMBY.emby.http: THREAD: --->[ async file download ] 2024-03-18 22:27:21.323 T:28034 error <general>: EMBY.emby.http: [ Unknown ] Expecting value: line 1 column 1 (char 0) 2024-03-18 22:27:21.323 T:28034 debug <general>: EMBY.emby.http: [ Unknown ] {'type': 'POST', 'url': 'https://connect.emby.media/service/user/authenticate', 'data': {'nameOrEmail': 'redacted.redacted@redacted.com', 'rawpw': 'redaCted'}} / Expecting value: line 1 column 1 (char 0)

 

I just modded the log and removed my password

Edited by alghorabi
Typos
  • Like 1
Link to comment
Share on other sites

Pejamas
On 18/03/2024 at 19:00, FrostByte said:

Most excellent.  E4K is now populating hdrtype for mkv and I can see the flags in skins that support it.

Heads up to others I did have to do a rebuild on movies/tvshows before it showed.

I did not check HLG as I no longer have anything in my library with that hdrtype, but I'm sure videorange supports HLG when I had it in the past so it should work.

image.thumb.jpeg.4f830e90da7201c434db24eeb5ea9ff0.jpeg

image.jpeg.c42e399a534e3de73b5fcc57c1564c9f.jpeg

Yep working here too after a rebuild. Although all my 1080p non HDR content is flagged with HDR (anything that doesn't have a video range in emby)

Link to comment
Share on other sites

FrostByte

Odd, all my 1080p was marked SDR (except the one 1080p which is actually HDR).  None of them have a video range.

image.thumb.jpeg.d8ab50fbeef069212a37cacbe079818a.jpeg

Link to comment
Share on other sites

Pejamas
2 hours ago, FrostByte said:

Odd, all my 1080p was marked SDR (except the one 1080p which is actually HDR).  None of them have a video range.

image.thumb.jpeg.d8ab50fbeef069212a37cacbe079818a.jpeg

I more just mean visually within the Kodi skin. Non HDR content says HDR but HDR content says hdr10

Link to comment
Share on other sites

FrostByte
15 minutes ago, Pejamas said:

I more just mean visually within the Kodi skin. Non HDR content says HDR but HDR content says hdr10

Maybe an issue with the logic in the skin?  jurialmunkey says he ignores anything other than "dolbyvision", "hdr10", or "hlg" in that field.  Anyway, it appears to work in Arctic Fuse.  Maybe try using a different skin and see what you get.  Edit: Estuary probably shows flags also based on hdrtype.

 

image.jpeg.31167e5f44eed94c537c50875fa449f4.jpeg

Edited by FrostByte
Link to comment
Share on other sites

FrostByte

I wonder if instead of putting "sdr" in that field it should be blank or null.  If Kodi only uses dolbyvision, hlg, and hdr10.

Link to comment
Share on other sites

FrostByte

Looks like Estuary is putting a blank space for a flag on SDR media now.  I don't think it did that before when it was blank.

image.jpeg.c547f729f4c80c46f2f28b4622a8946c.jpeg

Link to comment
Share on other sites

quickmic
2 hours ago, FrostByte said:

I wonder if instead of putting "sdr" in that field it should be blank or null.  If Kodi only uses dolbyvision, hlg, and hdr10.

Will do, seems Kodi is very picky or in better words. Inconsistent and not well designed.

  • Haha 1
Link to comment
Share on other sites

FrostByte
53 minutes ago, quickmic said:

Will do, seems Kodi is very picky or in better words. Inconsistent and not well designed.

Kind of looks like someone may have taken a shortcut if anything not recognized/wanted is automatically hdr10, or a blank flag.  No checking/filtering of input.

Edited by FrostByte
Link to comment
Share on other sites

AurelMarius
On 3/18/2024 at 10:00 AM, FrostByte said:

Most excellent.  E4K is now populating hdrtype for mkv and I can see the flags in skins that support it.

Heads up to others I did have to do a rebuild on movies/tvshows before it showed.

I did not check HLG as I no longer have anything in my library with that hdrtype, but I'm sure videorange supports HLG when I had it in the past so it should work.

image.thumb.jpeg.4f830e90da7201c434db24eeb5ea9ff0.jpeg

image.jpeg.c42e399a534e3de73b5fcc57c1564c9f.jpeg

Hi, how did you get the DV logo on arctic fuse ?

Link to comment
Share on other sites

FrostByte
8 minutes ago, AurelMarius said:

Hi, how did you get the DV logo on arctic fuse ?

It should work now with E4K 10.0.10.  You will need to repair your movie/tv libraries though after upgrading in order to update the table for each video.

  • Like 1
Link to comment
Share on other sites

AurelMarius
3 minutes ago, FrostByte said:

It should work now with E4K 10.0.10.  You will need to repair your movie/tv libraries though after upgrading in order to update the table for each video.

Thanks, that did the trick.

  • Like 1
Link to comment
Share on other sites

alghorabi

Created a new logfile. 
tried to disable SSL verification in the app if that was causing issues. 
But its still the same issue. This time I tried from a windows client instead of android but still same issue

kodi.log

Link to comment
Share on other sites

quickmic
Posted (edited)
1 hour ago, alghorabi said:

Created a new logfile. 
tried to disable SSL verification in the app if that was causing issues. 
But its still the same issue. This time I tried from a windows client instead of android but still same issue

kodi.log 169.7 kB · 0 downloads

The problem is not SSL, it's the emby connect. Will be fixed in next version.

Edited by quickmic
  • Thanks 1
Link to comment
Share on other sites

alghorabi
21 minutes ago, quickmic said:

The problem is not SSL, it's the emby connect. Will be fixed in next version.

Yes i was able to pinpoint that request_url In emby.py added the wrong flag for Content-Type it should be application/json instead of form 

 

but when i Did a fix for that it still didnt work. It seems that request in http.py overwrites the header data with something else inside the statements if header not in data: and if Authorization not in data:

Disregard that. It seams that  if ’Header’ not in data: overwrites the header with the right flag for Content-Type. So it cant be that 

Edited by alghorabi
  • Like 1
Link to comment
Share on other sites

quickmic
9 hours ago, alghorabi said:

Yes i was able to pinpoint that request_url In emby.py added the wrong flag for Content-Type it should be application/json instead of form 

 

but when i Did a fix for that it still didnt work. It seems that request in http.py overwrites the header data with something else inside the statements if header not in data: and if Authorization not in data:

Disregard that. It seams that  if ’Header’ not in data: overwrites the header with the right flag for Content-Type. So it cant be that 

I already fixed the issue. Just not uploaded yet. If it's urgent, you can replace the file in the attachment.

Yes, the Content type is wrong since 4.X times. Luckily, Requests plugin ignored that issue, but when I switched to liburl3, this is no longer valid.

And there was a second issue. I unified the http dict keys in the code and forgot one key also in emby.py. "parms" is the "playload" but on one spot (emby connect) there was still "data" key in use.

 

 

emby.py

  • Like 1
Link to comment
Share on other sites

alghorabi
9 hours ago, quickmic said:

I already fixed the issue. Just not uploaded yet. If it's urgent, you can replace the file in the attachment.

Yes, the Content type is wrong since 4.X times. Luckily, Requests plugin ignored that issue, but when I switched to liburl3, this is no longer valid.

And there was a second issue. I unified the http dict keys in the code and forgot one key also in emby.py. "parms" is the "playload" but on one spot (emby connect) there was still "data" key in use.

 

 

emby.py 24.03 kB · 1 download

Thank you. It worked! I was able to pinpoint that the were an issue with that emby connect called the key data and not params that http looked for. But I werent able to figure out that the fix was just to replace 'data' with 'params' 😅
Thank you very much!

  • Like 1
Link to comment
Share on other sites

alghorabi

Sorry for spaning. Can we specify that VC1 should be transcoded on the emby server? 

Link to comment
Share on other sites

quickmic
10 hours ago, alghorabi said:

Sorry for spaning. Can we specify that VC1 should be transcoded on the emby server? 

Yes, I'll add an option.

Link to comment
Share on other sites

quickmic

New PUBLIC TESTING version available 10.0.11:

Delta changelog 10.0.10 -> 10.0.11

fix emby connect
remove sdr from strHdrType
add transcode option for video: vc1, prores, msmpeg4v2
add transcode option for audio: aac_latm, dtshd_hra, dtshd_ma, pcm_s16le, truehd, opus

  • Like 2
Link to comment
Share on other sites

FrostByte
4 hours ago, quickmic said:

New PUBLIC TESTING version available 10.0.11:

Delta changelog 10.0.10 -> 10.0.11


remove sdr from strHdrType

Looks like that fixed it.  Estuary no longer displays a blank flag for SDR movies, thanks.

  • Like 1
Link to comment
Share on other sites

quickmic
36 minutes ago, FrostByte said:

Looks like that fixed it.  Estuary no longer displays a blank flag for SDR movies, thanks.

That's so weird. A valid info in database means an invalid icon and a blank record in database is valid for the skin. Sometimes I really love Kodi.

  • Haha 2
Link to comment
Share on other sites

DarWun

Movie playback from E4K to Emby has stopped being reported on the Emby dashboard after updating to 10.0.11. TV shows still show as expected. Rolling back to 10.0.10 does not resolve the issue.

I have reset the database in E4K, and it has not resolved the issue. When I play movies from other clients (i.e. Emby Theatre), playback is reported on the Emby dashboard. I'm at a loss as to what is going on here. Logs attached.

embyserver (1).txt kodi.log

Link to comment
Share on other sites

quickmic
Posted (edited)
7 hours ago, DarWun said:

Movie playback from E4K to Emby has stopped being reported on the Emby dashboard after updating to 10.0.11. TV shows still show as expected. Rolling back to 10.0.10 does not resolve the issue.

I have reset the database in E4K, and it has not resolved the issue. When I play movies from other clients (i.e. Emby Theatre), playback is reported on the Emby dashboard. I'm at a loss as to what is going on here. Logs attached.

embyserver (1).txt 46.94 kB · 1 download kodi.log 10.61 MB · 1 download

The plugin has no issues and it's defiantly not related to .11 version. Howevere, your Kodi installation reports crap.

EMBY.hooks.player: playercommand received: ('avstart', '{"item":{"type":"unknown"},"player":{"playerid":-1,"speed":1}}')

I think Kodi installation is broken, no idea why or you trigger playback in a special way.

Standard procedure: Test via PC/Laptop with stock Kodi and just the plugin installed. I'm quite sure, there will be zero issues.

Edited by quickmic
Link to comment
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now
×
×
  • Create New...