Jump to content

New Plugin - Subscene subtitle


nRafinia
Go to solution Solved by nRafinia,

Recommended Posts

nRafinia
5 hours ago, Luke said:

From what i can see by reviewing the plugin code, it requires you have to either an imdb id or tvdb id set on each episode.

This happens when both are blank. it does not appear to do any lookups by name, so having at least one of these values is mandatory.

Yes exactly,

If I have time, I add searching by name without IMDB/TVDB ID

  • Like 1
Link to comment
Share on other sites

36 minutes ago, nRafinia said:

Hi

Version 2.3.0 released.

Please check it, and if you have an error, tell me to resolve it.

Thanks from everyone

 

https://github.com/nRafinia/Emby.Subtitle.Subscene/releases/latest

Emby.Subtitle.Subscene.dll 45 kB · 0 downloads

OK Since you're updating the code, what I would suggest is in situations where an exception prevents your method from continuing, remove all of your try/catch and just let the exception bubble up to the core. This will make troubleshooting a lot easier. Don't try/catch and return null. Instead just allow the exception to be thrown.

Also I don't know if this will help you or not, but if you target the 4.8 nuget package then the request object has a new SeriesProviderIds property. For episodes this will give you data about the series.

  • Like 1
Link to comment
Share on other sites

Chacka
11 hours ago, nRafinia said:

Yes exactly,

If I have time, I add searching by name without IMDB/TVDB ID

I tested the new plugin and still receive errors in the log while running the scheduled task. See attached & thanks.

test_embyserver.txt

Link to comment
Share on other sites

1 hour ago, Chacka said:

I tested the new plugin and still receive errors in the log while running the scheduled task. See attached & thanks.

test_embyserver.txt 40.51 kB · 1 download

Based on his comments, he says that's normal.

But @nRafiniayou should avoid the error by checking the id values for null and just returning an empty result list.

Link to comment
Share on other sites

Chacka
19 minutes ago, Luke said:

Based on his comments, he says that's normal.

But @nRafiniayou should avoid the error by checking the id values for null and just returning an empty result list.

The subtitles for one TV series are available on Subscene, however they also produced the error. Emby does not show the fetched resource.

Link to comment
Share on other sites

19 minutes ago, Chacka said:

The subtitles for one TV series are available on Subscene, however they also produced the error. Emby does not show the fetched resource.

Did you read his and my explanations? I think we understand why.

Link to comment
Share on other sites

Chacka
13 minutes ago, Luke said:

Did you read his and my explanations? I think we understand why.

Yes, but it appears that he said he updated the application for text searching and asked me to provide feedback.

  • Thanks 1
Link to comment
Share on other sites

Chacka
17 minutes ago, Chacka said:

Yes, but it appears that he said he updated the application for text searching and asked me to provide feedback.

Sorry, I thought he requested me to test a proposed fix. I misunderstood with your plugin post.

  • Thanks 1
Link to comment
Share on other sites

  • 3 weeks later...
ledaile

This Plugin - Subscene subtitle is not work with Synology server :((

Link to comment
Share on other sites

9 hours ago, ledaile said:

This Plugin - Subscene subtitle is not work with Synology server :((

Hi there, I’m sure the developer is happy to help, but please see 

Thanks.

  • Agree 1
Link to comment
Share on other sites

nRafinia

Hello to everyone,

I am working on a new version of the plugins based on your logs and will be back soon.

Thank you for your patience and attention

  • Like 1
  • Thanks 2
Link to comment
Share on other sites

  • 2 weeks later...
ledaile
On 3/10/2024 at 1:36 PM, nRafinia said:

Hello to everyone,

I am working on a new version of the plugins based on your logs and will be back soon.

Thank you for your patience and attention

Hi nRfinia, When do you release new version?

Link to comment
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now
×
×
  • Create New...