Jump to content
PrincessClevage

Active video has small gap on side and bottom of screen

Recommended Posts

Luke

Yes that's another thing. Try without the hack and just jump out of full screen and then back in. See if that works. We can come up with a better hack based on that.

Share this post


Link to post
Share on other sites
AdrianW

Try without the hack and just jump out of full screen and then back in. See if that works. 

 

Minimize and maximize always fixed it - it's just a pain. 

Share this post


Link to post
Share on other sites
ShoutingMan

Adding content to my library, I see that Emby updated and re-added the bug. I’ll either kludge the full screen or downgrade Electron again.

Share this post


Link to post
Share on other sites
AdrianW

Adding content to my library, I see that Emby updated and re-added the bug. I’ll either kludge the full screen or downgrade Electron again.

 

I downgraded electron which worked for a few days but then yesterday ET wouldn't even open - which may or may not have been caused by electron. I forced an update (which re-introduced the problem but at least ET would start) so I used the code work around in main.js instead.

Share this post


Link to post
Share on other sites
Luke

Minimize and maximize always fixed it - it's just a pain. 

 

You were doing this after video started, right?

Share this post


Link to post
Share on other sites
AdrianW

You were doing this after video started, right?

 

Yes. 

Share this post


Link to post
Share on other sites
nicko84

After the var bounds you could do something like bounds.height +=3; and same for width.

 

 

Hello AdrianW and Luke,

 

Can you give the code to add after Bounds to resize window please ?

 

Thanks

Share this post


Link to post
Share on other sites
AdrianW

 

Can you give the code to add after Bounds to resize window please ?

 

 

Here's what I did:

 

change this:

    function onWindowResize() {

        if (!useTrueFullScreen || currentWindowState === 'Normal') {
            var bounds = mainWindow.getBounds();
            playerWindow.setBounds(bounds);
        }
    }

to this:

    function onWindowResize() {

        if (!useTrueFullScreen || currentWindowState === 'Normal') {
            var bounds = mainWindow.getBounds();
   	    bounds.height += 6;
	    bounds.width += 6;
            playerWindow.setBounds(bounds);
        }
    }

Share this post


Link to post
Share on other sites
nicko84

Thanks AdrianW, it works very well !

Share this post


Link to post
Share on other sites
nicko84

Hello Luke,

 

Same issue...gap at the bottom and right side of the video when refresh rate changes (50 to 23)

 

If you reduce the window when the video is playing and extend it (full screen) then gaps vanish…

 

So for the moment i'm using AdrianW trick to resize video (+3/+3)

 

NB : same issue whith Electron 4.0.0 and ET 3.0.6

Edited by nicko84

Share this post


Link to post
Share on other sites
Guest asrequested

Is it just me, or is refresh rate switching not working in 3.0.6?

 

 

UPDATE

 

It works fine on my other machine. But the gap on the right and bottom is still there.

Edited by Doofus

Share this post


Link to post
Share on other sites
AdrianW

But the gap on the right and bottom is still there.

 

I had to apply the hack again yesterday after ET updated itself.

Share this post


Link to post
Share on other sites
nicko84

Hello Luke,

 

Some news about this problem ?

Share this post


Link to post
Share on other sites
DrJekle

Following this as I also have the same issue. Of course I just max/minimize after playback, like others have said it works but a pain

Share this post


Link to post
Share on other sites
ShoutingMan

With Emby 3.0.6 the white line is back. I assume I have to manually revert Electron again. Is Electron version 1.8.7 still the latest version that works right?

Share this post


Link to post
Share on other sites
Luke

To my knowledge yes.

Share this post


Link to post
Share on other sites
Guest asrequested

electron 5.0.0-beta.1 has a ton of fixes/changes. I wonder if this fix has anything to do with this issue?

Share this post


Link to post
Share on other sites
Luke

Cool thanks for the info!

Share this post


Link to post
Share on other sites
nicko84

Hello,

 

ET 3.0.6 and electron 5.0.0 beta 2 : the issue isn't solved, still gaps at the bottom et right size of the screen (grrrr !)

Edited by nicko84
  • Like 2

Share this post


Link to post
Share on other sites
serpi

So mabe it IS a bug in ET, how it handles screen mode changes and only shows with Electron 2.0+?

 

If it was a bug in Electron, I would believe some other programs would have also that problem and there would have been a fix to it?

 

But it also seems, there is not that much development going on for ET.

Looking at the releases, it's most times only replacing Electron/mpv,

 

And there's still the now useless 3d mode setting and no setting to get the checkmark for watched content back.

 

But at least the never implemented plugin settings are gone (would be better, to have some plugins, like themes, YouTube, etc).

 

Ciao, Alfred

  • Like 2

Share this post


Link to post
Share on other sites
nicko84

So i still use the trick in main.json to resize window and hope for a patch soon.

 

It works well in Kodi and Plex player and many others for a long time...

Share this post


Link to post
Share on other sites
freddyfinn

Maybe this should be added to future releases until a permanent solution is found.

Works for me.

 

 

Here's what I did:

 

change this:

    function onWindowResize() {

        if (!useTrueFullScreen || currentWindowState === 'Normal') {
            var bounds = mainWindow.getBounds();
            playerWindow.setBounds(bounds);
        }
    }

to this:

    function onWindowResize() {

        if (!useTrueFullScreen || currentWindowState === 'Normal') {
            var bounds = mainWindow.getBounds();
   	    bounds.height += 6;
	    bounds.width += 6;
            playerWindow.setBounds(bounds);
        }
    }
  • Like 2

Share this post


Link to post
Share on other sites
nicko84

+1

 

Maybe added to settings in ET like "Overscan" option.

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now

×
×
  • Create New...