Active video has small gap on side and bottom of screen

[Luke 24450]

Yes that's another thing. Try without the hack and just jump out of full screen and then back in. See if that works. We can come up with a better hack based on that.

[AdrianW 938]

Try without the hack and just jump out of full screen and then back in. See if that works. 

 

Minimize and maximize always fixed it - it's just a pain. 

[ShoutingMan 84]

Adding content to my library, I see that Emby updated and re-added the bug. I’ll either kludge the full screen or downgrade Electron again.

[AdrianW 938]

Adding content to my library, I see that Emby updated and re-added the bug. I’ll either kludge the full screen or downgrade Electron again.

 

I downgraded electron which worked for a few days but then yesterday ET wouldn't even open - which may or may not have been caused by electron. I forced an update (which re-introduced the problem but at least ET would start) so I used the code work around in main.js instead.

[Luke 24450]

Minimize and maximize always fixed it - it's just a pain. 

 

You were doing this after video started, right?

[AdrianW 938]

You were doing this after video started, right?

 

Yes. 

[nicko84 31]

After the var bounds you could do something like bounds.height +=3; and same for width.

 

 

Hello AdrianW and Luke,

 

Can you give the code to add after Bounds to resize window please ?

 

Thanks

[AdrianW 938]

 

Can you give the code to add after Bounds to resize window please ?

 

 

Here's what I did:

 

change this:

    function onWindowResize() {

        if (!useTrueFullScreen || currentWindowState === 'Normal') {
            var bounds = mainWindow.getBounds();
            playerWindow.setBounds(bounds);
        }
    }

to this:

    function onWindowResize() {

        if (!useTrueFullScreen || currentWindowState === 'Normal') {
            var bounds = mainWindow.getBounds();
   	    bounds.height += 6;
	    bounds.width += 6;
            playerWindow.setBounds(bounds);
        }
    }

[nicko84 31]

Thanks AdrianW, it works very well !

[Luke 24450]

Can you please try this version:

https://www.dropbox.com/s/p0ezaa2sl88kxr2/emby-theater.zip?dl=0

 

Just unzip and run it portable. Thanks.

[nicko84 31]

Hello Luke,

 

Same issue...gap at the bottom and right side of the video when refresh rate changes (50 to 23)

 

If you reduce the window when the video is playing and extend it (full screen) then gaps vanish…

 

So for the moment i'm using AdrianW trick to resize video (+3/+3)

 

NB : same issue whith Electron 4.0.0 and ET 3.0.6

Edited December 23, 2018 by nicko84

[Guest asrequested]

Is it just me, or is refresh rate switching not working in 3.0.6?

 

 

UPDATE

 

It works fine on my other machine. But the gap on the right and bottom is still there.

Edited December 23, 2018 by Doofus

[AdrianW 938]

But the gap on the right and bottom is still there.

 

I had to apply the hack again yesterday after ET updated itself.

[nicko84 31]

Hello Luke,

 

Some news about this problem ?

[DrJekle 4]

Following this as I also have the same issue. Of course I just max/minimize after playback, like others have said it works but a pain

[ShoutingMan 84]

With Emby 3.0.6 the white line is back. I assume I have to manually revert Electron again. Is Electron version 1.8.7 still the latest version that works right?

[Luke 24450]

To my knowledge yes.

[Guest asrequested]

electron 5.0.0-beta.1 has a ton of fixes/changes. I wonder if this fix has anything to do with this issue?

[Luke 24450]

Cool thanks for the info!

[nicko84 31]

Hello,

 

ET 3.0.6 and electron 5.0.0 beta 2 : the issue isn't solved, still gaps at the bottom et right size of the screen (grrrr !)

Edited February 10, 2019 by nicko84

[serpi 37]

So mabe it IS a bug in ET, how it handles screen mode changes and only shows with Electron 2.0+?

 

If it was a bug in Electron, I would believe some other programs would have also that problem and there would have been a fix to it?

 

But it also seems, there is not that much development going on for ET.

Looking at the releases, it's most times only replacing Electron/mpv,

 

And there's still the now useless 3d mode setting and no setting to get the checkmark for watched content back.

 

But at least the never implemented plugin settings are gone (would be better, to have some plugins, like themes, YouTube, etc).

 

Ciao, Alfred

[Guest asrequested]

Yeah, Theater does need some love.

[nicko84 31]

So i still use the trick in main.json to resize window and hope for a patch soon.

 

It works well in Kodi and Plex player and many others for a long time...

[freddyfinn 7]

Maybe this should be added to future releases until a permanent solution is found.

Works for me.

 

 

Here's what I did:

 

change this:

    function onWindowResize() {

        if (!useTrueFullScreen || currentWindowState === 'Normal') {
            var bounds = mainWindow.getBounds();
            playerWindow.setBounds(bounds);
        }
    }

to this:

    function onWindowResize() {

        if (!useTrueFullScreen || currentWindowState === 'Normal') {
            var bounds = mainWindow.getBounds();
   	    bounds.height += 6;
	    bounds.width += 6;
            playerWindow.setBounds(bounds);
        }
    }

[nicko84 31]

+1

 

Maybe added to settings in ET like "Overscan" option.