Top Picks support thread

[chef 3749]

10 hours ago, Happy2Play said:

Is that related to "Download in advance" as it is on demand if not present.  So I would guess TheGuru would have to validate what images exist with primary item.

Chef you use copy existing images if present and only download from provider if needed correct?

Yes, we only try the providers if the images don't exist locally. 

If the provider doesn't give us an image though, it seems to break when it draws a generic thumb with text.

I think I've found the problematic code. 

I still would have thought that the providers would have the fast and furious movie.

 

[Darkseidd 58]

I have @TheGru issue but with korean movie that TMDB original title is in Korea. I set the library to take english alternative title, so the movie name not in Hangul at my emby

[GrimReaper 3330]

27 minutes ago, chef said:

I still would have thought that the providers would have the fast and furious movie.

TMDB surely does, what is the plugin logic for querying, does it query by name/identify or queries with known providerid? 

https://api.themoviedb.org/3/search/movie?api_key=f6bd687ffa63cd282b6ff2c6877f2669&query=The+Fast+And+The+Furious&year=2001

https://api.themoviedb.org/3/movie/9799?api_key=f6bd687ffa63cd282b6ff2c6877f2669&language=en-US

https://api.themoviedb.org/3/movie/9799/images?api_key=f6bd687ffa63cd282b6ff2c6877f2669

https://api.themoviedb.org/3/movie/9799/images?api_key=f6bd687ffa63cd282b6ff2c6877f2669&language=en-US&include_image_language=en

 

 

Edited March 2, 2023 by GrimReaper

[Painkiller8818 204]

@TheGru@Darkseidd

Are you downloading some images manually?

I see on the images of @TheGru very different naming conventions, sometime it is just folder, sometimes it is fanart1, fanart2 etc.

i never had a fanart1 or fanart2 with automatic downloads, except i decided to download more than one fanarts.

this is how a movie looks for me if i add it new and let everything download automatically and this seems very different to yours (ignore the theme, this is because of a plugin)

In my folder there is just the MKV file, the rest comes automatically after adding and detecting.

[chef 3749]

18 minutes ago, GrimReaper said:

TMDB surely does, what is the plugin logic for querying, does it query by name/identify or queries with known providerid? 

https://api.themoviedb.org/3/search/movie?api_key=f6bd687ffa63cd282b6ff2c6877f2669&query=The+Fast+And+The+Furious&year=2001

https://api.themoviedb.org/3/movie/9799?api_key=f6bd687ffa63cd282b6ff2c6877f2669&language=en-US

https://api.themoviedb.org/3/movie/9799/images?api_key=f6bd687ffa63cd282b6ff2c6877f2669

https://api.themoviedb.org/3/movie/9799/images?api_key=f6bd687ffa63cd282b6ff2c6877f2669&language=en-US&include_image_language=en

 

 

Actually, this is good point. 

Right now we are looking by name, however, we should be checking to see if emby has the actual ID first then check by name.

 

[chef 3749]

13 minutes ago, Painkiller8818 said:

@TheGru@Darkseidd

Are you downloading some images manually?

I see on the images of @TheGru very different naming conventions, sometime it is just folder, sometimes it is fanart1, fanart2 etc.

i never had a fanart1 or fanart2 with automatic downloads, except i decided to download more than one fanarts.

this is how a movie looks for me if i add it new and let everything download automatically and this seems very different to yours (ignore the theme, this is because of a plugin)

In my folder there is just the MKV file, the rest comes automatically after adding and detecting.

We rely on Emby to give a parameter with the name in it. 

So the code never calls the path directly. It is whatever emby returns as the path from the db... If it exists. 

 

[chef 3749]

48 minutes ago, Darkseidd said:

I have @TheGru issue but with korean movie that TMDB original title is in Korea. I set the library to take english alternative title, so the movie name not in Hangul at my emby

Interesting, so this definitely would mean it happens when the providers are queried by name.

I'll try to get the providers ID from emby and see if it can fix this issue. 

It should at least stop it from happening as often. If emby doesn't have the provider ID, it will  have to query by name anyway and see what comes back. 

Then if it still has no results, then the generic Skia code will have to be fixed.

I write a Skia test console app to test where it is breaking. 

 

Edited March 2, 2023 by chef

[chef 3749]

Hmm.. I apparently rethrew an exception when the first bitmap url errors from the provider.

I didn't comment the code at the time, but currently I can't see why I would have done that.

The method should return the list of bitmaps instead of exiting after the first exception.

I've commented the code now, but I'm going to run this and see what happens if it doesn't exit early.

There must have been a reason, but looking at this part now, the reason isn't obvious.

 

Edited March 2, 2023 by chef

[Darkseidd 58]

1 hour ago, Painkiller8818 said:

@TheGru@Darkseidd

Are you downloading some images manually?

I see on the images of @TheGru very different naming conventions, sometime it is just folder, sometimes it is fanart1, fanart2 etc.

i never had a fanart1 or fanart2 with automatic downloads, except i decided to download more than one fanarts.

this is how a movie looks for me if i add it new and let everything download automatically and this seems very different to yours (ignore the theme, this is because of a plugin)

In my folder there is just the MKV file, the rest comes automatically after adding and detecting.

occasionally yes. couldnt remember which media i did manual image download (via emby)

[chef 3749]

and finally, I was able to reproduce the object reference error.

I'm going to push a new version. 

The only thing that might still cause an issue is when the providers don't return anything.

I'm going to fix this next.

[chef 3749]

Now, I see even Fast and furious gets proper treatment, when missing images in the folders. 

I deleted all the images, and then ran the top picks which seemed to have populated the custom image properly.

[chef 3749]

.48 has been pushed to the catalog.

Now, about these custom generic images... 

I've got to test the Skia code.

There maybe another release before I leave for work today. Hopefully.

 

[Eigeplackter 76]

The issue with crashing the server is solved in .48, but plugin is not working.

See attached debug log.

embyserver-63813373828.txt

[chef 3749]

47 minutes ago, Eigeplackter said:

The issue with crashing the server is solved in .48, but plugin is not working.

See attached debug log.

embyserver-63813373828.txt 24.07 kB · 0 downloads

Whoa, we don't have access permissions to the top picks folder on your Linux machine.

But, why? 

Can you please restart emby?

 

Edited March 2, 2023 by chef

[Darkseidd 58]

@chefcan i control the outcome?

for Top 20 movies and top 20 tv, i agree to this,  if the list is in descending order

 

2023-03-03 01:45:29.240 Info Top Picks: Top 20 movies:
2023-03-03 01:45:29.240 Info Top Picks: Honest Thief
2023-03-03 01:45:29.240 Info Top Picks: Zack Snyder's Justice League
2023-03-03 01:45:29.240 Info Top Picks: Fantastic Beasts: The Crimes of Grindelwald
2023-03-03 01:45:29.240 Info Top Picks: 21 Bridges
2023-03-03 01:45:29.240 Info Top Picks: Ralph Breaks the Internet
2023-03-03 01:45:29.240 Info Top Picks: Wreck-It Ralph
2023-03-03 01:45:29.240 Info Top Picks: The Little Prince
2023-03-03 01:45:29.240 Info Top Picks: Alice in Wonderland
2023-03-03 01:45:29.240 Info Top Picks: Bee Movie
2023-03-03 01:45:29.240 Info Top Picks: Black Swan
2023-03-03 01:45:29.240 Info Top Picks: All the Old Knives
2023-03-03 01:45:29.240 Info Top Picks: Dual
2023-03-03 01:45:29.240 Info Top Picks: Cruella
2023-03-03 01:45:29.240 Info Top Picks: Nobody
2023-03-03 01:45:29.240 Info Top Picks: Remember Me
2023-03-03 01:45:29.240 Info Top Picks: Frozen
2023-03-03 01:45:29.240 Info Top Picks: Minions & More Volume 1
2023-03-03 01:45:29.240 Info Top Picks: Welcome Home Roscoe Jenkins
2023-03-03 01:45:29.241 Info Top Picks: The Amityville Horror
2023-03-03 01:45:29.241 Info Top Picks: Top 20 tv:
2023-03-03 01:45:29.241 Info Top Picks: Animaniacs
2023-03-03 01:45:29.241 Info Top Picks: Adventure Time
2023-03-03 01:45:29.241 Info Top Picks: Jinny's Kitchen
2023-03-03 01:45:29.241 Info Top Picks: How I Met Your Father
2023-03-03 01:45:29.241 Info Top Picks: Halo
2023-03-03 01:45:29.241 Info Top Picks: How I Met Your Mother
2023-03-03 01:45:29.241 Info Top Picks: Monsters at Work
2023-03-03 01:45:29.241 Info Top Picks: Popular items have 9
2023-03-03 01:45:29.269 Info Top Picks: Returning popular items 9
2023-03-03 01:45:29.288 Info Top Picks: Available Top Pick Ranks are 9
2023-03-03 01:45:29.288 Info Top Picks: Top Picks contains 0 user defined items
2023-03-03 01:45:29.289 Info Top Picks: Engagement Items contains 9

 

and full logs as in attached. alot of errors related to TopPicks

embyserver(2).txt

[chef 3749]

Skia is erroring there, but are the images getting created? 

I did add more verbose logging to catch those errors and put them in the log.

That way we could see how the providers and Skia was having issues.

 

[Eigeplackter 76]

1 hour ago, chef said:

Whoa, we don't have access permissions to the top picks folder on your Linux machine.

But, why? 

Can you please restart emby?

 

It‘s a Synology (yes Linux at heart).

The log above was after plugin update+restart, but tried again just for you 

Same result, permission denied.

Im not at a client right now, so I cant check permissions of the dll.

[Darkseidd 58]

37 minutes ago, chef said:

Skia is erroring there, but are the images getting created? 

I did add more verbose logging to catch those errors and put them in the log.

That way we could see how the providers and Skia was having issues.

 

incoming screenshot from mobile.

 

this is what created at top picks library (after manual library scan)

 

seems matched what created  in folder as well

attached also what listed at top picks menu

[Darkseidd 58]

9 minutes ago, Darkseidd said:

incoming screenshot from mobile.

 

this is what created at top picks library (after manual library scan)

 

seems matched what created  in folder as well

attached also what listed at top picks menu

remember my previous unsolved issue, where tapping on movie-ty0e top picks crashes my docker&omv6 pi4B?

 

i took liberty to test again on various client since alot of version jump already

Movie top picks (Honest Thief)

Android app - crash

AndroidTV app - crash

iPad app - crash

Web browser - crash

 

TV series top pick (Jinny's Kirchen)

Android app - no issue

AndroidTV app - no issue

iPad app - no issue

Web browser - no issue

I couldn't figure why this happened

 

attached also logs, if it help (no unhandled)

 

 

 

 

hardware_detection-63813409134.txt embyserver-63813409117.txt hardware_detection-63813409002.txt embyserver-63813408984.txt hardware_detection-63813408875.txt embyserver-63813408857.txt hardware_detection-63813408755.txt embyserver-63813408741.txt

[Darkseidd 58]

would like to verify with you @chef

 

is this normal content inside .strm file generated? the path shows here is my smb path to the movie

[chef 3749]

36 minutes ago, Darkseidd said:

would like to verify with you @chef

 

is this normal content inside .strm file generated? the path shows here is my smb path to the movie

Sorry for the intermittent replies, I'm at work for a couple more hours.

 

I believe the folder path could be correct.

It should point back to the item that emby is reading the original from.

Are you reading your DL folder directly into emby?

Edited March 2, 2023 by chef

[chef 3749]

1 hour ago, Darkseidd said:

remember my previous unsolved issue, where tapping on movie-ty0e top picks crashes my docker&omv6 pi4B?

 

i took liberty to test again on various client since alot of version jump already

Movie top picks (Honest Thief)

Android app - crash

AndroidTV app - crash

iPad app - crash

Web browser - crash

 

TV series top pick (Jinny's Kirchen)

Android app - no issue

AndroidTV app - no issue

iPad app - no issue

Web browser - no issue

I couldn't figure why this happened

 

attached also logs, if it help (no unhandled)

 

 

 

 

hardware_detection-63813409134.txt 120.49 kB · 0 downloads embyserver-63813409117.txt 45.83 kB · 0 downloads hardware_detection-63813409002.txt 120.49 kB · 0 downloads embyserver-63813408984.txt 44.39 kB · 0 downloads hardware_detection-63813408875.txt 120.49 kB · 0 downloads embyserver-63813408857.txt 44.63 kB · 0 downloads hardware_detection-63813408755.txt 120.49 kB · 0 downloads embyserver-63813408741.txt 1.05 MB · 0 downloads

Oh God, there is so much happening there.

I hope it isn't all top picks.

It seems like ffprobe is throwing a lot of errors in the log. I will need to analyze this further to really understand.

[Eigeplackter 76]

@chef

 

 

no rush, we dont want you to feel chased…. and I mean it 

[chef 3749]

3 hours ago, Darkseidd said:

would like to verify with you @chef

 

is this normal content inside .strm file generated? the path shows here is my smb path to the movie

Got another break here at work.

So to answer your question, the path in the strm file should match the path for the original file.

For example, I have this episode save in this path:

 

If I were to look inside the strm file for this episode in top picks, I should see the same path: "L:\TV\....." etc.

Edited March 2, 2023 by chef

[Darkseidd 58]

6 hours ago, chef said:

Got another break here at work.

So to answer your question, the path in the strm file should match the path for the original file.

For example, I have this episode save in this path:

 

If I were to look inside the strm file for this episode in top picks, I should see the same path: "L:\TV\....." etc.

how about movie's strm content? since i have no issue with tvshow in toppicks..