Jump to content

ComSkipper ... A Emby Plugin that skips commercials


BillOatman

Recommended Posts

muzicman0

weird that it doesn't work for me then.  no idea.

Where do you have the plugin installed?  ProgramData or the System folder?

Link to comment
Share on other sites

BillOatman
14 hours ago, muzicman0 said:

weird that it doesn't work for me then.  no idea.

Where do you have the plugin installed?  ProgramData or the System folder?

I usually turn off emby, put the dll in both places, and restart emby. I'm sure that's overkill, but it works.

If you get a debug log when it should skip a commercial and send it to me, I'll have a look.

Link to comment
Share on other sites

muzicman0

I must be doing something wrong.  I enabled debug logs, then played the video, then turned debug logs off, but I don't see a debug log in the logs section.

Link to comment
Share on other sites

muzicman0

I think I figured out the debug log thing.  it just adds info to the normal log from what I can tell.  It is attached.  I think this might be the relevant area:

 

2024-01-30 10:07:04.828 Debug Com Skipper: Playback Session = 2f7ed9d8506e6e9eed1ec8424bb2f753 Path = nfs://10.10.0.140/TV/TV/Night Court (2023)/Season 02/Night Court (2023) - S02E05 - Hold the Pickles, Keep the Change.mpg
2024-01-30 10:07:04.828 Debug Com Skipper: Media File: nfs://10.10.0.140/TV/TV/Night Court (2023)/Season 02/Night Court (2023) - S02E05 - Hold the Pickles, Keep the Change.mpg   EDL file nfs://10.10.0.140/TV/TV/Night Court (2023)/Season 02/Night Court (2023) - S02E05 - Hold the Pickles, Keep the Change.edl
2024-01-30 10:07:04.828 Debug Com Skipper: Comskip EDL file [nfs://10.10.0.140/TV/TV/Night Court (2023)/Season 02/Night Court (2023) - S02E05 - Hold the Pickles, Keep the Change.edl] does not exist.
2024-01-30 10:07:04.828 Debug Com Skipper: No usable EDL file found.  Looking for chapter commercial points.
2024-01-30 10:07:04.828 Debug Com Skipper: Chapters ... Media File: nfs://10.10.0.140/TV/TV/Night Court (2023)/Season 02/Night Court (2023) - S02E05 - Hold the Pickles, Keep the Change.mpg
2024-01-30 10:07:04.828 Debug Com Skipper: Name: Chapter 1 StartPositionTicks = 0
2024-01-30 10:07:04.828 Debug Com Skipper: Name: Chapter 2 StartPositionTicks = 3000000000
2024-01-30 10:07:04.828 Debug Com Skipper: Name: Chapter 3 StartPositionTicks = 6000000000
2024-01-30 10:07:04.828 Debug Com Skipper: Name: Chapter 4 StartPositionTicks = 9000000000
2024-01-30 10:07:04.828 Debug Com Skipper: Name: Chapter 5 StartPositionTicks = 12000000000
2024-01-30 10:07:04.828 Debug Com Skipper: Name: Chapter 6 StartPositionTicks = 15000000000
2024-01-30 10:07:04.828 Debug Com Skipper: Name: Chapter 7 StartPositionTicks = 18000000000
2024-01-30 10:07:04.828 Debug Com Skipper: No chapters that are advertisements found.

 

Here is a screenshot showing the edl file does in fact exist!

image.jpeg.689c672503f80cb733067ed877275444.jpeg

embyserver.txt

Edited by muzicman0
Link to comment
Share on other sites

roaku
45 minutes ago, muzicman0 said:

I think I figured out the debug log thing.  it just adds info to the normal log from what I can tell.  It is attached.  I think this might be the relevant area:

 

2024-01-30 10:07:04.828 Debug Com Skipper: Playback Session = 2f7ed9d8506e6e9eed1ec8424bb2f753 Path = nfs://10.10.0.140/TV/TV/Night Court (2023)/Season 02/Night Court (2023) - S02E05 - Hold the Pickles, Keep the Change.mpg
2024-01-30 10:07:04.828 Debug Com Skipper: Media File: nfs://10.10.0.140/TV/TV/Night Court (2023)/Season 02/Night Court (2023) - S02E05 - Hold the Pickles, Keep the Change.mpg   EDL file nfs://10.10.0.140/TV/TV/Night Court (2023)/Season 02/Night Court (2023) - S02E05 - Hold the Pickles, Keep the Change.edl
2024-01-30 10:07:04.828 Debug Com Skipper: Comskip EDL file [nfs://10.10.0.140/TV/TV/Night Court (2023)/Season 02/Night Court (2023) - S02E05 - Hold the Pickles, Keep the Change.edl] does not exist.
2024-01-30 10:07:04.828 Debug Com Skipper: No usable EDL file found.  Looking for chapter commercial points.
2024-01-30 10:07:04.828 Debug Com Skipper: Chapters ... Media File: nfs://10.10.0.140/TV/TV/Night Court (2023)/Season 02/Night Court (2023) - S02E05 - Hold the Pickles, Keep the Change.mpg
2024-01-30 10:07:04.828 Debug Com Skipper: Name: Chapter 1 StartPositionTicks = 0
2024-01-30 10:07:04.828 Debug Com Skipper: Name: Chapter 2 StartPositionTicks = 3000000000
2024-01-30 10:07:04.828 Debug Com Skipper: Name: Chapter 3 StartPositionTicks = 6000000000
2024-01-30 10:07:04.828 Debug Com Skipper: Name: Chapter 4 StartPositionTicks = 9000000000
2024-01-30 10:07:04.828 Debug Com Skipper: Name: Chapter 5 StartPositionTicks = 12000000000
2024-01-30 10:07:04.828 Debug Com Skipper: Name: Chapter 6 StartPositionTicks = 15000000000
2024-01-30 10:07:04.828 Debug Com Skipper: Name: Chapter 7 StartPositionTicks = 18000000000
2024-01-30 10:07:04.828 Debug Com Skipper: No chapters that are advertisements found.

 

Here is a screenshot showing the edl file does in fact exist!

image.jpeg.689c672503f80cb733067ed877275444.jpeg

embyserver.txt 107.13 kB · 0 downloads

Might be time to double check file permissions.

Link to comment
Share on other sites

richt

I've had random failures in the past IF the folder in the library had an "(Optional) Shared network folder" specified.  Seems that Emby had trouble keeping track of the EDL file in that scenario.  Additionally, you appear to be using nfs shares.  Not sure if that will have an impact as I've never tried them with Emby, but use SMB for all my shares. 

Link to comment
Share on other sites

muzicman0

Yes, I think I might know what is going on.  It relates to the fact that the API will ALWAYS return the network share path instead of what is on the local server.  Since I don't have access to the NFS share from the server, that is why it is failing.  I am going to look into adding NFS to the server (it's Windows, but I think it is an option).  If that doesn't work, then I might have to change to SMB, but that will require updating a few scripts I have running, so I really don't want to do that if I don't have to.

Link to comment
Share on other sites

muzicman0

Yep, that was it.  When I reverted back to SMB, it works.

Link to comment
Share on other sites

BillOatman
21 hours ago, muzicman0 said:

I think I figured out the debug log thing.  it just adds info to the normal log from what I can tell.  It is attached.  I think this might be the relevant area:

 

2024-01-30 10:07:04.828 Debug Com Skipper: Playback Session = 2f7ed9d8506e6e9eed1ec8424bb2f753 Path = nfs://10.10.0.140/TV/TV/Night Court (2023)/Season 02/Night Court (2023) - S02E05 - Hold the Pickles, Keep the Change.mpg
2024-01-30 10:07:04.828 Debug Com Skipper: Media File: nfs://10.10.0.140/TV/TV/Night Court (2023)/Season 02/Night Court (2023) - S02E05 - Hold the Pickles, Keep the Change.mpg   EDL file nfs://10.10.0.140/TV/TV/Night Court (2023)/Season 02/Night Court (2023) - S02E05 - Hold the Pickles, Keep the Change.edl
2024-01-30 10:07:04.828 Debug Com Skipper: Comskip EDL file [nfs://10.10.0.140/TV/TV/Night Court (2023)/Season 02/Night Court (2023) - S02E05 - Hold the Pickles, Keep the Change.edl] does not exist.
2024-01-30 10:07:04.828 Debug Com Skipper: No usable EDL file found.  Looking for chapter commercial points.
2024-01-30 10:07:04.828 Debug Com Skipper: Chapters ... Media File: nfs://10.10.0.140/TV/TV/Night Court (2023)/Season 02/Night Court (2023) - S02E05 - Hold the Pickles, Keep the Change.mpg
2024-01-30 10:07:04.828 Debug Com Skipper: Name: Chapter 1 StartPositionTicks = 0
2024-01-30 10:07:04.828 Debug Com Skipper: Name: Chapter 2 StartPositionTicks = 3000000000
2024-01-30 10:07:04.828 Debug Com Skipper: Name: Chapter 3 StartPositionTicks = 6000000000
2024-01-30 10:07:04.828 Debug Com Skipper: Name: Chapter 4 StartPositionTicks = 9000000000
2024-01-30 10:07:04.828 Debug Com Skipper: Name: Chapter 5 StartPositionTicks = 12000000000
2024-01-30 10:07:04.828 Debug Com Skipper: Name: Chapter 6 StartPositionTicks = 15000000000
2024-01-30 10:07:04.828 Debug Com Skipper: Name: Chapter 7 StartPositionTicks = 18000000000
2024-01-30 10:07:04.828 Debug Com Skipper: No chapters that are advertisements found.

 

Here is a screenshot showing the edl file does in fact exist!

image.jpeg.689c672503f80cb733067ed877275444.jpeg

embyserver.txt 107.13 kB · 0 downloads

Yeah you nailed it.  

The problem is likely that the plugin cannot open that file on the share.  I've never tried to do that.  Could be a permissions thing, or could be just a limitation of plugins.I have no way of testing it.

If anyone uses the EDL file this way please chime in. Otherwise it's open source so someone who has a network drive can debug it.

Edited by BillOatman
Link to comment
Share on other sites

muzicman0

at least last time I looked into it for a script that I wrote, there was no way to work around it.  The API will always return the network path if it is configured.  So the only option is to make the configured network path available on the Emby server.  Since I used NFS, it wasn't really possible, so I swapped back to UNC paths, and it now works.

  • Thanks 1
Link to comment
Share on other sites

TMCsw
36 minutes ago, muzicman0 said:

Since I used NFS, it wasn't really possible

If you go to Weinerdows Features and enable ‘Services for NFS’

image.png.42c842742786083084979d96bc8e7582.png

You can use NFS shares much like SMB. Ie '\\192.168.0.10\volume' or assign it to a drive letter.

image.png.92b4981580b476d2e6ccf6245ba50687.png

Link to comment
Share on other sites

muzicman0

I tried to make that work at first, but it didn't seem to want to work.  I was trying nfs://xx.xx.xx.xx, so maybe that was it, but if it was, then it still wouldn't work for the plugin since it is specifying the path as nfs://x.x.x.x.

In any case, it seems to be working now that I swapped everything over to SMB.  I am not sure why I even tried NFS to begin with.  I switched a few years ago for some reason, but not sure why.

Link to comment
Share on other sites

daldana

@BillOatmanNew question, is Comskipper compatible with beta version 4.8.0.78 or stable version 4.8.0.80? Thanks.

Edited by daldana
Link to comment
Share on other sites

TMCsw
3 hours ago, daldana said:

is Comskipper compatible with beta version 4.8.0.78 or stable version 4.8.0.80? Thanks

Working as usual for me..

Link to comment
Share on other sites

daldana

@TMCswThanks for replying! It wasn't working for me in the beta version, so I uninstalled it then reinstalled it and it's working now. Thanks again!

Link to comment
Share on other sites

reneboulard

Since updating to 4.8.0.80 Comskipper does not work anymore.  On a windows and ubuntu install.

I also did a clean install and the same error occured.  

2024-02-04 11:46:37.675 Info Com Skipper: EDL file /var/lib/emby/data/livetv/recordings/Coronation Street (1960)/Coronation Street 2024-01-09.edl found.
2024-02-04 11:46:37.675 Info Server: http/1.1 Response 204 to host6. Time: 23ms. POST http://192.168.1.165:8096/emby/Sessions/Playing?X-Emby-Client=Emby Web&X-Emby-Device-Name=Chrome Windows&X-Emby-Device-Id=df828d81-517e-4efc-b8d2-28855cc8f5fd&X-Emby-Client-Version=4.8.0.80&X-Emby-Token=x_secret6_x&X-Emby-Language=fr-ca&reqformat=json
2024-02-04 11:46:37.675 Error Com Skipper: Could not parse EDL file /var/lib/emby/data/livetv/recordings/Coronation Street (1960)/Coronation Street 2024-01-09.edl. Exception: Input string was not in a correct format.

Thank you for the help!

 

Link to comment
Share on other sites

roaku
5 minutes ago, reneboulard said:

Since updating to 4.8.0.80 Comskipper does not work anymore.  On a windows and ubuntu install.

I also did a clean install and the same error occured.  

2024-02-04 11:46:37.675 Info Com Skipper: EDL file /var/lib/emby/data/livetv/recordings/Coronation Street (1960)/Coronation Street 2024-01-09.edl found.
2024-02-04 11:46:37.675 Info Server: http/1.1 Response 204 to host6. Time: 23ms. POST http://192.168.1.165:8096/emby/Sessions/Playing?X-Emby-Client=Emby Web&X-Emby-Device-Name=Chrome Windows&X-Emby-Device-Id=df828d81-517e-4efc-b8d2-28855cc8f5fd&X-Emby-Client-Version=4.8.0.80&X-Emby-Token=x_secret6_x&X-Emby-Language=fr-ca&reqformat=json
2024-02-04 11:46:37.675 Error Com Skipper: Could not parse EDL file /var/lib/emby/data/livetv/recordings/Coronation Street (1960)/Coronation Street 2024-01-09.edl. Exception: Input string was not in a correct format.

Thank you for the help!

 

I'm not having any issues on Ubuntu with 4.8.

Are your edls generated by Comskipper or something else?

Link to comment
Share on other sites

reneboulard
29 minutes ago, roaku said:

I'm not having any issues on Ubuntu with 4.8.

Are your edls generated by Comskipper or something else?

The edls are generated with comskip, I have not change this.

I manage the emby server for my kids they each have one, and all system have the same error after the update.  On windows system and ubuntu, english or french setup.

I am at lost.

 

Edited by reneboulard
Link to comment
Share on other sites

roaku
42 minutes ago, reneboulard said:

The edls are generated with comskip, I have not change this.

I manage the emby server for my kids they each have one, and all system have the same error after the update.  On windows system and ubuntu, english or french setup.

I am at lost.

 

My comskip version is 0.82.011 running on Ubuntu.

But I just checked my Comskipper version and I'm still on 1.4 (latest is 2.0), so the issue may be in the later versions of the plugin.

It could also be an issue specific to your setup, like read permissions on the edl files. Potentially, Emby/the plugin can see that the file exists, but not actually open it for reading.

 

Link to comment
Share on other sites

reneboulard
33 minutes ago, roaku said:

My comskip version is 0.82.011 running on Ubuntu.

But I just checked my Comskipper version and I'm still on 1.4 (latest is 2.0), so the issue may be in the later versions of the plugin.

It could also be an issue specific to your setup, like read permissions on the edl files. Potentially, Emby/the plugin can see that the file exists, but not actually open it for reading.

 

I will investigate further, and report back.  Just to make sure it was not my setup at fault, I reformated my spare server, installed ubuntu server and emby 4.8.0.80 on it.  Same problem.  I think it is related to the update.

 

Just my 2 cents.

Link to comment
Share on other sites

reneboulard
9 minutes ago, reneboulard said:

I will investigate further, and report back.  Just to make sure it was not my setup at fault, I reformated my spare server, installed ubuntu server and emby 4.8.0.80 on it.  Same problem.  I think it is related to the update.

 

Just my 2 cents.

I found the problem, the edl file created by comskip use US convention to create the numbers, separating the fraction with a period, my system are in french and we use a comma to separate the fraction, this was solve a while back, but for some reason version 4.8.0.80 re-introduce the problem.

See this post 

Not sure if the fix should be from Comskipper or Emby?

Link to comment
Share on other sites

roaku
8 minutes ago, reneboulard said:

I found the problem, the edl file created by comskip use US convention to create the numbers, separating the fraction with a period, my system are in french and we use a comma to separate the fraction, this was solve a while back, but for some reason version 4.8.0.80 re-introduce the problem.

See this post 

Not sure if the fix should be from Comskipper or Emby?

Nice catch.

I see that culture setting is still in the plugin code, but it's very possible that Emby has changed something in 4.8 that unintentionally overrides/resets/ignores that setting.

Link to comment
Share on other sites

reneboulard
6 minutes ago, roaku said:

Nice catch.

I see that culture setting is still in the plugin code, but it's very possible that Emby has changed something in 4.8 that unintentionally overrides/resets/ignores that setting.

I try to change the culture setting at the OS level and Emby level.

If i change the culture setting at the OS level it still not work if Emby is in French.

If I put emby in English evething work great.

So Emby overide the culture setting of the plugin.

Problem found, now how to fix it.  I want my emby interface in French.

Link to comment
Share on other sites

roaku
8 minutes ago, reneboulard said:

I try to change the culture setting at the OS level and Emby level.

If i change the culture setting at the OS level it still not work if Emby is in French.

If I put emby in English evething work great.

So Emby overide the culture setting of the plugin.

Problem found, now how to fix it.  I want my emby interface in French.

From the looks of it, the plugin dev would need to move the culture setting from the Run method to the ReadEdlFile method.

I think the Run method is getting called once when Emby starts up, then Emby changes the setting at some point after that. By the time someone's watching something, the setting is 'wrong'.

The plugin may need to start setting the culture back to what Emby wants art the end of its edl processing too.

This is all just my best guess though.

Link to comment
Share on other sites

BillOatman
21 hours ago, roaku said:

Nice catch.

I see that culture setting is still in the plugin code, but it's very possible that Emby has changed something in 4.8 that unintentionally overrides/resets/ignores that setting.

@LukeI still have this set in the plugin code, (first thing entering the Run() method), it was added to resolve the issue above.
 

            // Set for correct parsing of the EDL file regardless of servers culture
            CultureInfo.DefaultThreadCurrentCulture = new CultureInfo("en-US");

Do I need to do something different in 4.8?

 

Edited by BillOatman
Link to comment
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now
×
×
  • Create New...