New Statistics plugin

[ChaoOos 2]

37 minutes ago, cayars said:

Hi, These two movies are 720 and 1080.

 Yes that is correct, but it is sorted incorrectly.
For example, Alice (1080p) is sorted at 720p.

Edited August 29, 2021 by ChaoOos

[Carlo 4330]

Oh I understand now. 

Paladin is 960x720 but the standard resolution for a 720p file is 1280x720.

Same with Wonderland which is 1424x1080 but the standard resolution for a 1080 file is 1920x1080. 

This most likely is why you see these show up in the next resolution down the list.

 

[hackthis02 91]

4 hours ago, ChaoOos said:

 Yes that is correct, but it is sorted incorrectly.
For example, Alice (1080p) is sorted at 720p.

I think @cayars maybe correct. I will double check the code, but I'm don't believe I'm doing any math in the plug-in, simply pulling what Emby is telling me.

What you could try is delete the Statistice.xml file in the
%appdata%\Emby-Server\plugins\configurations\Statistics.xml (Windows) 
/var/lib/emby/plugins/configurations/Statistics.xml (Linux)

and running the task again.

[Happy2Play 8271]

5 hours ago, cayars said:

Hi, These two movies are 720 and 1080.

But per the image above these movies are listed at a lower resolution then Emby identifies them as.

@hackthis02 how is resolution calculated in the plugin, would appear width need adjusting.  But Emby had this same issue for awhile the odd resolutions

1424X1080

960X720

another example

1440x1080 shown as 720p in the plugin

[hackthis02 91]

25 minutes ago, Happy2Play said:

But per the image above these movies are listed at a lower resolution then Emby identifies them as.

@hackthis02 how is resolution calculated in the plugin, would appear width need adjusting.  But Emby had this same issue for awhile the odd resolutions

1424X1080

960X720

another example

1440x1080 shown as 720p in the plugin

I think you're right, I'm doing the calculation on the width then sorting on the height. I'll have to rework this.

[ChaoOos 2]

Thx for your feedback.

I also suspect that the width is included. The height would be sufficient. Or the plugin takes over the values from Emby.

[Happy2Play 8271]

17 minutes ago, ChaoOos said:

The height would be sufficient

But would run it the same issue with something like 1920x704 so all none 16:9 media needs a range.  So I would guess a dev would have to choose either width or height then provide a specific range per resolution

17 minutes ago, ChaoOos said:

Or the plugin takes over the values from Emby.

But that will become a issue in 4.7 as Emby is currently not showing value of none 16:9 media.

Edited August 29, 2021 by Happy2Play

[hackthis02 91]

6 minutes ago, Happy2Play said:

But that will become a issue in 4.7 as Emby is currently not showing value of none 16:9 media.

I was wrong, this was legacy code before I took over the plug-in. It's doing it's own calculations rather than pulling from Emby. But it's doing them by width then grouping by height. I'm going to redo it since calculating by one factor then grouping by another doesn't make sense.

[Diedrich 355]

On 8/29/2021 at 4:17 PM, ChaoOos said:

Thx for your feedback.

I also suspect that the width is included. The height would be sufficient. Or the plugin takes over the values from Emby.

  

On 8/29/2021 at 4:45 PM, hackthis02 said:

I was wrong, this was legacy code before I took over the plug-in. It's doing it's own calculations rather than pulling from Emby. But it's doing them by width then grouping by height. I'm going to redo it since calculating by one factor then grouping by another doesn't make sense.

I need to put my hat in the ring for this. I'm also getting the mis-sorting of quality. I would prefer the plugin just look at the "Title" field, e.g. 1080p, 720p, etc. This way no calculations, no 'minimum/maximum' height - simply look for the words 1080p, etc.

Edited November 4, 2021 by Diedrich

[hackthis02 91]

2 minutes ago, Diedrich said:

  

I need to put my hat in the ring for this. I'm also getting the mis-sorting of quality. I would prefer the plugin just look at the "Title" field, e.g. 1080p, 720p, etc. This way no calculations, no 'minimum/maximum' height - simply look for the words 1080p, etc.

This is on my list. But I'm currently working on implementing TVDB's new API's before the ones I'm currently using get deprecated.

[Diedrich 355]

Request, please:

• Top 10 largest 4K movies
• Top 10 largest 1080p movies
• List movies with columns like the Reports plugin.
  • Add columns for video and audio bitrates
  • Add column for Audio format - Reports plugin has Audio format but you can't group/sort by it.
  • Add column for Size on Disk
  • Sort columns ascending and descending
  • Add filters to sort and/or group movies (example - group by quality (1080p, 4K, etc))

I'm just trying to think of things that the Reports plugin and the Statistics plugin don't yet provide.

Edited December 4, 2021 by Diedrich

[Happy2Play 8271]

Is there a way to use already cached TVDB info instead of having to download it again for this plugin?

\cache\tvdb

4.6 is using same v3 api data, but 4.7 changes to v4 api data.

[hackthis02 91]

4 hours ago, Happy2Play said:

Is there a way to use already cached TVDB info instead of having to download it again for this plugin?

\cache\tvdb

4.6 is using same v3 api data, but 4.7 changes to v4 api data.

I've been looking into the TVDB API upgrade and other options since it appears to be going paid. If a new user installs an addon that uses the cached data, what will happen? Will it be blank or is Emby paying for the v4 API and wanting devs to pull from the cache?

[Happy2Play 8271]

3 hours ago, hackthis02 said:

is Emby paying for the v4 API and wanting devs to pull from the cache?

Emby will provide TVDB v4 in 4.7, no longer using v3.  I was just thinking if the existing data could be used it would be easier without multiple downloads from TVDB.

[hackthis02 91]

9 hours ago, Happy2Play said:

Emby will provide TVDB v4 in 4.7, no longer using v3.  I was just thinking if the existing data could be used it would be easier without multiple downloads from TVDB.

I didn't know Emby offered that. I'll look into it. Do you know if/where the most current Emby API documentation is? I've looked around a few times and couldn't find anything other than poking around the DLL metadata.

[Carlo 4330]

You should find the data under cache\tvdb if using 4.7.

If you take a look at it you'll probably figure out what you need to do to leverage what's already present.

[hackthis02 91]

I just pushed a version to use the cached TVDB. Tell me if anyone has any issues.
(Note there are no other fixes/improvements in this release.)

[Happy2Play 8271]

47 minutes ago, hackthis02 said:

I just pushed a version to use the cached TVDB. Tell me if anyone has any issues.
(Note there are no other fixes/improvements in this release.)

Looking at the log it looks like it only read 43 series of 189 en.xml that are present on this test system.  So stats are a little erratic.

Having series in different languages would appear to be an issue also.

 

Note 4.7 changes to json files (episodes-official.json and language episodes-official-eng.json) from v4 api.

 

[DarWun 265]

12 hours ago, hackthis02 said:

I just pushed a version to use the cached TVDB. Tell me if anyone has any issues.
(Note there are no other fixes/improvements in this release.)

For all of the series in my library, the number of episodes aired in the Collected column is equal to the number of episodes collected. With the previous version of the plug-in there would be lines like "GET https://www.thetvdb.com/api/82a72ddf3d6a98d04c6b9a6ba94d84de/series/369414/all/en.zip" in the log for each series checked. Now there is nothing listed in the log file to indicate that the statistics plug-in even ran. 

[hackthis02 91]

12 hours ago, Happy2Play said:

Looking at the log it looks like it only read 43 series of 189 en.xml that are present on this test system.  So stats are a little erratic.

Having series in different languages would appear to be an issue also.

 

Note 4.7 changes to json files (episodes-official.json and language episodes-official-eng.json) from v4 api.

 

This change is for the 4.6 build. I haven't started the 4.7 yet.

5 minutes ago, DarWun said:

For all of the series in my library, the number of episodes aired in the Collected column is equal to the number of episodes collected. With the previous version of the plug-in there would be lines like "GET https://www.thetvdb.com/api/82a72ddf3d6a98d04c6b9a6ba94d84de/series/369414/all/en.zip" in the log for each series checked. Now there is nothing listed in the log file to indicate that the statistics plug-in even ran. 

Yes, I'm no longer making those call since Emby is already doing that and caching it locally.

[testingtv 3]

I just noticed a similar thing like @DarWun the "collected" Column isnt showing the correct maximum number of episodes.

It just says 100% for every show.

[Happy2Play 8271]

25 minutes ago, testingtv said:

I just noticed a similar thing like @DarWun the "collected" Column isnt showing the correct maximum number of episodes.

It just says 100% for every show.

Not sure when my test system corrected itself.

 

This assumes you are stable 4.6.7.0.  Will not work on beta 4.7 as Emby changes to v4 api and receives json files instead of xml.  Currently old version of plugin will be needed to use old method on 4.7 beta server.

You will need to have debug logging enabled to see plugin reading cached data.

2022-04-21 16:12:26.921 Debug Statistics: 75332
2022-04-21 16:12:26.923 Debug Statistics: C:\Users\Media\Desktop\Stable\programdata\cache\tvdb\75332\en.xml
2022-04-21 16:12:27.019 Debug Statistics: 4395
2022-04-21 16:12:27.019 Debug Statistics: 4395

Edited April 21, 2022 by Happy2Play

[testingtv 3]

I am using a 4.6.7.0 server.

 

Ran the process multiple times now.

Looking into the logs I can find this entry

2022-04-22 01:22:01.080 Debug Statistics: 73378
2022-04-22 01:22:01.080 Debug Statistics: C:\Users\testingtv\AppData\Roaming\Emby-Server\programdata\cache\tvdb\73378\en.xml

I was also wondering the file en.xml does not exist at that location. There is only a de.xml

Edited April 21, 2022 by testingtv

[hackthis02 91]

2 minutes ago, testingtv said:

I am using a 4.6.7.0 server.

 

Ran the process multiple times now.

Looking into the logs I can find this entry

2022-04-22 01:22:01.080 Debug Statistics: 73378
2022-04-22 01:22:01.080 Debug Statistics: C:\Users\testingtv\AppData\Roaming\Emby-Server\programdata\cache\tvdb\73378\en.xml

I was wondering because the file en.xml does not exist at that location. There is only a de.xml

Okay, that means your server has German selected at the default language? If so, the plugin isn't using that setting.

[Happy2Play 8271]

7 minutes ago, testingtv said:

I am using a 4.6.7.0 server.

 

Ran the process multiple times now.

Looking into the logs I can find this entry

2022-04-22 01:22:01.080 Debug Statistics: 73378
2022-04-22 01:22:01.080 Debug Statistics: C:\Users\testingtv\AppData\Roaming\Emby-Server\programdata\cache\tvdb\73378\en.xml

I was also wondering the file en.xml does not exist at that location. There is only a de.xml

Yes I commented on that above as this will be a issue for all users that do not have this metadata in en.xml, it will be in their specific language.

Not positive is the plugin alway used en.zip for its data?  Dev already comments.

Edited April 21, 2022 by Happy2Play