crusher11 854 Posted September 26, 2022 Share Posted September 26, 2022 Right, but the discussion is about having multiple spans marked as being the intro, not skipping the same point multiple times. Link to comment Share on other sites More sharing options...
Luke 37093 Posted September 27, 2022 Share Posted September 27, 2022 On 9/24/2022 at 4:46 PM, pünktchen said: Okay, maybe i should have asked is this intentional? I think the idea of multiple intros just hadn't really been considered. Link to comment Share on other sites More sharing options...
sydlexius 243 Posted September 27, 2022 Share Posted September 27, 2022 11 minutes ago, Luke said: I think the idea of multiple intros just hadn't really been considered. I don't think it makes a ton of sense to have more than one set of intro markers, however what would be the harm in allowing it? OTOH, when plugins like the Comskip one start importing EDL data into markers, supporting multiples of something like "commercial start/stop" sets would make sense. For that matter, eventual support for multiple "postcredit start/stop" sets might make sense. 2 1 Link to comment Share on other sites More sharing options...
rbjtech 4283 Posted September 27, 2022 Share Posted September 27, 2022 For commercials - then I don't think these should ever go in the database - that is what the industry standard EDL file is for. Duplicating this into a database makes no sense and the whole thing then becomes less portable. Just read the EDL file and use it, stop trying to re-engineer an existing working industry standard solution... Having separate markers for segments of a video that can be clearly defined, does makes sense and as these are not held to any standard elsewhere, putting those in a database makes sense - and for the reasons I gave above, are a one off function per episode. PreviouslyOn - start/end (not implemented/supported) Intro - start/end (implemented/supported on all clients) Credits - start/end (partially implemented/supported on ATV client) There could also be support for extra segments per episode for specialist video such as Anime - an 'Intro2' if you will - maybe even a custom named marker with a custom 'Notification' afterwards. 1 Link to comment Share on other sites More sharing options...
sydlexius 243 Posted September 27, 2022 Share Posted September 27, 2022 6 hours ago, rbjtech said: For commercials - then I don't think these should ever go in the database - that is what the industry standard EDL file is for. Duplicating this into a database makes no sense and the whole thing then becomes less portable. Just read the EDL file and use it, stop trying to re-engineer an existing working industry standard solution... Having separate markers for segments of a video that can be clearly defined, does makes sense and as these are not held to any standard elsewhere, putting those in a database makes sense - and for the reasons I gave above, are a one off function per episode. PreviouslyOn - start/end (not implemented/supported) Intro - start/end (implemented/supported on all clients) Credits - start/end (partially implemented/supported on ATV client) There could also be support for extra segments per episode for specialist video such as Anime - an 'Intro2' if you will - maybe even a custom named marker with a custom 'Notification' afterwards. I kind of view EDLs like I do NFO files. They're adopted across multiple implementations which is great for portability, but it is often useful to ingest their data into a database for performance, reporting, and transformative purposes. 1 Link to comment Share on other sites More sharing options...
scarfaro 4 Posted September 29, 2022 Share Posted September 29, 2022 How can I install this plugin? I have always done this via emby or a .dll file. But I can't find it anywhere here. Link to comment Share on other sites More sharing options...
Cheesegeezer 3087 Posted September 29, 2022 Share Posted September 29, 2022 37 minutes ago, scarfaro said: How can I install this plugin? I have always done this via emby or a .dll file. But I can't find it anywhere here. Plugin Catalogue under Metadata Section Link to comment Share on other sites More sharing options...
rbjtech 4283 Posted October 5, 2022 Share Posted October 5, 2022 @TeamB Just to help with what is worth adding to the ThemeService - in the IntroSummary report - would it be worth adding a condition/parameter to only show Intro's that are over say 60 seconds in length ? ie - the most annoying ones that you are most likely to skip ? Link to comment Share on other sites More sharing options...
crusher11 854 Posted October 5, 2022 Share Posted October 5, 2022 Two changes I'd really like to see with this: 1. An option to edit chapters 2. The time code field being one box, instead of an hours box/minutes box/seconds box. Would make it easier to enter time codes manually and also to copy and paste. Link to comment Share on other sites More sharing options...
b0dyr0ck2006 57 Posted October 5, 2022 Share Posted October 5, 2022 this works really well but is going to take me some time to work through over a hundred TV shows Link to comment Share on other sites More sharing options...
TeamB 2353 Posted October 5, 2022 Author Share Posted October 5, 2022 7 hours ago, rbjtech said: ThemeService - in the IntroSummary report Do you mean on the search page here: https://themeservice.azurewebsites.net/Home/Search Add a min duration to the intro length. Link to comment Share on other sites More sharing options...
TeamB 2353 Posted October 5, 2022 Author Share Posted October 5, 2022 4 hours ago, crusher11 said: 1. An option to edit chapters 2. The time code field being one box, instead of an hours box/minutes box/seconds box. Would make it easier to enter time codes manually and also to copy and paste. You can copy existing time by using the button next to the existing chapter, it copies the time to the top add form. you can then edit the time and re add. I know this is not a true edit action but for now it works if a bit clunky. I can look at a true edit action at some point. my thoughts at the time were that getting a time code 01:45.156 correct and having to parse it correctly is a pain in the ass, the separate boxes help with all of that as each box is just an int and well defined. It might be possible to have both options, not sure yet. Link to comment Share on other sites More sharing options...
TeamB 2353 Posted October 5, 2022 Author Share Posted October 5, 2022 32 minutes ago, b0dyr0ck2006 said: this works really well but is going to take me some time to work through over a hundred TV shows not all tv shows have useful detectable intros, some are too varying or too short to worry about. the idea was for the community to come together and work this out for shows and use https://themeservice.azurewebsites.net To host all the info and data which could then be used by the plugin to auto detect all the intros that are worth trying to detect. 1 Link to comment Share on other sites More sharing options...
b0dyr0ck2006 57 Posted October 5, 2022 Share Posted October 5, 2022 21 minutes ago, TeamB said: not all tv shows have useful detectable intros, some are too varying or too short to worry about. the idea was for the community to come together and work this out for shows and use https://themeservice.azurewebsites.net To host all the info and data which could then be used by the plugin to auto detect all the intros that are worth trying to detect. I've begun adding shows to that list 3 Link to comment Share on other sites More sharing options...
crusher11 854 Posted October 6, 2022 Share Posted October 6, 2022 7 hours ago, TeamB said: You can copy existing time by using the button next to the existing chapter, it copies the time to the top add form. you can then edit the time and re add. I know this is not a true edit action but for now it works if a bit clunky. I can look at a true edit action at some point. my thoughts at the time were that getting a time code 01:45.156 correct and having to parse it correctly is a pain in the ass, the separate boxes help with all of that as each box is just an int and well defined. It might be possible to have both options, not sure yet. In terms of copying/pasting, I'm thinking more of situations where I would be copying from Adobe Premiere, or MKVToolnix, not copying an existing time. It doesn't seem like it would be that difficult to parse, given it has to be exactly two numbers, then a colon, then exactly two numbers, then a colon, then exactly two numbers, then a decimal point, then exactly three numbers. Link to comment Share on other sites More sharing options...
rbjtech 4283 Posted October 6, 2022 Share Posted October 6, 2022 (edited) 8 hours ago, TeamB said: Do you mean on the search page here: https://themeservice.azurewebsites.net/Home/Search Add a min duration to the intro length. No I mean from the emby database - calculated via the IntroStart and IntroEnd values as shown below. I'd like to add the shows first where there is a long Intro - but I can't see Intro length on the summary and I think it would be useful to add as a season summary ? Thanks! Edited October 6, 2022 by rbjtech Link to comment Share on other sites More sharing options...
rbjtech 4283 Posted October 6, 2022 Share Posted October 6, 2022 (edited) To add .. Would it be possible to list the Season details on the ThemeService lists ? In the example below - it looks like I have added Picard twice, but infact there is a different theme/intro for each Season ... here .. Edited October 6, 2022 by rbjtech Link to comment Share on other sites More sharing options...
TeamB 2353 Posted October 6, 2022 Author Share Posted October 6, 2022 3 hours ago, crusher11 said: It doesn't seem like it would be that difficult to parse, given it has to be exactly two numbers, then a colon, then exactly two numbers, then a colon, then exactly two numbers, then a decimal point, then exactly three numbers. ok. Jump on this site https://dotnetfiddle.net/ write me a function that can take a string in the following formats and return a TimeSpan object 1.12:12:12.123 1.1:1:1:1.123 1:1.1 1.1 12:12:34.12345678 Link to comment Share on other sites More sharing options...
TeamB 2353 Posted October 6, 2022 Author Share Posted October 6, 2022 2 hours ago, rbjtech said: No I mean from the emby database - calculated via the IntroStart and IntroEnd values as shown below. so it would be the average intro duration for all the episodes that have one in the season? 2 hours ago, rbjtech said: Would it be possible to list the Season details on the ThemeService lists ? In the example below - it looks like I have added Picard twice, but infact there is a different theme/intro for each Season ... the season and episode are available in the Theme info page. The season and episode numbers are not currently used anywhere for matching, they are just for reference and play no part in which theme to use. All themes for a series are used when trying to detect intros. Link to comment Share on other sites More sharing options...
rbjtech 4283 Posted October 6, 2022 Share Posted October 6, 2022 2 minutes ago, TeamB said: so it would be the average intro duration for all the episodes that have one in the season? Yes - this is normally the same as any individual episode intro length - but ep1 without an intro (for example) would skew an average - so it would need to be the average of anything which has an intro, not just divide by the number of episodes in the season. 5 minutes ago, TeamB said: the season and episode are available in the Theme info page. The season and episode numbers are not currently used anywhere for matching, they are just for reference and play no part in which theme to use. All themes for a series are used when trying to detect intros. Yes - ok - understood but I then need to click into each Theme to see this info. As an example - somebody has uploaded Westworld - it's there twice - this is Season 1 and Season 3 - no other Seasons ... If the results page of the search could show Seasons's as well - then I would know the other Seasons are missing - so either add them myself or not expect them to be matched. Link to comment Share on other sites More sharing options...
TeamB 2353 Posted October 6, 2022 Author Share Posted October 6, 2022 28 minutes ago, rbjtech said: Yes - this is normally the same as any individual episode intro length - but ep1 without an intro (for example) would skew an average - so it would need to be the average of anything which has an intro, not just divide by the number of episodes in the season. yep, that is what I said, "the average intro duration for all the episodes that have one in the season" 35 minutes ago, rbjtech said: If the results page of the search could show Seasons's as well - then I would know the other Seasons are missing - so either add them myself or not expect them to be matched. are the seasons different? 1 Link to comment Share on other sites More sharing options...
rbjtech 4283 Posted October 6, 2022 Share Posted October 6, 2022 4 minutes ago, TeamB said: are the seasons different? Maybe - but just re-ran detection and got a 100% match - so either way, it works .. Link to comment Share on other sites More sharing options...
b0dyr0ck2006 57 Posted October 6, 2022 Share Posted October 6, 2022 3 hours ago, rbjtech said: To add .. Would it be possible to list the Season details on the ThemeService lists ? In the example below - it looks like I have added Picard twice, but infact there is a different theme/intro for each Season ... here .. Same for American Horror Story. Season 1 and Season 2 are different but looks like ive added the same thing 1 Link to comment Share on other sites More sharing options...
TeamB 2353 Posted October 6, 2022 Author Share Posted October 6, 2022 1 hour ago, rbjtech said: Maybe - but just re-ran detection and got a 100% match - so either way, it works .. so from the two intros that are there it covers all seasons ok, that is good and to be expected in a lot of series. i will add season and episode number to the table, the main reason i did not want to is i feel users that dont understand would expect there to be an intro for every season or even every episode and as we can see from your above test that is not the case. 1 Link to comment Share on other sites More sharing options...
TeamB 2353 Posted October 7, 2022 Author Share Posted October 7, 2022 I added season and episode info to the results page https://themeservice.azurewebsites.net/Home/Search 1 Link to comment Share on other sites More sharing options...
Recommended Posts
Create an account or sign in to comment
You need to be a member in order to leave a comment
Create an account
Sign up for a new account in our community. It's easy!
Register a new accountSign in
Already have an account? Sign in here.
Sign In Now