Jump to content

Plugin - Chapter Editor (ChapterApi)


TeamB

Recommended Posts

rbjtech
33 minutes ago, chef said:

Because the core devs used so e of our code for internal intro skip.

If they say they dont care. 

One of the community members already sourced and posted intro skip code publicly anyway.

It doesn't matter to me. 

As you wrote the original code @chef, then you say if it's public or not - what emby copied/used/derived/asked to use/didn't ask to use in their private code is imo irrelevant.

We kept it closed source at the time as we knew JF were sniffing - but I see zero reason why it cannot be open source now ?

100% up to you my friend.

Edited by rbjtech
  • Agree 3
  • Thanks 1
Link to comment
Share on other sites

chef

Sure thing. I'll make it public. No issues here. 

  • Like 4
  • Thanks 3
Link to comment
Share on other sites

crusher11

A version of the IntroSkip plug-in that could create intro and credit markers without editing chapter points would be amazing.

Link to comment
Share on other sites

rbjtech
13 hours ago, crusher11 said:

A version of the IntroSkip plug-in that could create intro and credit markers without editing chapter points would be amazing.

Err.. just turn it off ?

image.png.181ee79ecbdd9688158af6b17ed38729.png

This may have confused you (the schedule) this should probably have been called core hidden markers insertion, not chapter insertion.

image.png.d7984028e7fe47ef455f6dec80828361.png

 

 

 

 

Link to comment
Share on other sites

crusher11

My understanding is that you have to add the chapter points first, then those are used to create the hidden markers.

Link to comment
Share on other sites

rbjtech
6 minutes ago, crusher11 said:

My understanding is that you have to add the chapter points first, then those are used to create the hidden markers.

I can't honestly remember, it's been a while .. I'll look a little later on or you can look yourself and let me know.   Once chef has released the source (and cheese will need to as well, he wrote the chapter insertion bit) then it's easy enough to make that an option and skip it..

Link to comment
Share on other sites

  • 1 month later...
Oratorian

Seems like ChapterAPI is not made to work with Beta version, when trying to extract the croma fingerprints or even the intro audio.

 

It just displays "Access token is invalid or expired."

image.png.ba8d4c40b7c65a7dba03307d01187ee7.png

The Addressbar has the api_key but its 'null' and there is no setting to set it for the plugin.
If i set eit manually with one of the keys, Audiofiles are still 0kb ..

Edited by Oratorian
Link to comment
Share on other sites

TeamB

its probably a change in the JS APIs.

Still getting over the last beta release cycle, I won't be touching the Beta for at least 12 months.

Link to comment
Share on other sites

TeamB

This should be fixed the the latest version.

- fix play icon display
- fix access token errors

  • Thanks 1
Link to comment
Share on other sites

TeamB
1 hour ago, Oratorian said:

when i try to extract the intro audio, they are all 0bytes 😕

are you using strm files?

Link to comment
Share on other sites

Oratorian

No. Mostly mkv and mp4

Edited by Oratorian
Link to comment
Share on other sites

TeamB
29 minutes ago, Oratorian said:

No. Mostly mkv and mp4

ok, do an extraction and pm me your emby log and i can look into it

Link to comment
Share on other sites

Oratorian

i just tested something.

If i run 
 

Quote

/opt/emby-server/bin # ./ffmpeg  -i "/mnt/Anime/DOTA Dragons Blood/Season 1/DOTA Dragons Blood - S01E02 - Princess of Nothing.mkv" -ss 66.9154228 -t 51.4925373 -ac 1 -acodec pcm_s16le -ar 44100 -c:v nul -f wav /opt/testintro.wav

it works just fine...

 

Even trying to extract a chromaprint results in - Error extracting chromaprint data 1 (23429)

Edited by Oratorian
Link to comment
Share on other sites

Oratorian
25 minutes ago, Oratorian said:

/opt/emby-server/bin # ./ffmpeg  -i "/mnt/Anime/DOTA Dragons Blood/Season 1/DOTA Dragons Blood - S01E02 - Princess of Nothing.mkv" -ss 66.9154228 -t 51.4925373 -ac 1 -acodec pcm_s16le -ar 44100 -c:v nul -f wav /opt/testintro.wav

 

I just ran the command as if emby would, not like me in my own little world, and got this:

export LD_LIBRARY_PATH=/opt/emby-server/lib/
$ /opt/emby-server/lib # ../bin/ffmpeg -accurate_seek -i "/mnt/Anime/DOTA Dragons Blood/Season 1/DOTA Dragons Blood - S01E02 - Princess of Nothing.mkv" -ss 66,9154228 -t 51,4925373 -ac 1 -acodec pcm_s16le -ar 44100 -c:v nul -f wav /root/test.wav
ffmpeg version 5.1-emby_2023_06_25 Copyright (c) 2000-2022 the FFmpeg developers and softworkz for Emby LLC
  built with gcc 10.3.0 (crosstool-NG 1.25.0)
Execution Date: 2024-03-30 15:09:52
Input #0, matroska,webm, from '/mnt/Anime/DOTA Dragons Blood/Season 1/DOTA Dragons Blood - S01E02 - Princess of Nothing.mkv':
  Metadata:
    title           : [Hakata Ramen] DOTA: Dragon's Blood S01E02 "Princess of Nothing" (2021) [Netflix 1080p x265 E-OPUS] ~Doc_Ramen
    encoder         : libebml v1.4.2 + libmatroska v1.6.4
    creation_time   : 2022-08-07T17:56:07.000000Z
  Duration: 00:26:12.52, start: -0.007000, bitrate: 1072 kb/s
  Stream #0:0(kor): Video: hevc (Main 10), yuv420p10le(tv, bt709), 1920x1080 [SAR 1:1 DAR 16:9], Level 120, 24 fps, 24 tbr, 1k tbn (default)
    Metadata:
      title           : HD 1080p HEVC [0,8Mb/s]
      BPS             : 813295
      DURATION        : 00:26:12.459000000
      NUMBER_OF_FRAMES: 37739
      NUMBER_OF_BYTES : 159859227
  Stream #0:1(eng): Audio: opus, 48000 Hz, 5.1, fltp, Start-Time -0.007s (default)
    Metadata:
      title           :  (48Khz)
      BPS             : 256196
      DURATION        : 00:26:12.519000000
      NUMBER_OF_FRAMES: 78626
      NUMBER_OF_BYTES : 50359298
  Stream #0:2(eng): Subtitle: subrip, Start-Time -0.007s
    Metadata:
      title           : English [SDH]
      BPS             : 63
      DURATION        : 00:24:05.333000000
      NUMBER_OF_FRAMES: 405
      NUMBER_OF_BYTES : 11468
  Stream #0:3: Video: mjpeg (Progressive), yuvj420p(pc, bt470bg/unknown/unknown), 640x640 [SAR 72:72 DAR 1:1], 90k tbr, 90k tbn, Start-Time -0.007s (attached pic)
    Metadata:
      filename        : [Hakata Ramen].jpg
      mimetype        : image/jpeg
Invalid duration specification for ss: 66,9154228
EXIT

 After taking pünktchens post

31 minutes ago, pünktchen said:

@TeamBThe problem is the decimal separator depending on the OS regional settings: https://github.com/faush01/ChapterApi/pull/4

into consideration and switched comma for dots it workrd.

 

/opt/emby-server/lib # ../bin/ffmpeg -accurate_seek -i "/mnt/Anime/DOTA Dragons Blood/Season 1/DOTA Dragons Blood - S01E02 - Princess of Nothing.mkv" -ss 66.9154228 -t 51.4925373 -ac 1 -acodec pcm_s16le -ar 44100 -c:v nul -f wav /root/test.wav
ffmpeg version 5.1-emby_2023_06_25 Copyright (c) 2000-2022 the FFmpeg developers and softworkz for Emby LLC
  built with gcc 10.3.0 (crosstool-NG 1.25.0)
Execution Date: 2024-03-30 15:19:21
Input #0, matroska,webm, from '/mnt/Anime/DOTA Dragons Blood/Season 1/DOTA Dragons Blood - S01E02 - Princess of Nothing.mkv':
  Metadata:
    title           : [Hakata Ramen] DOTA: Dragon's Blood S01E02 "Princess of Nothing" (2021) [Netflix 1080p x265 E-OPUS] ~Doc_Ramen
    encoder         : libebml v1.4.2 + libmatroska v1.6.4
    creation_time   : 2022-08-07T17:56:07.000000Z
  Duration: 00:26:12.52, start: -0.007000, bitrate: 1072 kb/s
  Stream #0:0(kor): Video: hevc (Main 10), yuv420p10le(tv, bt709), 1920x1080 [SAR 1:1 DAR 16:9], Level 120, 24 fps, 24 tbr, 1k tbn (default)
    Metadata:
      title           : HD 1080p HEVC [0,8Mb/s]
      BPS             : 813295
      DURATION        : 00:26:12.459000000
      NUMBER_OF_FRAMES: 37739
      NUMBER_OF_BYTES : 159859227
  Stream #0:1(eng): Audio: opus, 48000 Hz, 5.1, fltp, Start-Time -0.007s (default)
    Metadata:
      title           :  (48Khz)
      BPS             : 256196
      DURATION        : 00:26:12.519000000
      NUMBER_OF_FRAMES: 78626
      NUMBER_OF_BYTES : 50359298
  Stream #0:2(eng): Subtitle: subrip, Start-Time -0.007s
    Metadata:
      title           : English [SDH]
      BPS             : 63
      DURATION        : 00:24:05.333000000
      NUMBER_OF_FRAMES: 405
      NUMBER_OF_BYTES : 11468
  Stream #0:3: Video: mjpeg (Progressive), yuvj420p(pc, bt470bg/unknown/unknown), 640x640 [SAR 72:72 DAR 1:1], 90k tbr, 90k tbn, Start-Time -0.007s (attached pic)
    Metadata:
      filename        : [Hakata Ramen].jpg
      mimetype        : image/jpeg
File '/root/test.wav' already exists. Overwrite? [y/N] y
Stream mapping:
  Stream #0:1 -> #0:0 (opus (native) -> pcm_s16le (native))
Press [q] to stop, [?] for help
Output #0, wav, to '/root/test.wav':
  Metadata:
    INAM            : [Hakata Ramen] DOTA: Dragon's Blood S01E02 "Princess of Nothing" (2021) [Netflix 1080p x265 E-OPUS] ~Doc_Ramen
    ISFT            : Lavf59.27.100
  Stream #0:0(eng): Audio: pcm_s16le ([1][0][0][0] / 0x0001), 44100 Hz, mono, s16, 705 kb/s (default)
    Metadata:
      title           :  (48Khz)
      BPS             : 256196
      DURATION        : 00:26:12.519000000
      NUMBER_OF_FRAMES: 78626
      NUMBER_OF_BYTES : 50359298
      encoder         : Lavc59.37.100 pcm_s16le
elapsed=00:00:00.44 size=    4435kB time=00:00:51.49 bitrate= 705.6kbits/s throttle=off speed= 117x
video:0kB audio:4435kB subtitle:0kB other streams:0kB global headers:0kB muxing overhead: 0.004360%
EXIT

 

Edited by Oratorian
Link to comment
Share on other sites

Oratorian
1 hour ago, TeamB said:

i hate string format 😞

But my servers system language is set to en_US.UTF-8, so it must be a ffmeg limitation not a system locale limitation.

Link to comment
Share on other sites

TeamB
8 hours ago, Oratorian said:

But my servers system language is set to en_US.UTF-8, so it must be a ffmeg limitation not a system locale limitation.

I think it is a region thing not a Lang thing 

Link to comment
Share on other sites

Oratorian
5 hours ago, TeamB said:

I think it is a region thing not a Lang thing 

But the Region in an Ubuntu environment is defined be the system package locale.

Thats what i am curious about.

Link to comment
Share on other sites

TeamB

Sorry this took so long but Easter happened and then some work stuff.

Version 1.3.0.10 should fix the issue.

  • Thanks 1
Link to comment
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now
×
×
  • Create New...