colored icons on buttons don't contrast when selected by matching accent color

[daedalus 430]

colored icons on buttons get "hidden" when selected, while they should turn to white?

 

sample @ halloween theme

 

 

this also affects the "default" red checkmark on accent color red

[Luke 40111]

Thanks, will take a look.

[Happy2Play 9446]

Do to container focus background and icon status/rating (Played/favorite enabled being the same color). 

 

.emby-button-focusscale:focus .detailButton-icon {
    background: #ff9100;}

 

.ratingbutton-icon-withrating {

    color: #ff9100!important;)

Edited November 1, 2019 by Happy2Play

[daedalus 430]

Do to container focus background and icon status/rating (Played/favorite enabled being the same color). 

 

.emby-button-focusscale:focus .detailButton-icon {

    background: #ff9100;}

 

.ratingbutton-icon-withrating {

    color: #ff9100!important;)

 

this mainly affects ET and there its not applicable

 

 

half a year and still the same

Edited April 17, 2020 by daedalus

[Luke 40111]

I think it might actually be better to just keep the hearts as red in all themes. I think focusing a colored heart, and having it turn white when focused will not be intuitive.

[daedalus 430]

I think it might actually be better to just keep the hearts as red in all themes.

so it would still vanish with red accent color

[Luke 40111]

Well yes, assuming the shades of red are the same. I suppose another option is just to use a focus border instead.