Jump to content


Photo

Active video has small gap on side and bottom of screen


  • Please log in to reply
354 replies to this topic

#181 AdrianW OFFLINE  

AdrianW

    Advanced Member

  • Super Testers
  • 2350 posts
  • Local time: 04:41 PM
  • LocationPerth, Australia

Posted 25 November 2018 - 11:27 AM

You were doing this after video started, right?

 

Yes. 



#182 nicko84 OFFLINE  

nicko84

    Advanced Member

  • Members
  • 230 posts
  • Local time: 10:41 AM

Posted 07 December 2018 - 11:54 AM

After the var bounds you could do something like bounds.height +=3; and same for width.

 

 

Hello AdrianW and Luke,

 

Can you give the code to add after Bounds to resize window please ?

 

Thanks



#183 AdrianW OFFLINE  

AdrianW

    Advanced Member

  • Super Testers
  • 2350 posts
  • Local time: 04:41 PM
  • LocationPerth, Australia

Posted 08 December 2018 - 09:58 AM

 

Can you give the code to add after Bounds to resize window please ?

 

 

Here's what I did:

 

change this:

    function onWindowResize() {

        if (!useTrueFullScreen || currentWindowState === 'Normal') {
            var bounds = mainWindow.getBounds();
            playerWindow.setBounds(bounds);
        }
    }

to this:

    function onWindowResize() {

        if (!useTrueFullScreen || currentWindowState === 'Normal') {
            var bounds = mainWindow.getBounds();
   	    bounds.height += 6;
	    bounds.width += 6;
            playerWindow.setBounds(bounds);
        }
    }


#184 nicko84 OFFLINE  

nicko84

    Advanced Member

  • Members
  • 230 posts
  • Local time: 10:41 AM

Posted 08 December 2018 - 01:31 PM

Thanks AdrianW, it works very well !



#185 Luke OFFLINE  

Luke

    System Architect

  • Administrators
  • 128711 posts
  • Local time: 04:41 AM

Posted 21 December 2018 - 04:32 PM

Can you please try this version:

https://www.dropbox....heater.zip?dl=0

 

Just unzip and run it portable. Thanks.



#186 nicko84 OFFLINE  

nicko84

    Advanced Member

  • Members
  • 230 posts
  • Local time: 10:41 AM

Posted 22 December 2018 - 12:10 PM

Hello Luke,

 

Same issue...gap at the bottom and right side of the video when refresh rate changes (50 to 23)

 

If you reduce the window when the video is playing and extend it (full screen) then gaps vanish…

 

So for the moment i'm using AdrianW trick to resize video (+3/+3)

 

NB : same issue whith Electron 4.0.0 and ET 3.0.6


Edited by nicko84, 23 December 2018 - 05:24 AM.


#187 Doofus OFFLINE  

Doofus

    Advanced Member

  • Members
  • 11342 posts
  • Local time: 01:41 AM

Posted 23 December 2018 - 02:15 PM

Is it just me, or is refresh rate switching not working in 3.0.6?

 

 

UPDATE

 

It works fine on my other machine. But the gap on the right and bottom is still there.


Edited by Doofus, 23 December 2018 - 03:48 PM.


#188 AdrianW OFFLINE  

AdrianW

    Advanced Member

  • Super Testers
  • 2350 posts
  • Local time: 04:41 PM
  • LocationPerth, Australia

Posted 25 December 2018 - 11:47 AM

But the gap on the right and bottom is still there.

 

I had to apply the hack again yesterday after ET updated itself.



#189 nicko84 OFFLINE  

nicko84

    Advanced Member

  • Members
  • 230 posts
  • Local time: 10:41 AM

Posted 07 January 2019 - 07:22 AM

Hello Luke,

 

Some news about this problem ?



#190 DrJekle OFFLINE  

DrJekle

    Advanced Member

  • Members
  • 110 posts
  • Local time: 09:41 AM

Posted 10 January 2019 - 07:43 AM

Following this as I also have the same issue. Of course I just max/minimize after playback, like others have said it works but a pain

#191 ShoutingMan OFFLINE  

ShoutingMan

    Advanced Member

  • Members
  • 642 posts
  • Local time: 04:41 AM

Posted 03 February 2019 - 06:18 PM

With Emby 3.0.6 the white line is back. I assume I have to manually revert Electron again. Is Electron version 1.8.7 still the latest version that works right?



#192 Luke OFFLINE  

Luke

    System Architect

  • Administrators
  • 128711 posts
  • Local time: 04:41 AM

Posted 04 February 2019 - 01:12 AM

To my knowledge yes.



#193 Doofus OFFLINE  

Doofus

    Advanced Member

  • Members
  • 11342 posts
  • Local time: 01:41 AM

Posted 04 February 2019 - 01:55 AM

electron 5.0.0-beta.1 has a ton of fixes/changes. I wonder if this fix has anything to do with this issue?



#194 Luke OFFLINE  

Luke

    System Architect

  • Administrators
  • 128711 posts
  • Local time: 04:41 AM

Posted 04 February 2019 - 10:45 AM

Cool thanks for the info!

#195 nicko84 OFFLINE  

nicko84

    Advanced Member

  • Members
  • 230 posts
  • Local time: 10:41 AM

Posted 10 February 2019 - 06:47 AM

Hello,

 

ET 3.0.6 and electron 5.0.0 beta 2 : the issue isn't solved, still gaps at the bottom et right size of the screen (grrrr !)


Edited by nicko84, 10 February 2019 - 02:23 PM.

  • serpi and ShoutingMan like this

#196 serpi OFFLINE  

serpi

    Advanced Member

  • Members
  • 205 posts
  • Local time: 09:41 AM

Posted 10 February 2019 - 12:34 PM

So mabe it IS a bug in ET, how it handles screen mode changes and only shows with Electron 2.0+?

 

If it was a bug in Electron, I would believe some other programs would have also that problem and there would have been a fix to it?

 

But it also seems, there is not that much development going on for ET.

Looking at the releases, it's most times only replacing Electron/mpv,

 

And there's still the now useless 3d mode setting and no setting to get the checkmark for watched content back.

 

But at least the never implemented plugin settings are gone (would be better, to have some plugins, like themes, YouTube, etc).

 

Ciao, Alfred


  • daedalus and PrincessClevage like this

#197 Doofus OFFLINE  

Doofus

    Advanced Member

  • Members
  • 11342 posts
  • Local time: 01:41 AM

Posted 10 February 2019 - 12:45 PM

Yeah, Theater does need some love.
  • daedalus, JAJ and serpi like this

#198 nicko84 OFFLINE  

nicko84

    Advanced Member

  • Members
  • 230 posts
  • Local time: 10:41 AM

Posted 10 February 2019 - 02:27 PM

So i still use the trick in main.json to resize window and hope for a patch soon.

 

It works well in Kodi and Plex player and many others for a long time...



#199 freddyfinn OFFLINE  

freddyfinn

    Member

  • Members
  • 29 posts
  • Local time: 06:41 PM

Posted 12 February 2019 - 07:04 AM

Maybe this should be added to future releases until a permanent solution is found.

Works for me.

 

 

Here's what I did:

 

change this:

    function onWindowResize() {

        if (!useTrueFullScreen || currentWindowState === 'Normal') {
            var bounds = mainWindow.getBounds();
            playerWindow.setBounds(bounds);
        }
    }

to this:

    function onWindowResize() {

        if (!useTrueFullScreen || currentWindowState === 'Normal') {
            var bounds = mainWindow.getBounds();
   	    bounds.height += 6;
	    bounds.width += 6;
            playerWindow.setBounds(bounds);
        }
    }

  • serpi and ShoutingMan like this

#200 nicko84 OFFLINE  

nicko84

    Advanced Member

  • Members
  • 230 posts
  • Local time: 10:41 AM

Posted 12 February 2019 - 01:40 PM

+1

 

Maybe added to settings in ET like "Overscan" option.






0 user(s) are reading this topic

0 members, 0 guests, 0 anonymous users