Luke 37093 Posted August 21, 2016 Share Posted August 21, 2016 the duplication is resolved for the next release of emby server. 1 Link to comment Share on other sites More sharing options...
ecks669 4 Posted August 21, 2016 Author Share Posted August 21, 2016 (edited) the problem is not the duplicate values since duplicates dont affect anything but the incorrect values for (airsbefore_episode, displayepisode, airsbefore_season, displayseason) which emby read and syncs to kodi. I guess I will just have to write a script to scan all nfos and remove those tags which emby should read and then sync with kodi. Edited August 21, 2016 by ecks669 Link to comment Share on other sites More sharing options...
Angelblue05 4130 Posted August 21, 2016 Share Posted August 21, 2016 (edited) Something sounds incorrect, because the add-on does insert the value -1 for episode ordering, but only in the event the episode number is not returned by the server. I know you said the episode number is correct, it's just the ordering that is incorrect. Do you mind providing the following: Enable the emby for kodi add-on log level as debug. Then just hit save in the metadata manager for one episode that has this issue. Provide your Kodi log so I can verify. If you need help with that http://emby.media/community/index.php?/topic/17599-how-to-report-a-problem/ Edited August 21, 2016 by Angelblue05 Link to comment Share on other sites More sharing options...
ecks669 4 Posted August 22, 2016 Author Share Posted August 22, 2016 (edited) Ok here is the log, just some information on how it appears in kodi. The ordering in kodi appears as follows episodes 17-23 and then the rest 1-16. I saved episode 17 and episode 1 and no ordering changed. I looked in the nfo and 17 has correct values and 1 does not, it has those -1 values. kodi.log Edited August 22, 2016 by ecks669 1 Link to comment Share on other sites More sharing options...
Angelblue05 4130 Posted August 26, 2016 Share Posted August 26, 2016 (edited) @@ecks669 Sorry for coming back to you so late on this one. I've checked your log, everything looks fine. However you are right, the server returns -1 as AirsBeforeEpisode and that is what is causing the issue in Kodi. I would assume if we were to default everything as -1, then that could technically solve the issue. You say it's only in Kodi the ordering is messed up; In the webclient, it looks fine? Can you try this build, let me know if it resolves the issue... Just install from zip over your current build. Also, you will need to do a reset of the local database to apply the fix. plugin.video.emby-2.2.20~alpha.zip Edited August 26, 2016 by Angelblue05 Link to comment Share on other sites More sharing options...
Luke 37093 Posted August 26, 2016 Share Posted August 26, 2016 The reason the web client is fine i would think is because we don't do anything with those values other than save them to nfo for Kodi to read. I can change the values that get written, like I said earlier, but what I'm wondering is if you guys can help figure out what those values should be as I'm not too familiar with how Kodi uses them. Thanks. Link to comment Share on other sites More sharing options...
Angelblue05 4130 Posted August 26, 2016 Share Posted August 26, 2016 Ok, They should be null unless they actually have values. Sent from my iPhone using Tapatalk Link to comment Share on other sites More sharing options...
Luke 37093 Posted August 26, 2016 Share Posted August 26, 2016 But what should they be? Link to comment Share on other sites More sharing options...
Angelblue05 4130 Posted August 26, 2016 Share Posted August 26, 2016 (edited) Can you give me specifics @@Luke and I'll look into it for you. I haven't used Kodi on it's own for a while. Sent from my iPhone using Tapatalk Edited August 26, 2016 by Angelblue05 Link to comment Share on other sites More sharing options...
Luke 37093 Posted August 26, 2016 Share Posted August 26, 2016 Post 21 goes over what values we're putting in there. Thanks. 1 Link to comment Share on other sites More sharing options...
Angelblue05 4130 Posted August 26, 2016 Share Posted August 26, 2016 Got it, I'll let you know about it. Sent from my iPhone using Tapatalk Link to comment Share on other sites More sharing options...
pünktchen 1258 Posted August 26, 2016 Share Posted August 26, 2016 displayseason and displayepisode should be -1 or better shouldn't be used at all if you don't want the specials to be sorted between the regular episodes. Otherwise displayseason gets the number of the season the special was aired and displayepisode gets the sort number. Eg. a special that was aired in season 2 between episode 3 and 4 gets displayseason 2 and displayepisode 4. A regular episode never gets displayseason and displayepisode. A special case i have to verify first would be if there were 2 specials aired between episode 3 and 4 but one only has the second special locally available. 2 Link to comment Share on other sites More sharing options...
Angelblue05 4130 Posted August 26, 2016 Share Posted August 26, 2016 Hey thanks for this @@pünktchen Sent from my iPhone using Tapatalk Link to comment Share on other sites More sharing options...
pünktchen 1258 Posted August 26, 2016 Share Posted August 26, 2016 Further info (i've exported some nfo in Kodi): no matter how many specials were aired between episode 3 and 4, they ALL get displayepisode 4! Link to comment Share on other sites More sharing options...
pünktchen 1258 Posted August 26, 2016 Share Posted August 26, 2016 Last info: specials that were aired at the end of a season (NOT at the beginning of the next one) get displayepisode 4096. 1 Link to comment Share on other sites More sharing options...
Luke 37093 Posted August 26, 2016 Share Posted August 26, 2016 Well you need to look at post #21. Our backing storage is done in a way that is similar to how tvdb utilizes specials. So what I need to know is exactly how to convert that to and from the kodi convention. Link to comment Share on other sites More sharing options...
pünktchen 1258 Posted August 26, 2016 Share Posted August 26, 2016 (edited) Well you need to look at post #21. Our backing storage is done in a way that is similar to how tvdb utilizes specials. So what I need to know is exactly how to convert that to and from the kodi convention. Airs Before: 04x11 -> displayseason 4 and displayepisode 11 <episodedetails> <title>Catch the Frak Up</title> <showtitle>Battlestar Galactica (2003)</showtitle> <rating>7.700000</rating> <userrating>0</userrating> <epbookmark>0.000000</epbookmark> <year>0</year> <top250>0</top250> <season>0</season> <episode>9</episode> <uniqueid>1236631</uniqueid> <displayseason>4</displayseason> <displayepisode>11</displayepisode> <votes>3</votes> <outline></outline> <plot>A 13 minute narrated video clip giving you a full update of what has happened in Battlestar Galactica up to Season 4 Episode 10.</plot> <tagline></tagline> <runtime>45</runtime> <thumb>http://thetvdb.com/banners/episodes/73545/1236631.jpg</thumb> <mpaa>TV-14</mpaa> <playcount>0</playcount> <lastplayed></lastplayed> <id></id> <genre>Action</genre> <genre>Adventure</genre> <genre>Drama</genre> <genre>Science-Fiction</genre> <premiered>2003-12-08</premiered> <status></status> <code></code> <aired>2008-12-08</aired> <studio>SciFi</studio> <trailer></trailer> <resume> <position>0.000000</position> <total>0.000000</total> </resume> <dateadded>2016-08-26 20:34:09</dateadded> </episodedetails> --------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- Airs After Season: 4 -> displayseason 4 and displayepidode 4096 <episodedetails> <title>The Plan</title> <showtitle>Battlestar Galactica (2003)</showtitle> <rating>7.800000</rating> <userrating>0</userrating> <epbookmark>0.000000</epbookmark> <year>0</year> <top250>0</top250> <season>0</season> <episode>22</episode> <uniqueid>1197791</uniqueid> <displayseason>4</displayseason> <displayepisode>4096</displayepisode> <votes>32</votes> <outline></outline> <plot>The Plan storyline begins before the attack on the 12 colonies and will show events mainly from the perspective of two Cylon agents, Cavil and Anders.</plot> <tagline></tagline> <runtime>45</runtime> <thumb>http://thetvdb.com/banners/episodes/73545/1197791.jpg</thumb> <mpaa>TV-14</mpaa> <playcount>0</playcount> <lastplayed></lastplayed> <id></id> <genre>Action</genre> <genre>Adventure</genre> <genre>Drama</genre> <genre>Science-Fiction</genre> <credits>Jane Espenson</credits> <director>Edward James Olmos</director> <premiered>2003-12-08</premiered> <status></status> <code></code> <aired>2009-10-27</aired> <studio>SciFi</studio> <trailer></trailer> <resume> <position>0.000000</position> <total>0.000000</total> </resume> <dateadded>2016-08-26 21:10:20</dateadded> </episodedetails> Edited August 26, 2016 by pünktchen 1 Link to comment Share on other sites More sharing options...
Luke 37093 Posted August 27, 2016 Share Posted August 27, 2016 Thanks. I thought that's what we're doing Link to comment Share on other sites More sharing options...
Angelblue05 4130 Posted August 27, 2016 Share Posted August 27, 2016 If it is, where are those -1 values coming from in the user's case? Sent from my iPhone using Tapatalk Link to comment Share on other sites More sharing options...
Luke 37093 Posted August 27, 2016 Share Posted August 27, 2016 maybe they came from tvdb because i don't see anything in our code defaulting them to -1. so i will have to update it to check for -1 and not write it in that situation. 1 Link to comment Share on other sites More sharing options...
ecks669 4 Posted August 28, 2016 Author Share Posted August 28, 2016 (edited) OK I installed that emby plugin and reset the kodi database and the ordering didnt change for that show that was in the logs same exact order. Isnt the problem on the emby server side since it can be fixed on there? Also for the tags sent to kodi those 4 displayseason displayepisode and the airsbefore ones should be removed and not even be added in the first place for regular episodes. All you need is season and episode, those are only if you want to overwrite and make them appear in another season or episode order. That could be wanted for specials but even those do not require it since they appear in there own specials season. And yes only kodi is affected everything is fine in the webclient Edited August 28, 2016 by ecks669 Link to comment Share on other sites More sharing options...
Angelblue05 4130 Posted August 28, 2016 Share Posted August 28, 2016 Ok. Well I tried. This will need to be rectified server side with Luke's proposed solution. Sent from my iPhone using Tapatalk Link to comment Share on other sites More sharing options...
ecks669 4 Posted August 28, 2016 Author Share Posted August 28, 2016 (edited) Just to add about the extra tags, this is straight from the kodi documentation <displayseason>3</displayseason> <!-- For TV show specials, determines how the special episode is sorted in "all" and season views. --> <displayepisode>7</displayepisode> <!-- For TV show specials, determines how the special episode is sorted in "all" and season views. If marked as episode 7, the special will come before the real episode 7. --> So those 2 are only for specials not for regular episodes and the airsbefore ones are not needed at all since you can achieve any order you want with just those 2 tags for specials Edited August 28, 2016 by ecks669 1 Link to comment Share on other sites More sharing options...
Luke 37093 Posted August 28, 2016 Share Posted August 28, 2016 Ok thanks so we'll only make sure to write those values for special episodes. Link to comment Share on other sites More sharing options...
Angelblue05 4130 Posted August 29, 2016 Share Posted August 29, 2016 (edited) Version 3.1.126.0 I've just encountered this issue. I don't know where the value comes from, but it's wrong....: u'AirsBeforeSeasonNumber': 1 <airsbefore_season>1</airsbefore_season> I retraced the emby server log to the cache for the scraped episode: {"air_date":"2011-03-14T00:00:00.0000000Z","episode_number":21,"name":"Monsters in the End","overview":"Everyone has something to hide - whether it be a secret romance, who they really are and what their true intentions are. For Aria, Emily, Hanna and Spencer, keeping things hidden is second nature, but having to live with those secrets can become a big burden. How long can Aria be with someone when they can't go out in public? Is it a true friendship when Spencer and Toby aren't able to be seen together? How truthful can Emily be when she can't be honest about whom she wants to be with? And how can Hanna move on when she secretly still wants to be with the one who broke her heart? With someone like \"A\" out there to watch their every move, four Liars may not have to worry about keeping things hidden for too much longer. Meanwhile, Rosewood police officer Garrett Reynolds is keeping his promise to keep a close eye on the girls - much closer than they realize.","id":761908,"season_number":1,"still_path":"/8Ck5bIGze5NsBO9UrYTUSC7vBhF.jpg","vote_average":9,"vote_count":2,"images":{"stills":[{"aspect_ratio":1.77845351867941,"file_path":"/8Ck5bIGze5NsBO9UrYTUSC7vBhF.jpg","height":1151,"vote_average":5.3125,"vote_count":1,"width":2047},{"aspect_ratio":1.77739130434783,"file_path":"/9c3OwS25dOhwBcRGDIAMGWfpulE.jpg","height":1150,"vote_average":0,"vote_count":0,"width":2044},{"aspect_ratio":1.77777777777778,"file_path":"/ihv0oAfnSvGjuX8eRTDoSkHFZiF.jpg","height":1152,"vote_average":0,"vote_count":0,"width":2048},{"aspect_ratio":1.77777777777778,"file_path":"/uawYSyQurDAmOXsW9w5xeFT9Vx1.jpg","height":1152,"vote_average":0,"vote_count":0,"width":2048},{"aspect_ratio":1.77777777777778,"file_path":"/3JCxkIA8uIeQlijFIQPW3ZACi2L.jpg","height":225,"vote_average":0,"vote_count":0,"width":400}]},"external_ids":{"freebase_mid":"/m/0j832b3","tvdb_id":3719941,"tvrage_id":0},"credits":{"cast":[{"character":"Spencer Hastings","credit_id":"52a65f5519c2951a6b01dd4c","id":277081,"name":"Troian Bellisario","profile_path":"/pLcUHQsyDrXjgZKy1ti15LFDn9u.jpg","order":0},{"character":"Hanna Marin","credit_id":"52a65f6019c2951a6b01ddb0","id":78030,"name":"Ashley Benson","profile_path":"/6cC7dCRdw1z8LOHrCFeqjzJfZB5.jpg","order":1},{"character":"Aria Montgomery","credit_id":"52a65f6d19c2951a6b01df34","id":205307,"name":"Lucy Hale","profile_path":"/r3hs2FTSp0RvR7lB2jeqF6tNg9z.jpg","order":2},{"character":"Emily Fields","credit_id":"52a65f9c19c2951a6801ac9c","id":222088,"name":"Shay Mitchell","profile_path":"/kfvtEaN66gQS8JJStG7eG1ehwmb.jpg","order":3},{"character":"Ezra Fitz","credit_id":"52a65f7c19c2951a7101350f","id":222089,"name":"Ian Harding","profile_path":"/kulyZCPDOQOekH3HMtltkiYo8wk.jpg","order":5},{"character":"Ashley Marin","credit_id":"52a65f8c19c2951a5f017da5","id":78805,"name":"Laura Leighton","profile_path":"/6GdQOIwUbfIlDGExP2VIh6Ur3ba.jpg","order":5},{"character":"Ella Montgomery","credit_id":"52a65fda19c2951a5c012dd8","id":26469,"name":"Holly Marie Combs","profile_path":"/6nBsYLxhHzzf7Q0PQzBjnGjz5kX.jpg","order":39},{"character":"Byron Montgomery","credit_id":"52a6600819c2951a7101531d","id":21549,"name":"Chad Lowe","profile_path":"/pskKim9BpycKRRIhxSEDQuwEwlA.jpg","order":40}],"crew":[{"id":1212583,"credit_id":"5258a124760ee34661653f7b","name":"Chris Grismer","department":"Directing","job":"Director"},{"id":1219562,"credit_id":"5258a124760ee34661653fab","name":"Oliver Goldstick","department":"Writing","job":"Writer"}],"guest_stars":[{"id":991980,"name":"Tyler Blackburn","credit_id":"52a6601c19c2951a6801ce1e","character":"Caleb Rivers","order":4,"profile_path":"/xRJfFKv9QlbN3MUurY9x5T1ryA9.jpg"},{"id":93377,"name":"Janel Parrish","credit_id":"52a6607619c2951a6b01fdce","character":"Mona Vanderwaal","order":6,"profile_path":"/n0a9h319zcUsZdc0Dt77PQpnVzO.jpg"},{"id":62168,"name":"Sasha Pieterse","credit_id":"52a65faa19c2951a650198ef","character":"Alison DiLaurentis","order":7,"profile_path":"/vkuCkYVYopLSMT6ceGKI2UV1kjk.jpg"},{"id":57136,"name":"Ryan Merriman","credit_id":"5258a137760ee34661654ddb","character":"Ian Thomas","order":14,"profile_path":"/sdo2IMtBRjiIJOLpmBrebAJaF89.jpg"},{"id":33296,"name":"Torrey DeVitto","credit_id":"5258a137760ee34661654e03","character":"Melissa Hastings","order":15,"profile_path":"/fXxgnqtygQXE9OQvNvqFCGWYJNI.jpg"},{"id":1251570,"name":"Lesley Fera","credit_id":"5258a13f760ee346616550b8","character":"Veronica Hastings","order":32,"profile_path":"/coA844itjYAVLJzVO0YD9TFc44r.jpg"},{"id":1251573,"name":"Paloma Guzmán","credit_id":"5258a143760ee34661655189","character":"Jackie Molina","order":37,"profile_path":"/nkypPtHS4Jz0Cr130LyYEcC257d.jpg"},{"id":94792,"name":"Tammin Sursok","credit_id":"5662c5cc9251412d7b003574","character":"Jenna Marshall","order":46,"profile_path":"/ghyiaX0upZev0shZcQ0OuE5AZ8y.jpg"},{"id":1225783,"name":"Lindsey Shaw","credit_id":"5664176f9251412acd007b45","character":"Paige McCullers","order":79,"profile_path":"/9qZZ5Vm9T7dXKX6mkXMESl4VaNs.jpg"},{"id":86132,"name":"Claire Holt","credit_id":"56642325c3a3682be90084f3","character":"Samara Cook","order":89,"profile_path":"/kxdk67jh9rNDsgL0kMqEyyukwS3.jpg"},{"id":130936,"name":"Yani Gellman","credit_id":"5664233bc3a3682bcd007c4e","character":"Garrett Reynolds","order":90,"profile_path":"/cOygPwAcFlPjrYti9bp4IU8zDbF.jpg"},{"id":1193605,"name":"Keegan Allen","credit_id":"556f6f379251413c01000625","character":"Toby Cavanaugh","order":500,"profile_path":"/osTSMTonidy8vxn3oNs8rSOu3Ir.jpg"}]},"videos":{"results":[]}} Edited August 29, 2016 by Angelblue05 Link to comment Share on other sites More sharing options...
Recommended Posts
Create an account or sign in to comment
You need to be a member in order to leave a comment
Create an account
Sign up for a new account in our community. It's easy!
Register a new accountSign in
Already have an account? Sign in here.
Sign In Now