Jump to content

Show Intro Skip Option


Liquidfire88

Recommended Posts

1 hour ago, Micael456 said:

Looks like I can't edit my previous post. Crashed again, lost the emby server process. When I restart it, which logs (if any) would be useful?

1983234720_2021-09-07(1).png.e239bcdcab303ddd44c837bee3bd6818.png

144215282_2021-09-07(2).png.2e0b688b29436c81f12ac057767a3ca9.png

image.png.4b81b4d23578d47a9af8be6e9735ba6e.png

The main server log would be very useful! Thank you.

Link to comment
Share on other sites

Micael456
5 minutes ago, chef said:

The main server log would be very useful! Thank you.

I've attached it. Doesn't actually seem as useful as I'd have hoped though, I'll be honest. Just stopped.

5 minutes ago, chef said:

Should we consider a standalone app which handles the calculations for emby?

I don't know to be honest - I imagine that would add additional overhead. It just depends on if the process will succesfully work within the embyserver process or not.

 

I didn't have these issues when running on my test windows instance, though I don't know if that's to do with the CPU/RAM (i5 8600k / 16GB RAM vs odroid specs) or the size of the library.

embyserver-63766611431.txt

Link to comment
Share on other sites

rbjtech
5 minutes ago, chef said:

Should we consider a standalone app which handles the calculations for emby?

Why do you think this - it works perfectly well inside emby as a Plugin ?

The issue is understanding how it's hitting systems and throttle it - As Yoda said to Luke  - 'Control, Control - you must learn Control..'  🤪

 

Link to comment
Share on other sites

6 minutes ago, rbjtech said:

 

The issue is understanding how it's hitting systems and throttle it 

 

We could try changing the run time to every ten to fifteen  minutes. Only take four series at a time. Process the four series, then wait. 

 

 

Link to comment
Share on other sites

rbjtech

There may be some issues on the latest Beta - it seems to not complete / resume properly.  I'm just going to load the previous version and start again to confirm.

Link to comment
Share on other sites

1 minute ago, rbjtech said:

There may be some issues on the latest Beta - it seems to not complete / resume properly.  I'm just going to load the previous version and start again to confirm.

Interesting. Anything in the logs?

Link to comment
Share on other sites

rbjtech
5 minutes ago, chef said:

Interesting. Anything in the logs?

Nothing in the logs - it just seems to 'stop' - still taking CPU but not producing anything.   Just reverting and then I'll see if I can re-create.  brb

ok - so found the issue - the titlesequence.db is empty - let me try on .7 and then try to re-create on .8

Edited by rbjtech
Link to comment
Share on other sites

25 minutes ago, rbjtech said:

Nothing in the logs - it just seems to 'stop' - still taking CPU but not producing anything.   Just reverting and then I'll see if I can re-create.  brb

ok - so found the issue - the titlesequence.db is empty - let me try on .7 and then try to re-create on .8

That is strange. .8 wouldn't have touched the db, it had some UI changes and logging.

 

Link to comment
Share on other sites

rbjtech

ok - so retried with both - now both have identical results - very odd.

I may have had a corrupt dB from some of the previous testing - I'm going to continue to add shows as this was just with one...

Would it be possible to enable the code for the chapters and send me a private version ?  I'm keen to try this as well 👍

SkipIntro Version 2.0.2.7 embyserver-63766619848.txt SkipIntro Version 2.0.2.8 embyserver-63766620910.txt

Link to comment
Share on other sites

54 minutes ago, rbjtech said:

ok - so retried with both - now both have identical results - very odd.

I may have had a corrupt dB from some of the previous testing - I'm going to continue to add shows as this was just with one...

Would it be possible to enable the code for the chapters and send me a private version ?  I'm keen to try this as well 👍

SkipIntro Version 2.0.2.7 embyserver-63766619848.txt 7.78 kB · 0 downloads SkipIntro Version 2.0.2.8 embyserver-63766620910.txt 8.09 kB · 2 downloads

I just retried .8 with a new DB, and I can't reproduce any issues.

The logs seem to be scanning okay. 

Do you mean, the DB is empty after the second task completes?

 

I'll try and finish up the chapter code. It's being tricky while I try and learn it :)

Link to comment
Share on other sites

rbjtech
3 minutes ago, chef said:

Do you mean, the DB is empty after the second task completes?

Yes, but the task had not completed - thus it 'stopped' as presumably it was looking for FP that wasn't there.

I should have deleted the dB before trying .7 but didn't - so I'm going to put it down to that. ;)

I'm also going to try a couple of manual 'stops' on both the FP and Detect tasks and check the recovery. (using .8) 

  • Like 1
Link to comment
Share on other sites

54 minutes ago, rbjtech said:

Yes, but the task had not completed - thus it 'stopped' as presumably it was looking for FP that wasn't there.

I should have deleted the dB before trying .7 but didn't - so I'm going to put it down to that. ;)

I'm also going to try a couple of manual 'stops' on both the FP and Detect tasks and check the recovery. (using .8) 

We'll take note.

I think we handled most areas of the code where the removed fingerprint will cause issues. We'll find out  while using the plugin if there are still areas that need to handle the removed fingerprints. :)

  • Like 1
Link to comment
Share on other sites

Micael456

I think there's something hinky going on with either the DB or the UI to be honest... might be specifically due to it crashing, or perhaps not.

As per my emby server logs, it was working on Covert Affairs season two when crashing. When I try to load that season up on the plugins GUI...


1505364484_2021-09-07(3).thumb.png.2a1292e6d678a177a64792cc4e017994.png

Link to comment
Share on other sites

1 hour ago, Micael456 said:

I think there's something hinky going on with either the DB or the UI to be honest... might be specifically due to it crashing, or perhaps not.

As per my emby server logs, it was working on Covert Affairs season two when crashing. When I try to load that season up on the plugins GUI...


1505364484_2021-09-07(3).thumb.png.2a1292e6d678a177a64792cc4e017994.png

okay, are these the issues:

  • it looks like you are missing data for episode 1 & 2
  • episodes 3, 4 & 5 don't have sequence data
  • episode 6 is repeated

is this the only series that has odd entries in the data table? the rest are okay?

Edited by chef
Link to comment
Share on other sites

Micael456
Just now, chef said:

okay, are these the issues:

  • it looks like you are missing data for episode 1 & 2
  • episodes 3, 4 & 5 don't have sequence data
  • episode 6 is repeated

@chef, sorry- I wasn't clear enough. They're displaying as different shows. This is meant to be Covert Affairs season 2, but it's also randomly pulled in Charmed Season One.

Link to comment
Share on other sites

10 minutes ago, Micael456 said:

@chef, sorry- I wasn't clear enough. They're displaying as different shows. This is meant to be Covert Affairs season 2, but it's also randomly pulled in Charmed Season One.

That is strange. The series IDs should not have let that happen.

If you clear browser data, and then refresh the page. Pull down that data again, is it still the same?

 

Does it happen with any other series?

Edited by chef
Link to comment
Share on other sites

rbjtech

Not a big issue - but any reason why you are logging 'no title sequence' as a 'Warn' ?  I would have though this was an 'Info' as there is nothing you can do about it ?

alv.PNG.2309ad614d35496b05b567f6a810fe12.PNG

 

 

Link to comment
Share on other sites

Micael456
12 minutes ago, chef said:

That is strange. The series IDs should not have let that happen.

If you clear browser data, and then refresh the page. Pull down that data again, is it still the same?

 

Does it happen with any other series?

OK, clearing the browser cache did the job.

I guess just need to add

Cache-Control: no-cache

to the html code then for that page?

 

----

It crashed again- I'm lowering the max Title Detection to 2 and will let you know how that goes.

With regards to the UI pages, they (at least on mine) don't load properly at all when the Title Detection sequence is running. Once you stop the schedule it's nice and snappy again.

 

embyserver-63766622438.txt

Link to comment
Share on other sites

11 minutes ago, rbjtech said:

Not a big issue - but any reason why you are logging 'no title sequence' as a 'Warn' ?  I would have though this was an 'Info' as there is nothing you can do about it ?

alv.PNG.2309ad614d35496b05b567f6a810fe12.PNG

 

 

That warn needs a better description, and can be switched to 'debug'.

What has happened there is, all episodes in that season are without title sequences. 

 

Although that could be the case, I ran into an instance where Rick and Morty season 3 should have had title sequence data, but didn't. I figured it could happen where we miss items. But we don't want to reprocess them over and over if the episodes don't actually have sequences worth skipping (Mr robot for example). 

Just warn the log.

  • Agree 1
Link to comment
Share on other sites

1 hour ago, Micael456 said:

OK, clearing the browser cache did the job.

I guess just need to add



Cache-Control: no-cache

to the html code then for that page?

 

----

It crashed again- I'm lowering the max Title Detection to 2 and will let you know how that goes.

With regards to the UI pages, they (at least on mine) don't load properly at all when the Title Detection sequence is running. Once you stop the schedule it's nice and snappy again.

 

embyserver-63766622438.txt 1.34 MB · 1 download

Because we are accessing the database during the task, it is probably interfering with the page load.

We could skip loading the UI table during the task. 

Just to keep things smooth. 

What do you guys think?

 

Edited by chef
Link to comment
Share on other sites

rbjtech
1 minute ago, chef said:

Because we are accessing the database during the task, it is probably interfering with the page load.

We could not load the UI table during the task. 

Just to keep things smooth. 

What do you guys think?

 

Let me test this, but for me this did not cause any issues and it was instant - but I think this largely depends on the size of the dB - for my testing, they are tiny at the moment.

Unless you are watching the log, then the UI is the only feedback you will see - so I don't think you can disable it during the task (that may take days..) ?

 

Link to comment
Share on other sites

Micael456
4 minutes ago, chef said:

We could not load the UI table during the task. 

Just to keep things smooth. 

What do you guys think?

I agree. 

Or if you wanted to be really fancy, give them a popup warning that the task will be paused if they continue, and present the option to the end user.

 

For now though I'd say a splash page informing the user that it can't be viewed during processing is probably easiest.

  • Like 1
Link to comment
Share on other sites

rbjtech
9 minutes ago, Micael456 said:

I agree. 

Or if you wanted to be really fancy, give them a popup warning that the task will be paused if they continue, and present the option to the end user.

 

For now though I'd say a splash page informing the user that it can't be viewed during processing is probably easiest.

Emby is just doing a SQL query - if it doesn't have the capacity to do this, how is emby going to do it's own core playback queries ?  

If your cpu/disk is that busy, then you need to reduce the workload a little !

Link to comment
Share on other sites

Here is how we can manage chapters... so far.

 

  1. If the Intro starts at the beginning of the first chapter 
  • move to chapter 2 and  change StartpositionTicks to TitleSequenceEnd.
  • push all subsequent Chapters 'StartPositionTicks' ahead the duration of the intro  (or else we run the risk of screwing up the timestamps, or oddly short chapters)
  • make sure not to mark the subsequent chapters start positions longer then the runtime of the item. //<--that would be bad.

 

         2. The intro doesn't start at the beginning of the first chapter (There is a recap)

  • move to chapter 2 - change StartPositionTicks to the TitleSequenceStart timestamp
  • move to chapter 3 - change StartPositionTicks to the TitleSequenceEnd timestamp
  • push all subsequent Chapters 'StartPositionTicks' ahead the duration of the intro  
  • make sure not to mark the subsequent chapters start positions longer then the runtime of the item.

There is probably more to it then that. But that is where I am. Do you think they'll take issue with us changing chapter data... if it done correctly, and doesn't cause issues?

 

Link to comment
Share on other sites

Guest
This topic is now closed to further replies.
×
×
  • Create New...