Jump to content

New Plugin: Discord Notifications

rechigo

By rechigo,
in Plugins

 Share

Recommended Posts

grafxxx

grafxxx

Posted
Posted

Yes config is the same as he posted his xml earlier. We'll wait for his answer.

Thank you. Can I downgrade to stable without a problem or is that tricky?

Link to comment
Share on other sites
BillOatman

BillOatman

Posted
Posted
Just now, grafxxx said:

Yes config is the same as he posted his xml earlier. We'll wait for his answer.

Thank you. Can I downgrade to stable without a problem or is that tricky?

No issues at all, but I don't think that stable version works which is why I stepped in. I don't use this plugin.

Link to comment
Share on other sites
grafxxx

grafxxx

Posted
Posted

Ok but if i'm on emby beta 4.6.0.48 and he is not that means that my emby beta is the problem. that is why i asked about the downgrade

Link to comment
Share on other sites
BillOatman

BillOatman

Posted
Posted
6 minutes ago, grafxxx said:

Ok but if i'm on emby beta 4.6.0.48 and he is not that means that my emby beta is the problem. that is why i asked about the downgrade

Ohhhhhhhhhhh that downgrade.  I'm not sure about that, I don't use the betas.

Link to comment
Share on other sites
GrimReaper

GrimReaper

Posted
Posted
28 minutes ago, BillOatman said:

@grafxxxYou are running the beta and not getting enriched information and

@GrimReaper76  You are not running the beta are are getting the enriched data

Is that correct?

If so, can you guys compare notes and make sure your configurations are the same? If it ends up being a beta issue I'll likely wait until its released then take a look at it.

Running latest stable 4.5.4.0 here.

Link to comment
Share on other sites
BillOatman

BillOatman

Posted
Posted
3 minutes ago, grafxxx said:

so the issue is my emby beta version then. @GrimReaper76do you know if a downgrade is possible without issues?

Or just wait for the beta to be released which should be "soon". Once that happens we can investigate what is different.

Link to comment
Share on other sites
GrimReaper

GrimReaper

Posted
Posted
Just now, grafxxx said:

so the issue is my emby beta version then. @GrimReaper76do you know if a downgrade is possible without issues?

AFAIK it ain't recommendable, although I've seen posts where few lucky users did downgrade with no issues, albeit in minority. @Luke

Link to comment
Share on other sites
Luke Emby Team

Luke

Posted
Posted
5 minutes ago, BillOatman said:

Or just wait for the beta to be released which should be "soon". Once that happens we can investigate what is different.

Today.

  • Thanks 1
Link to comment
Share on other sites
GrimReaper

GrimReaper

Posted
Posted
4 minutes ago, grafxxx said:

Ok. So I stay on my beta for now and we'll see if it stops working with @GrimReaper76 as he updates ;)

You mean IF/WHEN he updates. ;) I'll test with portable 4.6 stable, but main server is staying 4.5.4.0 for some time as 4.6 might potentially break some plugins, will give it time to propagate. 

Link to comment
Share on other sites
BillOatman

BillOatman

Posted
Posted
12 minutes ago, grafxxx said:

Ok. So I stay on my beta for now and we'll see if it stops working with @GrimReaper76 as he updates ;)

Once its released and you update we can work together to get it resolved.

  • Like 1
Link to comment
Share on other sites
grafxxx

grafxxx

Posted
Posted

@Luke with the upcoming release of 4.6 should I switch to that version or is it systematically the same as my beta 4.6.0.48?

Link to comment
Share on other sites
BillOatman

BillOatman

Posted
Posted
3 hours ago, GrimReaper76 said:

Running latest stable 4.5.4.0 here.

Did you try a TV episode to see if it got that enriched data?  

Link to comment
Share on other sites
GrimReaper

GrimReaper

Posted
Posted
40 minutes ago, BillOatman said:

Did you try a TV episode to see if it got that enriched data?  

Yup, getting both Episodes and Movies notifications enriched.

478641452_Screenshot2021-05-19195806.png.299b6874b8793a669bd869873f9913e9.png

 

  • Thanks 1
Link to comment
Share on other sites
BillOatman

BillOatman

Posted
Posted

So it is pretty clearly something different in the beta server.  Once it's released we'll see if there is a new library to link to.

  • Like 1
Link to comment
Share on other sites
GrimReaper

GrimReaper

Posted
Posted (edited)
34 minutes ago, BillOatman said:

So it is pretty clearly something different in the beta server.  Once it's released we'll see if there is a new library to link to.

Latest 4.6.0.50 with 111.dll, no joy, debug log attached.

embyserver.txt

Edit: Also with current 107.dll I've got running on 4.5.4.0.

Edited by GrimReaper76
Link to comment
Share on other sites
BillOatman

BillOatman

Posted
Posted
5 minutes ago, Luke said:

That's just the plugin needing an update so should be easy enough.

Thanks, I was figuring that was likely the case.  Will there be a updated nuget for that when the server is released?

Link to comment
Share on other sites
Luke Emby Team

Luke

Posted
Posted
Just now, BillOatman said:

Thanks, I was figuring that was likely the case.  Will there be a updated nuget for that when the server is released?

There already is.

  • Haha 1
Link to comment
Share on other sites
GrimReaper

GrimReaper

Posted
Posted (edited)
1 hour ago, BillOatman said:

This was built with the new Emby library for the new server.

@GrimReaper76   @grafxxx

  Emby.Notifications.Discord1112.dll.zip 55.31 kB · 3 downloads

Getting there, testing TV shows, partially enriched notifications received (no Poster nor Thumb).

2059293902_Screenshot2021-05-19214901.png.72c6934359431d7a113e4b1728d1d19a.png

 

embyserver (1).txt

 

Edit: Same for Movies, no artwork.

1444083143_Screenshot2021-05-19215600.png.c6db3e478c3c6d45e87a7ae0ea443318.png

 

embyserver (2).txt

 

Edit2: All hyperlinks parsed properly, both towards item on Emby server and external links.

Edited by GrimReaper76
Link to comment
Share on other sites
BillOatman

BillOatman

Posted
Posted (edited)

@Luke This is how it is populating images ... should anything have changed in this server/library release for this (the exception message is not in the log)? 

                           // populate images
                            if (item.HasImage(ImageType.Primary))
                            {
                                string imageUrl = "";

                                if (!item.GetImageInfo(ImageType.Primary, 0).IsLocalFile)
                                {
                                    imageUrl = item.GetImagePath(ImageType.Primary);
                                }
                                else if (serverConfig.EnableRemoteAccess == true && !options.ExcludeExternalServerLinks) // in the future we can proxy images through memester server if people want to hide their server address
                                {
                                    imageUrl = $"{sysInfo.WanAddress}/emby/Items/{itemId}/Images/Primary";
                                }
                                else
                                {
                                    string localPath = item.GetImagePath(ImageType.Primary);

                                    try
                                    {
                                        ImageServiceResponse response = MemesterServiceHelper.UploadImage(localPath, _jsonSerializer);
                                        imageUrl = response.filePath;
                                    }
                                    catch (Exception e)
                                    {
                                        _logger.ErrorException("Failed to proxy image", e);
                                    }
                                }

                                mediaAddedEmbed.embeds.First().thumbnail = new Thumbnail
                                {
                                    url = imageUrl
                                };
                            }

 

Edited by BillOatman
Link to comment
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now
 Share
Go to topic listing
×
×
  • Create New...