New Plugin: Discord Notifications

[grafxxx 4]

Yes config is the same as he posted his xml earlier. We'll wait for his answer.

Thank you. Can I downgrade to stable without a problem or is that tricky?

[BillOatman 575]

Just now, grafxxx said:

Yes config is the same as he posted his xml earlier. We'll wait for his answer.

Thank you. Can I downgrade to stable without a problem or is that tricky?

No issues at all, but I don't think that stable version works which is why I stepped in. I don't use this plugin.

[grafxxx 4]

Ok but if i'm on emby beta 4.6.0.48 and he is not that means that my emby beta is the problem. that is why i asked about the downgrade

[BillOatman 575]

6 minutes ago, grafxxx said:

Ok but if i'm on emby beta 4.6.0.48 and he is not that means that my emby beta is the problem. that is why i asked about the downgrade

Ohhhhhhhhhhh that downgrade.  I'm not sure about that, I don't use the betas.

[GrimReaper 4140]

28 minutes ago, BillOatman said:

@grafxxxYou are running the beta and not getting enriched information and

@GrimReaper76  You are not running the beta are are getting the enriched data

Is that correct?

If so, can you guys compare notes and make sure your configurations are the same? If it ends up being a beta issue I'll likely wait until its released then take a look at it.

Running latest stable 4.5.4.0 here.

[grafxxx 4]

so the issue is my emby beta version then. @GrimReaper76do you know if a downgrade is possible without issues?

I'll try to downgrade and test again. Thank you for your support @GrimReaper76 & @BillOatman

Edited May 19, 2021 by grafxxx

[BillOatman 575]

3 minutes ago, grafxxx said:

so the issue is my emby beta version then. @GrimReaper76do you know if a downgrade is possible without issues?

Or just wait for the beta to be released which should be "soon". Once that happens we can investigate what is different.

[GrimReaper 4140]

Just now, grafxxx said:

so the issue is my emby beta version then. @GrimReaper76do you know if a downgrade is possible without issues?

AFAIK it ain't recommendable, although I've seen posts where few lucky users did downgrade with no issues, albeit in minority. @Luke

[Luke 40072]

5 minutes ago, BillOatman said:

Or just wait for the beta to be released which should be "soon". Once that happens we can investigate what is different.

Today.

[grafxxx 4]

Ok. So I stay on my beta for now and we'll see if it stops working with @GrimReaper76 as he updates

[GrimReaper 4140]

4 minutes ago, grafxxx said:

Ok. So I stay on my beta for now and we'll see if it stops working with @GrimReaper76 as he updates

You mean IF/WHEN he updates.  I'll test with portable 4.6 stable, but main server is staying 4.5.4.0 for some time as 4.6 might potentially break some plugins, will give it time to propagate. 

[BillOatman 575]

12 minutes ago, grafxxx said:

Ok. So I stay on my beta for now and we'll see if it stops working with @GrimReaper76 as he updates

Once its released and you update we can work together to get it resolved.

[grafxxx 4]

@Luke with the upcoming release of 4.6 should I switch to that version or is it systematically the same as my beta 4.6.0.48?

[BillOatman 575]

3 hours ago, GrimReaper76 said:

Running latest stable 4.5.4.0 here.

Did you try a TV episode to see if it got that enriched data?  

[GrimReaper 4140]

40 minutes ago, BillOatman said:

Did you try a TV episode to see if it got that enriched data?  

Yup, getting both Episodes and Movies notifications enriched.

 

[BillOatman 575]

So it is pretty clearly something different in the beta server.  Once it's released we'll see if there is a new library to link to.

[GrimReaper 4140]

34 minutes ago, BillOatman said:

So it is pretty clearly something different in the beta server.  Once it's released we'll see if there is a new library to link to.

Latest 4.6.0.50 with 111.dll, no joy, debug log attached.

embyserver.txt

Edit: Also with current 107.dll I've got running on 4.5.4.0.

Edited May 19, 2021 by GrimReaper76

[Luke 40072]

11 minutes ago, GrimReaper76 said:

Latest 4.6.0.50 with 111.dll, no joy, debug log attached.

embyserver.txt 51.21 kB · 0 downloads

Edit: Also with current 107.dll I've got running on 4.5.4.0.

That's just the plugin needing an update so should be easy enough.

[BillOatman 575]

5 minutes ago, Luke said:

That's just the plugin needing an update so should be easy enough.

Thanks, I was figuring that was likely the case.  Will there be a updated nuget for that when the server is released?

[Luke 40072]

Just now, BillOatman said:

Thanks, I was figuring that was likely the case.  Will there be a updated nuget for that when the server is released?

There already is.

[BillOatman 575]

This was built with the new Emby library for the new server.

@GrimReaper76   @grafxxx

 Emby.Notifications.Discord1112.dll.zip

Edited May 19, 2021 by BillOatman

[GrimReaper 4140]

1 hour ago, BillOatman said:

This was built with the new Emby library for the new server.

@GrimReaper76   @grafxxx

  Emby.Notifications.Discord1112.dll.zip 55.31 kB · 3 downloads

Getting there, testing TV shows, partially enriched notifications received (no Poster nor Thumb).

 

embyserver (1).txt

 

Edit: Same for Movies, no artwork.

 

embyserver (2).txt

 

Edit2: All hyperlinks parsed properly, both towards item on Emby server and external links.

Edited May 19, 2021 by GrimReaper76

[BillOatman 575]

@Luke This is how it is populating images ... should anything have changed in this server/library release for this (the exception message is not in the log)?

                           // populate images
                            if (item.HasImage(ImageType.Primary))
                            {
                                string imageUrl = "";

                                if (!item.GetImageInfo(ImageType.Primary, 0).IsLocalFile)
                                {
                                    imageUrl = item.GetImagePath(ImageType.Primary);
                                }
                                else if (serverConfig.EnableRemoteAccess == true && !options.ExcludeExternalServerLinks) // in the future we can proxy images through memester server if people want to hide their server address
                                {
                                    imageUrl = $"{sysInfo.WanAddress}/emby/Items/{itemId}/Images/Primary";
                                }
                                else
                                {
                                    string localPath = item.GetImagePath(ImageType.Primary);

                                    try
                                    {
                                        ImageServiceResponse response = MemesterServiceHelper.UploadImage(localPath, _jsonSerializer);
                                        imageUrl = response.filePath;
                                    }
                                    catch (Exception e)
                                    {
                                        _logger.ErrorException("Failed to proxy image", e);
                                    }
                                }

                                mediaAddedEmbed.embeds.First().thumbnail = new Thumbnail
                                {
                                    url = imageUrl
                                };
                            }

 

Edited May 19, 2021 by BillOatman

[grafxxx 4]

so with the new version of the plugin it doesn't work at all. It crashes and is not visible anymore in emby.

embyserver.txt

[BillOatman 575]

3 minutes ago, grafxxx said:

so with the new version of the plugin it doesn't work at all. It crashes and is not visible anymore in emby.

embyserver.txt 54.23 kB · 0 downloads

You are still running the beta server.