Jump to content

Make ChannelFolderType Work correctly


gallileo
 Share

Recommended Posts

gallileo

Hi there,

 

I have started looking at Emby's plugin API. I have two Plex Plugins I would like to convert for Emby. They are both channel plugins.

 

I was trying out the Channel plugin API and saw the ChannelFolderType option. However, as I found out it does not have an effect. After searching through the source code and running it under a debugger, I found the following line, that prevents this from working: https://github.com/MediaBrowser/Emby.Common/blob/6ef8705ed609666555894c698dfc140fd8314831/MediaBrowser.Controller/Entities/BaseItem.cs#L2047-L2055

 

Is there a reason, the line about ChannelFolderItem couldn't be removed? Or return the normal type, when e.g. another option on the ChannelItemInfo is set?

 

I have tried removing the check for the channel, and it seems to work fine and display the series as it normally would with a real series.

 

I think allowing ChannelFolderType to work correctly, would greatly improve the channel plugins.

 

Kind regards,

 

Leo

Link to comment
Share on other sites

Hmm, yea we should probably get that removed. Only question is what other work will that end up requiring for us. What are the plugins, anything popular?

Link to comment
Share on other sites

gallileo

@@Luke Well from scanning through the code, it seems like it shouldn't impact that much. Especially, if that line was only disabled with another flag (so that old plugins don't suddenly have a different layout). But then again, the code is kinda confusing for that part :P.

 

The plugins are actually still in development :), but I can see them being popular. One is for Floatplane (https://floatplane.com) and the other is for Dropout (https://www.dropout.tv)

Edited by gallileo
Link to comment
Share on other sites

Right well there won't be any server side impact. The impact will be with how apps see and treat them. I guess we can try it.

Link to comment
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now
 Share

×
×
  • Create New...