Jump to content


Photo

Make ChannelFolderType Work correctly

plugin channel

  • Please log in to reply
3 replies to this topic

#1 gallileo OFFLINE  

gallileo

    Newbie

  • Members
  • 6 posts
  • Local time: 01:01 PM

Posted 02 November 2018 - 06:48 PM

Hi there,

 

I have started looking at Emby's plugin API. I have two Plex Plugins I would like to convert for Emby. They are both channel plugins.

 

I was trying out the Channel plugin API and saw the ChannelFolderType option. However, as I found out it does not have an effect. After searching through the source code and running it under a debugger, I found the following line, that prevents this from working: https://github.com/M....cs#L2047-L2055

 

Is there a reason, the line about ChannelFolderItem couldn't be removed? Or return the normal type, when e.g. another option on the ChannelItemInfo is set?

 

I have tried removing the check for the channel, and it seems to work fine and display the series as it normally would with a real series.

 

I think allowing ChannelFolderType to work correctly, would greatly improve the channel plugins.

 

Kind regards,

 

Leo



#2 Luke OFFLINE  

Luke

    System Architect

  • Administrators
  • 136081 posts
  • Local time: 08:01 AM

Posted 02 November 2018 - 08:22 PM

Hmm, yea we should probably get that removed. Only question is what other work will that end up requiring for us. What are the plugins, anything popular?

#3 gallileo OFFLINE  

gallileo

    Newbie

  • Members
  • 6 posts
  • Local time: 01:01 PM

Posted 03 November 2018 - 07:54 AM

@Luke Well from scanning through the code, it seems like it shouldn't impact that much. Especially, if that line was only disabled with another flag (so that old plugins don't suddenly have a different layout). But then again, the code is kinda confusing for that part :P.

 

The plugins are actually still in development :), but I can see them being popular. One is for Floatplane (https://floatplane.com) and the other is for Dropout (https://www.dropout.tv)


Edited by gallileo, 03 November 2018 - 07:55 AM.


#4 Luke OFFLINE  

Luke

    System Architect

  • Administrators
  • 136081 posts
  • Local time: 08:01 AM

Posted 03 November 2018 - 01:12 PM

Right well there won't be any server side impact. The impact will be with how apps see and treat them. I guess we can try it.







Also tagged with one or more of these keywords: plugin, channel

0 user(s) are reading this topic

0 members, 0 guests, 0 anonymous users