bluemonkey07 590 Posted September 13, 2014 Posted September 13, 2014 Hi I just noticed that tv theme music only plays on the series list. . And it stops when entering the seasons and episodes lists. .. I'm sure this was not always the case but I'm not sure when it changed... or if it is by design or a bug ?
Luke 40115 Posted September 14, 2014 Posted September 14, 2014 not sure. xnappo - there's an inherit param you can use with the theme song api
im85288 1493 Posted September 14, 2014 Posted September 14, 2014 Must be a bug, I'll take a look to see what's up.
im85288 1493 Posted September 14, 2014 Posted September 14, 2014 @@xnappo - I fixed this (and at the same time brought back the rotating backgrounds at episode and season level) by re-adding the use of the seriesId as the guiid. I noticed you removed it for something to do with the dynamic plot...can you take a look at that as it's not something I use due to the problems with not having it available in all view types.
xnappo 1608 Posted September 14, 2014 Posted September 14, 2014 Sure - I will check it. The dynamic plot can be available in all view types, you just have to change the skin
xnappo 1608 Posted September 14, 2014 Posted September 14, 2014 Yep - now dynamic plot is broken - it show the series plot in TV.... I suggest we pass in SeriesID and if it is not "" use it instead for music/art. We could do it the other way around, but I think this makes the most sense. xnappo
Luke 40115 Posted September 14, 2014 Posted September 14, 2014 i don't know if this is what you're talking about, but you can pass the episode id into the endpoint to get the theme songs, along with an inheritance param, and it will handle that for you, just in terms of making sure you are getting the right theme songs.
xnappo 1608 Posted September 14, 2014 Posted September 14, 2014 Is that a new feature? It would be great if we could inherit from the series level if something is not defined at the episode/season level.
im85288 1493 Posted September 14, 2014 Posted September 14, 2014 Well we are also using the seriesid to get the backgrounds for seasons and episodes. I'm happy with any solution you want to go for as long as your aware of the two areas that were effected by the change. Another way would be to add another parameter..like realid that could be used for the plot info. Many ways really
Luke 40115 Posted September 14, 2014 Posted September 14, 2014 no, it's nothing new. Items/{Id}/ThemeSongs?InheritFromParent=true I think my mistake was not to enable this by default. Also, you should not think of this in terms of episode/season/series. just think of it as theme songs for item X. The result object contains an OwnerId property that you can use to compare with currently playing theme songs. Example: Enter series -> play theme songs, keep track of OwnerId -> Enter season, get theme songs -> Is owner Id the same? Then keep playing the current ones. Is it different? then stop and play the new ones.
Luke 40115 Posted September 14, 2014 Posted September 14, 2014 The theme videos endpoint works the same way.
im85288 1493 Posted September 14, 2014 Posted September 14, 2014 no, it's nothing new. Items/{Id}/ThemeSongs?InheritFromParent=true I think my mistake was not to enable this by default. Also, you should not think of this in terms of episode/season/series. just think of it as theme songs for item X. The result object contains an OwnerId property that you can use to compare with currently playing theme songs. Example: Enter series -> play theme songs, keep track of OwnerId -> Enter season, get theme songs -> Is owner Id the same? Then keep playing the current ones. Is it different? then stop and play the new ones. I don't think we need this for xbmc, you can only really navigate from series->season->episode plus we cache the theme song info at series level for better performance. But nice to know if things change
Luke 40115 Posted September 14, 2014 Posted September 14, 2014 yea but it's designed to be an abstraction. if you circumvent server-side features it's only going to lead to issues getting reported about inconsistency from other clients. you should do this for all types because the rules apply to everything.
im85288 1493 Posted September 14, 2014 Posted September 14, 2014 So am I right in thinking that a call is made to retrieve the theme songs on each navigation through series to season(s) to each episode? That sounds like a lot of traffic when it's pretty obvious a series should share theme music.
Luke 40115 Posted September 14, 2014 Posted September 14, 2014 correct, although the web client does it, and the web browser is at the bottom of the performance totem pole compared to all of our other apps. so if it can handle it, you should be able to as well (with Pi being the exception).
xnappo 1608 Posted September 14, 2014 Posted September 14, 2014 That only solves half the problem though - the second issue is the backdrops... xnappo
im85288 1493 Posted September 14, 2014 Posted September 14, 2014 Exactly...why not just add a new one for the dynamic plot. Keep guiid for theme music and backgrounds and use realid for the plot stuff. I'm not looking at the code whilst saying this though so maybe not so practical?
xnappo 1608 Posted September 14, 2014 Posted September 14, 2014 Yep - that is the what would need to happen. It is quite a bit of work unfortunately. Almost think it would be easiest to make a whole new thread. I actually am not all that familiar with this code - can you take a look and see if you agree it would be too nasty to deal with in the existing BackgroundLoader? xnappo
im85288 1493 Posted September 14, 2014 Posted September 14, 2014 Yeah sure, I'll be able to have a look in about half an hour..
im85288 1493 Posted September 14, 2014 Posted September 14, 2014 Well I had a look and yep it does seem a bit like the chicken and the egg problem...fix one and it breaks the other... maybe the safest way is to define a different method for the plot stuff in BackgroundLoader - so not setItemBackgroundLink but maybe setItemPlotLink which uses the realId rather than the guiId.
xnappo 1608 Posted September 14, 2014 Posted September 14, 2014 Okay, that sounds like a good plan. I will see if I can get to it today. Glad this was caught before pushing to the XBMC repo. xnappo
xnappo 1608 Posted September 14, 2014 Posted September 14, 2014 Okay, I agree. Set up the structure and we will work with it. xnappo
xnappo 1608 Posted September 14, 2014 Posted September 14, 2014 On second thought, if you are suggesting duplicating a large amount of code out of the name of a file.. Not sure I agree.
Recommended Posts