yocker 1630 Posted yesterday at 01:01 AM Author Posted yesterday at 01:01 AM 1 hour ago, AngelSing said: @yocker Hi, I have a question about the built-in/default icons. I installed EmbyIcons on my NAS and some built-in icons are working correctly, for example resolution and codec icons like 1080p, H264, AC3, etc. However, when I scan the library in Icon Manager, some language icons are reported as missing, for example lang.french.png. I checked the GitHub repository and I can see language icons there, but they seem to use an underscore format, for example lang_french.png, while the plugin/Icon Manager is asking for lang.french.png. Is this expected? Are the embedded/default language icons inside the DLL using underscore names, while the Icon Manager expects dot-based names? Or should the built-in fallback icons be detected automatically for these language icons too? I just want to confirm if this is a naming issue in the embedded icons, a limitation of the built-in fallback icons, or if I’m misunderstanding how the default icons are loaded. The icons built into the plugin are using "_" (for example lang_english.png) and the user custom icons are using "." (lang.english.png) This was done to make it easier for me when making the plugin and separating the icons to make having both embedded and user icons possible. The troubleshooter only checks for the user icons and not the icons built into the plugin. 1
AngelSing 58 Posted yesterday at 01:11 AM Posted yesterday at 01:11 AM (edited) @Yocker Hi again, sorry for bothering you so much. I have been testing the plugin all day and I have a question about regional language detection. I am testing EmbyIcons with internal MKV audio and subtitle tracks tagged as es-419 in MKVToolNix. MKVToolNix shows the tracks as es-419, but EmbyIcons still displays the standard lang.spanish.png / sub.spanish.png icons instead of using something like lang.spanish (latin america).png or sub.spanish (latin america).png. In Emby’s media information, the language still appears as “Spanish”, even though the MKV track language is set to es-419 and the track title says “Español (Latinoamérica)”. Does EmbyIcons currently read only Emby’s displayed language name, or can it read the IETF/BCP47 language tag from the MKV track? Would it be possible to support regional language variants such as es-419 for internal MKV audio and subtitle tracks? Thanks again for your work on the plugin. Edited yesterday at 01:12 AM by AngelSing delete img
yocker 1630 Posted yesterday at 01:19 AM Author Posted yesterday at 01:19 AM 2 minutes ago, AngelSing said: @Yocker Hi again, sorry for bothering you so much. I have been testing the plugin all day and I have a question about regional language detection. I am testing EmbyIcons with internal MKV audio and subtitle tracks tagged as es-419 in MKVToolNix. MKVToolNix shows the tracks as es-419, but EmbyIcons still displays the standard lang.spanish.png / sub.spanish.png icons instead of using something like lang.spanish (latin america).png or sub.spanish (latin america).png. In Emby’s media information, the language still appears as “Spanish”, even though the MKV track language is set to es-419 and the track title says “Español (Latinoamérica)”. Does EmbyIcons currently read only Emby’s displayed language name, or can it read the IETF/BCP47 language tag from the MKV track? Would it be possible to support regional language variants such as es-419 for internal MKV audio and subtitle tracks? Thanks again for your work on the plugin. No bother at all. It uses the information that Emby gives it, so unless Emby serves the regional name the plugin won't use it. The series aggregation is already a semi heavy task and adding MKV reading to that would just make it worse. That's not to say that it's not possible, just that it might not be a good idea. I will look into what i can do, no promises! 1
AngelSing 58 Posted yesterday at 01:30 AM Posted yesterday at 01:30 AM 10 minutes ago, yocker said: No bother at all. It uses the information that Emby gives it, so unless Emby serves the regional name the plugin won't use it. The series aggregation is already a semi heavy task and adding MKV reading to that would just make it worse. That's not to say that it's not possible, just that it might not be a good idea. I will look into what i can do, no promises! Thanks for the explanation. So, just to make sure I understand correctly: the issue is not really in EmbyIcons, but in the information that Emby provides to the plugin, right? In my MKV file, the internal audio and subtitle tracks are tagged as es-419 in MKVToolNix, and the track title says “Español (Latinoamérica)”. However, Emby’s media information only shows the language as “Spanish”. Does this mean that Emby is reading the MKV language as Spanish but not exposing the regional IETF/BCP47 tag, such as es-419, to plugins? If that is the case, would this need to be improved in Emby itself so that plugins like EmbyIcons can receive the full regional language value instead of only the base language name? I’m just trying to understand where the limitation is: EmbyIcons, Emby’s media info, or the way Emby exposes media stream language data to plugins.
yocker 1630 Posted yesterday at 01:40 AM Author Posted yesterday at 01:40 AM 5 minutes ago, AngelSing said: Thanks for the explanation. So, just to make sure I understand correctly: the issue is not really in EmbyIcons, but in the information that Emby provides to the plugin, right? In my MKV file, the internal audio and subtitle tracks are tagged as es-419 in MKVToolNix, and the track title says “Español (Latinoamérica)”. However, Emby’s media information only shows the language as “Spanish”. Does this mean that Emby is reading the MKV language as Spanish but not exposing the regional IETF/BCP47 tag, such as es-419, to plugins? If that is the case, would this need to be improved in Emby itself so that plugins like EmbyIcons can receive the full regional language value instead of only the base language name? I’m just trying to understand where the limitation is: EmbyIcons, Emby’s media info, or the way Emby exposes media stream language data to plugins. Correct, the plugin can only read the information that Emby gives it. This info is pretty much the same info that EmbyIcons gets from Emby. There are a few exceptions to that but that is in general how EmbyIcons work, get info from Emby and then put an icon on the poster according to the info. Not sure how Emby gets it's info, sorry. Most likely through FFMpeg/FFprobe. 1
AngelSing 58 Posted yesterday at 02:36 AM Posted yesterday at 02:36 AM 56 minutes ago, yocker said: Correct, the plugin can only read the information that Emby gives it. This info is pretty much the same info that EmbyIcons gets from Emby. There are a few exceptions to that but that is in general how EmbyIcons work, get info from Emby and then put an icon on the poster according to the info. Not sure how Emby gets it's info, sorry. Most likely through FFMpeg/FFprobe. Thanks, that makes sense. So I’ll ask the Emby support/development team why Emby is only exposing the base language as “Spanish” instead of the full regional language tag, such as es-419. Since EmbyIcons depends on the media stream information provided by Emby, it seems this would need to be handled or exposed correctly by Emby first. Thanks again for clarifying how EmbyIcons gets its data. 1
yocker 1630 Posted 14 hours ago Author Posted 14 hours ago (edited) New version in the catalog (v5.54.5). Moved beta to stable. Changed: 1) Added some language fallbacks. 2) Improved troubleshooter, works with movies and shows icon prefixes (eg. lang. sub. and so on). Edited 14 hours ago by yocker
AngelSing 58 Posted 9 hours ago Posted 9 hours ago Hi @yocker, I have a small feature suggestion regarding the Icon Bar option. Currently, when Icon Bar is enabled, the bar is displayed on every poster in the library, regardless of whether that item actually has any EmbyIcons icons assigned to it. In my case, I mainly use custom tag-based icons, and the Icon Bar does help the icons stand out more. However, the downside is that the bar also appears on posters that have no icons at all, which can make the library look a bit inconsistent. Would it be possible to add an option that only displays the Icon Bar when at least one EmbyIcons icon is present on the poster? For example, if a movie has audio, subtitle, quality, or custom tag icons, the bar would be shown. If the movie has no icons, the poster would remain unchanged and no bar would be displayed. I am not sure what the best implementation would be internally, but perhaps it could be tied to the same detection logic that determines whether icons are rendered on a poster. I think this would help the icons stand out while keeping the library cleaner and avoiding unnecessary overlays on posters that don't use EmbyIcons. Just a suggestion. Thanks for the great plugin!
yocker 1630 Posted 2 hours ago Author Posted 2 hours ago (edited) 6 hours ago, AngelSing said: Hi @yocker, I have a small feature suggestion regarding the Icon Bar option. Currently, when Icon Bar is enabled, the bar is displayed on every poster in the library, regardless of whether that item actually has any EmbyIcons icons assigned to it. In my case, I mainly use custom tag-based icons, and the Icon Bar does help the icons stand out more. However, the downside is that the bar also appears on posters that have no icons at all, which can make the library look a bit inconsistent. Would it be possible to add an option that only displays the Icon Bar when at least one EmbyIcons icon is present on the poster? For example, if a movie has audio, subtitle, quality, or custom tag icons, the bar would be shown. If the movie has no icons, the poster would remain unchanged and no bar would be displayed. I am not sure what the best implementation would be internally, but perhaps it could be tied to the same detection logic that determines whether icons are rendered on a poster. I think this would help the icons stand out while keeping the library cleaner and avoiding unnecessary overlays on posters that don't use EmbyIcons. Just a suggestion. Thanks for the great plugin! I never really thought of that, i will add it to the to do list. Thank you for the suggestion! Edited 2 hours ago by yocker
Recommended Posts
Create an account or sign in to comment
You need to be a member in order to leave a comment
Create an account
Sign up for a new account in our community. It's easy!
Register a new accountSign in
Already have an account? Sign in here.
Sign In Now