ShaneP 246 Posted July 10, 2021 Posted July 10, 2021 (edited) Hey All, Firstly, excellent work! secondly, I noticed that this has stopped working in Emby 4.6.4.0, I have forked the repo and fixed if anyone is interested. (Have PR out for main repo) https://github.com/ShanePe/Emby.SmartPlaylist.Plugin/ Sorry also, I have made an update, if the playlist has NOT yet been generated, it will generate it, regardless of the playlist schedule trigger. So one no longer need to 'manually' run first to initialize the playlist if it falls outside of playlist generation schedule. (Make sense !?!?!?!) Version 2.4.0.3 Feature Create a copy of a playlist. (Duplicate) Decluttered UI by adding a pop up menu to playlists New Criteria: Added Audio Stream Codec Criteria (Stream: Audio Codec) Added Audio Stream Language Criteria (Stream: Audio Language) Added Audio Stream Display title Criteria (Stream: Audio Display Title) Added Subtitle Stream Language Criteria (Stream: Subtitle Language) Added Video Stream Codec Criteria (Stream: Video Codec) Added Video Stream Display title Criteria (Stream: Video Display Title) Updated Criteria: Parental Rating: Now uses official rating under the hood Resolution Height: Now uses video streams to determine the available video heights rather than the metadata. Resolution Width: Now uses video streams to determine the available video widths rather than the metadata. Added Monitor Mode to shuffle playlist type. Meaning that the playlist will be destroyed and recreated on a schedule, but between scheduled executions, media item changes will be batched and monitored for inclusion/exclusion. (So .... combination of live and shuffle modes but could have a perf hit on larger playlists, experimental) Collapsible sections in the playlist editor that keeps state, for more UI real estate. Added the ability to add notes to a playlist (limited to 256 chars). If there are notes assigned a pop up is displayed when hovering over a playlist (2 second delay). Order all selection lists on criteria with dropdowns alphabetically. ------------------------------------------------------- Releases Here -> (See change logs in this thread .... way down) Plugin for Emby Server 4.7: SmartPlaylist-2.4.0.3.zip Edited October 7, 2023 by GrimReaper New Version 2.4.0.3 12 12
koopa8840 24 Posted July 10, 2021 Posted July 10, 2021 Do you have a link for the dll file? I have never dealt with github. Thanks for updating this.
ShaneP 246 Posted July 10, 2021 Author Posted July 10, 2021 Sure, here it is, just make sure to back up your old one first, just in case SmartPlaylist.dll.zip 1
koopa8840 24 Posted July 10, 2021 Posted July 10, 2021 This typo is located in Emby.SmartPlaylist.Plugin-develop\frontend\src\app\components\App.tsx. I'll report back, in a few days, after I have had time to play with it.
ShaneP 246 Posted July 10, 2021 Author Posted July 10, 2021 (edited) 13 minutes ago, koopa8840 said: This typo is located in Emby.SmartPlaylist.Plugin-develop\frontend\src\app\components\App.tsx. I'll report back, in a few days, after I have had time to play with it. Yea, saw this on the original repo and fixed it, this has been checked into my master branch on my forked repo, if you want to grab it. Or ... here's the DLL. I see from the thread that there are a few calls for smart collections, so investigating this and trying to understand the code base more... so watch this space SmartPlaylist.2.0.0.0.zip Edited July 10, 2021 by ShaneP 1
koopa8840 24 Posted July 10, 2021 Posted July 10, 2021 (edited) Download and extract the dll from the zip file. Place dll file in Emby\programdata\plugins\ folder and restart Emby server. You will find the settings in the server dashboard under Advanced. Edited July 10, 2021 by koopa8840 1
Bazzu85 22 Posted July 11, 2021 Posted July 11, 2021 11 hours ago, ShaneP said: Yea, saw this on the original repo and fixed it, this has been checked into my master branch on my forked repo, if you want to grab it. Or ... here's the DLL. I see from the thread that there are a few calls for smart collections, so investigating this and trying to understand the code base more... so watch this space SmartPlaylist.2.0.0.0.zip 98.79 kB · 2 downloads thx a lot for the new release! I putted a star on the github page.. a couple of suggestion if you want to mantain it for the future: when releasing a new dll add it to the github release section..so the users can download it with searching the forum.. Make a new forum post so your work is never lost.. BTW just tested new and is working again like a charm..
Happy2Play 9079 Posted July 11, 2021 Posted July 11, 2021 Split topic and closed previous topic. @ShanePcan maintain updated dll in first post.
crashnash86 0 Posted July 11, 2021 Posted July 11, 2021 Thanks ShaneP for this update, I have installed the .dll file and restarted the server. The SmartPlaylist option is appearing in the left menu under advanced but when I click it to configure nothing happens. The screen just stays the same, I have also tried clicking smart playlists from the plugin section but again nothing happens. Does anyone know why this is not loading? Thanks in advance
koopa8840 24 Posted July 11, 2021 Posted July 11, 2021 Could you provide a screenshot of what you are seeing?
crashnash86 0 Posted July 11, 2021 Posted July 11, 2021 Sure when I click SmartPlaylist here nothing happens.
PenkethBoy 2066 Posted July 11, 2021 Posted July 11, 2021 (edited) Same as Crashnash but error in log 2021-07-11 16:29:01.746 Info Server: http/1.1 Response 200 to ::1. Time: 0ms. http://localhost:8096/emby/web/configurationpages?Name=smartplaylist.html&X-Emby-Client=Emby Web&X-Emby-Device-Name=Google Chrome Windows&X-Emby-Device-Id=d9a27c48-0767-4197-880a-fc4bf91a09b8&X-Emby-Client-Version=4.7.0.3 2021-07-11 16:29:01.756 Error Server: Error processing request *** Error Report *** Version: 4.7.0.3 Command line: F:\EmbyCore\system\EmbyServer.dll Operating system: Microsoft Windows 10.0.19043 Framework: .NET Core 3.1.13 OS/Process: x64/x64 Runtime: F:/EmbyCore/system/System.Private.CoreLib.dll Processor count: 8 Data path: F:\EmbyCore\programdata Application path: F:\EmbyCore\system System.IO.FileNotFoundException: System.IO.FileNotFoundException: Could not find file 'F:\EmbyCore\system\dashboard-ui\scrollHelper.js'. File name: 'F:\EmbyCore\system\dashboard-ui\scrollHelper.js' at System.IO.FileStream.ValidateFileHandle(SafeFileHandle fileHandle) at System.IO.FileStream.CreateFileOpenHandle(FileMode mode, FileShare share, FileOptions options) at System.IO.FileStream..ctor(String path, FileMode mode, FileAccess access, FileShare share, Int32 bufferSize, FileOptions options) at Emby.Server.Implementations.IO.ManagedFileSystem.GetFileStream(String path, FileOpenMode mode, FileAccessMode access, FileShareMode share, Int32 bufferSize, FileOpenOptions fileOpenOptions) at Emby.Server.Implementations.IO.ManagedFileSystem.GetFileStream(String path, FileOpenMode mode, FileAccessMode access, FileShareMode share, FileOpenOptions fileOpenOptions) at Emby.Server.Implementations.IO.IOManager.GetResponse(HttpRequestOptions options, MediaProtocol protocol) at Emby.Server.Implementations.IO.IOManager.GetResponse(HttpRequestOptions options) at Emby.Server.Implementations.HttpServer.HttpResultFactory.GetContent(StaticFileResultOptions options, Int64 offset, Int64 length, CancellationToken cancellationToken) at Emby.Server.Implementations.HttpServer.FileWriter.SetContentResponseHeaders(Nullable`1 reportedTotalContentLength, CancellationToken cancellationToken) at Emby.Server.Implementations.HttpServer.HttpResultFactory.GetStaticResult(IRequest requestContext, StaticResultOptions options) at Emby.Web.Api.DashboardService.Get(GetDashboardResource request) at Emby.Server.Implementations.Services.ServiceController.GetTaskResult(Task task) at Emby.Server.Implementations.Services.ServiceHandler.ProcessRequestAsync(HttpListenerHost appHost, IRequest httpReq, IResponse httpRes, RestPath restPath, String responseContentType, CancellationToken cancellationToken) at Emby.Server.Implementations.HttpServer.HttpListenerHost.RequestHandler(IRequest httpReq, ReadOnlyMemory`1 urlString, ReadOnlyMemory`1 localPath, CancellationToken cancellationToken) Source: System.Private.CoreLib TargetSite: Microsoft.Win32.SafeHandles.SafeFileHandle ValidateFileHandle(Microsoft.Win32.SafeHandles.SafeFileHandle) 'F:\EmbyCore\system\dashboard-ui\scrollHelper.js'. which is not part of emby? this is with beta server .3 Edited July 11, 2021 by PenkethBoy
Happy2Play 9079 Posted July 11, 2021 Posted July 11, 2021 Looks like scrollhelper was removed in beta 4.7. So another divide between stable and beta. So it work fine in 4.6.4.0 but is broken in beta 4.7.
GrumpyTrucker 3 Posted July 14, 2021 Posted July 14, 2021 Couple of quick questions if that's OK? 1) When would the playlist Shuffle if Daily/Weekly etc is selected? Midnight? 8am? Sunday? Monday? 2) For some reason, on my server anyway, running a Scheduled Task to generate a new playlist seems to have stopped working since installing this version of the plugin. Any tips on kickstarting it again? Because I work through the night I had a scheduled task to shuffle the playlists at 9am, since shuffling at midnight (if that's what "Shuffle Daily" does would mean my playlist would probably shuffle while I was listening to it.
ShaneP 246 Posted July 16, 2021 Author Posted July 16, 2021 On 7/14/2021 at 1:28 PM, GrumpyTrucker said: Couple of quick questions if that's OK? 1) When would the playlist Shuffle if Daily/Weekly etc is selected? Midnight? 8am? Sunday? Monday? 2) For some reason, on my server anyway, running a Scheduled Task to generate a new playlist seems to have stopped working since installing this version of the plugin. Any tips on kickstarting it again? Because I work through the night I had a scheduled task to shuffle the playlists at 9am, since shuffling at midnight (if that's what "Shuffle Daily" does would mean my playlist would probably shuffle while I was listening to it. Hey Gumpy 1) So, looking through the code. say you have it set to daily. any run after midnight UTC would regenerate the playlist. 2) I've have fixed a few bugs around this, and added "Smart" Collections in the new version, All the codinig is done, just doing some tests and clean up and should be ready for testing really soon.
ShaneP 246 Posted July 17, 2021 Author Posted July 17, 2021 (edited) Version 2.0.0.1 Ready for testing Added Support for 'Smart' Collections Fixed minor bugs around scheduling Revamped UI to be more inline with Emby and Themes Releases Here -> Let me know if you have any issues... and as always... enter at your own peril Edited July 17, 2021 by ShaneP
crashnash86 0 Posted July 17, 2021 Posted July 17, 2021 Hey @ShaneP This is great thanks for the update. I was wondering if its normal for it to take around 10 seconds to load the things in the playlists. For example, I have set it up to create a playlist based on movies from a certain date range (80's Movies) from 1980 - 1989. When I click this section all is working great however its takes 5- 10 seconds for anything to appear. It might be because of the amount of movies its added which I think is around 1200. Is there anyway to improve this so that it can be speeded up at all? Its a fantastic plugin and a feature I have wanted in EMBY for a long time. Thanks for all the work on this
ShaneP 246 Posted July 17, 2021 Author Posted July 17, 2021 5 hours ago, crashnash86 said: Hey @ShaneP This is great thanks for the update. I was wondering if its normal for it to take around 10 seconds to load the things in the playlists. For example, I have set it up to create a playlist based on movies from a certain date range (80's Movies) from 1980 - 1989. When I click this section all is working great however its takes 5- 10 seconds for anything to appear. It might be because of the amount of movies its added which I think is around 1200. Is there anyway to improve this so that it can be speeded up at all? Its a fantastic plugin and a feature I have wanted in EMBY for a long time. Thanks for all the work on this Hey @crashnash86, is this when you open the generated playlist? If so, this is a normal Emby playlist and the 'opening' is handled by Emby themselves (not sure if there is much I can do here), maybe one of the guy from Emby could take a look, alternatively you could break down your playlists into smaller playlists? I could try see if I could created Embedded Playlists. So you could have: Playlist 1980-1989 Playlist 1980-1981 Movie 1 Movie 2 Playlist 1981-1982 Movie 1 Movie 2 Playlist (etc)
koopa8840 24 Posted July 17, 2021 Posted July 17, 2021 7 hours ago, crashnash86 said: Hey @ShaneP This is great thanks for the update. I was wondering if its normal for it to take around 10 seconds to load the things in the playlists. I experience this, anywhere, within Emby and not just on the playlists.
richardyu301 3 Posted July 20, 2021 Posted July 20, 2021 On 7/12/2021 at 1:05 AM, Happy2Play said: Looks like scrollhelper was removed in beta 4.7. So another divide between stable and beta. So it work fine in 4.6.4.0 but is broken in beta 4.7. So does it mean that down the road after upgrade we won't be able to use this plugin?
Bazzu85 22 Posted July 20, 2021 Posted July 20, 2021 49 minutes ago, richardyu301 said: So does it mean that down the road after upgrade we won't be able to use this plugin? @ShaneP has to make a compatibility update to remove the scrollhelper section and replace to something that works before that change become stable
Happy2Play 9079 Posted July 20, 2021 Posted July 20, 2021 1 hour ago, richardyu301 said: So does it mean that down the road after upgrade we won't be able to use this plugin? 37 minutes ago, Bazzu85 said: @ShaneP has to make a compatibility update to remove the scrollhelper section and replace to something that works before that change become stable Correct, if the dev does not maintain two separate branches then the plugin will only function on stable branch and has to be updated when 4.7 is released. There are a couple plugin devs that only maintain one branch.
Recommended Posts
Create an account or sign in to comment
You need to be a member in order to leave a comment
Create an account
Sign up for a new account in our community. It's easy!
Register a new accountSign in
Already have an account? Sign in here.
Sign In Now