Jump to content

Emby NextGen Subs disabled by default in player.py


stefprob
 Share

Recommended Posts

stefprob

I had a problem in Kodi, i had to enable subtitles in OSD settings every time i started playback of a video or movie. Pressing "make this default for all media" did not have any effect, next time i played a video, i had to re-enable subs.

The problem lays in a file called player.py in Kodi\addons\plugin.video.emby-next-gen\hooks\ where subtitles are disabled by default (self.Monitor.player.showSubtitles(False)) and this file ignores the settings of Kodi. Changing the value to "True" enabled subtitles, but i believe that this has to be fixed.

I will post this to the Emby forum so that they will be able to fix it.

Link to comment
Share on other sites

quickmic

Absolutly correct, but this has a side effect. If you enable ("True") or completly remove this line it also ignores the Kodi setting and subtitles are enabled by default even if they should be disabled.

That's why I have to choose between default on and default off, but it never uses the Kodi setting.

It's on my todo list, but I haven't found a proper solution yet.

Edited by quickmic
Link to comment
Share on other sites

stefprob
Posted (edited)

Why don't you drop a line in Emby NextGen, player settings, where we can choose if we want subs on or off by default? I think this could be a proper solution...

Or you can take input from the Kodi settings, if this is possible at all.

Edited by stefprob
  • Like 1
Link to comment
Share on other sites

quickmic

Both possible and both are workarounds for a issue which should never exist ūüôĄ

In the end you're right, it will be the only solution.

btw, the core issue is the API for SRT subtitles. As soon as SRT are (just) loaded via API, Kodi enables subtitles.

Edited by quickmic
Link to comment
Share on other sites

  • 2 weeks later...
lipemanel

Good to know that this is already being checked, since this was a topic that was really causing me issues and took me quite some time to find this feedback :)

Great job with this app, btw ;)

  • Like 1
Link to comment
Share on other sites

quickmic

You can try experimental version from here:

 

 

... but I think there is still an issue with preferred language.

Also changes in the default subtitle settings requires a Kodi restart to be synced with next-gen

Edited by quickmic
Link to comment
Share on other sites

  • 3 weeks later...
psychosb

Hello there.

I'm having the exact same problem with my external subtitles and the Emby Next Gen.

Is this problem solved?

Link to comment
Share on other sites

12 minutes ago, psychosb said:

Hello there.

I'm having the exact same problem with my external subtitles and the Emby Next Gen.

Is this problem solved?

Hi @psychosb can you please go over an example?

Thanks.

Link to comment
Share on other sites

psychosb

Hello @Luke.

I can provide more information as requested, should I open a new topic?

I have replied here because I have the problem with the Subs disabled.

Thanks

Edited by psychosb
Link to comment
Share on other sites

quickmic

This was fixed in the latest experimental version of Emby next gen.

fyi, changes of the subtitle default settings requires a Kodi restart.

Link to comment
Share on other sites

psychosb
9 hours ago, quickmic said:

This was fixed in the latest experimental version of Emby next gen.

fyi, changes of the subtitle default settings requires a Kodi restart.

Thanks, I'll try the experimental version.

On this version it auto enables the subtitle when the .SRT file has the same filename of the .MKV file?

 

Link to comment
Share on other sites

quickmic

It works as the native Kodi subtitle implementation. Default on/off, also manual subtitle adjustments are supported.

Please be aware that default language selection is not supported yet.

Link to comment
Share on other sites

BaukeZwart

@psychosb You can also use the Kodi Language Preference Manager plugin.
I use the version posted in the very last post of that thread. It's has options to set audio and subtitel language, and auto enable or disable subtitels based on preferred subs found or not. 

Link to comment
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now
 Share

×
×
  • Create New...