emby for kodi music bug

[quickmic 72]

2020-08-08 12:18:14.538 T:1624122224  NOTICE: EMBY.objects.kodi.artwork -> DELETE cached 8/8a4085eb.jpg
2020-08-08 12:18:14.538 T:1624122224  NOTICE: EMBY.database -> [texture] 2 rows updated.
2020-08-08 12:18:14.544 T:1624122224  NOTICE: EMBY.objects.core.music -> DELETE song [154480] 133187
2020-08-08 12:18:14.545 T:1624122224  NOTICE: EMBY.library -> ERROR:: 'id'
                                            Traceback (most recent call last):
                                              File "/storage/.kodi/addons/plugin.video.emby/resources/lib/library.py", line 988, in run
                                                obj(item['Id'])
                                              File "/storage/.kodi/addons/plugin.video.emby/resources/lib/helper/wrapper.py", line 100, in wrapper
                                                return func(*args, **kwargs)
                                              File "/storage/.kodi/addons/plugin.video.emby/resources/lib/helper/wrapper.py", line 113, in wrapper
                                                return func(self, item, e_item=e_item, *args, **kwargs)
                                              File "/storage/.kodi/userdata/addon_data/plugin.video.emby/emby/objects/core/music.py", line 484, in remove
                                                self.emby_db.remove_wild_item(obj['id'])
                                            KeyError: 'id'
2020-08-08 12:18:15.439 T:2148524912  NOTICE: EMBY.library -> [ DELAY UPDATES ]
2020-08-08 12:18:16.621 T:1624122224  NOTICE: Previous line repeats 1 times.
2020-08-08 12:18:16.622 T:1624122224  NOTICE: EMBY.objects.kodi.artwork -> DELETE cached 2/2b62e225.jpg
2020-08-08 12:18:16.622 T:1624122224  NOTICE: EMBY.database -> [texture] 2 rows updated.
2020-08-08 12:18:16.633 T:1624122224  NOTICE: EMBY.objects.core.music -> DELETE song [155937] 133245

 

I modified some song-titels in emby server.

log is from incremental sync

 

Kodi 18.7 (libreelec) on raspi 4, plugin version. 4.1.19

Edited August 8 by quickmic

[Luke 25096]

Hi, what problem are you having?

[quickmic Topic Author 72]

I thought it was obvious.

Code issue in emby kodi plugin.

Looks "self.emby_db.remove_wild_item(obj['id'])" should be "self.emby_db.remove_wild_item(obj['Id'])"

 

....case sensitive

 

Maybe issue is also in additional spots.

Edited August 10 by quickmic

[quickmic Topic Author 72]

I have fixed the bug, please review pull request:

https://github.com/MediaBrowser/plugin.video.emby.objects/pull/4/files

 

[Luke 25096]

Great, thanks, I'll take a look at it !