Fixed Movies don't start anymore

[laola 12]

I do have the same issue - should I just wait for an updated version or should I replace the py as well ?

[Volkmar 14]

I would try to replace the py. (make a backup from the old one)

[Angelblue05 4131]

Check for updates in the addon settings > advanced. That should pick up on the fix that was just pushed to github.

Edited October 12, 2018 by Angelblue05

[Volkmar 14]

I'm scared! I just have a running system again 

[sualfred 677]

We just pushed the changes to the repo ^^ Plus fixed another small one that was introcuded with the file I gave you.

No need to worry.

[Volkmar 14]

After installing the update and patch was applied:

 

Results:

 

Resuming a movie via widget -> resume at(resuming time): passed

Playing a new movie via widget: passed

 

Resuming a movie via widget -> context menu -> resume at(resuming time): kodi crashed

Playing a new movie via widget -> context menu -> play: kodi crashed

Resuming a movie via widget -> context menu -> information -> resume: kodi crashed

 

 

Changed the settings -> media -> videos -> default action = show information

Resuming a video: passed

Playing a new video: crash kodi

[sualfred 677]

Have you restarted after the patch has been applied?

This was required on my end at home.

Edited October 12, 2018 by sualfred

[Volkmar 14]

I restarted the box after each crash completely (incl. making the box powerless)

[sualfred 677]

Please open the exisitng actions.py on your box and scroll down to the bottom.

 

To this part:

   
.....
 elif not isPlaying and window('emby.playinfo.bool') and not xbmc.getCondVisibility('Window.IsVisible(DialogContextMenu.xml)'):
        window('emby.context.count', value=str(count + 1))

        if count == 2:

            window('emby.playinfo', clear=True)
            window('emby.context.count', clear=True)

    elif not isPlaying and window('emby.context.widget.bool') and not xbmc.getCondVisibility('Window.IsVisible(DialogVideoInfo.xml)'):
        window('emby.context.count', value=str(count + 1))

        if count == 2:

            window('emby.context.widget', clear=True)
            window('emby.context.count', clear=True)

Please change both lines from "if count == 2" to "if count == 3" And test it again.

If that doesn't work increase it to 4. If that also doesn't work try 5 and 6.

 

Also don't forget to restart Kodi after replacing the values and let us know if another value works.

Edited October 12, 2018 by sualfred

[Volkmar 14]

changed the value up to "6", same results (kodi still crashes)

[sualfred 677]

How long does it take until your playback starts?

[Volkmar 14]

4.12 seconds

[Volkmar 14]

changing back to the action.py you gave me yesterday.

It works again, even via context menu.

[sualfred 677]

Please change to the current one and increase the count to something very like 100

Edited October 12, 2018 by sualfred

[Volkmar 14]

100 works

decreasing the value to 25: still works fine

Edited October 12, 2018 by Volkmar

[sualfred 677]

Please try to decrease it more and let me know the lowest possible value.

[Volkmar 14]

8 is the lowest possible value

[sualfred 677]

Ok. Race condition issue.

 

I have an idea which works on my end.

 

Please go to your default addon folder: /addons/plugin.video.emby/resources/lib/database

and edito _init_.py:

From this
 

try:
    from objects import obj
except Exception as error:
    # clear patch
    LOG.exception(error)
    delete_folder()
    dialog("ok", heading="{emby}", line1=_(33155))
    xbmc.executebuiltin('RestartApp')

to this
 

try:
    from objects import obj
except Exception as error:
    pass

And after that please replace the actions.py in the hidden folder again with the one that is attached to this post.

If that still does not work please increase the count value again and let me know if the minimum required count value is lower than before.
 

actions.zip

[Volkmar 14]

with value 1 it don't work, I had to increase to value 7 (before it was value 8)

[sualfred 677]

Hmm ok. We will look into it. At least it works for you for the moment.

[sualfred 677]

@@Volkmar
 

Could you please try the attached actions.py?

And increase the count value again until it works.

actions.zip

Edited October 12, 2018 by sualfred

[Volkmar 14]

I didn't had to increase the value. It works to me as it is (value 1).

 

/addons/plugin.video.emby/resources/lib/database/_init_.py is still modified.

[sualfred 677]

That's what I wanted to hear. Great. Thanks

[Angelblue05 4131]

I will apply the changes by sualfred. Thank you for confirming this resolves the situation.

[Angelblue05 4131]

@@Volkmar

 

Let's try this again, in the add-on settings > advanced > check for updates. Let me know if everything still works. We found a small error in the code, which I've corrected in the process.