Sek0n Posted May 22, 2015 Share Posted May 22, 2015 (edited) I was just curious if it was intentional to not allow movies to be deleted the same way shows can. If so, what is the reasoning? I added " or "movie" " to the monitor file, and have had no issues so far. Is there a risk with doing this that I've not thought of? Thanks for the great work, btw. The latest stuff has been fantastic. Edited May 22, 2015 by Sek0n Link to comment Share on other sites More sharing options...
xnappo Posted May 22, 2015 Share Posted May 22, 2015 (edited) The reasoning was that the episode delete was added for people who use Kodi like a DVR, but that most people want a little more protection for their movie collection. There is no risk to your mod.. We can make it an option if more people want it. Edited May 22, 2015 by xnappo 1 Link to comment Share on other sites More sharing options...
Sek0n Posted May 22, 2015 Author Share Posted May 22, 2015 Ah, ok. Makes sense. Would be nice as an option, but I'm content with just doing it myself. Thanks. Link to comment Share on other sites More sharing options...
xnappo Posted May 22, 2015 Share Posted May 22, 2015 It is a reasonable and very easy request. I'll get it in there at some point. Link to comment Share on other sites More sharing options...
marcelveldt Posted May 22, 2015 Share Posted May 22, 2015 I was just curious if it was intentional to not allow movies to be deleted the same way shows can. If so, what is the reasoning? I added " or "movie" " to the monitor file, and have had no issues so far. Is there a risk with doing this that I've not thought of? Thanks for the great work, btw. The latest stuff has been fantastic. Feel free to commit your change as a PR to us on Github, that way other users can benefit from this too :-) Link to comment Share on other sites More sharing options...
xnappo Posted May 22, 2015 Share Posted May 22, 2015 Well - his is a hard-coded offer delete for movies - definitely don't want that. Link to comment Share on other sites More sharing options...
Sek0n Posted May 22, 2015 Author Share Posted May 22, 2015 (edited) Yea, I'll leave that be and let you add the option when it's ready. In-case anyone does actually wan't to do it at their own risk; I changed line 76 in KodiMonitor.py from if jsondata.get("type") == "episode": to if jsondata.get("type") == "episode" or "movie": (Let me know if you don't want this here, or just edit it out) Edited May 22, 2015 by Sek0n Link to comment Share on other sites More sharing options...
xnappo Posted May 22, 2015 Share Posted May 22, 2015 Naw, totally fine to post that Link to comment Share on other sites More sharing options...
Recommended Posts