Skip subtitle download if video contains download language subtitle

[happytonakai 6]

In the subtitle downloads setup, there is an option 'Skip if the video already contains embedded subtitles'.

It means literally that the download will be skipped if the video has embedded subtitles no matter in which language it is.

I think it's better be 'Skip if the video already contains embedded subtitle that matches the download language'. Because many videos contain embedded English subtitles.

[Luke 38535]

HI, no that's not true. It matches against the configured languages for downloading.

[happytonakai 6]

23 hours ago, Luke said:

HI, no that's not true. It matches against the configured languages for downloading.

Hi. So do you mean that the functionality is essentially what I suggested: skipping the download if the video already contains embedded subtitles in a language that matches one of the configured languages for downloading?

[Happy2Play 9080]

Skip if the video already contains embedded subtitles
Keeping text versions of subtitles will result in more efficient delivery and decrease the likelihood of video transcoding.

The note is to vague as one will want to get subs if embedded are PSG.  So subtitle type needs/should always be a factor.

[Luke 38535]

1 hour ago, happytonakai said:

Hi. So do you mean that the functionality is essentially what I suggested: skipping the download if the video already contains embedded subtitles in a language that matches one of the configured languages for downloading?

Yes.

[pwhodges 1717]

2 hours ago, Happy2Play said:

Skip if the video already contains embedded subtitles
Keeping text versions of subtitles will result in more efficient delivery and decrease the likelihood of video transcoding.

The note is to vague as one will want to get subs if embedded are PSG.  So subtitle type needs/should always be a factor.

That is a separate decision, and should be a separate option.

Conflating requiring subtitles in a particular language and the possibility of transcoding being required is not logical.

Paul