[bug] Images chargées depuis GitHub

[neves000 15]

Bonjour,

Actuellement, GitHub est cassé et est complètement inaccessible. Cela m'a fait remarquer que certaines images d'Emby sont chargées depuis GitHub au lieu d’être embarquées dans l'application :

Exemple avec l’icône de Firefox : https://github.com/MediaBrowser/Emby.Resources/raw/master/images/devices/firefox.png

Le bug est présent sur Emby 4.6.7.0. Possible d'embarquer les images dans les prochaines versions ? Rien de très grave, mais si on peut éviter d’être dépendant d'un site externe autant le faire

Edited November 27, 2021 by neves000

[Happy2Play 8281]

Oui, c'est un problème mais techniquement un problème Github car ce sont des ressources en ligne. Mais ce serait une bonne idée que ces images soient des packages avec le serveur ou un téléchargement unique de Gihub sur votre serveur.

 

Yes it is a issue but technically a Github issue since they are online resources.  But it would be a good idea for these images to be packages with the server or a one time download from Gihub to your server.

 

2021-11-27 12:46:01.764 Info HttpClient: GET https://api.github.com/repos/MediaBrowser/Emby.Releases/releases
2021-11-27 12:46:21.799 Error HttpClient: Connection to https://api.github.com/repos/MediaBrowser/Emby.Releases/releases timed out
2021-11-27 12:46:21.799 Info App: Timed out checking for application updates. Will try again later
2021-11-27 12:46:21.799 Debug TaskManager: Check for application updates Completed after 0 minute(s) and 20 seconds
2021-11-27 12:51:37.821 Error App: Error getting connection info
	*** Error Report ***
	Version: 4.7.0.18
	Command line: Y:\Emby-Server\system\EmbyServer.dll
	Operating system: Microsoft Windows 10.0.19043
	Framework: .NET 6.0.0-rtm.21522.10
	OS/Process: x64/x64
	Runtime: Y:/Emby-Server/system/System.Private.CoreLib.dll
	Processor count: 12
	Data path: Y:\Emby-Server\programdata
	Application path: Y:\Emby-Server\system
	System.Net.Http.HttpRequestException: System.Net.Http.HttpRequestException: The requested name is valid, but no data of the requested type was found. (ipv4bot.whatismyipaddress.com:80)
	 ---> System.Net.Sockets.SocketException (11004): The requested name is valid, but no data of the requested type was found.
	   at System.Net.Sockets.Socket.AwaitableSocketAsyncEventArgs.ThrowException(SocketError error, CancellationToken cancellationToken)
	   at System.Net.Sockets.Socket.AwaitableSocketAsyncEventArgs.System.Threading.Tasks.Sources.IValueTaskSource.GetResult(Int16 token)
	   at System.Net.Sockets.Socket.<ConnectAsync>g__WaitForConnectWithCancellation|277_0(AwaitableSocketAsyncEventArgs saea, ValueTask connectTask, CancellationToken cancellationToken)
	   at System.Net.Http.HttpConnectionPool.ConnectToTcpHostAsync(String host, Int32 port, HttpRequestMessage initialRequest, Boolean async, CancellationToken cancellationToken)
	   --- End of inner exception stack trace ---
	   at Emby.Server.Implementations.HttpClientManager.CoreHttpClientManager.SendAsyncInternal(HttpRequestOptions options, String httpMethod)
	   at Emby.Server.Implementations.HttpClientManager.CoreHttpClientManager.SendAsync(HttpRequestOptions options, String httpMethod)
	   at Emby.Server.Connect.ConnectEntryPoint.GetIpAddress(String lookupUrl)
	   at Emby.Server.Connect.ConnectEntryPoint.TimerCallback(Object state)
	Source: Emby.Server.Implementations
	TargetSite: Void MoveNext()
	InnerException: System.Net.Sockets.SocketException: The requested name is valid, but no data of the requested type was found.
	Source: System.Net.Sockets
	TargetSite: Void ThrowException(System.Net.Sockets.SocketError, System.Threading.CancellationToken)
	   at System.Net.Sockets.Socket.AwaitableSocketAsyncEventArgs.ThrowException(SocketError error, CancellationToken cancellationToken)
	   at System.Net.Sockets.Socket.AwaitableSocketAsyncEventArgs.System.Threading.Tasks.Sources.IValueTaskSource.GetResult(Int16 token)
	   at System.Net.Sockets.Socket.<ConnectAsync>g__WaitForConnectWithCancellation|277_0(AwaitableSocketAsyncEventArgs saea, ValueTask connectTask, CancellationToken cancellationToken)
	   at System.Net.Http.HttpConnectionPool.ConnectToTcpHostAsync(String host, Int32 port, HttpRequestMessage initialRequest, Boolean async, CancellationToken cancellationToken)

 

[Luke 37060]

Yes we plan to make them a one-time download in future updates. It's on the to do list. Thanks.