Jump to content

XBMB3C feature suggestions


tube82

Recommended Posts

elcabong

ive noticed an issue with data going to xbmc in 1 instance:

when playing an un-played episode, the plot gets passed so it can be called using xbmc's json > player.getitem.  but if i stop the episode, creating a resume point, when resuming the episode, plot is not available through xbmc's json > player.getitem.

 

i know getting the info through xbmc's json is a small use case, but it would make implementing something like the link below a bit easier instead of hitting xbmc for nowplaying, then mbs3 json for the rest of the data:

 

http://forum.xbmc.org/showthread.php?tid=153126

 

requested info:

cover, fanart, genre, year, first aired/released, runtime, rating, director, writer

 

ive tried poking around line 885 in xbmb3c/default.py to add the additional info, but have been unsuccessful.

Link to comment
Share on other sites

xnappo

 

ive tried poking around line 885 in xbmb3c/default.py to add the additional info, but have been unsuccessful.

 

I think I see the problem.

 

Look for this:

while xbmc.Player().getTime() < (seekToTime - 5):
            xbmc.Player().pause
            xbmc.sleep(100)
            xbmc.Player().seekTime(seekToTime)
            xbmc.sleep(100)
            xbmc.Player().play()

Replace with this (only last line differs):

while xbmc.Player().getTime() < (seekToTime - 5):
            xbmc.Player().pause
            xbmc.sleep(100)
            xbmc.Player().seekTime(seekToTime)
            xbmc.sleep(100)
            xbmc.Player().play(playurl, item)

It that works, let me know and I will check it in.  

 

xnappo

Edited by xnappo
Link to comment
Share on other sites

elcabong

tested search, working fast here as well.  looks good..  can you sort the results alphabetically until a better sort function is determined?  this should put all like items next to each other, and keep multiple episodes of shows next to each other.

Link to comment
Share on other sites

elcabong

nope, same issue persists.

 

 

here is the json output from player.getitem the first time its played

{"id":"1","jsonrpc":"2.0","result":{"item":{
"album":"",
"artist":[],
"cast":[],
"country":[],
"dateadded":"",
"director":[],
"episode":1,
"episodeguide":"",
"fanart":"",
"file":"smb://myserver/TV Shows/Orphan Black/Season 02/Orphan Black - 2x01 - Nature Under Constraint and Vexed.mkv",
"firstaired":"",
"genre":[],
"imdbnumber":"",
"label":"Nature Under Constraint and Vexed",
"lastplayed":"",
"mpaa":"",
"originaltitle":"",
"playcount":0,
"plot":"Sarah is out of options, on the run, and pursued by deadly adversaries. Desperate to find her daughter Kira, Sarah suspects ruthless pro-clone Rachel is behind her daughter’s disappearance and sparks an all out war against her. Alison and Donnie attend the funeral of her fallen friend, Aynsley, causing Alison to sink into guilt and despair. Cosima is faced with a perplexing decision that may have dire consequences.",
"plotoutline":"",
"premiered":"",
"productioncode":"",
"rating":0,
"resume":{"position":0,"total":0},
"runtime":0,
"season":2,
"set":"",
"setid":-1,
"showlink":[],
"showtitle":"",
"sorttitle":"",
"streamdetails":{"audio":[],"subtitle":[],"video":[]},
"studio":[],
"tag":[],
"tagline":"",
"thumbnail":"image://http%3a%2f%2flocalhost%3a15001%2f%3fid%3d6f810ae9de86b8bf51c20fdcb92ac855%26type%3dPrimary%26tag%3d1743bb95263846a8798036b703db7198/",
"title":"Nature Under Constraint and Vexed",
"top250":0,
"track":-1,
"trailer":"",
"tvshowid":-1,
"type":"unknown",
"uniqueid":{"unknown":""},
"votes":"",
"writer":[],
"year":0}}}

and here is the json output from player.getitem each time after the first.  i think it may have something to do with the lastplayed field handling.  seems to be the only new info, while a bit of the previous info is missing

{"id":"1","jsonrpc":"2.0","result":{"item":{
"dateadded":"",
"director":[],
"episode":-1,
"episodeguide":"",
"fanart":"",
"file":"smb://myserver/TV Shows/Orphan Black/Season 02/Orphan Black - 2x01 - Nature Under Constraint and Vexed.mkv",
"firstaired":"",
"genre":[],
"imdbnumber":"",
"label":"Orphan Black - 2x01 - Nature Under Constraint and Vexed",
"lastplayed":"2014-04-21 14:58:23",
"mpaa":"",
"originaltitle":"",
"playcount":0,
"plot":"",
"plotoutline":"",
"premiered":"",
"productioncode":"",
"rating":0,
"resume":{"position":0,"total":0},
"runtime":0,
"season":-1,
"set":"",
"setid":-1,
"showlink":[],
"showtitle":"",
"sorttitle":"",
"streamdetails":{"audio":[],"subtitle":[],"video":[]},
"studio":[],
"tag":[],
"tagline":"",
"thumbnail":"image://http%3a%2f%2flocalhost%3a15001%2f%3fid%3d6f810ae9de86b8bf51c20fdcb92ac855%26type%3dPrimary%26tag%3d1743bb95263846a8798036b703db7198/",
"title":"",
"top250":0,
"track":-1,
"trailer":"",
"tvshowid":-1,
"type":"unknown",
"uniqueid":{"unknown":""},
"votes":"",
"writer":[],
"year":0}}}
Link to comment
Share on other sites

xnappo

I played with that myself, but it wasn't very good - because you end up with a bunch of songs first.

 

I will keep messing with it though - I agree it needs some sort of refinement.

 

xnappo

Link to comment
Share on other sites

elcabong

what about reverse alpha?  would put the order like this (at least for my test results)

 

tv series > music artists > movies > folder (collections if grouped in folders) > episodes > audio

Link to comment
Share on other sites

xnappo

Well I am hesitant to code around it - it is really an MB3 server limitation.  Try a search in the Web client and you get the same result.

 

With all of the non-standard queries I would like to see sorting ability added - like for NextUp I would like to be able to sort by series name...

 

xnappo

  • Like 1
Link to comment
Share on other sites

elcabong

ah, i didnt think to check it against the web version.. i see what you mean.  having just what you implemented is a huge plus already.

 

if/when the time comes to look into this again, let me know if there is a request to add functionality to mbs3 search, il +1.

Link to comment
Share on other sites

xnappo

From all I can tell there is nothing wrong with our code...  The information shows up correctly during playback, so I think it may be on the XBMC side.

 

xnappo

Link to comment
Share on other sites

xnappo

Just read the following post in the XBMB3C thread on the XBMC forums:

 

AFAIK there still isn't a favorite TV shows list node, right? I think it's a good suggestion.

That is such an obvious and easy feature it is sneaking its way past 0.9.0 feature freeze :)  It is in the Git now.

 

Helps that I want it :D

 

xnappo

Edited by xnappo
  • Like 1
Link to comment
Share on other sites

elcabong

From all I can tell there is nothing wrong with our code...  The information shows up correctly during playback, so I think it may be on the XBMC side.

 

xnappo

 

thanks for looking into it

 

after digging around a little more today and looking at the logs, you are correct, it looks like xbmb3c is passing the available info when the playback starts.  i also tested with 2 different boxes and noticed that the first time i played any video, even if it was played on another box, would show the correct info, but after stopping and resuming on the box, some of the info is gone.  when i delete the local MyVideosXX.db it gives me the full stread details.. it looks like when xbmc stores addon videos it plays, it doesnt store much info locally, and the next time it plays, it pulls the lacking local info..  will look around a little more, hopefully its just an issue with the current build im on.

Edited by elcabong
  • Like 1
Link to comment
Share on other sites

elcabong

there is an error on line 285 of default.py, the favorite show has sectype std.movies instead of std.tvshows.  otherwise.. awesome.. sometimes you dont know how much youve been missing a feature til its there

  • Like 1
Link to comment
Share on other sites

tube82

Just read the following post in the XBMB3C thread on the XBMC forums:

 

 

I just installed this, but i there seems to be no favorite TV shows...is this normal? There is favorite Movies and episodes but no TV shows. Really cant use this plugin without that because the wife just hates to have to scrool 200+ Tv shows and i had created a favorites in the MBS hoping to use it in xbmc.

 

AFAIK there still isn't a favorite TV shows list node, right? I think it's a good suggestion.

  • Like 1
Link to comment
Share on other sites

rsday75

I am using the MB3 XBMC Confluence Skin. In the origional XBMC, when you right click on a movie one of the menu choices is movie imfo. This seems to work if I hit "i" on the keyboard, but it would be nice to have in the right click menu for remote use. In the skin forum, they said this would have to be added to this addon. Not a huge deal, but I thought maybe here would be a good place to list the idea.

Thanks,

Randall

Link to comment
Share on other sites

xnappo

Yeah, I think that is reasonable to add.  The context menu is getting really long though - need some ideas on consolidation.

xnappo

Link to comment
Share on other sites

tube82

I wanted to add a few minor suggestions we discussed in various threads, so they don't get lost.

 

In the Aeon Nox skin support thread we had a couple of things that are not really related to the skin but to XBMB3C itself:

 

More refinement to the mapping of images MB3 <-> XBMB3C

I had tried:

         extraData={'thumb' : getArtwork(item, "Primary") ,
                   'fanart_image' : getArtwork(item, "Backdrop") ,
                   'poster' : getArtwork(item, "poster") ,
                   'tvshow.poster': getArtwork(item, "tvshow.poster") ,
                   'banner' : getArtwork(item, "Banner") ,
                   'clearlogo' : getArtwork(item, "Logo") ,
                   'discart' : getArtwork(item, "Disc") ,
                   'clearart' : getArtwork(item, "Art") ,
                   'landscape' : getArtwork(item, "Thumb") ,

locally and got very good results. Currently 'landscape' uses the backdrop from MB3, which is not a good fit.

In addition, 'landscape' and 'banner' have separate images for TV shows and seasons. Currently for both image types the TV show image is used in season views instead of the season images.

 

Allow usage of additional images in widgets

Currenlty, 'landscape' and 'clearart' images (and maybe others) can't be used in home screen widgets.

 

 

In the window properties skin support thread I had the following suggestion:

 

Additional properties for series/seasons

ListItem.Property(UnWatchedEpisodes)
ListItem.Property(TotalEpisodes) 

XBMC uses those two properties to display the number of total/unwatched episodes of a show or season.

Link to comment
Share on other sites

xnappo

I tried the landscape=thumb changes, both with and without the series are and it did not work well at all for me.  Did you make any other changes?  I can't get 'Thumb' to work at all - but am putting time into the rotating fanart rather than this.  If you can make your mods to the latest Git that would be great.  If you want to be an official dev on the it - just let me know your Git username!

 

xnappo

Link to comment
Share on other sites

tube82

Interesting. Maybe MB3 just doesn't have the necessary images for the views?

A lot of movies lack the thumb images, so it's no view I would advice using for movies.

What content did you try them on?

 

Thumb and banner views for movies or on season levels are tricky because a lot of content doesn't have the images - that doesn't change the fact that it's the correct mapping though. A native XBMC runs into the same issues when using those views. When the user takes the time to create or find the images for the views they are really nice. Maybe it would be a good idea to use the show banner as a fallback if no season banner exists and to use the backdrop as a fallback when no thumb exists. But I strongly believe the first choice should be landscape=Thumb.

 

I can commit my changes if you want. My git name is the same as my name here.

 

 

I just tried the landscape views in the latest Aeon Nox version and I only get black images for 'landscape'. With and without my changes. Could it be you broke something with the rotation changes? The landscape images stil work with Arctic, so it seems to be a skin problem.

Edited by tube82
Link to comment
Share on other sites

xnappo

Okay - yes I am use Aeon Nox - and am seeing the same as you.  I don't *think* I touched that code - but it is certainly possible.  I will play with it with unmodified Nox and see.

 

xnappo

Link to comment
Share on other sites

tube82
xnappo

Okay - I confirmed I broke something when working on rotating art - I will get this one in there.

 

xnappo

Link to comment
Share on other sites

Guest
This topic is now closed to further replies.
×
×
  • Create New...