Jump to content
GrimReaper
Message added by GrimReaper,

For Plugin version of the tool, go to:

 

 

Recommended Posts

VicMoore
Posted (edited)

Eigeplackter, try this code. I think the problem was that I didn't convert the codec name to lower case.

Vic

tool_2.1e.zip

Edited by VicMoore
  • Thanks 1
Eigeplackter
Posted (edited)

Yes, it works !!

Nice job thank you very much.

 

 

EDIT: Ohhh 😞 

it only finds DTS, not Dolby Digital 5.1 or Dolby Digital

Edited by Eigeplackter
VicMoore
Posted

OK, I will look into that now 🙂

vis

VicMoore
Posted

Relace the editor.js with the code below.  When looking at the codecs in the editor the string that the search engine is looking for is in [ ] brackets. That's what you need to enter as the search string.

Vic

editor.js

Eigeplackter
Posted

Ahhh i see my fault. Thanks, now i got it.

VicMoore
Posted

Eigeplackter, the thanks all go to you. You helped me fix a bug in the code and improved the editor by adding the codecs.  Now everyone can filter on audio codecs.

Thanks, Vic

Eigeplackter
Posted (edited)

Maybe some improvement for further versions

Could the audio codec check only look for the 1st or default track ? It's no deal breaker, as I use CoverArt (which tags 1st/default language) and see, when there is a Dolby Digital overlay within the "dts" audio codec results.

 

EDIT: On a 2nd thought, that could be just my personal wish, as other may sure want to tag ALL "dts" tracks no matter which language

 

EDIT 2: Maybe I made a fault, but multiple selection screwed me over. I marked all titles with shift, excluded by single click unwanted movies and than clicked bulk. But nearly all movies seem to have gotten the "Dolby Surround 2.0" tag 😞 

EDIT 3: The audio codec filters don't work for tv shows, looks like the tool is only searching the tv show entry, where there is no audio codec, but ignores all episodes.

Edited by Eigeplackter
Eigeplackter
Posted (edited)

Additionally I'd like the option to search for (audio) channels, so you could combine codec "dts" and channels "2" to finde the DTS 2.0 movies.

 

EDIT: Filtering for FullHD (1080p) movies, returns 4K movies in list.

Edited by Eigeplackter
Eigeplackter
Posted

Handling question:

Right now I've got 882 movies, if I "Search for tags: 4k/UHD,FullHD 1080p,HD 720p,SD 576p" it returns 879.

So there are 3 movies I missed tagging a video format.

But I can't seem to find a way, to show me those 3 movies.

When I say "Has a tag = true" it shows the 879 again, when I set it to "Has a tag = false" it shows 0. I guess it's not just looking

for the tag input field, but ignores all movies that have any tag.

 

Tried using ! (for NOT) in "Search for tags" but seems as that is not the command I need.

 

VicMoore
Posted

When you search for particular tags, the tool uses the Emby API to ask Emby to search for those tags.  The tool just displays the returned results. I will play with the API and look for a way to do what you are asking. Give me a few days.

Vic

  • Thanks 1
Junglejim
Posted

This tagging tool seems to get better every week that goes by! 👍

This a must have for multiple reasons (smart pl/virtual tv/general lib tags/etc..)!

Thanks @VicMoore for putting so much time into this great app.

  • Agree 1
VicMoore
Posted

Jungle Jim, it's uses like you and moderators like Happy2Play and GrimReaper that have contributed so much to this tool.

Thank You, Vic

VicMoore
Posted (edited)

The latest code is attached below.  Nothing major changed, just a bug fix.

vic

tool_2.1f.zip

Edited by VicMoore
Eigeplackter
Posted

Is it correct, after adding tags that emby is rescanning those files as if they were brand new ?

Tagged to whole NCIS Collection and now emby is quite busy with re-scanning the intros.

Quote

2023-01-08 16:03:53.773 Info App: Best title sequence for /volume1/video/Serien/Navy CIS (2003)/Season 11/Navy CIS - S11E22 - Blue.mkv is 00:00:54.4776119 - 00:01:22.4626865. Confidence: 0,91

 

Other improvement might be to show, if the tool is frozen or still processing the tagging. As this screens makes me wonder sometimes, when I add tags:

 

image.thumb.png.cde81ae072583686b4028b061349b863.png

VicMoore
Posted

Eigeplackter,  you now have a progress bar on bulk saves. The code is below. Test it out. I did just a quick test.

Thanks for pointing this deficiency out, vic

tool_2.1g.zip

Eigeplackter
Posted

God, I feel like a slave driver 😕

I'll check it out and come back to you. 😄

 

 

deiniol39
Posted

I've just used it, progress bar is really handy and worked fine for me..

Eigeplackter
Posted

Stress test running, but now I know what's happening. Nice job, I really like it:

 

image.png.22dcf8a12cdb80b3353098582732386a.png

 

Would it be possible to refresh the results count ? Not in the bulk job, generally.

When I filter in this special playlist for tag=false, it shows me some entries, but at the top it still displays the unfiltered count.

 

 

Just me thinking about use cases ... start ignoring me, if I pester too much 😉

 

 

 

Eigeplackter
Posted

@VicMoore

Sorry but stress test failed, can the tool run into a timeout ?

Just came back and let script run while I was away, but the bar is still at 22% as it was 2 hrs ago.

I'll let it run over night, just to make sure, but there seems to be a limitating factor somehow.

Posted

OK, I will figure out what is wrong. Could you press F12 to bring up the browser console and see if you see any errors?

Don't worry about === Error  SyntaxError: Unexpected end of JSON input

 

Vic

Eigeplackter
Posted

Stops pretty early as it seems:

 

image.thumb.png.dd8b60a729c1c7add67f493a33299759.png

 

image.thumb.png.adfd2782de097cfcd818cdea0a1e389c.png

And at 22% it stops again, displaying this:

image.thumb.png.5dfb6de1e7034704c5f55577080ab324.png

6 problems:

Quote
    1.  A page or script is accessing at least one of navigator.userAgent, navigator.appVersion, and navigator.platform. Starting in Chrome 101, the amount of information available in the User Agent string will be reduced.

      To fix this issue, replace the usage of navigator.userAgent, navigator.appVersion, and navigator.platform with feature detection, progressive enhancement, or migrate to navigator.userAgentData.

      Note that for performance reasons, only the first access to one of the properties is shown.

    2. BETROFFENE RESSOURCEN
      1. 1 Quelle
        1. hls.js@latest:1
      •  
        Weitere Informationen: Verringerung der User-Agent-Strings
  1.  
    5
    Indicate whether to send a cookie in a cross-site request by specifying its SameSite attribute
    1. Because a cookie’s SameSite attribute was not set or is invalid, it defaults to SameSite=Lax, which prevents the cookie from being sent in a cross-site request. This behavior protects user data from accidentally leaking to third parties and cross-site request forgery.

      Resolve this issue by updating the attributes of the cookie:

      • Specify SameSite=None and Secure if the cookie should be sent in cross-site requests. This enables third-party use.
      • Specify SameSite=Strict or SameSite=Lax if the cookie should not be sent in cross-site requests.
    2. BETROFFENE RESSOURCEN
      1. 5 Cookies
      •  
        Weitere Informationen: Erläuterungen zu SameSite-Cookies

 

 

Posted
22 hours ago, Eigeplackter said:

@VicMoore

Sorry but stress test failed, can the tool run into a timeout ?

Just came back and let script run while I was away, but the bar is still at 22% as it was 2 hrs ago.

I'll let it run over night, just to make sure, but there seems to be a limitating factor somehow.

Does the stress test tool have anything to do with how you will actually use this app?

Eigeplackter
Posted

Yup, I like add lots of tags kinda regulary.

CBS is „a monster“ but there are more i.e. Walt Disney with nearly 800, Netflix 750, so on and on.

  • Like 1
Posted (edited)

WOW Eigeplackter...  I have never encountered these errors before.  I will try to duplicate what's happening by adding a tag to several thousand media items. 

Is it possible that you maxed out your resources on your chrome browser?

Vic

Edited by VicMoore
Posted (edited)

I completely revamped the Collection and Playlist code. While in a playlist or Collection you can remove items directly. While in a media folder you can create a new collection or playlist or add selected items to an existing playlist or collection.

Vic

 

tool_2.2.zip

Edited by VicMoore
  • Like 1

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now
×
×
  • Create New...