BUG: Taglines for new titles missing since 4.6.3.0

[Happy2Play 9780]

Can you create a test library with a test folder and disable readers, and enabled TMDB for metadata and images.  Place a movie in this test folder.

Do you get tagline?

[Theodore 136]

@Happy2Play

With or without my XML source file?

[Happy2Play 9780]

2 minutes ago, Theodore said:

@Happy2Play

With or without my XML source file?

I would test with readers disabled, so you don't have to delete as Emby will not read it.

[Theodore 136]

@Happy2Play

With readers disabled, the test movies imported and show the taglines but of course everything else about it is wrong or incomplete.

[Happy2Play 9780]

Okay so we know TMDB is providing the info, just don't know why your it is not displaying with the plugin on your system.

For me the original plugin would show tagline as long as I had TMDB enabled.

With the updates I made it would read all three taglines with the plugin alone.

[Theodore 136]

34 minutes ago, Happy2Play said:

With the updates I made it would read all three taglines with the plugin alone.

So what are you saying? Y'all need to make a plugin update and push it out?

[Happy2Play 9780]

7 minutes ago, Theodore said:

So what are you saying? Y'all need to make a plugin update and push it out?

Well Luke will make changes as needed but pretty much has said it is a community plugin. 

Recap

original 4.6/4.7 does not populate tagline from xml, all providers disabled.  With TMDB metadata provider enabled it populates.

Adding L292 back allowed the subnode Tagline to work for me.

Adding the single node Tagline  worked for me.

But the question is still why it works for me and not you.  I have used your data and it worked for me.  Unless @Lukeknows of anything else.

Edited July 6, 2021 by Happy2Play

[Theodore 136]

6 minutes ago, Happy2Play said:

Well Luke will make changes as needed but pretty much has said it is a community plugin. 

 

Ok. Let me know when the plugin update has been made and I'll look to implement it right away.

[Happy2Play 9780]

@LukeThis will be a issue in the XMLMetadata plugin again.

I personally just added Taglines so it reads my subnode.

                case "TagLines":
                case "Taglines":
                    {
                        if (!reader.IsEmptyElement)
                        {
                            using (var subtree = reader.ReadSubtree())
                            {
                                await FetchFromTaglinesNode(subtree, item).ConfigureAwait(false);
                            }
                        }
                        else
                        {
                            await reader.ReadAsync().ConfigureAwait(false);
                        }
                        break;

As there is no single node read.

	<Tagline>No one comes up here without a damn good reason.</Tagline>
	<Taglines>
		<Tagline>No one comes up here without a damn good reason.</Tagline>
	</Taglines>

and/or adding the single node also.

                case "Tagline":
                case "TagLine":
                    {
                        var val = await reader.ReadElementContentAsStringAsync().ConfigureAwait(false);

                        if (!string.IsNullOrEmpty(val))
                        {
                            item.Tagline = val;
                        }
                        break;
                    }

As other manager does this.  Only difference is the single node TagLine.

  <TagLine>Face the evil.</TagLine>
  <Taglines>
    <Tagline>Face the evil.</Tagline>
  </Taglines>

 

[Luke 42078]

What software is even creating these xml files anymore?

[Happy2Play 9780]

1 minute ago, Luke said:

What software is even creating these xml files anymore?

I still use MediaCenterMaster, but OP is/was using  MetaBrowser.

[Theodore 136]

39 minutes ago, Happy2Play said:

I still use MediaCenterMaster, but OP is/was using  MetaBrowser.

I'm using a combination of both of those and a little personal intervention (because it is faster and easier).