Jump to content

4.6 Tagged collection not hidden on Movie Library Screen but IS correctly hidden in Collections screen


Go to solution Solved by ebr,

Recommended Posts

Diedrich
Posted (edited)

Use-case: user Diedrich has a parental restriction to not show any content with the tags ReeceOnly or TravisOnly. Two collections have tags - one with ReeceOnly and the other with TravisOnly. These two collections are correctly hidden while on the Collections screen. These two collections are incorrectly NOT hidden while on the main Movies library screen.

User Diedrich's parental settings

Screenshot_20210523-002012__01__01.thumb.jpg.b5288947c5703d9ae11110e3da6452aa.jpg

 

One of the collection's tags to restrict seeing this item by Diedrich

Screenshot_20210523-001948__01__01.thumb.jpg.914c47bee0eb779424869137417a8bf7.jpg

 

Two tagged collections are CORRECTLY being hidden from Diedrich while on the Collections screen

Screenshot_20210523-002822__01__01.thumb.jpg.f5e2e2345f646030e592979cd3a80699.jpg

 

Two tagged collections are INCORRECTLY NOT hidden from Diedrich while on the main Movies library.

Screenshot_20210523-001847__01__01.thumb.jpg.dc63565cabbdf309c2d716358e9c7cb8.jpg

Emby2021-05-23 00-01-03.txt

Edited by Diedrich
Carlo
Posted

Thanks for reporting that.

Posted

Hi.  As a general rule, the visibility of collections is determined by the visibility of their contents.  Is that the difference in the two situations for you?  IOW - the one that doesn't show has contents that are also not visible via parental controls or other permissions?

Diedrich
Posted (edited)
3 hours ago, ebr said:

Hi.  As a general rule, the visibility of collections is determined by the visibility of their contents.  Is that the difference in the two situations for you?  IOW - the one that doesn't show has contents that are also not visible via parental controls or other permissions?

No, sir. Everything in Reece's collection (my son) is a G or PG movie and none of those are tagged with restrictions. I can see Reece's Movies collection and its contents in the movies library, but because the Reece's Movies collection is tagged, I can't see the collection nor its contents in the Collection Screen.

On the other hand, a few of Travis's movies are tagged so that I can't see them and this is correctly hiding them within the collection. The case still stands though that the tagged collection is visible in the movies library when it shouldn't and it IS correctly being hidden on the Collections Screen

Edited by Diedrich
  • Solution
Posted
5 minutes ago, Diedrich said:

The case still stands though that the tagged collection is visible in the movies library when it shouldn't

Again, I don't think the tag on the collection is going to make a difference there because the visibility of the collection should be determined by its contents but Luke will need to confirm.

Diedrich
Posted
4 minutes ago, ebr said:

Again, I don't think the tag on the collection is going to make a difference there because the visibility of the collection should be determined by its contents but Luke will need to confirm.

You are exactly right. I just did a test where I made all remaining movies in Travis's collection to be hidden from me. I no longer see his collection on the Movies Library Screen. Thanks for the solution.

This brings up a question though; even if the contents of a collection are not tagged, shouldn't the parent item (in this case a collection) take precedence over child items?

Carlo
Posted

Not if you consider a Collection to be virtual.  But in that case you also should not be able to apply a tag to it.
So it should be a bit more consistent.

Gilgamesh_48
Posted
59 minutes ago, ebr said:

Again, I don't think the tag on the collection is going to make a difference there because the visibility of the collection should be determined by its contents but Luke will need to confirm.

I STRONGLY disagree with the idea that a collection's contents should ever determine its visibility for a given user. The purpose of tags is to give people the ability to hide or show objects based on tagging and there are many reasons why I might want to hid a entire collection from some users and not from others. While that works for individual items it should also work for collections because, if for no other reason, it makes organization much easier.

But, as I have said before when we have had disagreements about "how" something "should" function, it is your software so you will never be wrong even when you might be a little short of being right. ;) 

Tagging a collection as "hidden" (blocked for a given user,) should always hide that entire collection from that user.

  • Like 1
Carlo
Posted

Not saying I agree with you or not, but this is a great line:

"it is your software so you will never be wrong even when you might be a little short of being right."

Posted
6 hours ago, Gilgamesh_48 said:

I might want to hid a entire collection from some users and not from others

But what does it mean when you "hide" a collection but not the contents?  Because the contents would still be visible individually.  That is why the visibility is determined by the contents.

Gilgamesh_48
Posted
34 minutes ago, ebr said:

But what does it mean when you "hide" a collection but not the contents?  Because the contents would still be visible individually.  That is why the visibility is determined by the contents.

We've been through this before. It is mainly for ease of browsing but you are absolutely sure you are right so I can never change your mind so I gave up over a year ago.

And, as I have said before, it is your software and the users do not matter. Particularly if the users want to use Emby in a non standard manner.

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now
×
×
  • Create New...