Titan skin

[saitoh183 137]

Aha, after long searching I found a little bug that was causing this. Fixed it and will provide a new beta later today.

If you allready would like to test it, please overwrite the attached "includesvariables.xml" file in c:\users\username\appdata\kodi\addons\skin.titan.beta\1080i

 

Close xbmc/kodi before overwriting the file.

 

IncludesVariables.xml

 

Yup everything seems in order now..thank you

[marcelveldt 736]

Okay, still totally confused by the percentage thing.  The only thing we have ever set AFAIK is:

list.setProperty("complete_percentage", str(cappedPercentage))  

That is from the 'old' code.  I am setting the same thing in the new code, and it looks to be working fine in Aeon Nox:

 

 

I can certainly set a NEW property called PercentPlayed - but I am really confused as to why it worked before.  It works with 'Fast' disabled?

 

Thanks,

xnappo

Id did a quick check in my skin's code and you're right... For XBMB3C addon something is different:

<value condition="ListItem.IsResumable + !Skin.HasSetting(HideWatchedCounts) + !StringCompare(ListItem.Overlay,OverlayWatched.png) + substring(Container.FolderPath,plugin://plugin.video.xbmb3c)">$INFO[ListItem.Property(complete_percentage)]%</value>
		<value condition="ListItem.IsResumable + !Skin.HasSetting(HideWatchedCounts) + !StringCompare(ListItem.Overlay,OverlayWatched.png)">$INFO[ListItem.PercentPlayed]%</value>

So, it is indeed the property complete_percentage, but that isn;t working with fast enabled, with fast disabled it's working fine.

Also wondering... why isn't the regular Listitem.PercentPlayed working in the first place ?

[marcelveldt 736]

Yup everything seems in order now..thank you

Great! Another thing to check off my list then

Thanks for reporting back and testing.

I'll include this in tonight's skin update.

[xnappo 1611]

I just checked in a change to the Git that might fix it.  I took a look at the XBMC source code (yikes!) and it has a pretty complicated routine to set it with a lot of dependencies.  It isn't something we can set directly from the Python API.

  case LISTITEM_PERCENT_PLAYED:
    if (item->IsFileItem() && ((const CFileItem *)item)->HasVideoInfoTag() && ((const CFileItem *)item)->GetVideoInfoTag()->m_resumePoint.IsPartWay())
      value = (int)(100 * ((const CFileItem *)item)->GetVideoInfoTag()->m_resumePoint.timeInSeconds / ((const CFileItem *)item)->GetVideoInfoTag()->m_resumePoint.totalTimeInSeconds);
    else if (item->IsFileItem() && ((const CFileItem *)item)->HasPVRRecordingInfoTag() && ((const CFileItem *)item)->GetPVRRecordingInfoTag()->m_resumePoint.IsPartWay())
      value = (int)(100 * ((const CFileItem *)item)->GetPVRRecordingInfoTag()->m_resumePoint.timeInSeconds / ((const CFileItem *)item)->GetPVRRecordingInfoTag()->m_resumePoint.totalTimeInSeconds);
    else
      value = 0;
    return true;
  }

But still don't get why complete_percent doesn't work for you with 'Fast' enabled!

 

xnappo

Edited December 30, 2014 by xnappo

[marcelveldt 736]

I just checked in a change to the Git that might fix it.  I took a look at the XBMC source code (yikes!) and it has a pretty complicated routine to set it with a lot of dependencies.  It isn't something we can set directly from the Python API.

But still don't get why complete_percent doesn't work for you with 'Fast' enabled!

 

xnappo

Thanks for looking at this.

BTW: the example of Aeon Nox you've send is not displaying the ResumePercentage from it's property, it's just added into the title itself by the addon (is somewehere in the addon settings). In my skin (and most others) you can have an overlay over the posters/images with unwatched items, percentage played etc.

 

ListItem.Property(complete_percentage) is still empty with your fix but now the regular ListItem.PercentPlayed seems to be working

One minor detail is that the percentage differs from what is added to the title

 

Edited December 30, 2014 by marcelveldt

[saitoh183 137]

A few new issues...

 

First, isnt Skin shortcut suppose to run when you add/remove widgets from tiles?

 

When i remove the widget from my MB tiles it works but i dont see the skin shortcut run(like when you add a tile). But when i want to do the same for my Favorite Tv show /movies tiles, the widget still remains (change/remove widget). This is also true for the place holder tile i made which seems to associate the widget of last tile created.

 

Secondly, When browsing items to add a new tile, under Tv Show and Movies the favorite TVshow/movies appear twice. If you add any of them, they will have the widget that i cant change or remove

 

Also on a side note, In the TV widget, In progress shows Up Next content instead of Resume content. I dont know which you were intending, but that would need to be fixed.

Edited December 30, 2014 by saitoh183

[xnappo 1611]

Well, Aeon Nox uses both:

 

The title is the string, the little circle, and the upper right are from properties.

 

What I am seeing now is actually a bug with the text mode with Fast OFF (which I can fix) and that the text version is mod 10 for some reason.

 

But now that I look, Nox was always using PercentPlayed, not complete_percent.  

 

Still confused

Edited December 30, 2014 by xnappo

[marcelveldt 736]

A few new issues...

 

First, isnt Skin shortcut suppose to run when you add/remove widgets from tiles?

 

When i remove the widget from my MB tiles it works but i dont see the skin shortcut run(like when you add a tile). But when i want to do the same for my Favorite Tv show /movies tiles, the widget still remains (change/remove widget). This is also true for the place holder tile i made which seems to associate the widget of last tile created.

 

Secondly, When browsing items to add a new tile, under Tv Show and Movies the favorite TVshow/movies appear twice. If you add any of them, they will have the widget that i cant change or remove

 

Also on a side note, In the TV widget, In progress shows Up Next content instead of Resume content. I dont know which you were intending, but that would need to be fixed.

1. The skinshortcuts is now so fast that you don't even see it running anymore ;-)

 

2. I fixed some issues with the widgets today on Git but not yest pushed them to the repo, this should be all fixed with new beta version.

 

3. The current default for "in progress tvshows" is that it shows "next up" items, which also contains the in progress items.

Do you think this should be a setting in the skin or addon ?

[marcelveldt 736]

Well, Aeon Nox uses both:

 

The title is the string, the little circle, and the upper right are from properties.

 

What I am seeing now is actually a bug with the text mode with Fast OFF (which I can fix) and that the text version is mod 10 for some reason.

 

But now that I look, Nox was always using PercentPlayed, not complete_percent.  

 

Still confused

I have no idea why I was using complete percent in the first place... Maybe this was some old stuff that wasn't working before ?

I switched to PercentPlayed now (if present). Let me know if I have to test something

[saitoh183 137]

1. The skinshortcuts is now so fast that you don't even see it running anymore ;-)

 

2. I fixed some issues with the widgets today on Git but not yest pushed them to the repo, this should be all fixed with new beta version.

 

3. The current default for "in progress tvshows" is that it shows "next up" items, which also contains the in progress items.

Do you think this should be a setting in the skin or addon ?

 

1 - Dammmmmnnn....lol

 

2 - Cool, will wait to see if the issues are corrected

 

3 - But when you enter the submenu item  In progress, it only shows resume content...which is what we should also see in the widget. Next up should be on its own. They arent all together in the webUI so it shouldnt be in the widget either. As for skin or addon, if it plagues other skins as well, then it should be the addon i guess.

[xnappo 1611]

Thanks for your help marcel.  I think I have everything fixed except in progress episodes for both fast and slow.  Can you check the Git?

[marcelveldt 736]

Thanks for your help marcel.  I think I have everything fixed except in progress episodes for both fast and slow.  Can you check the Git?

Everything is fixed now   :)  

[pünktchen 1409]

Any reason why the certification logos (German FSK) are that big in the facade views?

Edited December 30, 2014 by pünktchen

[marcelveldt 736]

Any reason why the certification logos (German FSK) are that big in the facade views?

No, they should be small... possible to send a screenshot to explain what you mean and where it happens ?

[saitoh183 137]

@@marcelveldt

 

Got some new problems. I decided to switch my wife's profile over to titan and its a bit of a mess.

 

I added Favorite Tv Shows, renamed it to My TV. Then i added submenu items, Kids-TV (it's its own node in MBS), Tv Shows (renamed to All Tvshows). Every time i enter Kids-TV or All TvShows, I get the content of Favorite TV Shows.

For movies its the same problem. 

 

Log: http://pastebin.com/QtffXQPg

 

Then i switched over to my Master profile and the tiles images are not right..Kids-Movies shows images from the Movies tiles, Anime is showing images of the Kids tiles. Eventually things place themselves on there own but i suspect which every part of the addon that is in charge of this , has a hard time dealing with profile switching, This issue is minor since after awhile the tiles show the proper image but i just wanted to point it out.

 

Log: http://pastebin.com/YhztGbHU

 

When i switch back to my wife profile, for some reason the Tv Show default tile reappeared as well (havent tested doing the switch profile back and forth a second time.yet)

[saitoh183 137]

@@marcelveldt

 

Got some new problems. I decided to switch my wife's profile over to titan and its a bit of a mess.

 

I added Favorite Tv Shows, renamed it to My TV. Then i added submenu items, Kids-TV (it's its own node in MBS), Tv Shows (renamed to All Tvshows). Every time i enter Kids-TV or All TvShows, I get the content of Favorite TV Shows.

For movies its the same problem. 

 

Log: http://pastebin.com/QtffXQPg

 

 

Did another test and it seems that the problem is only when you add any MB category as submenu item of Favorite Show/movies, they will all shows the content of favorites.

 

If i add the submenu item via Video Library>Video-Addon>MediaBrowser>Tv Show... That works but adding via Mediabrowser Collection doesnt.

Edited December 31, 2014 by saitoh183

[marcelveldt 736]

Did another test and it seems that the problem is only when you add any MB category as submenu item of Favorite Show/movies, they will all shows the content of favorites.

 

If i add the submenu item via Video Library>Video-Addon>MediaBrowser>Tv Show... That works but adding via Mediabrowser Collection doesnt.

Hi saitoh,

Thank you for testing and reporting these issues. I'm going to take a look at this next hour and report back to you.

So, to reproduce I should add a tile to Favourite TV shows on home with a submenu ? In the submenu I have to add some other MB3 collections ?

 

Did your problem with the user switching dissapear after a while ? Does it not happen again now ?

[marcelveldt 736]

New version pushed to the official kodi repo and will be available within the next few days:

 

Version 2.2.21 for Gotham
Version 3.2.21 for Helix

 

- Speed improvements
- Some fixes to the touchscreen support
- Improved widget assigment
- Various graphical and aligment fixes
- New views: Big List and Low List
- New appearance settings to further customize the look and feel

 

New features will be (as usual) added to the beta version first.

 

Thanks everyone for the great feedback and extensive usertesting.
 

Another great stable release of the skin just in time for 2014.
More great updates to come in 2015.

 

I wish you all a very good/happy new year's eve.

 

Marcel

Edited December 31, 2014 by marcelveldt

[saitoh183 137]

Hi saitoh,

Thank you for testing and reporting these issues. I'm going to take a look at this next hour and report back to you.

So, to reproduce I should add a tile to Favourite TV shows on home with a submenu ? In the submenu I have to add some other MB3 collections ?

 

 

Correct

 

 

Did your problem with the user switching dissapear after a while ? Does it not happen again now ?

 

The tiles still arent proper when switching to the master profile but just have to wait for the rotation to place itself and it comes back.

 

BTW, did you fix the widget issue yet cuz i still cant remove or change widgets from Favorite Shows/movies 

[saitoh183 137]

 

BTW, did you fix the widget issue yet cuz i still cant remove or change widgets from Favorite Shows/movies 

 

Will try the new version

[marcelveldt 736]

Correct

 

The tiles still arent proper when switching to the master profile but just have to wait for the rotation to place itself and it comes back.

 

BTW, did you fix the widget issue yet cuz i still cant remove or change widgets from Favorite Shows/movies 

It's an issue with the MB3 addon and profile switching. It takes about 5 minutes before the addon "knows" that you switched user before it will correct the menuitems etc.

We will definitely look at this, see this thread: http://mediabrowser.tv/community/index.php?/topic/12087-kodi-beta-version-discussion-thread/page-15&do=findComment&comment=161979

 

I fixed the widget issue in new skin version 3.2.21... Please try it out.

[saitoh183 137]

It's an issue with the MB3 addon and profile switching. It takes about 5 minutes before the addon "knows" that you switched user before it will correct the menuitems etc.

We will definitely look at this, see this thread: http://mediabrowser.tv/community/index.php?/topic/12087-kodi-beta-version-discussion-thread/page-15&do=findComment&comment=161979

 

I fixed the widget issue in new skin version 3.2.21... Please try it out.

 

Favorite TVshow still appears twice under Tvshow when looking to select it to make a tile. Widget sill doesnt work...i re-added Favorite TV show, select None for widget and it still creates a widget on main menu. I noticed that it None seems to equal Favorite Tv show content as widget. Because im able to change the widget but selecting None with put the favorite TV show list as widget. Same problem with Favorite Movies.

[saitoh183 137]

A cosmetic request:

 

Could you add lighter colors in the textcolor for headers. your shadow colors are all dark so none of the textcolors complement. except white...the rest are not readable. This is especially true when you have no background overlay.

Edited December 31, 2014 by saitoh183

[marcelveldt 736]

Favorite TVshow still appears twice under Tvshow when looking to select it to make a tile. Widget sill doesnt work...i re-added Favorite TV show, select None for widget and it still creates a widget on main menu. I noticed that it None seems to equal Favorite Tv show content as widget. Because im able to change the widget but selecting None with put the favorite TV show list as widget. Same problem with Favorite Movies.

Something seems to be messed up in your setup...

 

Maybe you could try to do the following:

Edit guisettings.xml file in texteditor for every xbmc profile (which has the problem).

Remove all references to skin.titan.beta in it.

The lines look like this:

 <setting type="string" name="skin.titan.widget-31157">custom</setting>

That way the skin is reset to defaults...

 

Another thing you could try to do is reset the menu items to defaults with the reset button for that in skin settings

[marcelveldt 736]

A cosmetic request:

 

Could you add lighter colors in the textcolor for headers. your shadow colors are all dark so none of the textcolors complement. except white...the rest are not readable. This is especially true when you have no background overlay.

good one, will add that to my list. Any ideas for colors ?