embyforkodi (next-gen) 6.X.X support

[quickmic 1703]

8 hours ago, pettergulbra said:

HI, I'll try to explain

Yes, I use Emby playlists. Made in Emby web.

When I open the playlist I have made widgets in my skin, but its the same as this: Add-ons >Video add-ons > Emby-Next-gen > Playlists (server) > My playlists

And if I go that way, it's the same as trough my widgets. Start's loading then jumps back. One of the list's is opening.

I can also send log, but there are so much tokens and stuff from Kodi log so I don't know is it safe? But can send it another way than pastebin.

I think there is a problem with music playlists, not with video playlists. I'll have a look.

[quickmic 1703]

4 hours ago, jonomite said:

I wanted to report that I managed to fix this issue by going to my server dashboard and manually deleting the associated device (from the device menu). After deleting the device, I started up Kodi, logged into e4k nex gen, and I am now seeing full remote controls. Interestingly, I tried numerous times to generate a new device ID in the e4k next gen settings menu, but that never seemed to work, and I'm not sure whether it actually did or did not generate a new device ID. Ultimately I had to go into my server dashboard and delete the device.  

Very good and makes sense to me, but strange why a new device ID could not be generated via plugin. I'll check it again.

[embyL0VER 71]

7 hours ago, quickmic said:

Very good and makes sense to me, but strange why a new device ID could not be generated via plugin. I'll check it again.

I can confirm jonomites experience. And I have recognized that the device was still listed with "Kodi 6.2.5" in the name.

After removing it from associated devices and a newly Kodi login, the device is correctly listed as "emby-next-gen 6.2.5".

So I think this problem doesn't occur for completely fresh setups but only for setups which are continuously updating emby-next-gen after you have made the change for the correct naming of the plugin itself.

EDIT: Also after doing this, now sending a message from the webgui to Kodi is working again. So it wasn't a network or real websocket issue.

Edited January 5, 2022 by embyL0VER

[SwanStream 64]

On 1/4/2022 at 7:04 AM, quickmic said:

add support for Kodi delete function @SwanStream please perform a test

Rock on dude, delete is now deleting! Thanks again for the support.

I wonder if it really needs to be a two step process tho? Can't there just be a setting in the add-in, under advanced maybe, defaulted to 'no', that asks "also delete the file upon delete request".... just an idea.

Edited January 6, 2022 by SwanStream

[quickmic 1703]

14 hours ago, SwanStream said:

Rock on dude, delete is now deleting! Thanks again for the support.

I wonder if it really needs to be a two step process tho? Can't there just be a setting in the add-in, under advanced maybe, defaulted to 'no', that asks "also delete the file upon delete request".... just an idea.

Yes, I can add a settings option. Must be serious warning there. Unless Kodi, the Emby-server-delete function removes the files too. Very dangerous to delete something accidentally.

[Junias 9]

On 12/23/2021 at 12:25 PM, quickmic said:

Please try this debug version attached:

 

Actually I try to make it thread save, there is a problem in some scenarios were Kodi crashes.

In my test setup Kodi crashes (only Kodi 18) and when library sync is running and external updates are incoming. Like playback progress updates from other boxes. Or change of watched content etc.

 

Somebody: Please try this version under Windows. I'm not sure if the method I used as a fix is working under Windows as well.

Just install, run and report if an error appears. This will be the next beta version which will be uploaded in Emby's Kodi beta repo.

 

plugin.video.emby-next-gen-6.2.4-build 8 (ex2) - thread and artwork.zip 1.3 MB · 5 downloads

 

Sorry, I was on holiday the last few days

I can try this version
Does it comes up with new Kodi Library sync?

Edited January 7, 2022 by Junias

[quickmic 1703]

53 minutes ago, Junias said:

 

Sorry, I was on holiday the last few days

I can try this version
Does it comes up with new Kodi Library sync?

No problem, use the latest beta from Emby's Kodi repo.

No need to resync.

[SwanStream 64]

14 hours ago, quickmic said:

Yes, I can add a settings option. Must be serious warning there. Unless Kodi, the Emby-server-delete function removes the files too. Very dangerous to delete something accidentally.

Agreed, very easy to do what can't be undone. There is a clear warning on the process as is, so it seems a similar one time pop-up in the settings would be enough... there is also that initial "are u sure" in kodi when deleting the entry, so if ur sure, your sure... gotta take responsibility for our own actions at some point, no?

Thanks for considering!

[jaybird2203 23]

1 hour ago, SwanStream said:

Agreed, very easy to do what can't be undone. There is a clear warning on the process as is, so it seems a similar one time pop-up in the settings would be enough... there is also that initial "are u sure" in kodi when deleting the entry, so if ur sure, your sure... gotta take responsibility for our own actions at some point, no?

Thanks for considering!

Also have to consider the accidental key presses...its not like no one has ever had hardware fail or a remote send additional keypresses before.

In my mind any clients should be a read only type scenario but we also have the ability to prevent the clients from file deletion being an option in the first place on the server side so the real question is, how much fire do you feel comfortable playing with to save a few clicks?

[misterkoat 6]

Anyone experiencing a problem with music where some albums will show up in kodi library but have no songs or not show up entirely?

[SwanStream 64]

22 hours ago, jaybird2203 said:

In my mind any clients should be a read only type scenario

Are you suggesting that because you feel that way we all have to??

 

[djhifi 56]

Hello there @quickmic I noticed the 6.2.4 version was not triggering the Incremental Sync so I updated to 6.2.5 and when I manually reset the library the progress bar seems to be frozen at

167672:EMBY:MOVIE - 3%

and

DELETE KODI-MUSIC DATABASE: BOOKMARK: EMBY - 6%

It constantly alternates between these 2. And doesn't do anything else.

First time this ever happened to me.

I've tried a number of things:

choosing "YES" to also clear Addon Settings

manually deleting Myvideo.db  via SMB share

nothing seems to work

I will try to manually delete a few things more and retry.

I'm out of ideas

EDIT: Found the fix

SOLUTION FOR PEOPLE THAT MAY HAVE THIS ISSUE IN THE FUTURE:

It proceeded with the database reset via the addon context menu after manually deleting "Thumbnails" folder, Emby.db and Myvideos.db 

And also choosing yes in the "reset database" to everything (artwork, settings, etc)

Wierdest thing ever that ever happened 

Edited January 9, 2022 by djhifi

[djhifi 56]

In the follow up to my previous post, wow, did you do anything on 6.2.5?

After resetting the database, it usually takes 2 hours to scan my entire database (11k Movies 2k TV Shows) using Native mode (direct path).

And now it just took 35minutes and everything seems to be in order.

I had to double check

WTF? Loving this!

Or did the factthat  I removed everything and started almost from scratch had to do with this?

[jonomite 29]

I've also noticed that the time it takes to do a full library sync has significantly decreased. Absolutely breathtaking! 

[quickmic 1703]

Yes, the sync was optimized in one of the previous versions. Some internal Kodi database queries were very "slow". Just off by a few milliseconds but this sums up on initial sync when it's looped 10.000 or even 100.000 thousands of times. The people (artist etc) sync was case insensitive. Not really necessary and delayed the sync dramatically.

[djhifi 56]

23 hours ago, quickmic said:

Yes, the sync was optimized in one of the previous versions. Some internal Kodi database queries were very "slow". Just off by a few milliseconds but this sums up on initial sync when it's looped 10.000 or even 100.000 thousands of times. The people (artist etc) sync was case insensitive. Not really necessary and delayed the sync dramatically.

Great, I thought so. Good work!

But bad news...the problem is happening again.

6.2.5 not doing incremental syncs for new content and resetting the database via the addon is not working, keeps brings the popups (which freeze)

(random number):EMBY:MOVIE - 5%

and

DELETE KODI-MUSIC DATABASE: BOOKMARK: EMBY - 3%

And doesn't move from there. I was trying to reset the database using the addon to see if it somehow fixed the Incremental Sync not working

I thought it was fixed with my previous post, seems not.

I'm out of ideas

I've attached the log this time

kodi.log

Edited January 10, 2022 by djhifi

[quickmic 1703]

17 minutes ago, djhifi said:

Great, I thought so. Good work!

But bad news...the problem is happening again.

6.2.5 not doing incremental syncs for new content and resetting the database via the addon is not working, keeps brings the popups (which freeze)

(random number):EMBY:MOVIE - 5%

and

DELETE KODI-MUSIC DATABASE: BOOKMARK: EMBY - 3%

And doesn't move from there. I was trying to reset the database using the addon to see if it somehow fixed the Incremental Sync not working

I thought it was fixed with my previous post, seems not.

I'm out of ideas

I've attached the log this time

kodi.log 88.46 kB · 0 downloads

I'll check that. Still a problem when removing items. Can you send me your databases via PM? "/userdata/Database/*"

 

[djhifi 56]

34 minutes ago, quickmic said:

I'll check that. Still a problem when removing items. Can you send me your databases via PM? "/userdata/Database/*"

 

I just deleted everything using the method I described in the "fix" post, let the scan finish and sure I will.

What's bothering me is not the removal, because I can tell there's something going on (i.e. unfinished in the code) what's bothering me is the fact the addon suddenly stopped doing incremental syncs (which then led me to the removal issue).

Can all this be due to the changes you made in the speed-up of the initial sync?

 

 

EDIT: DONE, check your Inbox 

Edited January 10, 2022 by djhifi

[quickmic 1703]

2 hours ago, djhifi said:

I just deleted everything using the method I described in the "fix" post, let the scan finish and sure I will.

What's bothering me is not the removal, because I can tell there's something going on (i.e. unfinished in the code) what's bothering me is the fact the addon suddenly stopped doing incremental syncs (which then led me to the removal issue).

Can all this be due to the changes you made in the speed-up of the initial sync?

 

 

EDIT: DONE, check your Inbox 

Thanks, will check.

No this has nothing todo with the performance improvement. Emby server reported a file/folder to be deleted and for some reason that crashed. Could be the item was already delete, or it was never synced in the first place and removve-request should be ignored etc.

I could easily write a "fix" ignoring the remove request in such a case but I wanna check what's the actual cause. Therefore I'll review your database...

[quickmic 1703]

9 hours ago, djhifi said:

addon suddenly stopped doing incremental syncs

Well, remove requests are part of the incremental sync. So it's logical that from this point, nothing will be synced any longer cause it crashed.

Edited January 10, 2022 by quickmic

[quickmic 1703]

On 1/6/2022 at 4:42 PM, SwanStream said:

Rock on dude, delete is now deleting! Thanks again for the support.

I wonder if it really needs to be a two step process tho? Can't there just be a setting in the add-in, under advanced maybe, defaulted to 'no', that asks "also delete the file upon delete request".... just an idea.

I checked, yes I keep it as it is. It's way too dangerous without the extra notification. Let me explain. The plugin captures remove notifications from Kodi. You assume this will only be trigger by pressing the delete button but it's not. e.g. a clear library command in Kodi wipes the complete (Kodi) database.

With just a toggle option in plugin config settings , this would also wipe ALL FILES on Emby server without questioning. Also 3rd party plugins could initialize a (Kodi) database wipe. I don't wanna be responsible for that. You can use a custom key with a delete command (single confirmation), but I'll not capture the internal Kodi (delete) events without additional (manual) confirmation. Actually, I'm thinking about a toggle option in settings menu to disable this function by default. But even if enabled, the popup will stay.

Edited January 10, 2022 by quickmic

[SwanStream 64]

Asked and answered. O.K.

Nother question - I have shows that have multiple versions of the same episode. In emby I can either leave it listed as one with a drop down to select which version I want to see, or I can tell emby to split the files to separate items. Emby then lists them separately, but with the same episode #, using other naming info from fe name to differentiate. I'd like that to carry over to kodi if possible. There is a pop-up asking which file, but its hard to identify at times. Would be easier if the split carried over. Is that possible?

If you're not familiar, you can name any old file with the same episode # drop it in the appropriate directory, and as long as the file name includes some other info at end that will be used to uniquely identify it. Then u can use an emby app to drill down and you should see it her a pull down or lower down an optIon to split the files. I.e. ABC - S01E01 - live.mkv and ABC - S01E01 - studio.mkv would do the trick....

Cheers and thx for considering!

[djhifi 56]

13 hours ago, quickmic said:

Well, remove requests are part of the incremental sync. So it's logical that from this point, nothing will be synced any longer cause it crashed.

Ok now that you explained it I understood.

(both posts that you made)

Just sent you the rest of the .db files you requested

PS: "Could be the item was already delete, or it was never synced in the first place and removve-request should be ignored etc."

If you could inform me what was (were) the item(s) when you review my .db I would be grateful.

Because I'm indeed removing some movies and shows from my server (exchanging from x264 to x265 to save space).

Edited January 11, 2022 by djhifi

[Guest worthington_j]

I noticed with 6.2.5 in List View the TV Shows have the fanart as the season folder icon instead of the poster.I downgraded back to 6.2.4 and reset my database and it displays correctly.

[kononvaler 0]

Deleted

Edited January 11, 2022 by kononvaler