Allow windows service to keep deleted items in recycling bin

[MBSki 1114]

Last time I tried the windows service, the issue was that if you deleted something accidentally, it was gone and there was no way to get it back from the recycling bin. Can the service be configured to allow saving deleted items in the recycling bin? 

[Luke 42078]

Hi, have you tried again?

[MBSki 1114]

1 hour ago, Luke said:

Hi, have you tried again?

No, I'm afraid to. Are you saying the service now saves the deleted items in the recycling bin?

[Carlo 4561]

You can also check out the Safe Delete plugin as well.

[MBSki 1114]

17 minutes ago, cayars said:

You can also check out the Safe Delete plugin as well.

@cayars Thanks, checked it out but it's pretty limited. Are you running the nssm service? Do you know if it keeps the file in the recycling bin or does it permanently delete still? Doesn't look like the service has changed at all in 6 years. 

[Carlo 4561]

I've not used it just wanted to mention that it's in the catalog.  It's rare for me to delete stuff from my system.

[Luke 42078]

22 hours ago, mbarylski said:

No, I'm afraid to. Are you saying the service now saves the deleted items in the recycling bin?

To be honest I don't recall the details, so I guess I would say that I'm not aware of anything specifically.

[MBSki 1114]

@Luke Ok, that means there's been no change and it still permanently deletes items. The service hasn't been updated for 6 years.

So, I guess this is still a feature request. Maybe Emby could use a different method for implementing as a service since nssm is so old and outdated?

[Luke 42078]

No that means it should work the same way as running the server as an application.

Of course it's possible there's always an issue, like maybe we're using a windows api that only works when the desktop shell is up. But I'm currently not aware of any such issue with the delete function.

[MBSki 1114]

10 minutes ago, Luke said:

No that means it should work the same way as running the server as an application.

Of course it's possible there's always an issue, like maybe we're using a windows api that only works when the desktop shell is up. But I'm currently not aware of any such issue with the delete function.

Well, in April 2019 you specifically stated that when using the windows service, files would immediately be deleted and would NOT go to the recycling bin. 

So, why isn't this a feature request? There's no indication from the versions since April 2019 that something was changed to fix the issue with the windows service doing a straight delete.

[Carlo 4561]

It's highly likely this isn't something that can be done easily.  Not all files that you delete in Windows go to the Recycle Bin when you delete them.  There are 3 or 4 exceptions to this.

First, only files deleted from fixed disks are sent to the Recycle Bin. Files deleted from removable media, such as memory cards, USB/jump/flash drives, external hard drives connected via USB, and floppy disks, are not sent to the Recyle Bin, but are instead permanently deleted. Also, files deleted from within the Windows command prompt are not sent to the Recycle Bin and are instead deleted immediately.

Additionally, the Recycle Bin has a maximum amount of data that it will hold.  Once that space is filled, the oldest files will automatically be deleted to make room for new files as they are moved to the Recycle Bin.   Files of a certain size are never sent to the recycle bin.

Programs not running on the desktop can usually not send files to the recycle bin as well.

The recycle bin on Windows has lots of quirks to say the least.

[Luke 42078]

Ok I forgot about that, sorry. It must be using a windows api that requires the desktop shell.

[MBSki 1114]

@Luke No problem, it was a long time ago. Does that mean we would need a different service "wrapper" to be able to implement this properly?

[Luke 42078]

No that won't make any difference.

[MBSki 1114]

Ok, well, I guess it's just a feature request then and I'll have to wait and see if someone likes the idea. Or, maybe someone will write their own service.

[Luke 42078]

Again the problem isn't the service, it's likely the way the delete is being done.

[MBSki 1114]

So, I'm not a dev so I don't know what's supposed to happen to get this to work. All I know is that a dev created a service for Plex that works fine. I'd like the same for Emby. Doesn't matter to me how it gets done or what the issue is.

If it's "how the delete is being done", it seems to me that it's an update the Emby devs would have to make, but like I said, I don't know and would just like it to work.