Device Images on Dashboard

[adminExitium 355]

Can we have the device images on the dashboard fetched from a CDN instead of GitHub directly? The current method has a flaw in that it depends on the GitHub page loading without issues. The current method failed for me today since GitHub was presenting me with a security prompt before allowing me to access the site.

 

Emby Server Version: 3.5.3.0

[Luke 42078]

Even for an  https image url? What was the prompt about?

[adminExitium 355]

This was a basic security prompt by Github regarding verification of the current account information.

[Carlo 4561]

Can you post a screen shot of this the next time you see it along with the server log?

[adminExitium 355]

Will do, but I am not sure how the server logs will help?

 

All that is requested is done on the client side (the web app, in my case) and that was simply because Github started prompting me to review my account/security settings before redirecting to the actually requested url.

[Luke 42078]

Right, don't need server logs but a screenshot would be great. Thanks.

[adminExitium 355]

Will try, but I am not sure when (or if) it will prompt me with that screen again.

 

I was just checking the source and saw that the github url is used directly. Wouldn't it be better to use the raw urls instead, since that is what they are redirected to anyway?

 

Source URL in the JS: 

https://github.com/MediaBrowser/Emby.Resources/raw/master/images/devices/chrome.png

Actual URL after a redirect:

https://raw.githubusercontent.com/MediaBrowser/Emby.Resources/master/images/devices/chrome.png

Edited January 22, 2019 by adminExitium

[Luke 42078]

I thought we were, but yes you are right. thanks !

[Luke 42078]

Actually the url we're using is the same one you get from the download button:

 

https://github.com/MediaBrowser/Emby.Resources/blob/master/images/devices/chrome.png

That url redirects but I'm not really sure we should just go ahead and use the redirected url.

[adminExitium 355]

We have a few options:

 

1. Use the GitHub URLs as-is with the caveat that issues like above can result in the site not loading.

2. Use the raw.github URLs with the drawback that the content-type is returned as "text/plain" for most content barring a few exceptions (like png, ico etc.) according to this https://github.com/rgrove/rawgit/blob/df9a6d00f40bacb9a5a3e07d99d3785d3327c2f8/conf/index.js#L28-L48

3. Use GitHub backed CDNs like https://raw.githack.com/ or https://gitcdn.xyz/

4. Setup a CloudFlare Proxied Server for the images

Edited January 22, 2019 by adminExitium

[Luke 42078]

I'd still like to see the prompt you are getting. thanks.

[adminExitium 355]

I found a sample screenshot for the prompt: https://sdtimes.com/wp-content/uploads/2018/08/checkup.png from this article: https://sdtimes.com/security/github-announces-new-account-security-and-recovery-practices/.

 

Probably showed up due to the recent breach announcement from HaveIBeenPawned.

Edited January 22, 2019 by adminExitium

[Luke 42078]

Alright i have no problem making changes but i will need to see this happen first, or see  more corroborating reports from other users. I will monitor this. Thanks.

[adminExitium 355]

Some more discrepancies:

 

* EmbyCon uses the icon from a third-party user repo instead of the main repo and uses the raw URL directly: https://raw.githubusercontent.com/faush01/plugin.video.embycon/develop/kodi.png

 

* Emby for Kodi also uses the icon from the kodi plugin repo and uses the raw URL too: https://raw.githubusercontent.com/MediaBrowser/plugin.video.emby/develop/kodi_icon.png

 

The image for Kodi is currently not loading in case of the Emby for Kodi plugin since the develop branch in the repo does not exist anymore.

The EmbyCon icon should also probably be updated to point to the main repo instead.

[Angelblue05 4132]

Yes I am aware of this for Emby for Kodi. The fix is pending on my remote and it’ll be fixed with the next version.