Delete Media bug v2

[xbmcgotham 35]

A different delete bug was mentioned in the post "Delete media bug" however as it looks a little different I made this new Post. Please move it if needed.

 

For some reason when clicking to remove a movie through the emby app on android, it will give an error message saying that it could not delete the file and should see the log. When checking the log, I get the following message:

2018-01-08 13:10:02.414 Info HttpServer: HTTP Response 200 to 127.0.0.1. Time: 0ms. http://192.168.50.119:8096/dlna/bf41675ced204d67b8c0d24cc91f4d76/description.xml

2018-01-08 13:10:06.049 Info HttpServer: HTTP DELETE http://192.168.50.119:8096/emby/Items/9fd986e02f19a361e9f4271b93427468. UserAgent: Mozilla/5.0 (Linux; Android 7.0; M6 Build/NRD90M; wv) AppleWebKit/537.36 (KHTML, like Gecko) Version/4.0 Chrome/51.0.2704.110 Mobile Safari/537.36

2018-01-08 13:10:06.080 Info App: Deleting item, Type: Movie, Name: WALL·E, Path: \\multimedia-nas\media\TEST\MOVIES\WALL·E (2008)\WALL·E.avi, Id: 9fd986e0-2f19-a361-e9f4-271b93427468

2018-01-08 13:10:06.610 Info HttpServer: HTTP POST http://192.168.50.119:8096/emby/Sessions/Playing/Progress. UserAgent: Mozilla/5.0 (Linux; Android 7.0; M6 Build/NRD90M; wv) AppleWebKit/537.36 (KHTML, like Gecko) Version/4.0 Chrome/51.0.2704.110 Mobile Safari/537.36

2018-01-08 13:10:06.626 Info HttpServer: HTTP Response 204 to 192.168.50.140. Time: 16ms. http://192.168.50.119:8096/emby/Sessions/Playing/Progress

2018-01-08 13:10:06.673 Error HttpServer: Error processing request

*** Error Report ***

Version: 3.2.60.0

Command line: C:\Users\media-admin\AppData\Roaming\Emby-Server\system\EmbyServer.dll

Operating system: Microsoft Windows NT 6.1.7601 Service Pack 1

64-Bit OS: False

64-Bit Process: False

User Interactive: True

Processor count: 2

Program data path: C:\Users\media-admin\AppData\Roaming\Emby-Server\programdata

Application directory: C:\Users\media-admin\AppData\Roaming\Emby-Server\system

System.IO.IOException: The directory is not empty

at System.IO.Win32FileSystem.RemoveDirectoryHelper(String fullPath, Boolean recursive, Boolean throwOnTopLevelDirectoryNotFound)

at System.IO.Win32FileSystem.RemoveDirectory(String fullPath, Boolean recursive)

at System.IO.Directory.Delete(String path, Boolean recursive)

at Emby.Server.Implementations.IO.ManagedFileSystem.DeleteDirectory(String path, Boolean recursive)

at Emby.Server.Implementations.Library.LibraryManager.<DeleteItem>d__70.MoveNext()

System.IO.IOException

at System.IO.Win32FileSystem.RemoveDirectoryHelper(String fullPath, Boolean recursive, Boolean throwOnTopLevelDirectoryNotFound)

at System.IO.Win32FileSystem.RemoveDirectory(String fullPath, Boolean recursive)

at System.IO.Directory.Delete(String path, Boolean recursive)

at Emby.Server.Implementations.IO.ManagedFileSystem.DeleteDirectory(String path, Boolean recursive)

at Emby.Server.Implementations.Library.LibraryManager.<DeleteItem>d__70.MoveNext()

 

2018-01-08 13:10:06.673 Info HttpServer: HTTP Response 500 to 192.168.50.140. Time: 624ms. http://192.168.50.119:8096/emby/Items/9fd986e02f19a361e9f4271b93427468

2018-01-08 13:10:16.626 Info HttpServer: HTTP POST http://192.168.50.119:8096/emby/Sessions/Playing/Progress. UserAgent: Mozilla/5.0 (Linux; Android 7.0; M6 Build/NRD90M; wv) AppleWebKit/537.36 (KHTML, like Gecko) Version/4.0 Chrome/51.0.2704.110 Mobile Safari/537.36

2018-01-08 13:10:16.626 Info HttpServer: HTTP Response 204 to 192.168.50.140. Time: 0ms. http://192.168.50.119:8096/emby/Sessions/Playing/Progress

2018-01-08 13:10:26.625 Info HttpServer: HTTP POST http://192.168.50.119:8096/emby/Sessions/Playing/Progress. UserAgent: Mozilla/5.0 (Linux; Android 7.0; M6 Build/NRD90M; wv) AppleWebKit/537.36 (KHTML, like Gecko) Version/4.0 Chrome/51.0.2704.110 Mobile Safari/537.36

 

The strange thing is, When setting up the movie mapping in the library, I was able to connect directly to the NAS drive even though no credentials and password were provided. This of course could be because I might have opened the nas drive in explorer before (cant remember) or maybe because I used the same user credentials on the NAS as on emby admin.

 

However, emby is able to put new files on the nas and replace old files, but for some reason it doesn't delete the file.

 

Any suggestions? Is this a bug or something else?

 

 

2. small other question. Why are the music artist images and additional information of the music album not downloaded to emby? It only shows a hyperlink to musicbrainz. Cant see anywhere in emby settings that might need to be enabled.

 

 

Thanks again

 

 

UPDATE: It seems that the error/bug has magically solved itself. After 30 min I suddenly found that the movie was deleted from folder. I put it back again and tested deleting it again and it worked without any error. So problem solved. :-)

 

Only 2 small questions left:

2. small other question. Why are the music artist images and additional information of the music album not downloaded to emby? It only shows a hyperlink to musicbrainz. Cant see anywhere in emby settings that might need to be enabled.

and

 

3. Is it at all possible to remove the delete function completely from the emby server, not just enable it per user. I have a very big media library and dont want any program to be able to delete files. To dangerous. I would be happy to change it somewhere in code if changing it in the gui is not possible.

Edited January 8, 2018 by xbmcgotham

[Luke 42083]

Yes, please see our wiki on user permissions:

 

https://github.com/MediaBrowser/Wiki/wiki/Users

 

Thanks.

[xbmcgotham 35]

@@Luke hi luke, not sure what you are refering to. cant see the answer for question 2 and 3 above in wiki link.

[Luke 42083]

for #2, we'd have to look at an example.

 

for #3, it is not explicitly answered, but it falls under the security settings mentioned here:

Users can have their own personalized media libraries, user data, recommendations, security settings, and more.

[xbmcgotham 35]

@@Luke

Hi,

 

#2. Not sure how I can give an example as no additional data is downloaded/shown (except for the musicbrainz hyperlink which goes directly to the correct album at their web site.) I would compare it to Kodi. when indexing the music in Kodi the extra album information like images and pictures/info of the artists are downloaded and shown in Kodi. At the moment in my emby library, nothing is shown. Only the image of the album which is embedded in the file. Let me know what precise you need from me to be able to tackle this challenge.

 

#3. I like to completely kill the code. Can I edit a script and common out the part that allows for this deletion cascade to be executed in the server files? If possible add this little feature request to the next update its so risky to be able to delete files completely without any additional stop verifications. Or maybe only mark it as deleted in the DB and if people want to really delete it, have it only shown on the server web interface and make it necessary for admins to manually do additional action to delete it the particular file/folder permanently? 

 

Thanks

[Luke 42083]

#3. I like to completely kill the code. Can I edit a script and common out the part that allows for this deletion cascade to be executed in the server files? If possible add this little feature request to the next update its so risky to be able to delete files completely without any additional stop verifications. Or maybe only mark it as deleted in the DB and if people want to really delete it, have it only shown on the server web interface and make it necessary for admins to manually do additional action to delete it the particular file/folder permanently? 

 

Thanks

 

Why not just restrict your user permissions to delete?

[xbmcgotham 35]

Not save enough. I don't trust code. Had a software company and so know about code writing etc. With so much media files on the NAS drive. protecting it is important. accidents do happen, so for me a delete function that can delete with just one click is in my humble opinion a dangerous option to have. Some more safety nets are needed. :-)

 

Please let me know if anything can be done currently or with the next update and what you would need for question #2.

 

Thanks again

Edited January 8, 2018 by xbmcgotham

[Luke 42083]

can we look at an example of an artist along with a screenshot of what you see in emby? thanks.

[xbmcgotham 35]

I think it might have been taking longer to load as I have a picture now. So, pictures are loaded. :-) However I do notice a difference in Kodi collected data and emby. In kodi it shows a description of the artist(s) (attached), and cant find it in emby. Is this because the gui is not programmed to show this information? Or is it something else? I was told that emby had a much better library scrapper and display function than kodi, or is this only enabled in premium version?

 

Thanks

 

 

[Luke 42083]

musicbrainz descriptions are usually empty. we support audiodb metadata but it is off by default because it can make the library scans a little slower. but if you enable that, it will generally have artist bios.

[xbmcgotham 35]

Thanks, good tip! However I cant seem to find where to enable audiodb option. Where is it hidden at. 

 

Any last idea on the delete options. Can I already do something in the code, or would it be possible to add something to next update?

Edited January 9, 2018 by xbmcgotham

[Luke 42083]

 

 

Thanks, good tip! However I cant seem to find where to enable audiodb option. Where is it hidden at. 

library -> metadata, enable the audiodb provider for artists.

 

 

 

Any last idea on the delete options. Can I already do something in the code, or would it be possible to add something to next update?

 

No, please use the interface to toggle user permissions. thanks.

[xbmcgotham 35]

Thanks @@Luke, that did wonders. Looks good. 

 

Will buy lifetime sub soon.

 

Let me know if I can place a feature request for the extra confirmation layers on delete option.

 

CU

[Luke 42083]

Thanks for the feedback. Yes you can always create feature request topics.