chef 3810 Posted September 21, 2021 Posted September 21, 2021 58 minutes ago, rbjtech said: I'm re-running on the beta with 100 shows/4700 episodes (FP db size=500Mb) and thus far I have not seen the db errr @chef - it's 30% through the detect. So it may be db size related .. I'll have more info in the morning .. but for the moment, I don't have a repeat of the error ... thanks. I thought I had placed the db requests badly. I do have something better written. Just finished it. I'm currently running it, and I don't see any sqlite errors. I'll update my portion on git.
adminExitium 355 Posted September 21, 2021 Posted September 21, 2021 Probably premature at this point, but asking anyway: * Any plans for writing these to NFO files for sharing across servers? I assume that will depend on Luke to update the NFO plugin accordingly to write the data to a custom Emby-specific field and not something that can be done by the plugin? * Is the scaling part (doing it in batches) ready to be used or is the recommendation still to keep a separate server with a smaller library to test with? Been following this for a while now and excited to give it a try.
rbjtech 5284 Posted September 21, 2021 Posted September 21, 2021 6 hours ago, chef said: thanks. I thought I had placed the db requests badly. I do have something better written. Just finished it. I'm currently running it, and I don't see any sqlite errors. I'll update my portion on git. It's still going (which is good news) - Now @ 62% I've got it running as a background task (only 2 threads) - so it's slower but steady - that is just fine by me.
CBers 7450 Posted September 21, 2021 Posted September 21, 2021 @Cheesegeezer / @chef I've had a few episodes of new season shows added overnight, but none seem to have intros added to their chapters list. What do I need to look at in the logs etc.?
rbjtech 5284 Posted September 21, 2021 Posted September 21, 2021 3 minutes ago, CBers said: @Cheesegeezer / @chef I've had a few episodes of new season shows added overnight, but none seem to have intros added to their chapters list. What do I need to look at in the logs etc.? If you have removed the interval schedule, then they won't be picked up until you re-run the tasks tasks again manually.
CBers 7450 Posted September 21, 2021 Posted September 21, 2021 5 minutes ago, rbjtech said: If you have removed the interval schedule, then they won't be picked up until you re-run the tasks tasks again manually. They run every 3 hours and I have also just manually run them.
rbjtech 5284 Posted September 21, 2021 Posted September 21, 2021 ok - do you see anything in the log for the time they ran ? - Log Class will be 'Intro Skip' - you should see it skip everything else related to that show. Ping me the name of the show and your log via PM if you like and I can filter by Introskip and take a look.
CBers 7450 Posted September 21, 2021 Posted September 21, 2021 2021-09-21 08:23:20.077 Debug Intro Skip: NCIS - S:19 - E:1: Extracting chunks from binary chroma-print. 2021-09-21 08:23:20.083 Debug Intro Skip: NCIS - S:19 - E:1: .bin file removed. 2021-09-21 08:23:20.083 Info Intro Skip: NCIS - S:19 - E:1: Saving. 2021-09-21 08:23:20.084 Info Intro Skip: NCIS - S:19 - E:1 complete - 5 seconds. 2021-09-21 08:26:34.706 Debug Intro Skip: NCIS - S:19 - E:1: Extracting chunks from binary chroma-print. 2021-09-21 08:26:34.714 Debug Intro Skip: NCIS - S:19 - E:1: .bin file removed. 2021-09-21 08:26:34.714 Info Intro Skip: NCIS - S:19 - E:1: Saving. 2021-09-21 08:26:34.715 Info Intro Skip: NCIS - S:19 - E:1 complete - 5 seconds. 2021-09-21 09:11:42.414 Info Intro Skip: NCIS - Season 19 chromaprint profile is up to date. 2021-09-21 09:16:25.155 Info Intro Skip: CHAPTER INSERT: TV Show: NCIS - Season 19 2021-09-21 09:19:13.086 Info Intro Skip: CHAPTER INSERT: TV Show: NCIS - Season 19 2021-09-21 09:21:30.240 Info Intro Skip: CHAPTER INSERT: TV Show: NCIS - Season 19 I manually added the Title Sequence times to the plugin tab for the show, as it was showing FALSE with no timings, then ran the CHAPTER INSERT task manually. Not sure why the plugin didn't originally add it. I've had this for a couple of other show's new episodes overnight.
rbjtech 5284 Posted September 21, 2021 Posted September 21, 2021 For NCIS S19 - this is a new season with only 1 episode (?) - so I believe ( @chef/ @Cheesegeezer will confirm) that you need at least two episodes in each season to compare against. Have any of the new shows with more than one episode already in them been FP'd ?
CBers 7450 Posted September 21, 2021 Posted September 21, 2021 9 minutes ago, rbjtech said: For NCIS S19 - this is a new season with only 1 episode (?) - so I believe ( @chef/ @Cheesegeezer will confirm) that you need at least two episodes in each season to compare against. Have any of the new shows with more than one episode already in them been FP'd ? Wasn't aware of that limitation. I'm speaking to Cheese currently, but thanks.
rbjtech 5284 Posted September 21, 2021 Posted September 21, 2021 2 minutes ago, CBers said: Wasn't aware of that limitation. I'm speaking to Cheese currently, but thanks. tbh it's a good catch, as I don't believe we have properly thought about just a single episode in a new season - We may be able to compare against the previous season but it's probably better to wait until you have at least two episodes in the new season, then you'll get both FP'd and it should then continue ok.
Cheesegeezer 3104 Posted September 21, 2021 Posted September 21, 2021 (edited) 22 minutes ago, CBers said: Wasn't aware of that limitation. I'm speaking to Cheese currently, but thanks. I will get this added to the instructions 17 minutes ago, rbjtech said: tbh it's a good catch, as I don't believe we have properly thought about just a single episode in a new season - We may be able to compare against the previous season but it's probably better to wait until you have at least two episodes in the new season, then you'll get both FP'd and it should then continue ok. We need to use the same season for the comparison and the thoughts behind it are this Seasons are likely to keep the same intro throughout if the studio decides to change the intro music for that season, we need to compare against those episodes. (For example White Collar (wife's favourite show) did it for one season) If just one episode has been added to a new season, i wouldn't manually add it's intro start & end times in the UI --- because when episode 2 is released and Episode 1 has been processed by the user, the detection will have set a flag to HasSequence for episode 1 and will not be processed nor used for comparison. Can't think of a fourth Edited September 21, 2021 by Cheesegeezer 1
CBers 7450 Posted September 21, 2021 Posted September 21, 2021 3 minutes ago, Cheesegeezer said: If it's just one episode, i wouldn't manually add it because when episode 2 is release and Episode 1 has been processed by the user, the detection will have set a flag to HasSequence and will not be used for comparison. So with the one I manually added timings for, should I just refresh the item, remove the timings and let Intro Skip process it from E2 going forward?
Cheesegeezer 3104 Posted September 21, 2021 Posted September 21, 2021 Just now, CBers said: So with the one I manually added timings for, should I just refresh the item, remove the timings and let Intro Skip process it from E2 going forward? yup, just click the green "Rescan Season xx" and this will remove the detection from the db. Then just leave it to do it's thing when E02 is automatically added. I will have a chat with the guys, but i'm feeling that after first "BIG" scan, we should be able to run all tasks sequentially. So the user doesn't have to figure out when to start each interval for each task. Cheers. 1
CBers 7450 Posted September 21, 2021 Posted September 21, 2021 (edited) 33 minutes ago, Cheesegeezer said: yup, just click the green "Rescan Season xx" and this will remove the detection from the db. Then just leave it to do it's thing when E02 is automatically added. I will have a chat with the guys, but i'm feeling that after first "BIG" scan, we should be able to run all tasks sequentially. So the user doesn't have to figure out when to start each interval for each task. Cheers. Thanks. I think I've broken something now When selecting the show NCIS, I get a the SPINNING BLUE CIRCLE. I have deleted an old empty season for this show, which now doesn't exist. Can't see anything in the logs, other than this. 2021-09-21 10:39:26.163 Info Intro Skip: NCIS - Season 0 chromaprint profile is up to date. 2021-09-21 10:39:27.064 Debug Intro Skip: NCIS - S:19 - E:1: Extracting chunks from binary chroma-print. 2021-09-21 10:39:27.065 Warn Intro Skip: NCIS - S:19 - E:1 .bin file doesn't exist. Thanks. EDIT: Looks like I deleted the Season 19 folder and the episode within it, so perhaps this is a blessing in disguise, as I always delete watched seasons when the finish, so how will the Intro Skip plugin deal with missing episodes/season? Edited September 21, 2021 by CBers 1
Cheesegeezer 3104 Posted September 21, 2021 Posted September 21, 2021 34 minutes ago, CBers said: Thanks. I think I've broken something now When selecting the show NCIS, I get a the SPINNING BLUE CIRCLE. I have deleted an old empty season for this show, which now doesn't exist. Can't see anything in the logs, other than this. 2021-09-21 10:39:26.163 Info Intro Skip: NCIS - Season 0 chromaprint profile is up to date. 2021-09-21 10:39:27.064 Debug Intro Skip: NCIS - S:19 - E:1: Extracting chunks from binary chroma-print. 2021-09-21 10:39:27.065 Warn Intro Skip: NCIS - S:19 - E:1 .bin file doesn't exist. Thanks. EDIT: Looks like I deleted the Season 19 folder and the episode within it, so perhaps this is a blessing in disguise, as I always delete watched seasons when the finish, so how will the Intro Skip plugin deal with missing episodes/season? Good catch actually. So we need to check if the episode or season or show is in the physical library against the database. thanks for breaking it again hehehe 1
chef 3810 Posted September 21, 2021 Posted September 21, 2021 (edited) It had been brought up before about pilot episodes. It can be printed, but we wouldn't get a detection on it until the second episode airs. That being said, I will change the code to not mark pilot episode as processed (S1E1, and of the totalRecordCount is only 1). Then it won't get missed when the second episode airs. Excellent! Edited September 21, 2021 by chef 1
Cheesegeezer 3104 Posted September 21, 2021 Posted September 21, 2021 3 minutes ago, chef said: It had been brought up before about pilot episodes. It can be printed, but we wouldn't get a detection on it until the second episode airs. That being said, I will change the code to not mark pilot episode as processed (S1E1, and of the totalRecordCount is only 1). Then it won't get missed when the second episode airs. Excellent! Morning Chef, We would also need this to do this for season episode count too.
chef 3810 Posted September 21, 2021 Posted September 21, 2021 2 hours ago, Cheesegeezer said: Good catch actually. So we need to check if the episode or season or show is in the physical library against the database. thanks for breaking it again hehehe We ignore virtual episodes and series in the library query. Is this what you mean is happening? It is picking up virtual items? I don't quite follow sorry.
CBers 7450 Posted September 21, 2021 Posted September 21, 2021 19 minutes ago, chef said: That being said, I will change the code to not mark pilot episode as processed (S1E1, and of the totalRecordCount is only 1) It's not just pilot episodes, but single episodes in a season. In my instance, it was Season 19 Episode 1. I don't have Seasons 1-18. 1
chef 3810 Posted September 21, 2021 Posted September 21, 2021 3 hours ago, CBers said: Thanks. I think I've broken something now When selecting the show NCIS, I get a the SPINNING BLUE CIRCLE. I have deleted an old empty season for this show, which now doesn't exist. Can't see anything in the logs, other than this. 2021-09-21 10:39:26.163 Info Intro Skip: NCIS - Season 0 chromaprint profile is up to date. 2021-09-21 10:39:27.064 Debug Intro Skip: NCIS - S:19 - E:1: Extracting chunks from binary chroma-print. 2021-09-21 10:39:27.065 Warn Intro Skip: NCIS - S:19 - E:1 .bin file doesn't exist. Thanks. EDIT: Looks like I deleted the Season 19 folder and the episode within it, so perhaps this is a blessing in disguise, as I always delete watched seasons when the finish, so how will the Intro Skip plugin deal with missing episodes/season? Ah I see what's happening... When you removed the item from the library, the intro skip should have seen that using the LibraryManager ItemRemoved event and also removed it from our data table. The event is there, however, it hadn't actually been tested that the table would sync... Until now. Let me do that this morning. 1
chef 3810 Posted September 21, 2021 Posted September 21, 2021 (edited) 2 minutes ago, CBers said: It's not just pilot episodes, but single episodes in a season. In my instance, it was Season 19 Episode 1. I don't have Seasons 1-18. Okay, yes that makes sense. It needs to not mark items as processed if the totalRecordCount is 1, no matter the season or episode index numbers. That is a good catch! Edited September 21, 2021 by chef 1
chef 3810 Posted September 21, 2021 Posted September 21, 2021 7 hours ago, adminExitium said: Probably premature at this point, but asking anyway: * Any plans for writing these to NFO files for sharing across servers? I assume that will depend on Luke to update the NFO plugin accordingly to write the data to a custom Emby-specific field and not something that can be done by the plugin? * Is the scaling part (doing it in batches) ready to be used or is the recommendation still to keep a separate server with a smaller library to test with? Been following this for a while now and excited to give it a try. There was talk about saving the fingerprint files for each episode in their respective folders. I would keep a separate instance for just a little while longer. We're very close with this plugin. There is definitely more to come, with regards to how this all will implement into Emby! That is about all I can say. It is exciting.
chef 3810 Posted September 21, 2021 Posted September 21, 2021 (edited) The github repo has the code necessary to fix the single episode part. I've got to try and test removing items, and sync the two tables. This means actually altering my library. I'll see what happens. Edited September 21, 2021 by chef 1
Cheesegeezer 3104 Posted September 21, 2021 Posted September 21, 2021 7 hours ago, adminExitium said: Probably premature at this point, but asking anyway: * Any plans for writing these to NFO files for sharing across servers? I assume that will depend on Luke to update the NFO plugin accordingly to write the data to a custom Emby-specific field and not something that can be done by the plugin? As far as we are concerned writing to external files, our stance was NO. Purely because we don't want any other apps outside emby using is feature--- if it's in an NFO, xml, etc.... Then anything can access and use it. 7 hours ago, adminExitium said: * Is the scaling part (doing it in batches) ready to be used or is the recommendation still to keep a separate server with a smaller library to test with? Just hold off a little while longer. There is some polishing occuring at the moment and until we are 100% happy and (err... it's 5% tested .. just kidding) its 99% tested with good results it will be available in the plugin catalogue.
Recommended Posts