Completed Show Intro Skip Option

[CBers 7450]

@Cheesegeezer / @chef Shout if/when you need any more testers.

My server sits doing diddly squat all day.
 

[Cheesegeezer 3104]

9 minutes ago, chef said:

Ah Man!

It's just to high...

what do you guys think?

A delay in the task, and maybe a forced garbage collection?

It should be mentioned that forced garbage collection isn't a great thing to do. But, this might be one of those instances where we break the 'rules'...

 

@Cheesegeezer Should the TitleSequenceDetectionManager be IDisposable? Then we create an instance each time?

I concur el chef lol

Quote

Implement IDisposable to Release Unmanaged Resources in C#. Types that use unmanaged resources must implement the IDisposable Interface to reclaim the unmanaged memory.The primary use of the IDisposable interface is to release unmanaged resources.. Use the Dispose method of this interface to explicitly release unmanaged resources in conjunction with the garbage collector.

 

[Cheesegeezer 3104]

@chef 2.0.3.0 is fully operational and synced with Github.  I conducted a few tests and i'm very happy with it.

Shall i go ahead and release to the masses matey

[rbjtech 5284]

being embyserver.exe rather than ffmpeg, I presume this is the Sequence Detect stage ?

What is the size of the dB titlesequence file ?

Is this post your modifications on the SQL query - ie are you loading the entire dB into memory here ?

[rbjtech 5284]

3 minutes ago, Cheesegeezer said:

@chef 2.0.3.0 is fully operational and synced with Github.  I conducted a few tests and i'm very happy with it.

Shall i go ahead and release to the masses matey

Functionally, I think we are good.  My concern is the usage of this on large library systems. 

I'm not sure we are there yet with 'scaling' - so I think a release with a caution to test on a limited library (especially if it's run on a NAS) may be a wise move.

[chef 3810]

6 minutes ago, rbjtech said:

being embyserver.exe rather than ffmpeg, I presume this is the Sequence Detect stage ?

What is the size of the dB titlesequence file ?

Is this post your modifications on the SQL query - ie are you loading the entire dB into memory here ?

 

Yes, that is the issue.  You are exactly right.

Before we release a test, let me look at this really quick. See if it can be fixed.

[CBers 7450]

@Cheesegeezer / @chef Do you want this thread moved to the "Tools and Utilities" forum?
 

This is now more a tool than a feature request.
 

[chef 3810]

Just now, CBers said:

@Cheesegeezer / @chef Do you want this thread moved to the "Tools and Utilities" forum?
 

This is now more a tool than a feature request.
 

Sure. Sounds good to me.

[Cheesegeezer 3104]

2 minutes ago, CBers said:

@Cheesegeezer / @chef Do you want this thread moved to the "Tools and Utilities" forum?
 

This is now more a tool than a feature request.
 

yep sure thing Keith!

[Cheesegeezer 3104]

7 minutes ago, chef said:

 

Yes, that is the issue.  You are exactly right.

Before we release a test, let me look at this really quick. See if it can be fixed.

ok go for it!  make sure you pull the latest release  

[CBers 7450]

2 minutes ago, Cheesegeezer said:

yep sure thing Keith!

OK, moving now.
 

[CBers 7450]

Moved to the "Tools and Utilities" forum.

 

[Cheesegeezer 3104]

and just like that we are here lol

Can you change the tag to "in progress"

[chef 3810]

Sweet! I found the memory problem guys!

@Cheesegeezer do I need to pull the newest version before I update the memory fix?

 

[rbjtech 5284]

9 minutes ago, CBers said:

@Cheesegeezer / @chef Do you want this thread moved to the "Tools and Utilities" forum?
 

This is now more a tool than a feature request.
 

Shouldn't it go into the Plugin's section ?

Tools and Utilities are 'external' to Emby - this is internal .. ?

Edited September 14, 2021 by rbjtech

[Cheesegeezer 3104]

1 minute ago, chef said:

Sweet! I found the memory problem guys!

@Cheesegeezer do I need to pull the newest version before I update the memory fix?

 

Yes

[CBers 7450]

2 minutes ago, Cheesegeezer said:

and just like that we are here lol

Can you change the tag to "in progress"

No, I can't seem to be able to do that
 

@Abobader ??

[CBers 7450]

3 minutes ago, rbjtech said:

Shouldn't it go into the Plugin's section ?

Can always be moved again, once released.
 

Edited September 14, 2021 by CBers

[Cheesegeezer 3104]

Just now, CBers said:

No, I can't seem to be able to do that
 

@Abobader ??

Is Gandalf still here?  wowzers he must be like 367 yrs old by now lol  

[CBers 7450]

Just now, Cheesegeezer said:

Is Gandalf still here?  wowzers he must be like 367 yrs old by now lol  

He is

 

[chef 3810]

Sorry this is taking so long. I really have to upgrade my dev box.

[Cheesegeezer 3104]

1 minute ago, chef said:

Sorry this is taking so long. I really have to upgrade my dev box.

not anytime soon with PC components in short supply hahaha

[rbjtech 5284]

It's difficult to keep up with you guys haha - but I believe the latest on our roadmap is below (updates in red) :-

#	Item	Priority	Description	Stage	Latest Update	Version Required	Needs Core Updates ?	ETA
1	FingerPrint(Chroma)	High	Creates a template based on a percentage of the Audio runtime.	Ready	More efficient use of dB but good enough for release when used with scheduler	2.0.2.8	No	Complete
2	Detection	High	Detects the 'repeating Audio' vs other episodes and calculates the IntroStart and IntroEnd	Ready	Possibly more accuracy but certainly good enough at the moment with 90-95%	2.0.2.8	No	Complete
3	Schedule	High	Due to the Detection needing the FP database, a schedule needs to be run to ensure the data is available.	Ready	Working now but needs manual config	2.0.2.8	No	Complete
4	Scaling	High	Depending on library size, these tasks can take days, even weeks - so it's important it's broken into manageable chunks.	In progress	Needs more testing on low powered NAS devices and memory issue resolved	2.0.3	No	?
5	Manual Skip	Medium	The IntroStart/IntroEnd can be added into the existing chapter points without needing Core development work	Ready		2.0.3	No	Complete
6	IntroSkip - Manual	High	Detection of an 'IntroStart/IntroEnd (in emby Chapters?) should bring a 'Skip Intro?' button to the front of the playback screen.	Design			Yes	?
7	IntroSkip - Auto	Medium	Assuming accuracy is good enough, then #6 could also be automatic if given the option.	Concept			Yes	?
8	Community dB	Low	A community dB of existing IntroStart/End points	Concept			No	?
9	Specials	Medium	Handling of Special Episodes - both In Season and Out of Season	Concept			No	?
10	Meta-Data Refresh	High	What happens when Metadata is refreshed - do we keep chapter points ?	Ready	As long as ID stays the same, then a metadata refresh is not an issue and chapters can be re-added in seconds.		No	Complete
11	External chapter file	Low	Write all chapters (incl new Intro) to an external XML or Text File	Rejected			No	?
12	Fix Chapter Insertion Logging Class	Low	Class should be IntroSkip, not App ?	Ready			No	Complete
13	API for Sequence/Intro Data	High	Function = TitleSequenceService	Ready		All	No	Complete
14	Exception / Ignore Shows	Medium	How do we handle shows we want ignored as we know they don’t have Intro's and/or 'troublesome' shows ?	Concept			No	?
15	Detection Accuracy	Low	Look at improvements in the Detection accuracy by using different sample rates.  Use other metadata if possible such as 'Sports' Genre to ignore detection ?	Concept			No	?

Edited September 14, 2021 by rbjtech

[chef 3810]

Just quickly trying this to make sure it limits the memory usage...

[chef 3810]

BOOM! Memory usage down by 1000 MB running five series at once!

CPU is high because I have 5 processing at once, but memory issue is squashed!

Nice catch @rbjtech! That one's all yours!

Edited September 14, 2021 by chef