crusher11 1101 Posted September 11, 2021 Posted September 11, 2021 I've a number of false positives in my sports stuff. The Australian Football League always uses the same audio recording of the national anthem, rather than having someone come and sing it, which caused a few matches. But there are other season where random snippets in the middle of a quarter get picked up as the intro, despite commentary saying completely different things.
chef 3810 Posted September 11, 2021 Posted September 11, 2021 1 hour ago, crusher11 said: I've a number of false positives in my sports stuff. The Australian Football League always uses the same audio recording of the national anthem, rather than having someone come and sing it, which caused a few matches. But there are other season where random snippets in the middle of a quarter get picked up as the intro, despite commentary saying completely different things. It will ignore anything under 10 seconds. It's most likely the 'intro' maybe too short. It's found but ignored. I know when I watch the Jays play, usually they wouldn't have an intro to the game, per se. I don't know if sport streams are going to fall into a category that will yield consistent results, unfortunately. But, there could be exceptions.
Neminem 1519 Posted September 11, 2021 Posted September 11, 2021 Tbh sport events are filed with commercials. and should be regarded as such. Thay do not have a predictable timeline. Anything can happen. Best guess is to use comskip for that, and put it in a separate library. Just my 10 cent. 3
rbjtech 5284 Posted September 11, 2021 Posted September 11, 2021 @chef @samuelqwe I can add to list of things to look at - but for the moment, I personally think the results are more than good enough. I have a question actually on which Audio 'stream' it uses for the sampling - one assumes it uses the first one it can find or the 'default' ? For all of my media for non native AAC streams, I insert a new Stereo AAC stream created from whatever the original Audio track was (AC3/DTS etc) - I do this to make it totally portable and playable on all devices. Does the stream codec, number of channels, Audio level etc make any difference to the detection ? Thanks !
samuelqwe 317 Posted September 11, 2021 Posted September 11, 2021 6 minutes ago, rbjtech said: @chef @samuelqwe I can add to list of things to look at - but for the moment, I personally think the results are more than good enough. I have a question actually on which Audio 'stream' it uses for the sampling - one assumes it uses the first one it can find or the 'default' ? For all of my media for non native AAC streams, I insert a new Stereo AAC stream created from whatever the original Audio track was (AC3/DTS etc) - I do this to make it totally portable and playable on all devices. Does the stream codec, number of channels, Audio level etc make any difference to the detection ? Thanks ! In theory, it shouldn’t really affect the detection because we’re downsampling the audio and converting it to mono when we fingerprint. We’re trying to eliminate as many variables as possible to make the detection the most accurate it can be. 1
crusher11 1101 Posted September 11, 2021 Posted September 11, 2021 7 hours ago, chef said: It will ignore anything under 10 seconds. It's most likely the 'intro' maybe too short. It's found but ignored. I know when I watch the Jays play, usually they wouldn't have an intro to the game, per se. I don't know if sport streams are going to fall into a category that will yield consistent results, unfortunately. But, there could be exceptions. Right, it shouldn't find an intro. But it does. Even though they sound completely different.
chef 3810 Posted September 12, 2021 Posted September 12, 2021 3 hours ago, crusher11 said: Right, it shouldn't find an intro. But it does. Even though they sound completely different. That would be expected. Replaying a recording of the nation anthem, that would probably do it. Any ideas how we might filter sport streams?
Micael456 45 Posted September 12, 2021 Posted September 12, 2021 3 hours ago, chef said: That would be expected. Replaying a recording of the nation anthem, that would probably do it. Any ideas how we might filter sport streams? For shows with Genre "Sport", add a button in the UI to explicitly invalidate an audio segment? i.e. not just "this is false", but "everything that matches with this is also false". 1
rbjtech 5284 Posted September 12, 2021 Posted September 12, 2021 3 hours ago, Micael456 said: For shows with Genre "Sport", add a button in the UI to explicitly invalidate an audio segment? i.e. not just "this is false", but "everything that matches with this is also false". Nice - we have other 'info' at our disposal to make semi-informed decisions. I like it.
crusher11 1101 Posted September 12, 2021 Posted September 12, 2021 6 hours ago, chef said: That would be expected. Replaying a recording of the nation anthem, that would probably do it. Any ideas how we might filter sport streams? No, I know why the anthem happens. But there are other seasons where it just identifies a random in-game snippet and none of the detected sections have anything in common.
crusher11 1101 Posted September 12, 2021 Posted September 12, 2021 Can we get a button on each episode to export the intro segment as an audio file?
Cheesegeezer 3104 Posted September 12, 2021 Posted September 12, 2021 17 minutes ago, crusher11 said: Can we get a button on each episode to export the intro segment as an audio file? Crusher, I think i remember in the past when we were doing some work with Vantage Point, that you have quite a few audio tracks that are already in mono and you set tags so that it changes your AVR to a different output (ProLogic II) or something like that. @chef @samuelqwe could it be that if the audio is already in mono then we can't downsample? this maybe causing the issues for crushers sport stuff
crusher11 1101 Posted September 12, 2021 Posted September 12, 2021 The sports stuff is all 2.0. At least what I've checked. The ability to quickly/easily export the intro sequence from any given episode could be helpful with figuring out things that trip it up one way or the other.
Cheesegeezer 3104 Posted September 12, 2021 Posted September 12, 2021 3 minutes ago, crusher11 said: The sports stuff is all 2.0. At least what I've checked. The ability to quickly/easily export the intro sequence from any given episode could be helpful with figuring out things that trip it up one way or the other. I don't know how easy that is to code as I have never delved into ffmpeg. The bottom line is we are actually interested in "Actual TV Shows", so i think the way to approach this is to allow the user to "ignore" folders or libraries that are still included in TV Shows. A "Sports" options would be nice to include as a library option, however I can't see that happening anytime this side of 2030. 2
chef 3810 Posted September 12, 2021 Posted September 12, 2021 (edited) Currently, you'd have to go through and save each entry's 'HasSequence' as 'false'. How many library items would you have to edit @crusher11? I guess what we need to have is the ability to ignore items in the library during the scan. Perhaps, we ignore items based on where they are in the file system? We could have an input in settings for the user to place drive/directories that would be ignored? Edited September 12, 2021 by chef
Cheesegeezer 3104 Posted September 12, 2021 Posted September 12, 2021 12 minutes ago, crusher11 said: The sports stuff is all 2.0. At least what I've checked. The ability to quickly/easily export the intro sequence from any given episode could be helpful with figuring out things that trip it up one way or the other. If you want to extract the audio for chef or samuel to look at then use the window video editor or what ever video editing app is available for your OS and crop and process a new one and upload to dropbox, google drive or onedrive.
chef 3810 Posted September 12, 2021 Posted September 12, 2021 (edited) I can see why sports is an issue. If crusher has the intro data, and (crazily enough...) it's implemented in the clients he's watching the game on. We would interrupt the game during the first 15 minutes with a button to skip an intro. We would definitely be getting either feature requests to fix it, or it would be flagged as a bug by other users who would eventually run into the same issues. Edited September 12, 2021 by chef
samuelqwe 317 Posted September 12, 2021 Posted September 12, 2021 1 hour ago, Cheesegeezer said: @chef @samuelqwe could it be that if the audio is already in mono then we can't downsample? this maybe causing the issues for crushers sport stuff That shouldn’t be affecting it, but then again FFmpeg can be a little weird sometimes, so it’s always possible there’s something happening there.
crusher11 1101 Posted September 12, 2021 Posted September 12, 2021 53 minutes ago, Cheesegeezer said: If you want to extract the audio for chef or samuel to look at then use the window video editor or what ever video editing app is available for your OS and crop and process a new one and upload to dropbox, google drive or onedrive. It should be fairly simple to code in, you'd just run ffmpeg with the video disabled, copy the audio, and set start and end times to whatever was detected. I think the sports issue is a distraction. Most of them failed to find any intro at all, as expected. And there's at least one episode of The Alfred Hitchcock Hour that also has a random snippet incorrectly identified as the intro. The sports just happened to be the most obvious thing, is all, absent the time to really go through the results. 1
Cheesegeezer 3104 Posted September 12, 2021 Posted September 12, 2021 11 minutes ago, crusher11 said: It should be fairly simple to code in, you'd just run ffmpeg with the video disabled, copy the audio, and set start and end times to whatever was detected. Not important right now.. more of a nice to have. 11 minutes ago, crusher11 said: I think the sports issue is a distraction. Most of them failed to find any intro at all, as expected. Agree lets move along. i have some issues with my Westworld episodes and I’m pretty sure it’s down to the encoding that causes the problems and not the plugins detection system.
Cheesegeezer 3104 Posted September 12, 2021 Posted September 12, 2021 (edited) @chef help me please bud... I suck at HTML and js and Where am i going wrong. I don't understand your methods of constructing the advanced config page.. pretty much everything you do is in the js, which is something I also suck at. So I need to wire this button into the config.cs file then read it back and watch for change events //Option for Auto Chapter Image Extraction html += '<div class="inputContainer">'; html += '<label style="width: auto;" class="mdl-switch mdl-js-switch">'; html += '<input is="emby-toggle" type="checkbox" class="chkChapterExtractEvent noautofocus mdl-switch__input" data-embytoggle="true">'; html += '<span class="toggleButtonLabel mdl-switch__label">Enable Auto Image Extraction</span>'; html += '<div class="mdl-switch__trackContainer">'; html += '<div class="mdl-switch__track"></div>'; html += '<div class="mdl-switch__thumb">'; html += '<span class="mdl-switch__focus-helper"></span>'; html += '</div>'; html += '</div>'; html += '</label>'; html += '<div class="fieldDescription">'; html += 'This will Automatically run the Thumbnail Image Extraction Process once the Intro Points have been inserted'; html += '</div>'; html += '</div>'; //auto Chapter image extraction var autoChapterExtract = dlg.querySelector('.chkChapterExtractEvent'); ApiClient.getPluginConfiguration(pluginId).then((config) => { autoChapterExtract.checked = config.EnableAutomaticImageExtraction; }); autoChapterExtract.addEventListener('change', (e) => { e.preventDefault(); ApiClient.getPluginConfiguration(pluginId).then((config) => { config.EnableAutomaticImageExtraction = autoChapterExtract.checked; ApiClient.updatePluginConfiguration(pluginId, config).then(() => { }); }); }); is it the changed event, does it need to be a click or how is emby toggle used, i normally use emby-checkbox as the class. Edited September 12, 2021 by Cheesegeezer
Cheesegeezer 3104 Posted September 12, 2021 Posted September 12, 2021 I just figured it out fella... was to do with the this data-embytoggle="true">' All good now mate. Cheers
Cheesegeezer 3104 Posted September 12, 2021 Posted September 12, 2021 (edited) @chef - New pull request waiting for you. Edited September 12, 2021 by Cheesegeezer
rbjtech 5284 Posted September 12, 2021 Posted September 12, 2021 3 hours ago, Cheesegeezer said: Not important right now.. more of a nice to have. Agree lets move along. i have some issues with my Westworld episodes and I’m pretty sure it’s down to the encoding that causes the problems and not the plugins detection system. Agreed - lets keep this on the list but low priority. Sometimes there really is 'odd' things in the Audio that a human cannot normally pick up. Much earlier in the thread, I actually went some way to proving this - and cut a 'known' working Intro and pasted into a 'non-working' Intro overwriting the existing Intro - resaved the file and bingo - it was then picked up the same as all the others. To the ear (well my ear anyway) it sounded identical. So I think we are going to get these 'oddities' and short of what I did (not recommended haha), we just have to accept them (or manually add if we are so inclined) - certainly for the foreseeable future.
Cheesegeezer 3104 Posted September 12, 2021 Posted September 12, 2021 (edited) So I was looking at the TV Show the boys and Amazon Originals call there IntroStart to IntroEnd just "Title Sequence" is this a route we should take? And be done with the 2 flags? @rbjtech @chef @samuelqwe Edited September 12, 2021 by Cheesegeezer
Recommended Posts