Micael456 45 Posted September 9, 2021 Posted September 9, 2021 4 minutes ago, Cheesegeezer said: So you can see below that the standard Emby 5min markers fall inbetween the start and end of the intro. I need to capture this and move chapter 4 outside to keep consistency, this will ensure that chapter fluidity is maintained. As I said earlier.... this is next on the list and i'll tackle it tomorrow as I've got a poker night to get ready for hehe Got it, that makes sense now. So just bump Chapter 4 to the other side and all good. Not sure if you were reading a while back, but we were discussing what happens if metadata was refreshed or the file is changed. Just something to bear in mind we may have to also remove those inserts ;). Anyway, thanks for explaining :). And enjoy your poker night!
Cheesegeezer 3104 Posted September 9, 2021 Posted September 9, 2021 1 minute ago, rbjtech said: A point to note is we need to re-produce any modifications post a metadata refresh - as emby will currently just re-read the original MKV etc or Auto Gen if there are no Chapters and wipe out any Intro modifications we have made .. This is very true, however at least the refresh doesn't require a fingerprint scan or intro detection, just needs the chapters running and thumbnail extraction to run. So maybe we can monitor if a refresh has been done and if so, we run the 2 tasks. 1
rbjtech 5284 Posted September 9, 2021 Posted September 9, 2021 7 minutes ago, chef said: But, I'm off to puree food for old people. See you all later! 7 minutes ago, Cheesegeezer said: ... I've got a poker night to get ready for hehe Great stuff guys - @chefenjoy your liquidizing ! and @Cheesegeezer try not to lose too much .. 1
Cheesegeezer 3104 Posted September 9, 2021 Posted September 9, 2021 cheers @rbjtech see ya on the flip side bro!!
crusher11 1101 Posted September 9, 2021 Posted September 9, 2021 Episodes two and four of the second season of Yes, Minister have horribly miscalculated intro times. Nothing stands out as a potential reason if I watch them back. All intros should start at 00:00 and end at roughly 00:42. The two episodes in question have detected intros that start at 00:13 and 00:14, and end at 00:37 and 00:38.
rbjtech 5284 Posted September 9, 2021 Posted September 9, 2021 (edited) 20 minutes ago, crusher11 said: Episodes two and four of the second season of Yes, Minister have horribly miscalculated intro times. Nothing stands out as a potential reason if I watch them back. All intros should start at 00:00 and end at roughly 00:42. The two episodes in question have detected intros that start at 00:13 and 00:14, and end at 00:37 and 00:38. Thanks - let me see if I can recreate this one too - for the previous example, mine did not have the issues. brb. edit - so I can reproduce this one. Just looking into the possible reasons .. Edited September 9, 2021 by rbjtech
rbjtech 5284 Posted September 9, 2021 Posted September 9, 2021 @crusher11 - Hmm, very odd. I've wiped the data and tried again - same result. But listening to the Intro's from those episodes, they appear exactly the same. It's not obvious, but you can click on the time and edit it to what you want (00:00:41 in our case) but clearly you would not really want to be doing that for lots of episodes. @chef - is this just 'one of those things in the accuracy of the technology' or can the bin files be used to see what is going on here ? My filtered log is below, but I don't believe it will show us much.. yes.txt
crusher11 1101 Posted September 9, 2021 Posted September 9, 2021 I'm aware that they can be edited (although the delete and arrow keys don't work, so it's a pain in the ass to do so), but it does seem to indicate an issue with the detection.
crusher11 1101 Posted September 9, 2021 Posted September 9, 2021 @rbjtech Just saw your earlier edit. Those are out, but not by as much as mine. Not even close.
chef 3810 Posted September 9, 2021 Posted September 9, 2021 (edited) Does the intro start with any kind of strange audio? Maybe audio doesn't start in the sequence until 3 seconds into the intro? I fixed the delete button, I'll put it up when I get home. If you press delete, it does work, but the UI doesn't get updated, so you'd have to refresh the browser. Edited September 9, 2021 by chef
crusher11 1101 Posted September 9, 2021 Posted September 9, 2021 @chef I mean the delete key on the keyboard, when editing the time codes. It doesn't do anything, only backspace works to delete characters. Pressing the left or right arrow keys causes focus to be removed from the text entry completely. So you have to constantly click in exactly the right place if you want to tweak something.
Cheesegeezer 3104 Posted September 9, 2021 Posted September 9, 2021 (edited) So Poker was cancelled tonight which is a shame, but it means i get a bit more time behind the laptop. I've done a little bit more work on the Chapters and it's working pretty good now. I don't know if we need to think of renaming the emby generated chapter numbers after removing the rogue one. We can see in the log below, I picked a good one and a bad one(a chapter was inbetween the introstart and introend) Episode: ChestNut Episode: Virtù e Fortuna Edited September 9, 2021 by Cheesegeezer 1
Cheesegeezer 3104 Posted September 9, 2021 Posted September 9, 2021 @chef I have just merged the latest to the master to remove Rogue chapters. 1
rbjtech 5284 Posted September 9, 2021 Posted September 9, 2021 Love the git branchname Let me know when you want me to test anything or everything re chapters - I have an isolated beta instance, so I'm not bothered if chapters get messed up while testing.
rbjtech 5284 Posted September 9, 2021 Posted September 9, 2021 4 hours ago, chef said: If you press delete, it does work, but the UI doesn't get updated, so you'd have to refresh the browser. Is this a browser dependent issue - as with Edge on v2.0.2.8 - the delete key works just fine ?
Cheesegeezer 3104 Posted September 9, 2021 Posted September 9, 2021 13 minutes ago, rbjtech said: Love the git branchname Let me know when you want me to test anything or everything re chapters - I have an isolated beta instance, so I'm not bothered if chapters get messed up while testing. Lol yeah had a good ring for the branch name!! we just need chef to update git with his recent release and then i think he can pop out another dll. 1
chef 3810 Posted September 9, 2021 Posted September 9, 2021 (edited) 4 hours ago, crusher11 said: @chef I mean the delete key on the keyboard, when editing the time codes. It doesn't do anything, only backspace works to delete characters. Pressing the left or right arrow keys causes focus to be removed from the text entry completely. So you have to constantly click in exactly the right place if you want to tweak something. It looks like 'contenteditable' is available for all browser. https://www.w3schools.com/tags/att_global_contenteditable.asp I will look further into it. What about that off title sequence? Anything different about the audio? Edited September 10, 2021 by chef
chef 3810 Posted September 10, 2021 Posted September 10, 2021 (edited) Argh! the 'contenteditable' attribute in HTML is just the worst. How has that even been released as a feature on the web? like @crusher11 says, the arrow keys, and the delete button lose focus, it's just awful. I guess we use inputs, but I really was hoping to stay away from them for the table. I guess no choice. Plus, I had to remove the Limit Testing because it started to have strange results. No good. It's gone. Cheese, in the Repository, we need to go back to having have a string sent to 'GetResult' after all. There was something strange happening when we called id.ToString(), and then checked if it was null or empty... argh. sorry man. That is my bad. The sequence task just completed, but didn't process anything. I narrowed it down to that, switched it back, and everything was okay. The chapter code is golden my friend, very nice! I like how you did the sort on the list. That is cool. We need to make sure that the scheduled task for chapter edit is set to 'enabled = false'. Anything that is going to change a users metadata should be opt in. Extending is cool, but for altering.. we have to let the user turn that on. Edited September 10, 2021 by chef
crusher11 1101 Posted September 10, 2021 Posted September 10, 2021 3 hours ago, chef said: It looks like 'contenteditable' is available for all browser. https://www.w3schools.com/tags/att_global_contenteditable.asp I will look further into it. What about that off title sequence? Anything different about the audio? Not that I can hear.
Cheesegeezer 3104 Posted September 10, 2021 Posted September 10, 2021 (edited) 9 hours ago, chef said: I narrowed it down to that, switched it back, and everything was okay. Oh man, I honestly can’t see why that would be a problem, but my bad also as i should have done a full test before pushing the fork. Quote The chapter code is golden my friend, very nice! I like how you did the sort on the list. That is cool. Thanks man, i wrote some long winded way of checking & editing the list and then re organising and then had a light bulb moment. Quote We need to make sure that the scheduled task for chapter edit is set to 'enabled = false'. Anything that is going to change a users metadata should be opt in. Extending is cool, but for altering.. we have to let the user turn that on. Well, the plugin is an optional install, without the chapter markers the intro skip function is useless. We are not altering any metadata but only inserting chapter points. I would put a disclaimer in to say this. we actually need to have an checkbox in the config that if enabled always forces the chapter task and thumbnail extraction to run after a refresh occurs. If this is not enabled or null then when the user refreshes metadata this will remove any chapter entries we have created and return the library back to normal. I know you have an internalID in the titlesesequencequery class however it looks like we have to drill down from series to season to episode everytime to get the episode ID from the DB, but it would make life much easier (and efficient) if we also stored the episodeID directly. This should allow us to pass the id into methods much easier. GetResult(id) was always throwing a null for me and would fail. what do you think? Edited September 10, 2021 by Cheesegeezer
rbjtech 5284 Posted September 10, 2021 Posted September 10, 2021 1 hour ago, Cheesegeezer said: Well, the plugin is an optional install, without the chapter markers the intro skip function is useless. We are not altering any metadata but only inserting chapter points. I would put a disclaimer in to say this. we actually need to have an checkbox in the config that if enabled always forces the chapter task and thumbnail extraction to run after a refresh occurs. If this is not enabled or null then when the user refreshes metadata this will remove any chapter entries we have created and return the library back to normal. @chef I have to agree with Cheese here and tbh this has been my viewpoint all along - and the reason why I seem to be so passionate about chapters haha. If people have bothered to install this plugin - waited many hours, maybe many days for it to finish - and all they get is a list of Intro points in the plugin - I think they will be disappointed as it's useless for actually er.. skipping the Intro. Yes I think (at the moment) default behaviour should be confirm each Show/Season to get the chapters updated (to confirm the data is good) - but this this should just be a button in the SkipIntro GUI. Maybe a 'confirm 'show' at top level, or confirm season ? (not sure if that's easy or difficult to do - but it will be a royal pain in the a**e to confirm a show with 20 seasons etc..) Maybe an external config change to Automatically put in the chapter points in without needing confirmation (ie auto_chapter_default=false) ?
Cheesegeezer 3104 Posted September 10, 2021 Posted September 10, 2021 (edited) @chef @rbjtech @ebr @Luke Anyone know how to trigger another Scheduled Task in code. I can't seem to find the task in Emby for running the ThumbnailImageExtract Task. It used to be here... Emby/Emby.Server.Implementations/ScheduledTasks/ChapterImagesTask.cs / Chapters is pretty much complete. Chef I have switched the GetResult(string id) back now in my code and can pass the Episode Id to the ChapterEdit Method, so when running the Chapter Insertion Task, it will ONLY select your sequenced episodes to process. You will have to then run the thumbnailImageExtract task after running the chapter Insertion task I have just done a full test on my small Test library and everything is working as expected. Attached is 2.0.2.9 This build has been set as a pull request in Git, I'll let you check it and merge the request. You may also notice a new design for the Plugin Icon -- Sorry chef the old one just looked like it was from an 80's video game lol IntroSkip 2.0.2.9.zip Edited September 10, 2021 by Cheesegeezer 3
CBers 7450 Posted September 10, 2021 Posted September 10, 2021 It's been fascinating reading this thread as it has evolved. Congrats to you guys for putting this together 1 1
chef 3810 Posted September 10, 2021 Posted September 10, 2021 I like that icon you made Cheese, but I didn't make the original icon, a community memebr did . Be careful changing metadata, there are service endpoint available for future client implemention. We want it to be like Netflix, Amazon, and yes, even Plex. But this is all very cool, and I can't wait to try it.
Cheesegeezer 3104 Posted September 10, 2021 Posted September 10, 2021 Wow Chef, you really wanted to be heard 3 of the same posts lol 1
Recommended Posts