Completed Show Intro Skip Option

[chef 3810]

53 minutes ago, Cheesegeezer said:

Making Progress now the intro's insert at the correct point.  I will need to find the real tricky one where the intro end overlaps a emby 5min marker

 

That's the Westworld Episode 3 where the intro starts much later in the episode

Quick question, what you are calling "IntroEnd" will be called 'Chapter 4' once all is sorted out?

[Cheesegeezer 3104]

@chef, just need to make this not quick and dirty now, i'm not sure where pull or pass the the ID from

[Cheesegeezer 3104]

1 minute ago, chef said:

Quick question, what you are calling "IntroEnd" will be called 'Chapter 4' once all is sorted out?

Absolutely not, we need specific flags that can be accessed during playback to allow for the "Button" to appear and disappear and need to be unique.

[Cheesegeezer 3104]

I just edited the start and end times for the intro in the middle and i have more work to do!! 

[Cheesegeezer 3104]

@chef can you upload the latest to git, so i can integrate chapters

[Micael456 45]

22 minutes ago, Cheesegeezer said:

Absolutely not, we need specific flags that can be accessed during playback to allow for the "Button" to appear and disappear and need to be unique.

If a chapter is split, could we not create a microsecond chapter for IntroEnd, and then follow it up with "ChapterName (cont.) straight away? (I know I'm banging on about those microchapters but honestly feel it's less invasive)

e.g.

Chapter 1

IntroStart

IntroEnd

Chapter 1 (cont)

Chapter 2

 

For clarity,

Chapter 1 -> IntroStart ("Chapter of x length")

IntroStart-IntroEnd (if appropriate, else to e.g. Chapter 2) (Chapter of intro length)

IntroEnd-Chapter 1 (or 2) (cont.) [1ms chapter]

Chapter 1 (cont) -> Chapter 2 etc as usual.

 

Edited September 9, 2021 by Micael456
Edit for clarity,

[Cheesegeezer 3104]

@chef you should have a pull request.

[Sammy 790]

Running fingerprint task now but maybe since there's now only one advanced setting for the plugin this could be just on the main plugin page?

[Cheesegeezer 3104]

3 minutes ago, Micael456 said:

If a chapter is split, could we not create a microsecond chapter for IntroEnd, and then follow it up with "ChapterName (cont.) straight away? (I know I'm banging on about those microchapters but honestly feel it's less invasive)

e.g.

Chapter 1

IntroStart

IntroEnd

Chapter 1 (cont)

Chapter 2

This is the part i'm working on right now.  We will have the Intro start and end still but the chapter ordering will be fixed, once i get my head around the conditions, maths and logic.

microsecond chapters will actually open a massive can of worms because then you are dealing with 2 entry and exit points.

[Sammy 790]

4 minutes ago, Cheesegeezer said:

@chef you should have a pull request.

Okay, so I just fired off a new scan and it's going to be updated again?  LOL.

[Cheesegeezer 3104]

Just now, Sammy said:

Okay, so I just fired off a new scan and it's going to be updated again?  LOL.

Chef has put in some code for testing, a couple of pages back.  You need to edit the xml file.  so you can just focus on a couple of seasons if you want

 

[Micael456 45]

Just now, Cheesegeezer said:

microsecond chapters will actually open a massive can of worms because then you are dealing with 2 entry and exit points.

Why would that pose an issue for the end? Isn't the button action simply Jump to Chapter "IntroEnd"?

Agree that for (as long as possible) of the actual intro it can be one long chapter, but from what I could see above you just labelled the next chapter as IntroEnd, so don't see how that's any different there?

[Cheesegeezer 3104]

6 minutes ago, Micael456 said:

Why would that pose an issue for the end? Isn't the button action simply Jump to Chapter "IntroEnd"?

Agree that for (as long as possible) of the actual intro it can be one long chapter, but from what I could see above you just labelled the next chapter as IntroEnd, so don't see how that's any different there?

Actually not, i'm using the information taken from the titlesequence database as the user can adjust these values in the config.  So I'm using the intro detection start time and the intro detection end time to insert the markers.

Also just out of curiosity... what do you mean by intrusive?

Edited September 9, 2021 by Cheesegeezer

[rbjtech 5284]

The issue is Emby does not use Chapters in the conventional way - they are effectively way points / markers.  They do not denote a start and an end - like they do in say an MKV file.

Therefore, IF emby decided to use these 'markers' to control the 'IntroSkip' button - then we need both - the IntroStart and the IntroEnd.

This is not particularly desirable -  as 'IntroStart' has no 'human' use - we just want to skip to the 'IntroEnd'.

I think there may be a few tricks we can use to improve this, but for the moment, I think it is good enough for this as a proof of concept - nothing is set in stone and these are chapter changes are 'optional' anyway. 

[Micael456 45]

9 minutes ago, Cheesegeezer said:

Actually not, i'm using the information taken from the titlesequence database as the user can adjust these values in the config.  So I'm using the intro detection start time and the intro detection end time to insert the markers.

So is IntroStart not a chapter from 14:12-15:00 there?

Apologies if I'm misunderstanding the screenshot. From what I understood you had

Chapter 3 (10:00) -> IntroStart (14:12)

IntroStart (14:12) -> Chapter 4 (15:00)

Chapter 4 (15:00) -> IntroEnd (15:49)

IntroEnd (15:49) -> Chapter 5 (20:00)

I'm assuming that it was just bog standard 5 minute emby chapters before.

I was suggesting instead of actively changing the existing chapters (i.e. chapter 4 ends after 49 seconds).

Chapter 3 [10:00] -> IntroStart [14:12]

IntroStart [14:12] -> Chapter 4 [15:00]

Chapter 4 [15:00] -> IntroEnd [15:49]

IntroEnd [15:49:00] -> Chapter 4 (cont.) [15:49:01]

Chapter 4 (cont.) [15:49:01] -> Chapter 5 [20:00]

That way we still have a "chapter" for the end to seek to, but we also don't mess up anyone's named chapters (I doubt people really care about the auto-genned chapters).

Would look something like or the bad paint-job below.

Edited September 9, 2021 by Micael456
typo

[Micael456 45]

6 minutes ago, rbjtech said:

The issue is Emby does not use Chapters in the conventional way - they are effectively way points / markers.  They do not denote a start and an end - like they do in say an MKV file.

 

That works even better then. Just insert two markers at the end point instead of one. One for "End", and one for "PreviousChapterWotWasHere (cont)" a second later.

 

My concern is that we might end up leaving it with a large section of the episode in a chapter called "IntroEnd" for no reason.

Edited September 9, 2021 by Micael456

[Cheesegeezer 3104]

3 minutes ago, Micael456 said:

So is IntroStart not a chapter from 14:12-15:00 there?

Apologies if I'm misunderstanding the screenshot. From what I understood you had

Chapter 3 (10:00) -> IntroStart (14:12)

IntroStart (14:12) -> Chapter 4 (15:00)

Chapter 4 (15:00) -> IntroEnd (15:49)

IntroEnd (15:49) -> Chapter 5 (20:00)

I'm assuming that it was just bog standard 5 minute emby chapters before.

I was suggesting instead of actively changing the existing chapters (i.e. chapter 4 ends after 49 seconds).

Chapter 3 [10:00] -> IntroStart [14:12]

IntroStart [14:12] -> Chapter 4 [15:00]

Chapter 4 [15:00] -> IntroEnd [15:49]

IntroEnd [15:49:00] -> Chapter 4 (cont.) [15:49:01]

Chapter 4 (cont.) [15:49:01] -> Chapter 5 [20:00]

That way we still have a "chapter" for the end to seek to, but we also don't mess up anyone's named chapters (I doubt people really care about the auto-genned chapters).

Would look something like or the bad paint-job below.

[chef 3810]

1 hour ago, Cheesegeezer said:

@chef you should have a pull request.

Thank you sir! 

[rbjtech 5284]

18 minutes ago, Micael456 said:

If a chapter is split, could we not create a microsecond chapter for IntroEnd, and then follow it up with "ChapterName (cont.) straight away? (I know I'm banging on about those microchapters but honestly feel it's less invasive)

e.g.

Chapter 1

IntroStart

IntroEnd

Chapter 1 (cont)

Chapter 2

 

For clarity,

Chapter 1 -> IntroStart ("Chapter of x length")

IntroStart-IntroEnd (if appropriate, else to e.g. Chapter 2) (Chapter of intro length)

IntroEnd-Chapter 1 (or 2) (cont.) [1ms chapter]

Chapter 1 (cont) -> Chapter 2 etc as usual.

 

I think you may be over complicating things... ?

Remember-

a) IntroSkip is a Plugin - therefore, if you have optionally installed it - you probably are expecting an IntroSkip facility somewhere on the 'timeline'.

b) IntroSkip does not modify the source file at all - it only updates the Emby chapter database.

For 'real' chapters - then we should try to be as 'invasive' (as you put it) as possible - ie we only modify what we need to to make the SkipIntro a reality.  For the 'Auto' chapters - then tbh I'm on the fence - as a simple recalculate from the IntroEnd every 5 mins might be a better way - they are 'meaningless' chapter markers anyway - so do you really care if they are recalculated ?

[chef 3810]

1 hour ago, Sammy said:

Running fingerprint task now but maybe since there's now only one advanced setting for the plugin this could be just on the main plugin page?

Yes one to rule it all. 

[Cheesegeezer 3104]

1 minute ago, Micael456 said:

That works even better then. Just insert two markers at the end point instead of one. One for "End", and one for "PreviousChapterWotWasHere (cont)" a second later.

 

My concern is that we might end up leaving it with a large section of the episode in a chapter called "IntroEnd" for no reason.

Micael, you are missing the point here.  There is absolutely no manipulation of existing chapters, we are only creating start and end point. I think you are overthinking this.  You need to trust us.

[Micael456 45]

1 minute ago, Cheesegeezer said:

Micael, you are missing the point here.  There is absolutely no manipulation of existing chapters, we are only creating start and end point. I think you are overthinking this.  You need to trust us.

OK, seems like very strange behaviour to me lol, but I haven't seen the chapterDB in Emby so if you say it's ok I'll trust you there. I guess since the client doesn't actually seem to show the Chapter Name it's not as relevant as I was thinking. From what @rbjtech says they're not real chapters anyway, just seek markers. So feel free to ignore my above :D.

 

4 minutes ago, rbjtech said:

b) IntroSkip does not modify the source file at all - it only updates the Emby chapter database.

 

This is true, but in my experience it's best to design it in the way that can do both wanted functions rather than have to re-engineer later (since we know some sort of chaptering is loosely on the list).

[chef 3810]

The pull request looks good.

By the way, did we test the changes to the Repository?  

 

I think we'd better move the code from the scheduled task into some kind of Manager.

Then we can create a button in the UI  that can contact the service, and edit the chapters.

Then the user has control over weather or not to edit the chapter data.

 

Nice job @Cheesegeezer, 

 

I also noticed my Namespace error just now as well. LOL!

 

But, I'm off to puree food for old people. See you all later!

 

[Cheesegeezer 3104]

2 minutes ago, Micael456 said:

OK, seems like very strange behaviour to me lol, but I haven't seen the chapterDB in Emby so if you say it's ok I'll trust you there. I guess since the client doesn't actually seem to show the Chapter Name it's not as relevant as I was thinking. From what @rbjtech says they're not real chapters anyway, just seek markers. So feel free to ignore my above :D.

 

This is true, but in my experience it's best to design it in the way that can do both wanted functions rather than have to re-engineer later (since we know some sort of chaptering is loosely on the list).

 

So you can see below that the standard Emby 5min markers fall inbetween the start and end of the intro.  I need to capture this and move chapter 4 outside to keep consistency, this will ensure that chapter fluidity is maintained.   As I said earlier.... this is next on the list and i'll tackle it tomorrow as I've got a poker night to get ready for hehe

 

 

 

[rbjtech 5284]

2 minutes ago, Micael456 said:

This is true, but in my experience it's best to design it in the way that can do both wanted functions rather than have to re-engineer later (since we know some sort of chaptering is loosely on the list).

This I do agree with - but modifying the source file chapters IS heavily invasive - the safest thing emby can do here is to write the 'modified' and unmodified chapters to a chapter.xml file for use by external tools/scripts to modify the source should the user wish that.

A point to note is we need to re-produce any modifications post a metadata refresh - as emby will currently just re-read the original MKV etc or Auto Gen if there are no Chapters and wipe out any Intro modifications we have made ..