Cheesegeezer 3104 Posted September 9, 2021 Posted September 9, 2021 1 minute ago, chef said: Yeah, I wouldn't automatically assume anything when it comes to the data. We shouldn't automatically mess with peoples chapters. They need time to edit the results in the UI table. We'll have a button in the UI they can press if they are satisfied with the results we are producing, and that will edit chapters for them. Exactly but I'm just testing at the moment 1
Cheesegeezer 3104 Posted September 9, 2021 Posted September 9, 2021 1 minute ago, rbjtech said: Yep - because 12:13 takes it in-between Chapter 3 (10:00) and 4 (15:00) ... It's already a mine field at the moment. hahaha but progress none the less 1
chef 3810 Posted September 9, 2021 Posted September 9, 2021 (edited) 55 minutes ago, rbjtech said: Yep - because 12:13 takes it in-between Chapter 3 (10:00) and 4 (15:00) ... right, this is why I would push all chapters a head the sequence duration, until we hit runtime. Edited September 9, 2021 by chef
rbjtech 5284 Posted September 9, 2021 Posted September 9, 2021 2 minutes ago, chef said: Where is the actual intro start on that episode? Did we get any of it right? the end? For my system, everything is correct - all seasons all episodes. I was just trying to reproduce the issues @Cheesegeezer has with s1e2 and s1e6. 1
rbjtech 5284 Posted September 9, 2021 Posted September 9, 2021 1 minute ago, chef said: right, this is why I would push all chapter durations a head the sequence duration, until we hit runtime. Why ? We just use the logic previously listed - We insert Intro after Chapter 3. We need to extend chapter Chapter 3 to end at 12:13 (the Start of the Intro) and modify Chapter 4 to Start at the end of the Intro. (13:50) ? 1
Cheesegeezer 3104 Posted September 9, 2021 Posted September 9, 2021 2 minutes ago, rbjtech said: Why ? We just use the logic previously listed - We insert Intro after Chapter 3. We need to extend chapter Chapter 3 to end at 12:13 (the Start of the Intro) and modify Chapter 4 to Start at the end of the Intro. (13:50) ? exactly, the introstart and end times are the chapter entry points, so we just need to check if the next chapter starts before the end time and adjust accordingly. I made that sound really simple but coding it isn't gonna be that simple ahhahahaha 1
chef 3810 Posted September 9, 2021 Posted September 9, 2021 2 minutes ago, rbjtech said: Why ? We just use the logic previously listed - We insert Intro after Chapter 3. We need to extend chapter Chapter 3 to end at 12:13 (the Start of the Intro) and modify Chapter 4 to Start at the end of the Intro. (13:50) ? Right, but what if the devs say they want to the scanner to detect the end titles as well? We'll want to be prepared for that. They brought it up before. Just keep it in the back of your mind that we might be doing this again, backwards as well... in the future...
rbjtech 5284 Posted September 9, 2021 Posted September 9, 2021 1 minute ago, chef said: Right, but what if the devs say they want to the scanner to detect the end titles as well? We'll want to be prepared for that. They brought it up before. Just keep it in the back of your mind that we might be doing this again, backwards as well... in the future... lol - then they better chime in now - my crystal ball is a hit hazy at the moment .. But end credits can be treated just the same as an Intro but in reverse as you say - to note, we cannot assume the end of the credits is the end of the episode though (Monsters @ Work anybody..!?)
Cheesegeezer 3104 Posted September 9, 2021 Posted September 9, 2021 4 minutes ago, chef said: Right, but what if the devs say they want to the scanner to detect the end titles as well? We'll want to be prepared for that. They brought it up before. Just keep it in the back of your mind that we might be doing this again, backwards as well... in the future... How do you mean, is that function not already in? We are not moving any total episode run times we are just editing the chapters essentially
chef 3810 Posted September 9, 2021 Posted September 9, 2021 7 minutes ago, Cheesegeezer said: exactly, the introstart and end times are the chapter entry points, so we just need to check if the next chapter starts before the end time and adjust accordingly. I made that sound really simple but coding it isn't gonna be that simple ahhahahaha 1
chef 3810 Posted September 9, 2021 Posted September 9, 2021 3 minutes ago, Cheesegeezer said: How do you mean, is that function not already in? We are not moving any total episode run times we are just editing the chapters essentially The end title sequence might create a short chapter somewhere in the middle is all... I dunno.
rbjtech 5284 Posted September 9, 2021 Posted September 9, 2021 After 1000 replies - you'd think @Luke & @ebr would have something to say .. 1
rbjtech 5284 Posted September 9, 2021 Posted September 9, 2021 (edited) 5 minutes ago, chef said: The end title sequence might create a short chapter somewhere in the middle is all... I dunno. For those shows with real chapters, it's highly likely the last Chapter IS the start of the End Credits. But for Auto chapter items - we probably need to remove the last chapter(s)and insert with EndCredits. But lets focus on IntroSkip first - I'm not even going to put CreditSkip on the list ... Edited September 9, 2021 by rbjtech 1 1
Cheesegeezer 3104 Posted September 9, 2021 Posted September 9, 2021 1 minute ago, rbjtech said: But lets focus on IntroSkip first - I'm not even going to put CreditSkip on the list ... Yeah exactly!! Crawl..... Walk...... Run...... Sprint...... Fly...... 1
Micael456 45 Posted September 9, 2021 Posted September 9, 2021 22 minutes ago, rbjtech said: we cannot assume the end of the credits is the end of the episode though (Monsters @ Work anybody..!?) That's v. true, there'll probably be a few shows like that. That said, it's a (relatively) simple case of comparing credits end time vs episode runtime. 14 minutes ago, rbjtech said: But lets focus on IntroSkip first - I'm not even going to put CreditSkip on the list ... Also fully agree here. The credits/end isn't a real pain now anyway as you can just skip forward. 2
Cheesegeezer 3104 Posted September 9, 2021 Posted September 9, 2021 Oh I thought the end credits detection had already been implemented!!
Micael456 45 Posted September 9, 2021 Posted September 9, 2021 2 minutes ago, Cheesegeezer said: Oh I thought the end credits detection had already been implemented!! Nah, that seems to trigger on a timer. Episode finish - x seconds. Works fine for shows with long credits, not so great for ones which abruptly end. Or ones where foolish younger me stripped out the credit chapter to hurry it along . As obviously the bottom bar pops up and you lose a section of the screen. 1 1
chef 3810 Posted September 9, 2021 Posted September 9, 2021 (edited) 21 minutes ago, Cheesegeezer said: Oh I thought the end credits detection had already been implemented!! It's always at 30 secs from the end of the stream, dispute it actually being the end credits or not. Edited September 9, 2021 by chef
chef 3810 Posted September 9, 2021 Posted September 9, 2021 But, that only proves they can implement the button with ease. The server is blasting out PlaybackProgressEventArgs and the client is watching for them. We just want the client to act a little earlier is all. Right!?! Super easy, barely an inconvenience. Wow wow wow wow wow....
Sammy 790 Posted September 9, 2021 Posted September 9, 2021 (edited) I can't keep up here! I'm away for a bit an there's what seems to be 100 or more new comments. @chef what is the github repo on this project? that will be an easier place to find the latest IntroSkip.dll I believe. Edited September 9, 2021 by Sammy
Sammy 790 Posted September 9, 2021 Posted September 9, 2021 1 hour ago, chef said: v2.0.2.9 Added Limit Testing Series Query now sorts the data by 'SortName' to ensure we grab the same series for both tasks while the limit is enabled. Default MaxDegreeOfParalellism is changed to: 2 (this can be maxed out at 20 for really badass systems, most PC's with a decent CPU can handle at least 4 to 5) How to enable Limit Testing for series: Find' IntroSkip.xml' - Found: "Emby-Server/programdata/plugins/configurations/IntroSkip.xml" If it exists from testing prior releases, delete it, and restart the server. Open the xml file find the following xml node: <Limit xsi:nil="true" /> Replace with: <Limit>4</Limit> Where 4 is the amount of series you would like to test the plugin on. This number can be what ever you want it to be. Save the xml Restart the server How to remove the Limit: Find' IntroSkip.xml' - Found: "Emby-Server/programdata/plugins/configurations/IntroSkip.xml" Open the xml file find the Limit node you created during limit testing. Remove the node add this in its place: <Limit xsi:nil="true" /> Save the xml Restart the server IntroSkip_v2.0.2.9.zip 45.9 kB · 0 downloads Here it is.. Do I need to follow the special instructions or can I shut down the server, remove the introsequence.db, drop the new dll an restart the server to scan? 1
chef 3810 Posted September 9, 2021 Posted September 9, 2021 1 hour ago, chef said: v2.0.2.9 Added Limit Testing Series Query now sorts the data by 'SortName' to ensure we grab the same series for both tasks while the limit is enabled. Default MaxDegreeOfParalellism is changed to: 2 (this can be maxed out at 20 for really badass systems, most PC's with a decent CPU can handle at least 4 to 5) How to enable Limit Testing for series: Find' IntroSkip.xml' - Found: "Emby-Server/programdata/plugins/configurations/IntroSkip.xml" If it exists from testing prior releases, delete it, and restart the server. Open the xml file find the following xml node: <Limit xsi:nil="true" /> Replace with: <Limit>4</Limit> Where 4 is the amount of series you would like to test the plugin on. This number can be what ever you want it to be. Save the xml Restart the server How to remove the Limit: Find' IntroSkip.xml' - Found: "Emby-Server/programdata/plugins/configurations/IntroSkip.xml" Open the xml file find the Limit node you created during limit testing. Remove the node add this in its place: <Limit xsi:nil="true" /> Save the xml Restart the server IntroSkip_v2.0.2.9.zip 45.9 kB · 0 downloads Hey you're alive! That's a good thing... I thi k you need to delete your database file. Right there @Sammy
chef 3810 Posted September 9, 2021 Posted September 9, 2021 Just now, Sammy said: Here it is.. Do I need to follow the special instructions or can I shut down the server, remove the introsequence.db, drop the new dll an restart the server to scan? No, just delete your titlesequence.db file. 1
Cheesegeezer 3104 Posted September 9, 2021 Posted September 9, 2021 4 minutes ago, Sammy said: I can't keep up here! I'm away for a git an there's what seems to be 100 or more new comments. @chef what is the github repo on this project? that will be an easier place to find the latest IntroSkip.dll I believe. it's what we like to call...... progress LOL
Cheesegeezer 3104 Posted September 9, 2021 Posted September 9, 2021 (edited) Making Progress now the intro's insert at the correct point. I will need to find the real tricky one where the intro end overlaps a emby 5min marker That's the Westworld Episode 3 where the intro starts much later in the episode Edited September 9, 2021 by Cheesegeezer 2
Recommended Posts