VirtualLlama 5 Posted April 17, 2017 Posted April 17, 2017 (edited) Hi all, I've been having an issue with missing tv episode ratings and I seem to have narrowed it down to some sort of bug in the Emby for Kodi plugin update process. I apologize if this a known issue, I couldn't find anything similar to this on the forums. What happens is that episodes will go from having a valid rating on the initial metadata import to having no rating at all. Steps to reproduce: - Clear the Kodi database with a local database reset from the Emby plugin. - Let the plugin reload all metadata from the Emby server. All episodes with ratings on the Emby Server should also have ratings in Kodi at this point. - Perform a metadata refresh on a tv season from the Emby Server, this will trigger an update to Kodi. - Once the update has been processed by the Emby for Kodi plugin, all episodes in the refreshed season will no longer have a rating. This issue also prevents an episode that doesn't have a rating on the initial import to Kodi from ever getting a rating even if one becomes available later. So far the only way I've found to get the ratings back is to do another local database reset in Kodi. Software versions: Kodi v.17.1. Emby for Kodi v.2.3.46 Windows 10 Emby Server v.3.2.10 (Synology build). In the attached log file the update that wipes out the ratings for a season starts at 22:15:11:805. EDIT: I should also mention that I have tried the 'Emby.Kodi Sync Queue' server plugin and the result is the same both with and without it installed. kodi.log Edited April 17, 2017 by VirtualLlama
sualfred 677 Posted April 18, 2017 Posted April 18, 2017 (edited) I can confirm that they are gone for some reasons after the metadata has been refreshed on Emby. @@im85288 Could you take of it please? I guess we just missed something while we were investigating the rating stuff for Krypton. Edit: @@im85288 The issue is somewhere at the update process (line 606) of tvshows.py. The unique ID is going to be dropped in the episodes table and the row of the rating table isn't updated as soon as the metadata will be changed. Edited April 18, 2017 by sualfred
sualfred 677 Posted April 19, 2017 Posted April 19, 2017 @@im85288 Found the issue and fixed it: https://github.com/MediaBrowser/plugin.video.emby/pull/88 1
VirtualLlama 5 Posted April 19, 2017 Author Posted April 19, 2017 (edited) Great to hear that it's fixed, thank you sualfred! I'll be looking forward to seeing this in a future version. Edited April 19, 2017 by VirtualLlama
no6mis 2 Posted April 20, 2017 Posted April 20, 2017 @@im85288 Found the issue and fixed it: https://github.com/MediaBrowser/plugin.video.emby/pull/88 Hi, the fix doesn't work for me. I patched the file but as soon I click save in the metadata manager the rating of this episode vanishes in kodi.
sualfred 677 Posted April 20, 2017 Posted April 20, 2017 (edited) Hi, the fix doesn't work for me. I patched the file but as soon I click save in the metadata manager the rating of this episode vanishes in kodi. Tested it again and it works (Krypton). All changed info values (incl. ratings) are going to be updated. Edited April 20, 2017 by sualfred
sualfred 677 Posted April 20, 2017 Posted April 20, 2017 My PR and first solution doesn't work for everyone so I gave it another try: https://github.com/sualfred/plugin.video.emby Please test this version and report back if everything works well.
sualfred 677 Posted April 20, 2017 Posted April 20, 2017 (edited) NOW it should work. Was too blind to see this small issue ....https://github.com/MediaBrowser/plugin.video.emby/pull/89 Edit: To get this working it's required to reset the complete database. Edited April 21, 2017 by sualfred 2
no6mis 2 Posted April 20, 2017 Posted April 20, 2017 yes, I can confirm that it's working fine now :-)
Recommended Posts