Access to "Button More Commands" disapeared via reverse proxying

[ulysse31 1]

Hi all,

 

Is it only me or does the button section :

 

<button is="emby-button" type="button" class="btnMoreCommands fab mini emby-button" title="Plus"><i class="md-icon">more_vert</i></button>

 

disapears via reverse proxying (apache2.4 here) ?

 

this section normally gives access to more actions such as "add to playlist" "Download" etc ...

 

I have noticed this loss of button access since I upgraded emby from 3.1.5 to 3.2.7 ...

 

Thanks for your feebacks.

 

 

Cheers all,

 

 

--

Ulysse31

 

[Luke 42077]

What screen exactly?

[ulysse31 1]

When you are in a media page (A film, or an episode) you have the read button and normally the "3 dot button" (the more command).

[Luke 42077]

Can you show a screenshot? thanks !

[ulysse31 1]

Hello,

 

Here is a view example from the internal network (direct access/no apache reverse proxy) :

 

 

 

You can see the "vertical 3 dot button" near the "Play" (Lire).

 

And here a view from the outside (with apache reverse proxy):

 

 

 

As you can see, the entire button disapears ...

I've been tweaking a bit to find why this happens, and here is what I have found until now :

 

- my apache uses mod_substitude to disable the addtocollection button, it uses a regex as :

 

Substitute "s|addtocollection|addtocollection\" style=\"display: none;|"
 

this always have worked with prior versions of emby, but now, for some reason, adding this substitude makes emby-server adding a new class type to the parent button (the vertical 3 dot button) :

it adds the class type "hide", disabling all possibility to access the more commands menu.

 

here is the parent button html content :

 

<button is="emby-button" type="button" class="btnMoreCommands fab mini hide emby-button" title="Plus"><i class="md-icon">more_vert</i></button>

 

I've tried modifiyng the regex  like this example : Substitute "s|addtocollection|addtocollection\" disabled|", but the result is the same : if I try to add/modify a parameter of a sub-button of the btnmorecommand menu (here the button with data-id addtocollection), it disables the entire menu by adding "hide" class to its parent button (btnmorecommand) ...

 

Does someone knows why ?

Edited March 27, 2017 by ulysse31

[Luke 42077]

If you remove all of your tweaks, does that restore everything?

[ulysse31 1]

Hi again,

 

Yes, of course, if I remove the Substitute, and clear the navigator cache, it works again (but the "add to collection" button appears also again ...).

The thing is, we still cannot specify which users is allowed or not to add/modify collections. As for now, all users can do it, which means the library can become messy quickly ...

I really don't understand why the server adds the class "hide" to the main button if a sub-button is disabled ...

 

Does someone has found a regex that works without disabling the main "btnmorecommands" button ?

Thanks a lot again.

 

 

--

Ulysse31

[pir8radio 1312]

why don't you use branding/css to hide the collection button? 

 

button[data-id=addtocollection]  {

    display: none;

}

[ulysse31 1]

Hello again,

 

Sorry for the late reply.

 

Thanks for the help @@pir8radio, this may be a solution.

Gonna try that.

 

Regards,

 

 

--

Ulysse31