speechles 2055 Posted July 14, 2016 Posted July 14, 2016 (edited) I will say, this theme/app does respond faster than the original. There is a reason for that, but officially, the pull request was never merged and just closed. https://github.com/MediaBrowser/Emby.Roku/pull/134 Here is the pull request to speed up that screen. I know exactly what you mean by faster, when entering the TV library it is instantly navigateable and responsive. Whereas the original takes a long time to fill in the TV library screen, how long depends on how many TV series you have. If you have 1,000+ TV Series it may take 3-5 minutes until the TV library screen is usable. It is all about where you use "&ImageTypeLimit=1" for which API calls. It breaks paging when used with some of the calls. This slows down the entire response. I found this out and went through and corrected every single placement. With the blueneon app I tested each to see if with it was faster with or without that imagetypelimit=1 part, and went with the faster one. Edited July 14, 2016 by speechles
ebr 16169 Posted July 14, 2016 Posted July 14, 2016 @@ebr another question, same topic. Suppose one fetches items/latest/ and doesnt make use of the groupitems key at all. Does this cause the sever to respect the value for groupitems internally? The internal groupitems is how the logged in user has set this in their user preferences. If it does, this makes it alot easier. If it doesnt, what is the call to get the logged in users groupitems bit? Sent from my Nexus 7 using Tapatalk Sorry, I don't understand the question. If you have the group option set, you always get the Series back from the query - does that answer it?
speechles 2055 Posted July 14, 2016 Posted July 14, 2016 (edited) Sorry, I don't understand the question. If you have the group option set, you always get the Series back from the query - does that answer it? So it returns the entire series item if the user chose to group items? This just seems so wrong. If I wanted to enter a tv-series I wouldve. Entering the tv-series thru latest should only show the latest episodes for that series, not all. So yeah, respecting the built-in server grouping will not be done. It is just done incorrectly and I shant follow suit. Instead, I can get the items without grouping them. Then I can use the seriesId to tell which belong to the same series and group them individually myself. This is what I was asking. I can do this, since the server isnt offering it. This will make the roku different (read as better) than the rest. Why does grouped episodes go to the entire series? Why was this lazy approach taken? Sure it's more work to sort and regroup all of this within the app, but the benefit in this case outweighs the cost. I don't understand why decisions like this are made which remove core functionality. The latest is for new episodes, not for the entire tv-series. It just seems silly and moot to argue. The correct way is obvious. The way emby server does it is not correct. Edited July 14, 2016 by speechles
speechles 2055 Posted July 15, 2016 Posted July 15, 2016 @@abnranger67 http://emby.media/community/index.php?/topic/24151-theme-blue-neon-night/?p=346614 Updated the app. Go ahead and get your "group" on.
ABNParatrooper 6 Posted July 16, 2016 Author Posted July 16, 2016 Shows are grouping now, thanks for the hard work. The issue now is that my movies for latest content are not showing latest but actually showing watched content. So now, under latest, all I am seeing are movies I have already watched (check mark included). TV shows however, are grouping fine.
speechles 2055 Posted July 16, 2016 Posted July 16, 2016 Shows are grouping now, thanks for the hard work. The issue now is that my movies for latest content are not showing latest but actually showing watched content. So now, under latest, all I am seeing are movies I have already watched (check mark included). TV shows however, are grouping fine.Doh... I see what happened there. Ill have a fix up shortly. This was my mistake. Apologies.... Sent from my Nexus 7 using Tapatalk
Recommended Posts
Create an account or sign in to comment
You need to be a member in order to leave a comment
Create an account
Sign up for a new account in our community. It's easy!
Register a new accountSign in
Already have an account? Sign in here.
Sign In Now