Commas in IMDb votes?

[GlassJoe 0]

Emby doesn't add commas when it scrapes votes from the IMDb, which makes it look pretty awful in Kodi. ex: 9.6 (1451346) vs 9.6 (1,451,346)

 

If you change the nfo manually and refresh, Emby doesn't even populate the votes section.

 

 

 

Edit: I should have added that if this ever changes, I'd switch from using Media Companion to Emby in a heartbeat. I just bought the mobile app and I'm loving it. Emby Theater is looking pretty good too.

Edited April 20, 2016 by GlassJoe

[im85288 1493]

Try one of the skins that use the skin helper addon (eg Titan), this sort of info (and a lot more eg IMDB Top 250 for movies/shows) is refreshed regularly.

 

If your query is more to do with how it shows in other Emby clients please post that query in the server section of the forum.

[xnappo 1611]

It might be in how we format it when we translate from Emby API to Kodi API.  I'll take a quick look.  (thinking Emby provides it as an int and we convert to string, but don't make it pretty?)

[im85288 1493]

Possibly, my main point really was that sort of info is almost redundant as soon as it's scraped (as of course it changes regularly in IMDB) but yes if it is a problem from our side it's worth looking into.

[xnappo 1611]

Okay - I took a look.  Looks like the vote count is always a string, and it is not 'pretty formatted' on the server.

 

We could format it in the addon, but best to request 'pretty format' on the server.

 

xnappo

[Luke 42077]

Are you sure? It is an int in the api json, a number that you can do whatever you like with.

[xnappo 1611]

Okay, thanks @@Luke - I didn't see us converting it to str, must be getting done automatically somehow.

[Angelblue05 4132]

We don't do anything to the vote count. Should we really do anything in the add-on, because numbers displays differently in different languages? For example, in French, we use spaces instead of commas. [emoji52]

 

 

Sent from my iPhone using Tapatalk

Edited April 23, 2016 by Angelblue05

[Luke 42077]

Yea if you can't localize it might be better to not do it at all.

[xnappo 1611]

11439572 vs. 311589342 is pretty pointless.  You can not tell by glancing at that which is higher.  11,439,572 vs 311,589,342.

 

We could use Engineering notation   11.439Mvotes

[Angelblue05 4132]

I'm surprised this is not handled by Kodi internally, with the label parsing... I wonder how they handle it by default.

 

Edit: I meant the label parsing in the skinning engine.

 

Sent from my iPhone using Tapatalk

Edited April 23, 2016 by Angelblue05

[xnappo 1611]

According to the op, the native Kodi scraper does handle it? 

 

@@GlassJoe - we need you to explain more.

Edited April 23, 2016 by xnappo

[spootdev 56]

We don't do anything to the vote count. Should we really do anything in the add-on, because numbers displays differently in different languages? For example, in French, we use spaces instead of commas. [emoji52]

 

 

Sent from my iPhone using Tapatalk

 

import locale

locale.setlocale(locale.LC_ALL, '')

 

locale.format('%d', total_movie_added, True)

[Angelblue05 4132]

Want to do a pull request and I'll check it out? Thanks [emoji854]

 

 

Sent from my iPhone using Tapatalk

[spootdev 56]

Hehehe, just an example.  No coding for me this weekend.  Way too little sleep. 

[xnappo 1611]

I think I have lost track of what we are even talking about.

 

I thought it was this:

        votecount = item.get('VoteCount')

 

But that is always NoneType/None.

 

xnappo

[Angelblue05 4132]

How is it always none?

 

 

Sent from my iPhone using Tapatalk

[xnappo 1611]

I don't know - I added a print after that line and it is always none for me.

[Angelblue05 4132]

You are right. Nothing is populated in c04 of the database. What the cluck? Looks like VoteCount is missing from the field list. So then, votecount is not the imdb vote count? What is?

 

 

Sent from my iPhone using Tapatalk

Edited April 24, 2016 by Angelblue05

[xnappo 1611]

Yep, exactly why I am confused!

[Angelblue05 4132]

Is this provided by the script skin helper or something?

 

 

Sent from my iPhone using Tapatalk