Issues with downloaded subtitles

[Nazgulled 11]

I've noticed an odd issue with the subtitles Emby downloads... They are all exactly 160 KB (163.840 bytes), when the subtitle text ends, the file is filled with NUL values to reach the 160KB, example:

 

But if the subtitle text is larger than the 160KB, it will duplicate the size to reach the exact 320 KB (327.680 bytes).

 

This seems really strange, is it just me?

 

One other thing slightly less relevant... On the reports page, it seems that the subtitles column is missing some information:

 

 

But I have subtitles for all my movies in 2 languages, English and Portuguese. Could this be, perhaps, because all my subtitles have the "pt" and "en" suffix instead of "por" and "eng" (which seems to be the ones that Emby uses on downloaded subtitles)? It would be nice if both patterns could be matched, 2-letter and 3-letter code.

[Luke 42083]

yes the 160kb thing is odd. It's probably something in the open subtitles library that we're using.

 

Have you compared your subtitles to our supported naming conventions:

 

https://github.com/MediaBrowser/Wiki/wiki/Subtitles

[Nazgulled 11]

yes the 160kb thing is odd. It's probably something in the open subtitles library that we're using.

That might be it... I personally run a cron job with subliminal to get subtitles from different providers (including OpenSubtitles) and those never get that odd NUL values, so maybe that's a bug on the lib you guys use.

 

 

Have you compared your subtitles to our supported naming conventions:

 

https://github.com/MediaBrowser/Wiki/wiki/Subtitles

Yeah, it's like I said, you guys are only looking for the 3 letter code and not the 2 letter code. It would be nice to look for both because many other tools that one might use mostly use 2 letter codes.

 

For instance, CouchPotato subtitle downloader uses 2 letter codes (internally it uses subliminal too). And it doesn't make sense for Emby to not detected these subtitles and re-download them. And why would one use both CouchPotato and Emby subtitles downloade, why not just one? Well, CouchPotato looks up for subtitles only once, when the movie is downloaded, Emby will search for them periodically (which is nice because there might not be a subtitle available when CouchPotato first searchs for subtitles).

 

Just a thought