Delete function deleted entire movie library

[Dibbes 514]

As per your Reason 4, Its actually best practice to have sub folders, Microsoft does not like thousands of files in a single folder, must faster to have them in their own folders.

 

Neither does ext4

[Fratopolis 63]

I never keep Movies in the root folder. I just rip to that location. Which I will no longer be doing

 

Problem Solved.

[JarvisTek 3]

This literally just happened to me. I had all my movies in subfolders, but I was using handbrake to preview my dvd to make sure it was in the correct title. This created a junk 30 second file in the root of the movie directory. Emby gave it some random title, and I deleted from there, you know, cause that's where I saw it and all. Now ALL my movies are all gone. Using NTFSundelete right now to recover everything (at least it all wasn't stored on the system drive), but wow, didn't see this coming. Maybe a simple check to determine how many folders and/or files it's going to be deleting before actually deleting everything?

[Luke 42078]

hi, the issue detailed earlier in this thread by Fratopolis is resolved for the next release. Thanks !

[dongphuongsoc 5]

Firstly, sorry for my poor English.

In one month, I get this issue twice: delete 1 video, emby remove all folders in same directory.

I use emby Version 4.9.0.30 beta

I have a folder/sub-folders contain videos.

Normally I didn't put file in root folder. But sometime I quickly download video and don't know it 's saved to root folder.

When I saw the video in library, don't like it, remove it. And boom, all the folder go to hell.

 I think the issue of system is:

Quote

 

When delete a video, Emby check if other file exist in folder (forget to check other folders) 

=>  Yes: keep the folder

=> No: remove folder

 

So if the root folder contain only 1 file and many sub-folder, when i delete the file, all sub-folders are deleted too.

Please fix it.

[ebr 16182]

1 hour ago, dongphuongsoc said:

So if the root folder contain only 1 file and many sub-folder,

Hi.  A folder with a single video in it is interpreted as a movie.  Sub-folders under it are just seen as some sort of "extras" for that movie.

For your situation, when you discover you've put a video in the wrong place, use your file system to remove it instead of Emby and there should be no issue.

[Q-Droid 989]

3 hours ago, ebr said:

Hi.  A folder with a single video in it is interpreted as a movie.  Sub-folders under it are just seen as some sort of "extras" for that movie.

For your situation, when you discover you've put a video in the wrong place, use your file system to remove it instead of Emby and there should be no issue.

OUCH. Efficient, but not the way you'd want to learn that you've purged your library. 

[darkassassin07 652]

This is a big reason I ONLY manage files via either a regular file explorer with a recycle bin, or via Sonarr/Radarr which both have options for a recycle bin instead of deleting files.

This is a rather rough lesson to learn unfortunately.

 

Emby really should consider something similar. Directly deleting potentially thousands of files, entirely unrelated to the selected media, due to a poor folder layout is rather stupid. 

Edited October 17, 2024 by darkassassin07

[Carlo 4561]

Or simply never delete anything if that folder is the path added to a library. Throw up a message to the user instead.
What would be even better, query the database to see if there are any other media files in the folder or subdirectory(s). If so throw up a message. If the user is an admin there could be button to exit or switch to the Metadata Manager Tree view opened to the location the user was at. This way they can see the layout and continue if they want. 

 

[dongphuongsoc 5]

11 hours ago, ebr said:

Hi.  A folder with a single video in it is interpreted as a movie.  Sub-folders under it are just seen as some sort of "extras" for that movie.

For your situation, when you discover you've put a video in the wrong place, use your file system to remove it instead of Emby and there should be no issue.

Browsing and managing movies/video in emby is a very useful function. You can view details, watch a little to know if it's good or not. I'm happy with it untill I got the problem (it took some tetrabyte of my movie).

I think we just need to add some more code to check if any item in library belong to its parents path.

Otherwise you should disable this function. There are many case that lead to this issue. It can be consider as UX/UI bug.

- Some folder does not contain only 1 video. But after we browse the library, delete some, it does.

- User mistake, save video in wrong place. We made a small mistake but paid dearly.

I still hope this function is not removed and the issue is fixed.